libmicrohttpd

commit d86385c9b4cc3a13835579611b08ed713ee17a29
parent e10685804a4e61e7e41747248347474dc9db90ed
Author: Christian Grothoff <christian@grothoff.org>
Date:   Fri,  6 Sep 2013 11:44:22 +0000

-nitpicks in tests

Diffstat:
M
src/testcurl/https/test_https_time_out.c
 | 
3
+++
M
src/testcurl/https/tls_test_common.c
 | 
6
+++---
M
src/testcurl/test_get.c
 | 
1
+
M
src/testcurl/test_quiesce.c
 | 
6
++++--

4 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/testcurl/https/test_https_time_out.c b/src/testcurl/https/test_https_time_out.c
@@ -62,6 +62,7 @@ test_tls_session_time_out (gnutls_session_t session)
   if (ret < 0)
     {
       fprintf (stderr, "Error: %s\n", MHD_E_FAILED_TO_CONNECT);
+      close (sd);
       return -1;
     }
 
@@ -69,6 +70,7 @@ test_tls_session_time_out (gnutls_session_t session)
   if (ret < 0)
     {
       fprintf (stderr, "Handshake failed\n");
+      close (sd);
       return -1;
     }
 
@@ -79,6 +81,7 @@ test_tls_session_time_out (gnutls_session_t session)
   if (send (sd, "", 1, 0) == 0)
     {
       fprintf (stderr, "Connection failed to time-out\n");
+      close (sd);
       return -1;
     }
 
diff --git a/src/testcurl/https/tls_test_common.c b/src/testcurl/https/tls_test_common.c
@@ -40,8 +40,8 @@ setup_ca_cert ()
                ca_cert_file_name, strerror (errno));
       return NULL;
     }
-  if (fwrite (ca_cert_pem, sizeof (char), strlen (ca_cert_pem), cert_fd)
-      != strlen (ca_cert_pem))
+  if (fwrite (ca_cert_pem, sizeof (char), strlen (ca_cert_pem) + 1, cert_fd)
+      != strlen (ca_cert_pem) + 1)
     {
       fprintf (stderr, "Error: failed to write `%s. %s'\n",
                ca_cert_file_name, strerror (errno));
@@ -401,7 +401,7 @@ setup_session (gnutls_session_t * session,
 	return -1;
      }
   memcpy (key->data, srv_key_pem, key->size);
-  cert->size = strlen (srv_self_signed_cert_pem);
+  cert->size = strlen (srv_self_signed_cert_pem) + 1;
   cert->data = malloc (cert->size);
   if (cert->data == NULL)
     {
diff --git a/src/testcurl/test_get.c b/src/testcurl/test_get.c
@@ -472,6 +472,7 @@ testStopRace (int poll_flag)
     if (CONNECT (fd, (struct sockaddr *)(&sin), sizeof(sin)) < 0)
     {
        fprintf(stderr, "connect: %m\n");
+       CLOSE (fd);
        return 512;
     }
     
diff --git a/src/testcurl/test_quiesce.c b/src/testcurl/test_quiesce.c
@@ -384,8 +384,10 @@ testExternalGet ()
       if (i == 0) {
         /* quiesce the daemon on the 1st iteration, so the 2nd should fail */
         fd = MHD_quiesce_daemon(d);
-        close(fd);
-        c = setupCURL(&cbc);
+	if (-1 == fd)
+	  abort ();
+        close (fd);
+        c = setupCURL (&cbc);
         multi = curl_multi_init ();
         mret = curl_multi_add_handle (multi, c);
       }