The issue reported below is correct, the fix is not. The "!=" comparing the RF flag should simply have been "==".

Louis wrote:

There is a change of behavior between 0.9.37 and 0.9.38.
When a client adds a "Connection: close" header in 0.9.37, MHD adds a "Connection: close" header to its response and then 
close the connection (as suggested in rfc2616, section 8.1.2.1).
The "Connection: close" header is not added in 0.9.38.
I looked into the 0.9.38 code and the code that prevents the inclusion of the "Connection: close" header is at line 773 of connection.c.
 if ( ( (NULL != client_requested_close) ||
 (MHD_YES == connection->read_closed) ) &&
 (NULL == response_has_close) &&
 (0 != (connection->response->flags & MHD_RF_HTTP_VERSION_1_0_ONLY) ) )
 must_add_close = MHD_YES;

Shouldn't it read
 if ( ( (NULL != client_requested_close) ||
 (MHD_YES == connection->read_closed) ||
 (0 != (connection->response->flags & MHD_RF_HTTP_VERSION_1_0_ONLY) ) ) &&
 (NULL == response_has_close) )
 must_add_close = MHD_YES;

Thanks,

Louis Benoit

1 files changed, 4 insertions, 0 deletions

diff --git a/ChangeLog b/ChangeLog
index 9b51d094..93ea225d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Fri Apr 10 22:02:27 CEST 2015
+        Fix logic to add "Connection: Close" that was broken in 0.9.38
+        when adding MHD_RF_HTTP_VERSION_1_0_ONLY. -CG
+
 Fri Apr 10 00:38:40 CEST 2015
         Ensure fast termination in MHD_USE_THREAD_PER_CONNECTION
         mode on W32 by using signal pipe. -CG