aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWillow Liquorice <willow@howhill.com>2022-08-26 02:41:41 +0100
committerMartin Schanzenbach <schanzen@gnunet.org>2022-08-30 09:41:48 +0200
commit586f250f1603572861af4b1bf570b3a253306bbf (patch)
tree5ecf517d59aab052a439db376eec564e1ccbaefb
parent4f03c106f941b6169914638a6a045a4fff7a2943 (diff)
downloadgnunet-586f250f1603572861af4b1bf570b3a253306bbf.tar.gz
gnunet-586f250f1603572861af4b1bf570b3a253306bbf.zip
-DOC: Established neovim workflow for checking and stripping comments, first pass over the ATS subsystem.
-rw-r--r--src/ats/gnunet-service-ats_addresses.c31
-rw-r--r--src/ats/gnunet-service-ats_addresses.h2
-rw-r--r--src/ats/gnunet-service-ats_plugins.c18
-rw-r--r--src/ats/gnunet-service-ats_plugins.h3
-rw-r--r--src/ats/gnunet-service-ats_preferences.c5
-rw-r--r--src/ats/gnunet-service-ats_reservations.c6
-rw-r--r--src/ats/gnunet-service-ats_scheduling.c14
-rw-r--r--src/ats/gnunet-service-ats_scheduling.h3
8 files changed, 3 insertions, 79 deletions
diff --git a/src/ats/gnunet-service-ats_addresses.c b/src/ats/gnunet-service-ats_addresses.c
index d02efd939..9c9856094 100644
--- a/src/ats/gnunet-service-ats_addresses.c
+++ b/src/ats/gnunet-service-ats_addresses.c
@@ -196,17 +196,6 @@ find_exact_address (const struct GNUNET_PeerIdentity *peer,
196} 196}
197 197
198 198
199/**
200 * Add a new address for a peer.
201 *
202 * @param peer peer
203 * @param plugin_name transport plugin name
204 * @param plugin_addr plugin address
205 * @param plugin_addr_len length of the plugin address in @a plugin_addr
206 * @param local_address_info the local address for the address
207 * @param session_id session id, can be 0
208 * @param prop performance information for this address
209 */
210void 199void
211GAS_addresses_add (const struct GNUNET_PeerIdentity *peer, 200GAS_addresses_add (const struct GNUNET_PeerIdentity *peer,
212 const char *plugin_name, 201 const char *plugin_name,
@@ -265,13 +254,6 @@ GAS_addresses_add (const struct GNUNET_PeerIdentity *peer,
265} 254}
266 255
267 256
268/**
269 * Update an address with new performance information for a peer.
270 *
271 * @param peer peer
272 * @param session_id session id, never 0
273 * @param prop performance information for this address
274 */
275void 257void
276GAS_addresses_update (const struct GNUNET_PeerIdentity *peer, 258GAS_addresses_update (const struct GNUNET_PeerIdentity *peer,
277 uint32_t session_id, 259 uint32_t session_id,
@@ -465,13 +447,6 @@ peerinfo_it (void *cls,
465} 447}
466 448
467 449
468/**
469 * Return information all peers currently known to ATS
470 *
471 * @param peer the respective peer, NULL for 'all' peers
472 * @param pi_it the iterator to call for every peer
473 * @param pi_it_cls the closure for @a pi_it
474 */
475void 450void
476GAS_addresses_get_peer_info (const struct GNUNET_PeerIdentity *peer, 451GAS_addresses_get_peer_info (const struct GNUNET_PeerIdentity *peer,
477 GNUNET_ATS_PeerInfo_Iterator pi_it, 452 GNUNET_ATS_PeerInfo_Iterator pi_it,
@@ -665,12 +640,6 @@ req_addr_peerinfo_it (void *cls,
665} 640}
666 641
667 642
668/**
669 * Handle 'address list request' messages from clients.
670 *
671 * @param cls client that sent the request
672 * @param alrm the request message
673 */
674void 643void
675GAS_handle_request_address_list (struct GNUNET_SERVICE_Client *client, 644GAS_handle_request_address_list (struct GNUNET_SERVICE_Client *client,
676 const struct AddressListRequestMessage *alrm) 645 const struct AddressListRequestMessage *alrm)
diff --git a/src/ats/gnunet-service-ats_addresses.h b/src/ats/gnunet-service-ats_addresses.h
index b39484f59..8e6f40f38 100644
--- a/src/ats/gnunet-service-ats_addresses.h
+++ b/src/ats/gnunet-service-ats_addresses.h
@@ -464,7 +464,7 @@ typedef void
464/** 464/**
465 * Return information all peers currently known to ATS 465 * Return information all peers currently known to ATS
466 * 466 *
467 * @param peer the respective peer 467 * @param peer the respective peer, NULL for 'all' peers
468 * @param pi_it the iterator to call for every peer 468 * @param pi_it the iterator to call for every peer
469 * @param pi_it_cls the closure for @a pi_it 469 * @param pi_it_cls the closure for @a pi_it
470 */ 470 */
diff --git a/src/ats/gnunet-service-ats_plugins.c b/src/ats/gnunet-service-ats_plugins.c
index d8d6be11d..d3db69caa 100644
--- a/src/ats/gnunet-service-ats_plugins.c
+++ b/src/ats/gnunet-service-ats_plugins.c
@@ -70,11 +70,6 @@ GAS_plugin_notify_preference_changed (const struct GNUNET_PeerIdentity *peer,
70} 70}
71 71
72 72
73/**
74 * The relative value for a property changed.
75 *
76 * @param address the peer for which a property changed
77 */
78void 73void
79GAS_plugin_notify_property_changed (struct ATS_Address *address) 74GAS_plugin_notify_property_changed (struct ATS_Address *address)
80{ 75{
@@ -425,13 +420,6 @@ load_quotas (const struct GNUNET_CONFIGURATION_Handle *cfg,
425} 420}
426 421
427 422
428/**
429 * Initialize plugins subsystem.
430 *
431 * @param cfg configuration to use
432 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error (failed to load
433 * solver plugin)
434 */
435int 423int
436GAS_plugin_init (const struct GNUNET_CONFIGURATION_Handle *cfg) 424GAS_plugin_init (const struct GNUNET_CONFIGURATION_Handle *cfg)
437{ 425{
@@ -493,12 +481,6 @@ GAS_plugin_done ()
493} 481}
494 482
495 483
496/**
497 * Tell the solver that the given address can now be used
498 * for talking to the respective peer.
499 *
500 * @param new_address the new address
501 */
502void 484void
503GAS_plugin_new_address (struct ATS_Address *new_address) 485GAS_plugin_new_address (struct ATS_Address *new_address)
504{ 486{
diff --git a/src/ats/gnunet-service-ats_plugins.h b/src/ats/gnunet-service-ats_plugins.h
index 0bd358917..1abdbbd80 100644
--- a/src/ats/gnunet-service-ats_plugins.h
+++ b/src/ats/gnunet-service-ats_plugins.h
@@ -67,7 +67,7 @@ GAS_plugin_notify_preference_changed (const struct GNUNET_PeerIdentity *peer,
67/** 67/**
68 * The relative value for a property changed. 68 * The relative value for a property changed.
69 * 69 *
70 * @param address the peer 70 * @param address The peer for which a property changed.
71 */ 71 */
72void 72void
73GAS_plugin_notify_property_changed (struct ATS_Address *address); 73GAS_plugin_notify_property_changed (struct ATS_Address *address);
@@ -78,7 +78,6 @@ GAS_plugin_notify_property_changed (struct ATS_Address *address);
78 * for talking to the respective peer. 78 * for talking to the respective peer.
79 * 79 *
80 * @param new_address the new address 80 * @param new_address the new address
81 * @param addr_net network scope the address is in
82 */ 81 */
83void 82void
84GAS_plugin_new_address (struct ATS_Address *new_address); 83GAS_plugin_new_address (struct ATS_Address *new_address);
diff --git a/src/ats/gnunet-service-ats_preferences.c b/src/ats/gnunet-service-ats_preferences.c
index 0869c65dc..c2b2dc4c1 100644
--- a/src/ats/gnunet-service-ats_preferences.c
+++ b/src/ats/gnunet-service-ats_preferences.c
@@ -747,11 +747,6 @@ GAS_preference_get_by_peer (void *cls,
747} 747}
748 748
749 749
750/**
751 * A performance client disconnected
752 *
753 * @param client the client
754 */
755void 750void
756GAS_preference_client_disconnect (struct GNUNET_SERVICE_Client *client) 751GAS_preference_client_disconnect (struct GNUNET_SERVICE_Client *client)
757{ 752{
diff --git a/src/ats/gnunet-service-ats_reservations.c b/src/ats/gnunet-service-ats_reservations.c
index a50e9d5b7..471a19859 100644
--- a/src/ats/gnunet-service-ats_reservations.c
+++ b/src/ats/gnunet-service-ats_reservations.c
@@ -135,12 +135,6 @@ GAS_reservations_set_bandwidth (const struct GNUNET_PeerIdentity *peer,
135} 135}
136 136
137 137
138/**
139 * Handle 'reservation request' messages from clients.
140 *
141 * @param client client that sent the request
142 * @param msg the request message
143 */
144void 138void
145GAS_handle_reservation_request (struct GNUNET_SERVICE_Client *client, 139GAS_handle_reservation_request (struct GNUNET_SERVICE_Client *client,
146 const struct ReservationRequestMessage *msg) 140 const struct ReservationRequestMessage *msg)
diff --git a/src/ats/gnunet-service-ats_scheduling.c b/src/ats/gnunet-service-ats_scheduling.c
index 456c222a9..2dfb70343 100644
--- a/src/ats/gnunet-service-ats_scheduling.c
+++ b/src/ats/gnunet-service-ats_scheduling.c
@@ -71,15 +71,6 @@ GAS_scheduling_remove_client (struct GNUNET_SERVICE_Client *client)
71} 71}
72 72
73 73
74/**
75 * Transmit the given address suggestion and bandwidth update to all scheduling
76 * clients.
77 *
78 * @param peer peer for which this is an address suggestion
79 * @param session_id session ID to use for the given client
80 * @param bandwidth_out assigned outbound bandwidth
81 * @param bandwidth_in assigned inbound bandwidth
82 */
83void 74void
84GAS_scheduling_transmit_address_suggestion (const struct 75GAS_scheduling_transmit_address_suggestion (const struct
85 GNUNET_PeerIdentity *peer, 76 GNUNET_PeerIdentity *peer,
@@ -114,11 +105,6 @@ GAS_scheduling_transmit_address_suggestion (const struct
114} 105}
115 106
116 107
117/**
118 * Handle 'address add' messages from clients.
119 *
120 * @param m the request message
121 */
122void 108void
123GAS_handle_address_add (const struct AddressAddMessage *m) 109GAS_handle_address_add (const struct AddressAddMessage *m)
124{ 110{
diff --git a/src/ats/gnunet-service-ats_scheduling.h b/src/ats/gnunet-service-ats_scheduling.h
index d68306988..ca6c1bd57 100644
--- a/src/ats/gnunet-service-ats_scheduling.h
+++ b/src/ats/gnunet-service-ats_scheduling.h
@@ -55,7 +55,7 @@ GAS_scheduling_remove_client (struct GNUNET_SERVICE_Client *client);
55 * clients. 55 * clients.
56 * 56 *
57 * @param peer peer for which this is an address suggestion 57 * @param peer peer for which this is an address suggestion
58 * @param session_id session ID to use 58 * @param session_id session ID to use for the given client
59 * @param bandwidth_out assigned outbound bandwidth 59 * @param bandwidth_out assigned outbound bandwidth
60 * @param bandwidth_in assigned inbound bandwidth 60 * @param bandwidth_in assigned inbound bandwidth
61 */ 61 */
@@ -72,7 +72,6 @@ GAS_scheduling_transmit_address_suggestion (const struct
72/** 72/**
73 * Handle 'address add' messages from clients. 73 * Handle 'address add' messages from clients.
74 * 74 *
75 * @param client client that sent the request
76 * @param m the request message 75 * @param m the request message
77 */ 76 */
78void 77void