aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Schanzenbach <schanzen@gnunet.org>2022-10-18 10:04:57 +0900
committerMartin Schanzenbach <schanzen@gnunet.org>2022-10-18 10:04:57 +0900
commitc9562b8cf7a29f4ec2457cb9d9d4530c24225da1 (patch)
treefb7d0296af5537ddda7e772a46e959c8ed64fbac
parent9173da4f8c1f4b50ccd9d61f6fa138904740ecfa (diff)
parentd748b0c920b0581ca65962f34d1f2e94c9a89926 (diff)
downloadgnunet-c9562b8cf7a29f4ec2457cb9d9d4530c24225da1.tar.gz
gnunet-c9562b8cf7a29f4ec2457cb9d9d4530c24225da1.zip
-fix conflict
-rwxr-xr-xcontrib/scripts/doc/warningfilter.py (renamed from contrib/warningfilter.py)8
-rw-r--r--doc/doxygen/.gitignore1
-rw-r--r--doc/doxygen/gnunet.doxy8
-rw-r--r--src/abd/delegate_misc.c1
-rw-r--r--src/abd/gnunet-abd.c4
-rw-r--r--src/arm/gnunet-service-arm.c2
-rw-r--r--src/ats/gnunet-service-ats_connectivity.c2
-rw-r--r--src/ats/gnunet-service-ats_reservations.h2
-rw-r--r--src/block/bg_bf.c2
-rw-r--r--src/block/plugin_block_template.c7
-rw-r--r--src/block/plugin_block_test.c7
-rw-r--r--src/cadet/cadet_api.c9
-rw-r--r--src/cadet/cadet_api_drop_message.c2
-rw-r--r--src/cadet/cadet_api_list_tunnels.c2
-rw-r--r--src/cadet/gnunet-cadet-profiler.c2
-rw-r--r--src/cadet/gnunet-service-cadet.c3
-rw-r--r--src/cadet/gnunet-service-cadet_channel.c4
-rw-r--r--src/cadet/gnunet-service-cadet_connection.c6
-rw-r--r--src/cadet/gnunet-service-cadet_connection.h2
-rw-r--r--src/cadet/gnunet-service-cadet_core.c8
-rw-r--r--src/cadet/gnunet-service-cadet_hello.c2
-rw-r--r--src/cadet/gnunet-service-cadet_paths.h4
-rw-r--r--src/cadet/gnunet-service-cadet_peer.c10
-rw-r--r--src/cadet/gnunet-service-cadet_tunnels.c17
-rw-r--r--src/cadet/gnunet-service-cadet_tunnels.h4
-rw-r--r--src/consensus/plugin_block_consensus.c1
-rw-r--r--src/conversation/conversation_api.c2
-rw-r--r--src/conversation/conversation_api_call.c4
-rw-r--r--src/core/core_api.c1
-rw-r--r--src/core/gnunet-service-core_kx.c9
-rw-r--r--src/datacache/plugin_datacache_postgres.c4
-rw-r--r--src/datacache/plugin_datacache_sqlite.c2
-rw-r--r--src/datastore/datastore_api.c2
-rw-r--r--src/datastore/gnunet-service-datastore.c15
-rw-r--r--src/datastore/plugin_datastore_postgres.c2
-rw-r--r--src/dht/gnunet-service-dht.h1
-rw-r--r--src/dht/gnunet-service-dht_clients.c12
-rw-r--r--src/dht/gnunet-service-dht_neighbours.c11
-rw-r--r--src/dht/gnunet-service-dht_neighbours.h4
-rw-r--r--src/dht/gnunet-service-dht_routing.c2
-rw-r--r--src/dhtu/plugin_dhtu_gnunet.c2
-rw-r--r--src/dhtu/plugin_dhtu_ip.c1
-rw-r--r--src/dns/dns_api.c3
-rw-r--r--src/dns/plugin_block_dns.c1
-rw-r--r--src/exit/gnunet-daemon-exit.c5
-rw-r--r--src/fs/fs_dirmetascan.c8
-rw-r--r--src/fs/fs_download.c65
-rw-r--r--src/fs/fs_file_information.c69
-rw-r--r--src/fs/fs_list_indexed.c8
-rw-r--r--src/fs/fs_namespace.c15
-rw-r--r--src/fs/fs_search.c4
-rw-r--r--src/fs/fs_test_lib.c1
-rw-r--r--src/fs/fs_uri.c17
-rw-r--r--src/fs/gnunet-service-fs.c6
-rw-r--r--src/fs/gnunet-service-fs_cadet_server.c1
-rw-r--r--src/fs/gnunet-service-fs_cp.c2
-rw-r--r--src/fs/gnunet-service-fs_push.c2
-rw-r--r--src/fs/plugin_block_fs.c3
-rw-r--r--src/gns/gns_tld_api.c2
-rw-r--r--src/gns/gnunet-gns-proxy.c1
-rw-r--r--src/gns/gnunet-service-gns.c3
-rw-r--r--src/gns/nss/nss_gns.c4
-rw-r--r--src/gns/plugin_block_gns.c1
-rw-r--r--src/gns/plugin_rest_gns.c2
-rw-r--r--src/gnsrecord/gnsrecord.c16
-rw-r--r--src/gnsrecord/gnsrecord_crypto.c19
-rw-r--r--src/gnsrecord/gnsrecord_misc.c8
-rw-r--r--src/gnsrecord/gnsrecord_serialization.c17
-rw-r--r--src/hello/address.c18
-rw-r--r--src/hello/hello-ng.c4
-rw-r--r--src/hello/hello.c22
-rw-r--r--src/hostlist/gnunet-daemon-hostlist_client.c2
-rw-r--r--src/identity/gnunet-service-identity.c15
-rw-r--r--src/identity/identity_api.c10
-rw-r--r--src/identity/plugin_rest_identity.c4
-rw-r--r--src/include/block_dns.h5
-rw-r--r--src/include/block_fs.h5
-rw-r--r--src/include/gnunet_abd_service.h9
-rw-r--r--src/include/gnunet_applications.h5
-rw-r--r--src/include/gnunet_ats_service.h6
-rw-r--r--src/include/gnunet_block_group_lib.h2
-rw-r--r--src/include/gnunet_block_lib.h3
-rw-r--r--src/include/gnunet_client_lib.h4
-rw-r--r--src/include/gnunet_common.h4
-rw-r--r--src/include/gnunet_configuration_lib.h2
-rw-r--r--src/include/gnunet_container_lib.h18
-rw-r--r--src/include/gnunet_crypto_lib.h14
-rw-r--r--src/include/gnunet_curl_lib.h14
-rw-r--r--src/include/gnunet_dhtu_plugin.h2
-rw-r--r--src/include/gnunet_disk_lib.h2
-rw-r--r--src/include/gnunet_dnsstub_lib.h2
-rw-r--r--src/include/gnunet_friends_lib.h5
-rw-r--r--src/include/gnunet_fs_service.h4
-rw-r--r--src/include/gnunet_getopt_lib.h1
-rw-r--r--src/include/gnunet_gns_service.h2
-rw-r--r--src/include/gnunet_gnsrecord_lib.h4
-rw-r--r--src/include/gnunet_hello_lib.h8
-rw-r--r--src/include/gnunet_json_lib.h4
-rw-r--r--src/include/gnunet_load_lib.h5
-rw-r--r--src/include/gnunet_messenger_service.h20
-rw-r--r--src/include/gnunet_mq_lib.h19
-rw-r--r--src/include/gnunet_mst_lib.h4
-rw-r--r--src/include/gnunet_my_lib.h19
-rw-r--r--src/include/gnunet_nat_auto_service.h2
-rw-r--r--src/include/gnunet_nc_lib.h2
-rw-r--r--src/include/gnunet_nt_lib.h5
-rw-r--r--src/include/gnunet_peerinfo_service.h1
-rw-r--r--src/include/gnunet_peerstore_service.h1
-rw-r--r--src/include/gnunet_pq_lib.h12
-rw-r--r--src/include/gnunet_reclaim_lib.h14
-rw-r--r--src/include/gnunet_reclaim_service.h8
-rw-r--r--src/include/gnunet_resolver_service.h5
-rw-r--r--src/include/gnunet_scalarproduct_service.h2
-rw-r--r--src/include/gnunet_service_lib.h8
-rw-r--r--src/include/gnunet_set_service.h10
-rw-r--r--src/include/gnunet_setu_service.h6
-rw-r--r--src/include/gnunet_socks.h5
-rw-r--r--src/include/gnunet_sq_lib.h2
-rw-r--r--src/include/gnunet_strings_lib.h4
-rw-r--r--src/include/gnunet_testbed_service.h8
-rw-r--r--src/include/gnunet_testing_lib.h6
-rw-r--r--src/include/gnunet_testing_netjail_lib.h4
-rw-r--r--src/include/gnunet_testing_ng_lib.h4
-rw-r--r--src/include/gnunet_time_lib.h2
-rw-r--r--src/include/gnunet_transport_application_service.h4
-rw-r--r--src/include/gnunet_transport_communication_service.h5
-rw-r--r--src/include/gnunet_transport_service.h5
-rw-r--r--src/messenger/gnunet-messenger.c14
-rw-r--r--src/messenger/gnunet-service-messenger_ego_store.h24
-rw-r--r--src/messenger/gnunet-service-messenger_handle.h26
-rw-r--r--src/messenger/gnunet-service-messenger_list_handles.h10
-rw-r--r--src/messenger/gnunet-service-messenger_list_messages.h8
-rw-r--r--src/messenger/gnunet-service-messenger_member.h20
-rw-r--r--src/messenger/gnunet-service-messenger_member_session.h16
-rw-r--r--src/messenger/gnunet-service-messenger_member_store.h12
-rw-r--r--src/messenger/gnunet-service-messenger_message_handle.h32
-rw-r--r--src/messenger/gnunet-service-messenger_message_kind.h2
-rw-r--r--src/messenger/gnunet-service-messenger_message_recv.h12
-rw-r--r--src/messenger/gnunet-service-messenger_message_send.h16
-rw-r--r--src/messenger/gnunet-service-messenger_message_store.h12
-rw-r--r--src/messenger/gnunet-service-messenger_operation.h8
-rw-r--r--src/messenger/gnunet-service-messenger_operation_store.h8
-rw-r--r--src/messenger/gnunet-service-messenger_room.h56
-rw-r--r--src/messenger/gnunet-service-messenger_service.h32
-rw-r--r--src/messenger/gnunet-service-messenger_tunnel.h26
-rw-r--r--src/messenger/messenger_api_contact.h10
-rw-r--r--src/messenger/messenger_api_contact_store.h14
-rw-r--r--src/messenger/messenger_api_handle.h18
-rw-r--r--src/messenger/messenger_api_list_tunnels.h16
-rw-r--r--src/messenger/messenger_api_message.h10
-rw-r--r--src/messenger/messenger_api_room.h12
-rw-r--r--src/messenger/messenger_api_util.h2
-rw-r--r--src/messenger/testing_messenger_barrier.h4
-rw-r--r--src/my/my_query_helper.c14
-rw-r--r--src/my/my_result_helper.c11
-rw-r--r--src/mysql/mysql.c1
-rw-r--r--src/namecache/gnunet-service-namecache.c2
-rw-r--r--src/namecache/namecache_api.c1
-rw-r--r--src/namestore/gnunet-namestore-fcfsd.c2
-rw-r--r--src/namestore/gnunet-namestore.c4
-rw-r--r--src/namestore/gnunet-service-namestore.c10
-rw-r--r--src/namestore/gnunet-zoneimport.c2
-rw-r--r--src/namestore/plugin_namestore_flat.c818
-rw-r--r--src/namestore/plugin_namestore_postgres.c4
-rw-r--r--src/namestore/plugin_rest_namestore.c2
-rw-r--r--src/nat-auto/gnunet-nat-server.c2
-rw-r--r--src/nat-auto/nat_auto_api_test.c2
-rw-r--r--src/nat/gnunet-nat.c2
-rw-r--r--src/nat/gnunet-service-nat.c2
-rw-r--r--src/nat/gnunet-service-nat_helper.c10
-rw-r--r--src/nat/gnunet-service-nat_mini.c8
-rw-r--r--src/nat/nat_api.c20
-rw-r--r--src/nat/nat_api_stun.c2
-rw-r--r--src/nse/gnunet-service-nse.c2
-rw-r--r--src/nt/nt.c6
-rw-r--r--src/peerinfo/peerinfo_api.c23
-rw-r--r--src/peerstore/peerstore_api.c11
-rw-r--r--src/peerstore/peerstore_common.c6
-rw-r--r--src/pq/pq_event.c2
-rw-r--r--src/pq/pq_exec.c9
-rw-r--r--src/pq/pq_result_helper.c26
-rw-r--r--src/reclaim/did.h4
-rw-r--r--src/reclaim/gnunet-service-reclaim.c16
-rw-r--r--src/reclaim/gnunet-service-reclaim_tickets.c21
-rw-r--r--src/reclaim/oidc_helper.c11
-rw-r--r--src/reclaim/oidc_helper.h6
-rw-r--r--src/reclaim/reclaim_api.c69
-rw-r--r--src/reclaim/reclaim_attribute.c33
-rw-r--r--src/reclaim/reclaim_credential.c72
-rw-r--r--src/regex/gnunet-regex-profiler.c1
-rw-r--r--src/regex/gnunet-service-regex.c6
-rw-r--r--src/regex/regex_api_announce.c5
-rw-r--r--src/regex/regex_api_search.c17
-rw-r--r--src/regex/regex_block_lib.c43
-rw-r--r--src/regex/regex_internal.c64
-rw-r--r--src/regex/regex_internal.h4
-rw-r--r--src/regex/regex_internal_dht.c6
-rw-r--r--src/rest/gnunet-rest-server.c1
-rw-r--r--src/rest/plugin_rest_config.c1
-rw-r--r--src/rest/rest.c13
-rw-r--r--src/revocation/revocation_api.c14
-rw-r--r--src/rps/gnunet-rps-profiler.c2
-rw-r--r--src/rps/gnunet-rps.c2
-rw-r--r--src/rps/gnunet-service-rps.c12
-rw-r--r--src/rps/gnunet-service-rps_sampler_elem.c2
-rw-r--r--src/rps/rps-sampler_common.c22
-rw-r--r--src/rps/rps-sampler_common.h2
-rw-r--r--src/rps/rps_api.c2
-rw-r--r--src/scalarproduct/gnunet-scalarproduct.c1
-rw-r--r--src/scalarproduct/gnunet-service-scalarproduct-ecc_alice.c2
-rw-r--r--src/scalarproduct/gnunet-service-scalarproduct-ecc_bob.c4
-rw-r--r--src/scalarproduct/gnunet-service-scalarproduct_alice.c2
-rw-r--r--src/scalarproduct/gnunet-service-scalarproduct_bob.c2
-rw-r--r--src/scalarproduct/scalarproduct_api.c25
-rw-r--r--src/secretsharing/gnunet-service-secretsharing.c1
-rw-r--r--src/secretsharing/secretsharing_api.c26
-rw-r--r--src/secretsharing/secretsharing_protocol.h8
-rw-r--r--src/set/gnunet-service-set.c4
-rw-r--r--src/set/gnunet-service-set_intersection.c9
-rw-r--r--src/set/gnunet-service-set_intersection.h2
-rw-r--r--src/set/gnunet-service-set_union.c6
-rw-r--r--src/set/gnunet-service-set_union_strata_estimator.c6
-rw-r--r--src/set/set_api.c63
-rw-r--r--src/seti/seti_api.c26
-rw-r--r--src/setu/ibf.c30
-rw-r--r--src/setu/setu_api.c26
-rw-r--r--src/sq/sq.c13
-rw-r--r--src/sq/sq_prepare.c8
-rw-r--r--src/sq/sq_query_helper.c2
-rw-r--r--src/statistics/gnunet-service-statistics.c10
-rw-r--r--src/statistics/statistics_api.c40
-rw-r--r--src/testbed-logger/testbed_logger_api.c7
-rw-r--r--src/testbed/gnunet-service-testbed.c9
-rw-r--r--src/testbed/gnunet-service-testbed.h11
-rw-r--r--src/testbed/gnunet-service-testbed_barriers.c4
-rw-r--r--src/testbed/gnunet-service-testbed_peers.c18
-rw-r--r--src/testbed/testbed_api.c75
-rw-r--r--src/testbed/testbed_api_barriers.c11
-rw-r--r--src/testbed/testbed_api_hosts.c19
-rw-r--r--src/testbed/testbed_api_operations.c8
-rw-r--r--src/testbed/testbed_api_operations.h4
-rw-r--r--src/testbed/testbed_api_peers.c55
-rw-r--r--src/testbed/testbed_api_testbed.c5
-rw-r--r--src/testbed/testbed_api_topology.c63
-rw-r--r--src/testbed/testbed_api_topology.h6
-rw-r--r--src/testing/testing.c60
-rw-r--r--src/testing/testing_api_cmd_local_test_prepared.c8
-rw-r--r--src/testing/testing_api_loop.c12
-rw-r--r--src/transport/gnunet-communicator-tcp.c16
-rw-r--r--src/transport/gnunet-communicator-udp.c12
-rw-r--r--src/transport/gnunet-service-tng.c32
-rw-r--r--src/transport/gnunet-service-transport.c7
-rw-r--r--src/transport/gnunet-service-transport_ats.c14
-rw-r--r--src/transport/gnunet-service-transport_ats.h3
-rw-r--r--src/transport/gnunet-service-transport_hello.c10
-rw-r--r--src/transport/gnunet-service-transport_manipulation.c4
-rw-r--r--src/transport/gnunet-service-transport_neighbours.c24
-rw-r--r--src/transport/gnunet-service-transport_neighbours.h2
-rw-r--r--src/transport/gnunet-service-transport_plugins.c19
-rw-r--r--src/transport/gnunet-service-transport_plugins.h4
-rw-r--r--src/transport/plugin_transport_http_client.c6
-rw-r--r--src/transport/plugin_transport_http_common.c45
-rw-r--r--src/transport/plugin_transport_http_common.h6
-rw-r--r--src/transport/plugin_transport_http_server.c2
-rw-r--r--src/transport/plugin_transport_tcp.c2
-rw-r--r--src/transport/plugin_transport_udp.c2
-rw-r--r--src/transport/tcp_server_legacy.c20
-rw-r--r--src/transport/transport-testing-cmds.h10
-rw-r--r--src/transport/transport-testing-communicator.c15
-rw-r--r--src/transport/transport-testing-filenames.c28
-rw-r--r--src/transport/transport-testing-main.c2
-rw-r--r--src/transport/transport-testing-main2.c2
-rw-r--r--src/transport/transport-testing2.c33
-rw-r--r--src/transport/transport-testing2.h2
-rw-r--r--src/transport/transport_api2_communication.c80
-rw-r--r--src/transport/transport_api_address_to_string.c4
-rw-r--r--src/transport/transport_api_cmd_backchannel_check.c12
-rw-r--r--src/transport/transport_api_cmd_connecting_peers.c11
-rw-r--r--src/transport/transport_api_cmd_send_simple.c10
-rw-r--r--src/transport/transport_api_core.c2
-rw-r--r--src/transport/transport_api_monitor_peers.c26
-rw-r--r--src/transport/transport_api_monitor_plugins.c4
-rw-r--r--src/transport/transport_api_offer_hello.c5
-rw-r--r--src/util/child_management.c2
-rw-r--r--src/util/common_logging.c38
-rw-r--r--src/util/configuration.c4
-rw-r--r--src/util/container_multihashmap32.c4
-rw-r--r--src/util/crypto_rsa.c2
-rw-r--r--src/util/dnsstub.c14
-rw-r--r--src/util/gnunet-scrypt.c1
-rw-r--r--src/util/gnunet-service-resolver.c8
-rw-r--r--src/util/helper.c46
-rw-r--r--src/util/mst.c14
-rw-r--r--src/util/network.c23
-rw-r--r--src/util/os_installation.c5
-rw-r--r--src/util/os_priority.c51
-rw-r--r--src/util/peer.c12
-rw-r--r--src/util/regex.c42
-rw-r--r--src/util/scheduler.c28
-rw-r--r--src/util/service.c2
-rw-r--r--src/util/socks.c2
-rw-r--r--src/util/speedup.c6
-rw-r--r--src/util/tun.c39
-rw-r--r--src/vpn/gnunet-service-vpn.c4
-rw-r--r--src/vpn/vpn_api.c22
305 files changed, 1532 insertions, 2748 deletions
diff --git a/contrib/warningfilter.py b/contrib/scripts/doc/warningfilter.py
index b8399bb38..31ac5865c 100755
--- a/contrib/warningfilter.py
+++ b/contrib/scripts/doc/warningfilter.py
@@ -61,18 +61,18 @@ matches = {
61 "undocumented param (name)": re.compile(r" parameter '([\w.]+)'"), 61 "undocumented param (name)": re.compile(r" parameter '([\w.]+)'"),
62 "explicit link not resolved": re.compile(rf"{main_match} explicit link request to '(\w+(?:\(\))?)' could not be resolved"), 62 "explicit link not resolved": re.compile(rf"{main_match} explicit link request to '(\w+(?:\(\))?)' could not be resolved"),
63 "unknown command": re.compile(rf"{main_match} Found unknown command '(\\\w+)'"), 63 "unknown command": re.compile(rf"{main_match} Found unknown command '(\\\w+)'"),
64 "missing argument": re.compile(rf"{main_match} argument '(\w+)' of command @param is not found in the argument list of {func_name}(?:{func_params}|{macro_params})"), 64 "missing argument": re.compile(rf"{main_match} argument '(\w+)' of command @param is not found in the argument list of ({func_name})(?:{func_params}|{macro_params})"),
65 "eof inside group": re.compile(rf"{main_match} end of file while inside a group"), 65 "eof inside group": re.compile(rf"{main_match} end of file while inside a group"),
66 "eof inside comment": re.compile(rf"{main_match} Reached end of file while still inside a \(nested\) comment. Nesting level \d+ \(probable line reference: \d+\)"), 66 "eof inside comment": re.compile(rf"{main_match} Reached end of file while still inside a \(nested\) comment. Nesting level \d+ \(probable line reference: (\d+)\)"),
67 "eof inside code block": re.compile(rf"{main_match} reached end of file while inside a 'code' block!"), 67 "eof inside code block": re.compile(rf"{main_match} reached end of file while inside a 'code' block!"),
68 "eof inside code block (line 2)": re.compile(rf"The command that should end the block seems to be missing!"), 68 "eof inside code block (line 2)": re.compile(rf"The command that should end the block seems to be missing!"),
69 "title mismatch": re.compile(rf"{main_match} group (?P<group_id>\w+): ignoring title \"(?P<new_title>{verbose_name})\" that does not match old title \"(?P<old_title>{verbose_name})\""), 69 "title mismatch": re.compile(rf"{main_match} group (?P<group_id>\w+): ignoring title \"(?P<new_title>{verbose_name})\" that does not match old title \"(?P<old_title>{verbose_name})\""),
70 "end of comment expecting command": re.compile(rf"{main_match} end of comment block while expecting command {command_re}"), 70 "end of comment expecting command": re.compile(rf"{main_match} end of comment block while expecting command ({command_re})"),
71 "no matching tag": re.compile(rf"{main_match} found </(?P<tag>[^>]+)> tag without matching <(?P=tag)>"), 71 "no matching tag": re.compile(rf"{main_match} found </(?P<tag>[^>]+)> tag without matching <(?P=tag)>"),
72 "documented empty return type": re.compile(rf"{main_match} documented empty return type of {func_name}"), 72 "documented empty return type": re.compile(rf"{main_match} documented empty return type of {func_name}"),
73 "unsupported tag": re.compile(rf"{main_match} Unsupported xml/html tag <(?P<tag>[^>]+)> found"), 73 "unsupported tag": re.compile(rf"{main_match} Unsupported xml/html tag <(?P<tag>[^>]+)> found"),
74 "expected whitespace after command": re.compile(rf"{main_match} expected whitespace after \\(?P<command>\w+) command"), 74 "expected whitespace after command": re.compile(rf"{main_match} expected whitespace after \\(?P<command>\w+) command"),
75 "illegal command": re.compile(rf"{main_match} Illegal command (?P<illegal_cmd>(?:@|\\)\w+) as part of a (?P<command>\\\w+) command"), 75 "illegal command": re.compile(rf"{main_match} Illegal command (?P<illegal_cmd>(?:@|\\)\w+) as part of a \\(?P<command>\w+) command"),
76 "undeclared symbol": re.compile(rf"{main_match} documented symbol '(\w+)' was not declared or defined\."), 76 "undeclared symbol": re.compile(rf"{main_match} documented symbol '(\w+)' was not declared or defined\."),
77 "nameless member": re.compile(rf"{main_match} member with no name found."), 77 "nameless member": re.compile(rf"{main_match} member with no name found."),
78 "end of empty list": re.compile(rf"{main_match} End of list marker found without any preceding list items"), 78 "end of empty list": re.compile(rf"{main_match} End of list marker found without any preceding list items"),
diff --git a/doc/doxygen/.gitignore b/doc/doxygen/.gitignore
index 6000c5c92..8cfc0958d 100644
--- a/doc/doxygen/.gitignore
+++ b/doc/doxygen/.gitignore
@@ -1,4 +1,5 @@
1version.doxy 1version.doxy
2gnunet.tag 2gnunet.tag
3doxygen_warnings.log
3html/ 4html/
4xml/ 5xml/
diff --git a/doc/doxygen/gnunet.doxy b/doc/doxygen/gnunet.doxy
index bfde393ae..3a7a9165f 100644
--- a/doc/doxygen/gnunet.doxy
+++ b/doc/doxygen/gnunet.doxy
@@ -820,7 +820,7 @@ WARN_FORMAT = "$file:$line: $text"
820# messages should be written. If left blank the output is written to standard 820# messages should be written. If left blank the output is written to standard
821# error (stderr). 821# error (stderr).
822 822
823WARN_LOGFILE = 823WARN_LOGFILE = "doxygen_warnings.log"
824 824
825#--------------------------------------------------------------------------- 825#---------------------------------------------------------------------------
826# Configuration options related to the input files 826# Configuration options related to the input files
@@ -1537,7 +1537,7 @@ ECLIPSE_DOC_ID = org.doxygen.Project
1537# The default value is: NO. 1537# The default value is: NO.
1538# This tag requires that the tag GENERATE_HTML is set to YES. 1538# This tag requires that the tag GENERATE_HTML is set to YES.
1539 1539
1540DISABLE_INDEX = NO 1540DISABLE_INDEX = YES
1541 1541
1542# The GENERATE_TREEVIEW tag is used to specify whether a tree-like index 1542# The GENERATE_TREEVIEW tag is used to specify whether a tree-like index
1543# structure should be generated to display hierarchical information. If the tag 1543# structure should be generated to display hierarchical information. If the tag
@@ -1554,7 +1554,7 @@ DISABLE_INDEX = NO
1554# The default value is: NO. 1554# The default value is: NO.
1555# This tag requires that the tag GENERATE_HTML is set to YES. 1555# This tag requires that the tag GENERATE_HTML is set to YES.
1556 1556
1557GENERATE_TREEVIEW = NONE 1557GENERATE_TREEVIEW = YES
1558 1558
1559# The ENUM_VALUES_PER_LINE tag can be used to set the number of enum values that 1559# The ENUM_VALUES_PER_LINE tag can be used to set the number of enum values that
1560# doxygen will group on one line in the generated HTML documentation. 1560# doxygen will group on one line in the generated HTML documentation.
@@ -2485,7 +2485,7 @@ DOT_IMAGE_FORMAT = svg
2485# The default value is: NO. 2485# The default value is: NO.
2486# This tag requires that the tag HAVE_DOT is set to YES. 2486# This tag requires that the tag HAVE_DOT is set to YES.
2487 2487
2488INTERACTIVE_SVG = NO 2488INTERACTIVE_SVG = YES
2489 2489
2490# The DOT_PATH tag can be used to specify the path where the dot tool can be 2490# The DOT_PATH tag can be used to specify the path where the dot tool can be
2491# found. If left blank, it is assumed the dot tool can be found in the path. 2491# found. If left blank, it is assumed the dot tool can be found in the path.
diff --git a/src/abd/delegate_misc.c b/src/abd/delegate_misc.c
index 0c5520d52..cc45cde04 100644
--- a/src/abd/delegate_misc.c
+++ b/src/abd/delegate_misc.c
@@ -190,6 +190,7 @@ GNUNET_ABD_delegate_from_string (const char *s)
190 * @param issuer the ego that should be used to issue the attribute 190 * @param issuer the ego that should be used to issue the attribute
191 * @param subject the subject of the attribute 191 * @param subject the subject of the attribute
192 * @param iss_attr the name of the attribute 192 * @param iss_attr the name of the attribute
193 * @param expiration the TTL of the credential
193 * @return handle to the queued request 194 * @return handle to the queued request
194 */ 195 */
195 196
diff --git a/src/abd/gnunet-abd.c b/src/abd/gnunet-abd.c
index 9f5fef958..6f6521d98 100644
--- a/src/abd/gnunet-abd.c
+++ b/src/abd/gnunet-abd.c
@@ -429,8 +429,8 @@ identity_cb (void *cls, struct GNUNET_IDENTITY_Ego *ego)
429 * Parse expiration time. 429 * Parse expiration time.
430 * 430 *
431 * @param expirationstring text to parse 431 * @param expirationstring text to parse
432 * @param etime_is_rel[out] set to #GNUNET_YES if time is relative 432 * @param[out] etime_is_rel set to #GNUNET_YES if time is relative
433 * @param etime[out] set to expiration time (abs or rel) 433 * @param[out] etime set to expiration time (abs or rel)
434 * @return #GNUNET_OK on success 434 * @return #GNUNET_OK on success
435 */ 435 */
436static int 436static int
diff --git a/src/arm/gnunet-service-arm.c b/src/arm/gnunet-service-arm.c
index b412094d3..da94efdd8 100644
--- a/src/arm/gnunet-service-arm.c
+++ b/src/arm/gnunet-service-arm.c
@@ -1358,7 +1358,7 @@ pool_write (char *pool_start, size_t pool_size, size_t *pool_pos, char *str)
1358 * Handle LIST-message. 1358 * Handle LIST-message.
1359 * 1359 *
1360 * @param cls identification of the client 1360 * @param cls identification of the client
1361 * @param message the actual message 1361 * @param request the actual message
1362 */ 1362 */
1363static void 1363static void
1364handle_list (void *cls, const struct GNUNET_ARM_Message *request) 1364handle_list (void *cls, const struct GNUNET_ARM_Message *request)
diff --git a/src/ats/gnunet-service-ats_connectivity.c b/src/ats/gnunet-service-ats_connectivity.c
index 5ee9b60f5..702c5ba87 100644
--- a/src/ats/gnunet-service-ats_connectivity.c
+++ b/src/ats/gnunet-service-ats_connectivity.c
@@ -76,7 +76,7 @@ GAS_connectivity_has_peer (void *cls,
76 * Handle #GNUNET_MESSAGE_TYPE_ATS_REQUEST_ADDRESS messages from clients. 76 * Handle #GNUNET_MESSAGE_TYPE_ATS_REQUEST_ADDRESS messages from clients.
77 * 77 *
78 * @param client client that sent the request 78 * @param client client that sent the request
79 * @param message the request message 79 * @param msg the request message
80 */ 80 */
81void 81void
82GAS_handle_request_address (struct GNUNET_SERVICE_Client *client, 82GAS_handle_request_address (struct GNUNET_SERVICE_Client *client,
diff --git a/src/ats/gnunet-service-ats_reservations.h b/src/ats/gnunet-service-ats_reservations.h
index d95945697..07edd69e0 100644
--- a/src/ats/gnunet-service-ats_reservations.h
+++ b/src/ats/gnunet-service-ats_reservations.h
@@ -58,8 +58,6 @@ GAS_handle_reservation_request (struct GNUNET_SERVICE_Client *client,
58 58
59/** 59/**
60 * Initialize reservations subsystem. 60 * Initialize reservations subsystem.
61 *
62 * @param server handle to our server
63 */ 61 */
64void 62void
65GAS_reservations_init (void); 63GAS_reservations_init (void);
diff --git a/src/block/bg_bf.c b/src/block/bg_bf.c
index b79ea3c55..c8269498e 100644
--- a/src/block/bg_bf.c
+++ b/src/block/bg_bf.c
@@ -226,7 +226,7 @@ GNUNET_BLOCK_GROUP_bf_create (void *cls,
226 * @param bg block group to use for testing 226 * @param bg block group to use for testing
227 * @param hc hash of element to evaluate 227 * @param hc hash of element to evaluate
228 * @return #GNUNET_YES if @a hc is (likely) a duplicate 228 * @return #GNUNET_YES if @a hc is (likely) a duplicate
229 * #GNUNET_NO if @a hc was definitively not in @bg (but now is) 229 * #GNUNET_NO if @a hc was definitively not in @a bg (but now is)
230 */ 230 */
231enum GNUNET_GenericReturnValue 231enum GNUNET_GenericReturnValue
232GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg, 232GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg,
diff --git a/src/block/plugin_block_template.c b/src/block/plugin_block_template.c
index 46a370924..4a271fa42 100644
--- a/src/block/plugin_block_template.c
+++ b/src/block/plugin_block_template.c
@@ -55,7 +55,7 @@
55 * by this @a type of block (this is not an error) 55 * by this @a type of block (this is not an error)
56 */ 56 */
57static struct GNUNET_BLOCK_Group * 57static struct GNUNET_BLOCK_Group *
58block_plugin_template_create_group (void *cls, 58block_plugin_template_create_group (void *ctx,
59 enum GNUNET_BLOCK_Type type, 59 enum GNUNET_BLOCK_Type type,
60 const void *raw_data, 60 const void *raw_data,
61 size_t raw_data_size, 61 size_t raw_data_size,
@@ -79,7 +79,7 @@ block_plugin_template_create_group (void *cls,
79 bf_size = TEMPLATE_BF_SIZE; 79 bf_size = TEMPLATE_BF_SIZE;
80 } 80 }
81 GNUNET_break (NULL == va_arg (va, const char *)); 81 GNUNET_break (NULL == va_arg (va, const char *));
82 return GNUNET_BLOCK_GROUP_bf_create (cls, 82 return GNUNET_BLOCK_GROUP_bf_create (ctx,
83 bf_size, 83 bf_size,
84 BLOOMFILTER_K, 84 BLOOMFILTER_K,
85 type, 85 type,
@@ -92,10 +92,9 @@ block_plugin_template_create_group (void *cls,
92 * Function called to validate a query. 92 * Function called to validate a query.
93 * 93 *
94 * @param cls closure 94 * @param cls closure
95 * @param ctx block context
96 * @param type block type 95 * @param type block type
97 * @param query original query (hash) 96 * @param query original query (hash)
98 * @param xquery extrended query data (can be NULL, depending on type) 97 * @param xquery extended query data (can be NULL, depending on type)
99 * @param xquery_size number of bytes in @a xquery 98 * @param xquery_size number of bytes in @a xquery
100 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not, #GNUNET_SYSERR if not supported 99 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not, #GNUNET_SYSERR if not supported
101 */ 100 */
diff --git a/src/block/plugin_block_test.c b/src/block/plugin_block_test.c
index 2e404bbc2..5afac9205 100644
--- a/src/block/plugin_block_test.c
+++ b/src/block/plugin_block_test.c
@@ -53,7 +53,7 @@
53 * by this @a type of block (this is not an error) 53 * by this @a type of block (this is not an error)
54 */ 54 */
55static struct GNUNET_BLOCK_Group * 55static struct GNUNET_BLOCK_Group *
56block_plugin_test_create_group (void *cls, 56block_plugin_test_create_group (void *ctx,
57 enum GNUNET_BLOCK_Type type, 57 enum GNUNET_BLOCK_Type type,
58 const void *raw_data, 58 const void *raw_data,
59 size_t raw_data_size, 59 size_t raw_data_size,
@@ -77,7 +77,7 @@ block_plugin_test_create_group (void *cls,
77 bf_size = TEST_BF_SIZE; 77 bf_size = TEST_BF_SIZE;
78 } 78 }
79 GNUNET_break (NULL == va_arg (va, const char *)); 79 GNUNET_break (NULL == va_arg (va, const char *));
80 return GNUNET_BLOCK_GROUP_bf_create (cls, 80 return GNUNET_BLOCK_GROUP_bf_create (ctx,
81 bf_size, 81 bf_size,
82 BLOOMFILTER_K, 82 BLOOMFILTER_K,
83 type, 83 type,
@@ -90,10 +90,9 @@ block_plugin_test_create_group (void *cls,
90 * Function called to validate a query. 90 * Function called to validate a query.
91 * 91 *
92 * @param cls closure 92 * @param cls closure
93 * @param ctx block context
94 * @param type block type 93 * @param type block type
95 * @param query original query (hash) 94 * @param query original query (hash)
96 * @param xquery extrended query data (can be NULL, depending on type) 95 * @param xquery extended query data (can be NULL, depending on type)
97 * @param xquery_size number of bytes in @a xquery 96 * @param xquery_size number of bytes in @a xquery
98 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not, #GNUNET_SYSERR if @a type is not supported 97 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not, #GNUNET_SYSERR if @a type is not supported
99 */ 98 */
diff --git a/src/cadet/cadet_api.c b/src/cadet/cadet_api.c
index 00c3d2e48..0bfb01868 100644
--- a/src/cadet/cadet_api.c
+++ b/src/cadet/cadet_api.c
@@ -198,7 +198,6 @@ create_channel (struct GNUNET_CADET_Handle *h,
198 * - Frees all memory used 198 * - Frees all memory used
199 * 199 *
200 * @param ch Pointer to the channel. 200 * @param ch Pointer to the channel.
201 * @param call_cleaner Whether to call the cleaner handler.
202 */ 201 */
203static void 202static void
204destroy_channel (struct GNUNET_CADET_Channel *ch) 203destroy_channel (struct GNUNET_CADET_Channel *ch)
@@ -461,7 +460,7 @@ cadet_mq_cancel_impl (struct GNUNET_MQ_Handle *mq, void *impl_state)
461/** 460/**
462 * Process the new channel notification and add it to the channels in the handle 461 * Process the new channel notification and add it to the channels in the handle
463 * 462 *
464 * @param h The cadet handle 463 * @param cls The cadet handle
465 * @param msg A message with the details of the new incoming channel 464 * @param msg A message with the details of the new incoming channel
466 */ 465 */
467static void 466static void
@@ -529,7 +528,7 @@ handle_channel_created (
529/** 528/**
530 * Process the channel destroy notification and free associated resources 529 * Process the channel destroy notification and free associated resources
531 * 530 *
532 * @param h The cadet handle 531 * @param cls The cadet handle
533 * @param msg A message with the details of the channel being destroyed 532 * @param msg A message with the details of the channel being destroyed
534 */ 533 */
535static void 534static void
@@ -582,7 +581,7 @@ check_local_data (void *cls, const struct GNUNET_CADET_LocalData *message)
582/** 581/**
583 * Process the incoming data packets, call appropriate handlers. 582 * Process the incoming data packets, call appropriate handlers.
584 * 583 *
585 * @param h The cadet handle 584 * @param cls The cadet handle
586 * @param message A message encapsulating the data 585 * @param message A message encapsulating the data
587 */ 586 */
588static void 587static void
@@ -620,7 +619,7 @@ handle_local_data (void *cls, const struct GNUNET_CADET_LocalData *message)
620 * Process a local ACK message, enabling the client to send 619 * Process a local ACK message, enabling the client to send
621 * more data to the service. 620 * more data to the service.
622 * 621 *
623 * @param h Cadet handle. 622 * @param cls Cadet handle.
624 * @param message Message itself. 623 * @param message Message itself.
625 */ 624 */
626static void 625static void
diff --git a/src/cadet/cadet_api_drop_message.c b/src/cadet/cadet_api_drop_message.c
index 2b031b5c0..e172418c4 100644
--- a/src/cadet/cadet_api_drop_message.c
+++ b/src/cadet/cadet_api_drop_message.c
@@ -27,7 +27,7 @@
27 27
28 28
29/** 29/**
30 * Drop the next cadet message of a given type.. 30 * Drop the next cadet message of a given type.
31 * 31 *
32 * @param mq message queue 32 * @param mq message queue
33 * @param ccn client channel number. 33 * @param ccn client channel number.
diff --git a/src/cadet/cadet_api_list_tunnels.c b/src/cadet/cadet_api_list_tunnels.c
index e9ae069bb..dce12835f 100644
--- a/src/cadet/cadet_api_list_tunnels.c
+++ b/src/cadet/cadet_api_list_tunnels.c
@@ -95,7 +95,7 @@ handle_get_tunnels (void *cls,
95 * Process a local reply about info on all tunnels, pass info to the user. 95 * Process a local reply about info on all tunnels, pass info to the user.
96 * 96 *
97 * @param cls a `struct GNUNET_CADET_ListTunnels *` 97 * @param cls a `struct GNUNET_CADET_ListTunnels *`
98 * @param message Message itself. 98 * @param msg Message itself.
99 */ 99 */
100static void 100static void
101handle_get_tunnels_end (void *cls, 101handle_get_tunnels_end (void *cls,
diff --git a/src/cadet/gnunet-cadet-profiler.c b/src/cadet/gnunet-cadet-profiler.c
index e61053f94..b84337370 100644
--- a/src/cadet/gnunet-cadet-profiler.c
+++ b/src/cadet/gnunet-cadet-profiler.c
@@ -659,8 +659,6 @@ ping (void *cls)
659/** 659/**
660 * @brief Reply with a pong to origin. 660 * @brief Reply with a pong to origin.
661 * 661 *
662 * @param cls Closure (peer).
663 * @param tc Task context.
664 */ 662 */
665static void 663static void
666pong (struct GNUNET_CADET_Channel *channel, 664pong (struct GNUNET_CADET_Channel *channel,
diff --git a/src/cadet/gnunet-service-cadet.c b/src/cadet/gnunet-service-cadet.c
index dd1f05807..07b580005 100644
--- a/src/cadet/gnunet-service-cadet.c
+++ b/src/cadet/gnunet-service-cadet.c
@@ -442,7 +442,7 @@ shutdown_task (void *cls)
442 * client @a cls opened port @a port. Bind them now. 442 * client @a cls opened port @a port. Bind them now.
443 * 443 *
444 * @param cls the `struct CadetClient` 444 * @param cls the `struct CadetClient`
445 * @param h_port the hashed port 445 * @param port the hashed port
446 * @param value the `struct CadetChannel` 446 * @param value the `struct CadetChannel`
447 * @return #GNUNET_YES (iterate over all such channels) 447 * @return #GNUNET_YES (iterate over all such channels)
448 */ 448 */
@@ -1226,7 +1226,6 @@ client_disconnect_cb (void *cls,
1226 * Setup CADET internals. 1226 * Setup CADET internals.
1227 * 1227 *
1228 * @param cls closure 1228 * @param cls closure
1229 * @param server the initialized server
1230 * @param c configuration to use 1229 * @param c configuration to use
1231 */ 1230 */
1232static void 1231static void
diff --git a/src/cadet/gnunet-service-cadet_channel.c b/src/cadet/gnunet-service-cadet_channel.c
index f742ba4a7..78658c296 100644
--- a/src/cadet/gnunet-service-cadet_channel.c
+++ b/src/cadet/gnunet-service-cadet_channel.c
@@ -1157,7 +1157,7 @@ GCCH_handle_channel_open_ack (
1157 * @param cls closure, to a flag where we indicate duplicate packets 1157 * @param cls closure, to a flag where we indicate duplicate packets
1158 * @param m1 a message of to sort 1158 * @param m1 a message of to sort
1159 * @param m2 another message to sort 1159 * @param m2 another message to sort
1160 * @return #GNUNET_YES if @e1 < @e2, otherwise #GNUNET_NO 1160 * @return #GNUNET_YES if @a e1 < @a e2, otherwise #GNUNET_NO
1161 */ 1161 */
1162static int 1162static int
1163is_before (void *cls, 1163is_before (void *cls,
@@ -1645,7 +1645,7 @@ GCCH_handle_remote_destroy (
1645 * @param cls closure, to a flag where we indicate duplicate packets 1645 * @param cls closure, to a flag where we indicate duplicate packets
1646 * @param crm1 an element of to sort 1646 * @param crm1 an element of to sort
1647 * @param crm2 another element to sort 1647 * @param crm2 another element to sort
1648 * @return #GNUNET_YES if @e1 < @e2, otherwise #GNUNET_NO 1648 * @return #GNUNET_YES if @a e1 < @a e2, otherwise #GNUNET_NO
1649 */ 1649 */
1650static int 1650static int
1651cmp_crm_by_next_retry (void *cls, 1651cmp_crm_by_next_retry (void *cls,
diff --git a/src/cadet/gnunet-service-cadet_connection.c b/src/cadet/gnunet-service-cadet_connection.c
index 66b67aa64..f01c1388e 100644
--- a/src/cadet/gnunet-service-cadet_connection.c
+++ b/src/cadet/gnunet-service-cadet_connection.c
@@ -431,9 +431,9 @@ GCC_ack_expected (const struct GNUNET_CADET_ConnectionTunnelIdentifier *cid)
431 431
432/** 432/**
433 * We observed an ACK for a message that was originally sent via 433 * We observed an ACK for a message that was originally sent via
434 * the connection identified by @a cti. 434 * the connection identified by @a cid.
435 * 435 *
436 * @param cti connection identifier where we got an ACK for a message 436 * @param cid connection identifier where we got an ACK for a message
437 * that was originally sent via this connection (the ACK 437 * that was originally sent via this connection (the ACK
438 * may have gotten back to us via a different connection). 438 * may have gotten back to us via a different connection).
439 */ 439 */
@@ -983,7 +983,7 @@ GCC_transmit (struct CadetConnection *cc, struct GNUNET_MQ_Envelope *env)
983 * Obtain the path used by this connection. 983 * Obtain the path used by this connection.
984 * 984 *
985 * @param cc connection 985 * @param cc connection
986 * @param off[out] set to the length of the path we use 986 * @param[out] off set to the length of the path we use
987 * @return path to @a cc 987 * @return path to @a cc
988 */ 988 */
989struct CadetPeerPath * 989struct CadetPeerPath *
diff --git a/src/cadet/gnunet-service-cadet_connection.h b/src/cadet/gnunet-service-cadet_connection.h
index 53c0c1541..54c845b13 100644
--- a/src/cadet/gnunet-service-cadet_connection.h
+++ b/src/cadet/gnunet-service-cadet_connection.h
@@ -322,7 +322,7 @@ GCC_get_ct (struct CadetConnection *cc);
322 * Obtain the path used by this connection. 322 * Obtain the path used by this connection.
323 * 323 *
324 * @param cc connection 324 * @param cc connection
325 * @param off[out] set to offset in this path where the connection @a cc ends 325 * @param[out] off set to offset in this path where the connection @a cc ends
326 * @return path to @a cc 326 * @return path to @a cc
327 */ 327 */
328struct CadetPeerPath * 328struct CadetPeerPath *
diff --git a/src/cadet/gnunet-service-cadet_core.c b/src/cadet/gnunet-service-cadet_core.c
index bff7632da..68f7405c3 100644
--- a/src/cadet/gnunet-service-cadet_core.c
+++ b/src/cadet/gnunet-service-cadet_core.c
@@ -612,10 +612,10 @@ timeout_cb (void *cls)
612 * later if the connection ever goes down. 612 * later if the connection ever goes down.
613 * 613 *
614 * @param cls the `struct RouteDirection` 614 * @param cls the `struct RouteDirection`
615 * @param available #GNUNET_YES if sending is now possible, 615 * @param ready #GNUNET_YES if sending is now possible,
616 * #GNUNET_NO if sending is no longer possible 616 * #GNUNET_NO if sending is no longer possible
617 * #GNUNET_SYSERR if sending is no longer possible 617 * #GNUNET_SYSERR if sending is no longer possible
618 * and the last envelope was discarded 618 * and the last envelope was discarded
619 */ 619 */
620static void 620static void
621dir_ready_cb (void *cls, int ready) 621dir_ready_cb (void *cls, int ready)
diff --git a/src/cadet/gnunet-service-cadet_hello.c b/src/cadet/gnunet-service-cadet_hello.c
index c7857032b..e1850d60a 100644
--- a/src/cadet/gnunet-service-cadet_hello.c
+++ b/src/cadet/gnunet-service-cadet_hello.c
@@ -57,7 +57,7 @@ static struct GNUNET_PEERINFO_NotifyContext *nc;
57 * Process each hello message received from peerinfo. 57 * Process each hello message received from peerinfo.
58 * 58 *
59 * @param cls Closure (unused). 59 * @param cls Closure (unused).
60 * @param peer Identity of the peer. 60 * @param id Identity of the peer.
61 * @param hello Hello of the peer. 61 * @param hello Hello of the peer.
62 * @param err_msg Error message. 62 * @param err_msg Error message.
63 */ 63 */
diff --git a/src/cadet/gnunet-service-cadet_paths.h b/src/cadet/gnunet-service-cadet_paths.h
index defdd0df2..0f3b4dd1a 100644
--- a/src/cadet/gnunet-service-cadet_paths.h
+++ b/src/cadet/gnunet-service-cadet_paths.h
@@ -53,8 +53,8 @@ GCPP_try_path_from_dht (const struct GNUNET_DHT_PathElement *get_path,
53 * We got an incoming connection, obtain the corresponding path. 53 * We got an incoming connection, obtain the corresponding path.
54 * 54 *
55 * @param path_length number of segments on the @a path 55 * @param path_length number of segments on the @a path
56 * @param path through the network, in reverse order 56 * @param pids path through the network, in reverse order
57 * (we are at the end, at index @a path_length) 57 * (we are at the end, at index @a path_length)
58 * @return corresponding path object 58 * @return corresponding path object
59 */ 59 */
60struct CadetPeerPath * 60struct CadetPeerPath *
diff --git a/src/cadet/gnunet-service-cadet_peer.c b/src/cadet/gnunet-service-cadet_peer.c
index 99669eb05..f2b508ae0 100644
--- a/src/cadet/gnunet-service-cadet_peer.c
+++ b/src/cadet/gnunet-service-cadet_peer.c
@@ -211,7 +211,7 @@ struct CadetPeer
211 211
212 /** 212 /**
213 * Sum over all of the offsets of all of the paths in the @a path_heads DLLs. 213 * Sum over all of the offsets of all of the paths in the @a path_heads DLLs.
214 * Used to speed-up @GCP_get_desirability_of_path() calculation. 214 * Used to speed-up #GCP_get_desirability_of_path() calculation.
215 */ 215 */
216 unsigned int off_sum; 216 unsigned int off_sum;
217 217
@@ -225,19 +225,13 @@ struct CadetPeer
225 unsigned int mqm_ready_counter; 225 unsigned int mqm_ready_counter;
226 226
227 /** 227 /**
228 * Current length of the @e path_heads and @path_tails arrays. 228 * Current length of the @e path_heads and @e path_tails arrays.
229 * The arrays should be grown as needed. 229 * The arrays should be grown as needed.
230 */ 230 */
231 unsigned int path_dll_length; 231 unsigned int path_dll_length;
232}; 232};
233 233
234 234
235/**
236 * Get the static string for a peer ID.
237 *
238 * @param cp Peer.
239 * @return Static string for it's ID.
240 */
241const char * 235const char *
242GCP_2s (const struct CadetPeer *cp) 236GCP_2s (const struct CadetPeer *cp)
243{ 237{
diff --git a/src/cadet/gnunet-service-cadet_tunnels.c b/src/cadet/gnunet-service-cadet_tunnels.c
index 9653fd3ec..c7e422926 100644
--- a/src/cadet/gnunet-service-cadet_tunnels.c
+++ b/src/cadet/gnunet-service-cadet_tunnels.c
@@ -169,7 +169,7 @@ struct CadetTunnelAxolotl
169 * 32-byte chain keys (used for forward-secrecy) for 169 * 32-byte chain keys (used for forward-secrecy) for
170 * receiving messages. Updated for every message. If 170 * receiving messages. Updated for every message. If
171 * messages are skipped, the respective derived MKs 171 * messages are skipped, the respective derived MKs
172 * (and the current @HKr) are kept in the @e skipped_head DLL. 172 * (and the current @e HKr) are kept in the @e skipped_head DLL.
173 */ 173 */
174 struct GNUNET_CRYPTO_SymmetricSessionKey CKr; 174 struct GNUNET_CRYPTO_SymmetricSessionKey CKr;
175 175
@@ -674,7 +674,7 @@ new_ephemeral (struct CadetTunnelAxolotl *ax)
674 * @param size Size of @c plaintext. 674 * @param size Size of @c plaintext.
675 * @param iv Initialization vector for the message. 675 * @param iv Initialization vector for the message.
676 * @param key Key to use. 676 * @param key Key to use.
677 * @param hmac[out] Destination to store the HMAC. 677 * @param[out] hmac Destination to store the HMAC.
678 */ 678 */
679static void 679static void
680t_hmac (const void *plaintext, 680t_hmac (const void *plaintext,
@@ -890,7 +890,7 @@ t_ax_decrypt (struct CadetTunnelAxolotl *ax,
890 * Encrypt header with the axolotl header key. 890 * Encrypt header with the axolotl header key.
891 * 891 *
892 * @param ax key material to use. 892 * @param ax key material to use.
893 * @param[in|out] msg Message whose header to encrypt. 893 * @param[in,out] msg Message whose header to encrypt.
894 */ 894 */
895static void 895static void
896t_h_encrypt (struct CadetTunnelAxolotl *ax, 896t_h_encrypt (struct CadetTunnelAxolotl *ax,
@@ -1488,7 +1488,7 @@ cleanup_ax (struct CadetTunnelAxolotl *ax)
1488 * Computes the new chain keys, and root keys, etc, and also checks 1488 * Computes the new chain keys, and root keys, etc, and also checks
1489 * whether this is a replay of the current chain. 1489 * whether this is a replay of the current chain.
1490 * 1490 *
1491 * @param[in|out] axolotl chain key state to recompute 1491 * @param[in,out] ax chain key state to recompute
1492 * @param pid peer identity of the other peer 1492 * @param pid peer identity of the other peer
1493 * @param ephemeral_key ephemeral public key of the other peer 1493 * @param ephemeral_key ephemeral public key of the other peer
1494 * @param ratchet_key senders next ephemeral public key 1494 * @param ratchet_key senders next ephemeral public key
@@ -3487,15 +3487,6 @@ GCT_send (struct CadetTunnel *t,
3487} 3487}
3488 3488
3489 3489
3490/**
3491 * Cancel a previously sent message while it's in the queue.
3492 *
3493 * ONLY can be called before the continuation given to the send
3494 * function is called. Once the continuation is called, the message is
3495 * no longer in the queue!
3496 *
3497 * @param tq Handle to the queue entry to cancel.
3498 */
3499void 3490void
3500GCT_send_cancel (struct CadetTunnelQueueEntry *tq) 3491GCT_send_cancel (struct CadetTunnelQueueEntry *tq)
3501{ 3492{
diff --git a/src/cadet/gnunet-service-cadet_tunnels.h b/src/cadet/gnunet-service-cadet_tunnels.h
index 018a3ec73..e893955a0 100644
--- a/src/cadet/gnunet-service-cadet_tunnels.h
+++ b/src/cadet/gnunet-service-cadet_tunnels.h
@@ -160,8 +160,8 @@ GCT_get_destination (struct CadetTunnel *t);
160 * Consider using the path @a p for the tunnel @a t. 160 * Consider using the path @a p for the tunnel @a t.
161 * The tunnel destination is at offset @a off in path @a p. 161 * The tunnel destination is at offset @a off in path @a p.
162 * 162 *
163 * @param cls our tunnel 163 * @param t our tunnel
164 * @param path a path to our destination 164 * @param p a path to our destination
165 * @param off offset of the destination on path @a path 165 * @param off offset of the destination on path @a path
166 */ 166 */
167void 167void
diff --git a/src/consensus/plugin_block_consensus.c b/src/consensus/plugin_block_consensus.c
index f30b9b0d7..241d8fc7b 100644
--- a/src/consensus/plugin_block_consensus.c
+++ b/src/consensus/plugin_block_consensus.c
@@ -52,7 +52,6 @@ struct BlockContext
52 * Function called to validate a query. 52 * Function called to validate a query.
53 * 53 *
54 * @param cls closure 54 * @param cls closure
55 * @param ctx block context
56 * @param type block type 55 * @param type block type
57 * @param query original query (hash) 56 * @param query original query (hash)
58 * @param xquery extrended query data (can be NULL, depending on type) 57 * @param xquery extrended query data (can be NULL, depending on type)
diff --git a/src/conversation/conversation_api.c b/src/conversation/conversation_api.c
index 1984abdd6..2ede33586 100644
--- a/src/conversation/conversation_api.c
+++ b/src/conversation/conversation_api.c
@@ -300,7 +300,7 @@ find_caller (struct GNUNET_CONVERSATION_Phone *phone,
300 * We received a `struct ClientPhoneHangupMessage`. 300 * We received a `struct ClientPhoneHangupMessage`.
301 * 301 *
302 * @param cls the `struct GNUNET_CONVERSATION_Phone *` 302 * @param cls the `struct GNUNET_CONVERSATION_Phone *`
303 * @param msg the message 303 * @param hang the message
304 */ 304 */
305static void 305static void
306handle_phone_hangup (void *cls, 306handle_phone_hangup (void *cls,
diff --git a/src/conversation/conversation_api_call.c b/src/conversation/conversation_api_call.c
index 2be7886fa..909b603ac 100644
--- a/src/conversation/conversation_api_call.c
+++ b/src/conversation/conversation_api_call.c
@@ -375,7 +375,7 @@ handle_call_hangup (void *cls,
375 * We received a `struct ClientAudioMessage`, check it is well-formed. 375 * We received a `struct ClientAudioMessage`, check it is well-formed.
376 * 376 *
377 * @param cls the `struct GNUNET_CONVERSATION_Call` 377 * @param cls the `struct GNUNET_CONVERSATION_Call`
378 * @param msg the message 378 * @param am the message
379 * @return #GNUNET_OK (always well-formed) 379 * @return #GNUNET_OK (always well-formed)
380 */ 380 */
381static int 381static int
@@ -393,7 +393,7 @@ check_call_audio (void *cls,
393 * We received a `struct ClientAudioMessage` 393 * We received a `struct ClientAudioMessage`
394 * 394 *
395 * @param cls the `struct GNUNET_CONVERSATION_Call` 395 * @param cls the `struct GNUNET_CONVERSATION_Call`
396 * @param msg the message 396 * @param am the message
397 */ 397 */
398static void 398static void
399handle_call_audio (void *cls, 399handle_call_audio (void *cls,
diff --git a/src/core/core_api.c b/src/core/core_api.c
index 81118693d..2e0bb1785 100644
--- a/src/core/core_api.c
+++ b/src/core/core_api.c
@@ -158,7 +158,6 @@ reconnect (struct GNUNET_CORE_Handle *h);
158 * Task schedule to try to re-connect to core. 158 * Task schedule to try to re-connect to core.
159 * 159 *
160 * @param cls the `struct GNUNET_CORE_Handle` 160 * @param cls the `struct GNUNET_CORE_Handle`
161 * @param tc task context
162 */ 161 */
163static void 162static void
164reconnect_task (void *cls) 163reconnect_task (void *cls)
diff --git a/src/core/gnunet-service-core_kx.c b/src/core/gnunet-service-core_kx.c
index c5992a824..b203f4902 100644
--- a/src/core/gnunet-service-core_kx.c
+++ b/src/core/gnunet-service-core_kx.c
@@ -488,7 +488,8 @@ derive_aes_key (const struct GNUNET_PeerIdentity *sender,
488 * @param iv initialization vector to use 488 * @param iv initialization vector to use
489 * @param in ciphertext 489 * @param in ciphertext
490 * @param out plaintext 490 * @param out plaintext
491 * @param size size of @a in/@a out 491 * @param size size of @a in / @a out
492 *
492 * @return #GNUNET_OK on success 493 * @return #GNUNET_OK on success
493 */ 494 */
494static int 495static int
@@ -1888,12 +1889,6 @@ GSC_NEIGHBOURS_get_queue_length (const struct GSC_KeyExchangeInfo *kxinfo)
1888} 1889}
1889 1890
1890 1891
1891/**
1892 * Check if the given neighbour has excess bandwidth available.
1893 *
1894 * @param target neighbour to check
1895 * @return #GNUNET_YES if excess bandwidth is available, #GNUNET_NO if not
1896 */
1897int 1892int
1898GSC_NEIGHBOURS_check_excess_bandwidth (const struct GSC_KeyExchangeInfo *kxinfo) 1893GSC_NEIGHBOURS_check_excess_bandwidth (const struct GSC_KeyExchangeInfo *kxinfo)
1899{ 1894{
diff --git a/src/datacache/plugin_datacache_postgres.c b/src/datacache/plugin_datacache_postgres.c
index 01b2372f1..df5fc4454 100644
--- a/src/datacache/plugin_datacache_postgres.c
+++ b/src/datacache/plugin_datacache_postgres.c
@@ -211,7 +211,7 @@ struct HandleResultContext
211 * 211 *
212 * @param cls closure of type `struct HandleResultContext` 212 * @param cls closure of type `struct HandleResultContext`
213 * @param result the postgres result 213 * @param result the postgres result
214 * @param num_result the number of results in @a result 214 * @param num_results the number of results in @a result
215 */ 215 */
216static void 216static void
217handle_results (void *cls, 217handle_results (void *cls,
@@ -433,7 +433,7 @@ struct ExtractResultContext
433 * 433 *
434 * @param cls closure with the `struct ExtractResultContext` 434 * @param cls closure with the `struct ExtractResultContext`
435 * @param result the postgres result 435 * @param result the postgres result
436 * @param num_result the number of results in @a result 436 * @param num_results the number of results in @a result
437 */ 437 */
438static void 438static void
439extract_result_cb (void *cls, 439extract_result_cb (void *cls,
diff --git a/src/datacache/plugin_datacache_sqlite.c b/src/datacache/plugin_datacache_sqlite.c
index 0753d87ce..1c6f24a82 100644
--- a/src/datacache/plugin_datacache_sqlite.c
+++ b/src/datacache/plugin_datacache_sqlite.c
@@ -161,7 +161,7 @@ struct Plugin
161 * @brief Prepare a SQL statement 161 * @brief Prepare a SQL statement
162 * 162 *
163 * @param dbh database handle 163 * @param dbh database handle
164 * @param zsql SQL statement text 164 * @param zSql SQL statement text
165 * @param[out] ppStmt set to the prepared statement 165 * @param[out] ppStmt set to the prepared statement
166 * @return 0 on success 166 * @return 0 on success
167 */ 167 */
diff --git a/src/datastore/datastore_api.c b/src/datastore/datastore_api.c
index 4b4a76eea..4d27efb4e 100644
--- a/src/datastore/datastore_api.c
+++ b/src/datastore/datastore_api.c
@@ -278,7 +278,7 @@ free_queue_entry (struct GNUNET_DATASTORE_QueueEntry *qe)
278/** 278/**
279 * Task that logs an error after some time. 279 * Task that logs an error after some time.
280 * 280 *
281 * @param qe `struct GNUNET_DATASTORE_QueueEntry` about which the error is 281 * @param cls `struct GNUNET_DATASTORE_QueueEntry` about which the error is
282 */ 282 */
283static void 283static void
284delay_warning (void *cls) 284delay_warning (void *cls)
diff --git a/src/datastore/gnunet-service-datastore.c b/src/datastore/gnunet-service-datastore.c
index 498a7b3e6..f45e71ee9 100644
--- a/src/datastore/gnunet-service-datastore.c
+++ b/src/datastore/gnunet-service-datastore.c
@@ -560,7 +560,7 @@ transmit_item (void *cls,
560 * Handle RESERVE-message. 560 * Handle RESERVE-message.
561 * 561 *
562 * @param cls identification of the client 562 * @param cls identification of the client
563 * @param message the actual message 563 * @param msg the actual message
564 */ 564 */
565static void 565static void
566handle_reserve (void *cls, const struct ReserveMessage *msg) 566handle_reserve (void *cls, const struct ReserveMessage *msg)
@@ -644,7 +644,7 @@ handle_reserve (void *cls, const struct ReserveMessage *msg)
644 * Handle RELEASE_RESERVE-message. 644 * Handle RELEASE_RESERVE-message.
645 * 645 *
646 * @param cls identification of the client 646 * @param cls identification of the client
647 * @param message the actual message 647 * @param msg the actual message
648 */ 648 */
649static void 649static void
650handle_release_reserve (void *cls, const struct ReleaseReserveMessage *msg) 650handle_release_reserve (void *cls, const struct ReleaseReserveMessage *msg)
@@ -768,7 +768,7 @@ put_continuation (void *cls,
768 * Verify PUT-message. 768 * Verify PUT-message.
769 * 769 *
770 * @param cls identification of the client 770 * @param cls identification of the client
771 * @param message the actual message 771 * @param dm the actual message
772 * @return #GNUNET_OK if @a dm is well-formed 772 * @return #GNUNET_OK if @a dm is well-formed
773 */ 773 */
774static int 774static int
@@ -787,7 +787,7 @@ check_put (void *cls, const struct DataMessage *dm)
787 * Handle PUT-message. 787 * Handle PUT-message.
788 * 788 *
789 * @param cls identification of the client 789 * @param cls identification of the client
790 * @param message the actual message 790 * @param dm the actual message
791 */ 791 */
792static void 792static void
793handle_put (void *cls, const struct DataMessage *dm) 793handle_put (void *cls, const struct DataMessage *dm)
@@ -949,7 +949,7 @@ handle_get_replication (void *cls, const struct GNUNET_MessageHeader *message)
949 * Handle GET_ZERO_ANONYMITY-message. 949 * Handle GET_ZERO_ANONYMITY-message.
950 * 950 *
951 * @param cls client identification of the client 951 * @param cls client identification of the client
952 * @param message the actual message 952 * @param msg the actual message
953 */ 953 */
954static void 954static void
955handle_get_zero_anonymity (void *cls, const struct GetZeroAnonymityMessage *msg) 955handle_get_zero_anonymity (void *cls, const struct GetZeroAnonymityMessage *msg)
@@ -1028,7 +1028,7 @@ remove_continuation (void *cls,
1028 * Verify REMOVE-message. 1028 * Verify REMOVE-message.
1029 * 1029 *
1030 * @param cls identification of the client 1030 * @param cls identification of the client
1031 * @param message the actual message 1031 * @param dm the actual message
1032 * @return #GNUNET_OK if @a dm is well-formed 1032 * @return #GNUNET_OK if @a dm is well-formed
1033 */ 1033 */
1034static int 1034static int
@@ -1047,8 +1047,7 @@ check_remove (void *cls, const struct DataMessage *dm)
1047 * Handle REMOVE-message. 1047 * Handle REMOVE-message.
1048 * 1048 *
1049 * @param cls closure 1049 * @param cls closure
1050 * @param client identification of the client 1050 * @param dm the actual message
1051 * @param message the actual message
1052 */ 1051 */
1053static void 1052static void
1054handle_remove (void *cls, const struct DataMessage *dm) 1053handle_remove (void *cls, const struct DataMessage *dm)
diff --git a/src/datastore/plugin_datastore_postgres.c b/src/datastore/plugin_datastore_postgres.c
index 27e8b7072..e49564dd9 100644
--- a/src/datastore/plugin_datastore_postgres.c
+++ b/src/datastore/plugin_datastore_postgres.c
@@ -760,7 +760,7 @@ struct ProcessKeysContext
760 * 760 *
761 * @param cls closure with a `struct ProcessKeysContext` 761 * @param cls closure with a `struct ProcessKeysContext`
762 * @param result the postgres result 762 * @param result the postgres result
763 * @param num_result the number of results in @a result 763 * @param num_results the number of results in @a result
764 */ 764 */
765static void 765static void
766process_keys (void *cls, 766process_keys (void *cls,
diff --git a/src/dht/gnunet-service-dht.h b/src/dht/gnunet-service-dht.h
index f7c2fed76..dcc972fc2 100644
--- a/src/dht/gnunet-service-dht.h
+++ b/src/dht/gnunet-service-dht.h
@@ -144,7 +144,6 @@ GDS_u_hold (struct GDS_Underlay *u,
144 * 144 *
145 * @param bd block details 145 * @param bd block details
146 * @param query_hash hash of the original query, might not match key in @a bd 146 * @param query_hash hash of the original query, might not match key in @a bd
147 * @param trunc_peer peer at which the path was truncated, or NULL if path starts at the origin
148 * @param get_path_length number of entries in @a get_path 147 * @param get_path_length number of entries in @a get_path
149 * @param get_path path the reply has taken 148 * @param get_path path the reply has taken
150 * @return true on success, false on failures 149 * @return true on success, false on failures
diff --git a/src/dht/gnunet-service-dht_clients.c b/src/dht/gnunet-service-dht_clients.c
index b4d139eec..19b464e63 100644
--- a/src/dht/gnunet-service-dht_clients.c
+++ b/src/dht/gnunet-service-dht_clients.c
@@ -584,7 +584,7 @@ handle_local_result (void *cls,
584 * Check DHT GET messages from the client. 584 * Check DHT GET messages from the client.
585 * 585 *
586 * @param cls the client we received this message from 586 * @param cls the client we received this message from
587 * @param message the actual message received 587 * @param get the actual message received
588 * @return #GNUNET_OK (always) 588 * @return #GNUNET_OK (always)
589 */ 589 */
590static enum GNUNET_GenericReturnValue 590static enum GNUNET_GenericReturnValue
@@ -602,7 +602,7 @@ check_dht_local_get (void *cls,
602 * Handler for DHT GET messages from the client. 602 * Handler for DHT GET messages from the client.
603 * 603 *
604 * @param cls the client we received this message from 604 * @param cls the client we received this message from
605 * @param message the actual message received 605 * @param get the actual message received
606 */ 606 */
607static void 607static void
608handle_dht_local_get (void *cls, 608handle_dht_local_get (void *cls,
@@ -720,7 +720,7 @@ find_by_unique_id (void *cls,
720 * Check "GET result seen" messages from the client. 720 * Check "GET result seen" messages from the client.
721 * 721 *
722 * @param cls the client we received this message from 722 * @param cls the client we received this message from
723 * @param message the actual message received 723 * @param seen the actual message received
724 * @return #GNUNET_OK if @a seen is well-formed 724 * @return #GNUNET_OK if @a seen is well-formed
725 */ 725 */
726static enum GNUNET_GenericReturnValue 726static enum GNUNET_GenericReturnValue
@@ -746,7 +746,7 @@ check_dht_local_get_result_seen (
746 * Handler for "GET result seen" messages from the client. 746 * Handler for "GET result seen" messages from the client.
747 * 747 *
748 * @param cls the client we received this message from 748 * @param cls the client we received this message from
749 * @param message the actual message received 749 * @param seen the actual message received
750 */ 750 */
751static void 751static void
752handle_dht_local_get_result_seen ( 752handle_dht_local_get_result_seen (
@@ -835,7 +835,7 @@ remove_by_unique_id (void *cls,
835 * depending on message type (if processed locally) 835 * depending on message type (if processed locally)
836 * 836 *
837 * @param cls client we received this message from 837 * @param cls client we received this message from
838 * @param message the actual message received 838 * @param dht_stop_msg the actual message received
839 * 839 *
840 */ 840 */
841static void 841static void
@@ -1603,8 +1603,6 @@ GDS_CLIENTS_process_put (const struct GNUNET_DATACACHE_Block *bd,
1603 1603
1604/** 1604/**
1605 * Initialize client subsystem. 1605 * Initialize client subsystem.
1606 *
1607 * @param server the initialized server
1608 */ 1606 */
1609static void 1607static void
1610GDS_CLIENTS_init (void) 1608GDS_CLIENTS_init (void)
diff --git a/src/dht/gnunet-service-dht_neighbours.c b/src/dht/gnunet-service-dht_neighbours.c
index 65b3014fd..9d1dff8a6 100644
--- a/src/dht/gnunet-service-dht_neighbours.c
+++ b/src/dht/gnunet-service-dht_neighbours.c
@@ -529,7 +529,6 @@ do_send (struct PeerInfo *pi,
529 * Sign that we are routing a message from @a pred to @a succ. 529 * Sign that we are routing a message from @a pred to @a succ.
530 * (So the route is $PRED->us->$SUCC). 530 * (So the route is $PRED->us->$SUCC).
531 * 531 *
532 * @param key key of the data (not necessarily the query hash)
533 * @param data payload (the block) 532 * @param data payload (the block)
534 * @param data_size number of bytes in @a data 533 * @param data_size number of bytes in @a data
535 * @param exp_time expiration time of @a data 534 * @param exp_time expiration time of @a data
@@ -1890,7 +1889,7 @@ GDS_NEIGHBOURS_handle_reply (struct PeerInfo *pi,
1890 * Check validity of a p2p put request. 1889 * Check validity of a p2p put request.
1891 * 1890 *
1892 * @param cls closure with the `struct PeerInfo` of the sender 1891 * @param cls closure with the `struct PeerInfo` of the sender
1893 * @param message message 1892 * @param put message
1894 * @return #GNUNET_OK if the message is valid 1893 * @return #GNUNET_OK if the message is valid
1895 */ 1894 */
1896static enum GNUNET_GenericReturnValue 1895static enum GNUNET_GenericReturnValue
@@ -1933,7 +1932,7 @@ check_dht_p2p_put (void *cls,
1933 * Core handler for p2p put requests. 1932 * Core handler for p2p put requests.
1934 * 1933 *
1935 * @param cls closure with the `struct Target` of the sender 1934 * @param cls closure with the `struct Target` of the sender
1936 * @param message message 1935 * @param put message
1937 */ 1936 */
1938static void 1937static void
1939handle_dht_p2p_put (void *cls, 1938handle_dht_p2p_put (void *cls,
@@ -2503,7 +2502,7 @@ process_reply_with_path (const struct GNUNET_DATACACHE_Block *bd,
2503 * Check validity of p2p result message. 2502 * Check validity of p2p result message.
2504 * 2503 *
2505 * @param cls closure 2504 * @param cls closure
2506 * @param message message 2505 * @param prm message
2507 * @return #GNUNET_YES if the message is well-formed 2506 * @return #GNUNET_YES if the message is well-formed
2508 */ 2507 */
2509static enum GNUNET_GenericReturnValue 2508static enum GNUNET_GenericReturnValue
@@ -2542,7 +2541,7 @@ check_dht_p2p_result (void *cls,
2542 * Core handler for p2p result messages. 2541 * Core handler for p2p result messages.
2543 * 2542 *
2544 * @param cls closure 2543 * @param cls closure
2545 * @param message message 2544 * @param prm message
2546 */ 2545 */
2547static void 2546static void
2548handle_dht_p2p_result (void *cls, 2547handle_dht_p2p_result (void *cls,
@@ -2754,7 +2753,7 @@ check_dht_p2p_hello (void *cls,
2754 * Core handler for p2p HELLO messages. 2753 * Core handler for p2p HELLO messages.
2755 * 2754 *
2756 * @param cls closure 2755 * @param cls closure
2757 * @param message message 2756 * @param hello message
2758 */ 2757 */
2759static void 2758static void
2760handle_dht_p2p_hello (void *cls, 2759handle_dht_p2p_hello (void *cls,
diff --git a/src/dht/gnunet-service-dht_neighbours.h b/src/dht/gnunet-service-dht_neighbours.h
index 96db21b9b..85e18d46d 100644
--- a/src/dht/gnunet-service-dht_neighbours.h
+++ b/src/dht/gnunet-service-dht_neighbours.h
@@ -101,7 +101,6 @@ GDS_NEIGHBOURS_handle_get (enum GNUNET_BLOCK_Type type,
101 * forwarding to local clients. 101 * forwarding to local clients.
102 * 102 *
103 * @param pi neighbour that should receive the block 103 * @param pi neighbour that should receive the block
104 * @param type type of the block
105 * @param bd details about the reply 104 * @param bd details about the reply
106 * @param query_hash query that was used for the request 105 * @param query_hash query that was used for the request
107 * @param get_path_length number of entries in put_path 106 * @param get_path_length number of entries in put_path
@@ -150,7 +149,7 @@ GDS_try_connect (void *cls,
150 * @param cls the closure, must be a `struct GDS_Underlay` 149 * @param cls the closure, must be a `struct GDS_Underlay`
151 * @param target handle to the target, 150 * @param target handle to the target,
152 * pointer will remain valid until @e disconnect_cb is called 151 * pointer will remain valid until @e disconnect_cb is called
153 * @para pid peer identity, 152 * @param pid peer identity,
154 * pointer will remain valid until @e disconnect_cb is called 153 * pointer will remain valid until @e disconnect_cb is called
155 * @param[out] ctx storage space for DHT to use in association with this target 154 * @param[out] ctx storage space for DHT to use in association with this target
156 */ 155 */
@@ -175,7 +174,6 @@ GDS_u_disconnect (void *ctx);
175 * Function to call when we receive a message. 174 * Function to call when we receive a message.
176 * 175 *
177 * @param cls the closure 176 * @param cls the closure
178 * @param origin where the message originated from
179 * @param[in,out] tctx ctx of target address where we received the message from 177 * @param[in,out] tctx ctx of target address where we received the message from
180 * @param[in,out] sctx ctx of our own source address at which we received the message 178 * @param[in,out] sctx ctx of our own source address at which we received the message
181 * @param message the message we received @param message_size number of 179 * @param message the message we received @param message_size number of
diff --git a/src/dht/gnunet-service-dht_routing.c b/src/dht/gnunet-service-dht_routing.c
index 8f87751bb..d81a2b2e1 100644
--- a/src/dht/gnunet-service-dht_routing.c
+++ b/src/dht/gnunet-service-dht_routing.c
@@ -341,8 +341,6 @@ try_combine_recent (void *cls,
341 * @param key key for the content 341 * @param key key for the content
342 * @param xquery extended query 342 * @param xquery extended query
343 * @param xquery_size number of bytes in @a xquery 343 * @param xquery_size number of bytes in @a xquery
344 * @param reply_bf bloomfilter to filter duplicates
345 * @param reply_bf_mutator mutator for @a reply_bf
346 */ 344 */
347void 345void
348GDS_ROUTING_add (const struct GNUNET_PeerIdentity *sender, 346GDS_ROUTING_add (const struct GNUNET_PeerIdentity *sender,
diff --git a/src/dhtu/plugin_dhtu_gnunet.c b/src/dhtu/plugin_dhtu_gnunet.c
index b072be2be..b0cee7e01 100644
--- a/src/dhtu/plugin_dhtu_gnunet.c
+++ b/src/dhtu/plugin_dhtu_gnunet.c
@@ -424,7 +424,7 @@ core_disconnect_cb (void *cls,
424 * @param cls a `struct Plugin` 424 * @param cls a `struct Plugin`
425 * @param peer id of the peer, NULL for last call 425 * @param peer id of the peer, NULL for last call
426 * @param hello hello message for the peer (can be NULL) 426 * @param hello hello message for the peer (can be NULL)
427 * @param error message 427 * @param err_msg message
428 */ 428 */
429static void 429static void
430peerinfo_cb (void *cls, 430peerinfo_cb (void *cls,
diff --git a/src/dhtu/plugin_dhtu_ip.c b/src/dhtu/plugin_dhtu_ip.c
index 612d2c119..06d0f0f60 100644
--- a/src/dhtu/plugin_dhtu_ip.c
+++ b/src/dhtu/plugin_dhtu_ip.c
@@ -303,7 +303,6 @@ create_target (struct Plugin *plugin,
303 * 303 *
304 * @param plugin the plugin handle 304 * @param plugin the plugin handle
305 * @param pid presumed identity of the target 305 * @param pid presumed identity of the target
306 * @param src source target is from, or NULL if unknown
307 * @param addr socket address to find 306 * @param addr socket address to find
308 * @param addrlen number of bytes in @a addr 307 * @param addrlen number of bytes in @a addr
309 * @return matching target object 308 * @return matching target object
diff --git a/src/dns/dns_api.c b/src/dns/dns_api.c
index 89f03bf63..b0bbb894f 100644
--- a/src/dns/dns_api.c
+++ b/src/dns/dns_api.c
@@ -102,7 +102,6 @@ struct GNUNET_DNS_Handle
102 * Reconnect to the DNS service. 102 * Reconnect to the DNS service.
103 * 103 *
104 * @param cls handle with the connection to connect 104 * @param cls handle with the connection to connect
105 * @param tc scheduler context (unused)
106 */ 105 */
107static void 106static void
108reconnect (void *cls); 107reconnect (void *cls);
@@ -171,7 +170,7 @@ check_request (void *cls,
171 * handle it. 170 * handle it.
172 * 171 *
173 * @param cls the `struct GNUNET_DNS_Handle *` 172 * @param cls the `struct GNUNET_DNS_Handle *`
174 * @param msg message from the service (request) 173 * @param req message from the service (request)
175 */ 174 */
176static void 175static void
177handle_request (void *cls, 176handle_request (void *cls,
diff --git a/src/dns/plugin_block_dns.c b/src/dns/plugin_block_dns.c
index 0531a8a5f..1bbd7f750 100644
--- a/src/dns/plugin_block_dns.c
+++ b/src/dns/plugin_block_dns.c
@@ -90,7 +90,6 @@ block_plugin_dns_create_group (void *cls,
90 * Function called to validate a query. 90 * Function called to validate a query.
91 * 91 *
92 * @param cls closure 92 * @param cls closure
93 * @param ctx block context
94 * @param type block type 93 * @param type block type
95 * @param query original query (hash) 94 * @param query original query (hash)
96 * @param xquery extrended query data (can be NULL, depending on type) 95 * @param xquery extrended query data (can be NULL, depending on type)
diff --git a/src/exit/gnunet-daemon-exit.c b/src/exit/gnunet-daemon-exit.c
index f4a17e32a..425f7c816 100644
--- a/src/exit/gnunet-daemon-exit.c
+++ b/src/exit/gnunet-daemon-exit.c
@@ -1821,7 +1821,7 @@ handle_tcp_remote (void *cls,
1821 * connection via this peer. 1821 * connection via this peer.
1822 * 1822 *
1823 * @param cls our `struct ChannelState *` 1823 * @param cls our `struct ChannelState *`
1824 * @param message the actual message 1824 * @param data the actual message
1825 * @return #GNUNET_OK to keep the connection open, 1825 * @return #GNUNET_OK to keep the connection open,
1826 * #GNUNET_SYSERR to close it (signal serious error) 1826 * #GNUNET_SYSERR to close it (signal serious error)
1827 */ 1827 */
@@ -1861,7 +1861,7 @@ check_tcp_data (void *cls,
1861 * connection via this peer. 1861 * connection via this peer.
1862 * 1862 *
1863 * @param cls our `struct ChannelState *` 1863 * @param cls our `struct ChannelState *`
1864 * @param message the actual message 1864 * @param data the actual message
1865 */ 1865 */
1866static void 1866static void
1867handle_tcp_data (void *cls, 1867handle_tcp_data (void *cls,
@@ -3231,7 +3231,6 @@ free_iterate (void *cls,
3231 * service process alive by virtue of being scheduled. 3231 * service process alive by virtue of being scheduled.
3232 * 3232 *
3233 * @param cls NULL 3233 * @param cls NULL
3234 * @param tc scheduler context
3235 */ 3234 */
3236static void 3235static void
3237dummy_task (void *cls) 3236dummy_task (void *cls)
diff --git a/src/fs/fs_dirmetascan.c b/src/fs/fs_dirmetascan.c
index cb50182f9..8dd216324 100644
--- a/src/fs/fs_dirmetascan.c
+++ b/src/fs/fs_dirmetascan.c
@@ -112,14 +112,6 @@ GNUNET_FS_directory_scan_abort (struct GNUNET_FS_DirScanner *ds)
112} 112}
113 113
114 114
115/**
116 * Obtain the result of the scan after the scan has signalled
117 * completion. Must not be called prior to completion. The 'ds' is
118 * freed as part of this call.
119 *
120 * @param ds directory scanner structure
121 * @return the results of the scan (a directory tree)
122 */
123struct GNUNET_FS_ShareTreeItem * 115struct GNUNET_FS_ShareTreeItem *
124GNUNET_FS_directory_scan_get_result (struct GNUNET_FS_DirScanner *ds) 116GNUNET_FS_directory_scan_get_result (struct GNUNET_FS_DirScanner *ds)
125{ 117{
diff --git a/src/fs/fs_download.c b/src/fs/fs_download.c
index e0ad8cd1d..102b297c1 100644
--- a/src/fs/fs_download.c
+++ b/src/fs/fs_download.c
@@ -1422,7 +1422,6 @@ try_reconnect (struct GNUNET_FS_DownloadContext *dc)
1422 * We're allowed to ask the FS service for our blocks. Start the download. 1422 * We're allowed to ask the FS service for our blocks. Start the download.
1423 * 1423 *
1424 * @param cls the 'struct GNUNET_FS_DownloadContext' 1424 * @param cls the 'struct GNUNET_FS_DownloadContext'
1425 * @param mq handle to use for communication with FS (we must destroy it!)
1426 */ 1425 */
1427static void 1426static void
1428activate_fs_download (void *cls) 1427activate_fs_download (void *cls)
@@ -2096,36 +2095,6 @@ create_download_context (struct GNUNET_FS_Handle *h,
2096} 2095}
2097 2096
2098 2097
2099/**
2100 * Download parts of a file. Note that this will store
2101 * the blocks at the respective offset in the given file. Also, the
2102 * download is still using the blocking of the underlying FS
2103 * encoding. As a result, the download may *write* outside of the
2104 * given boundaries (if offset and length do not match the 32k FS
2105 * block boundaries). <p>
2106 *
2107 * This function should be used to focus a download towards a
2108 * particular portion of the file (optimization), not to strictly
2109 * limit the download to exactly those bytes.
2110 *
2111 * @param h handle to the file sharing subsystem
2112 * @param uri the URI of the file (determines what to download); CHK or LOC URI
2113 * @param meta known metadata for the file (can be NULL)
2114 * @param filename where to store the file, maybe NULL (then no file is
2115 * created on disk and data must be grabbed from the callbacks)
2116 * @param tempname where to store temporary file data, not used if filename is non-NULL;
2117 * can be NULL (in which case we will pick a name if needed); the temporary file
2118 * may already exist, in which case we will try to use the data that is there and
2119 * if it is not what is desired, will overwrite it
2120 * @param offset at what offset should we start the download (typically 0)
2121 * @param length how many bytes should be downloaded starting at offset
2122 * @param anonymity anonymity level to use for the download
2123 * @param options various options
2124 * @param cctx initial value for the client context for this download
2125 * @param parent parent download to associate this download with (use NULL
2126 * for top-level downloads; useful for manually-triggered recursive downloads)
2127 * @return context that can be used to control this download
2128 */
2129struct GNUNET_FS_DownloadContext * 2098struct GNUNET_FS_DownloadContext *
2130GNUNET_FS_download_start (struct GNUNET_FS_Handle *h, 2099GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
2131 const struct GNUNET_FS_Uri *uri, 2100 const struct GNUNET_FS_Uri *uri,
@@ -2163,40 +2132,6 @@ GNUNET_FS_download_start (struct GNUNET_FS_Handle *h,
2163} 2132}
2164 2133
2165 2134
2166/**
2167 * Download parts of a file based on a search result. The download
2168 * will be associated with the search result (and the association
2169 * will be preserved when serializing/deserializing the state).
2170 * If the search is stopped, the download will not be aborted but
2171 * be 'promoted' to a stand-alone download.
2172 *
2173 * As with the other download function, this will store
2174 * the blocks at the respective offset in the given file. Also, the
2175 * download is still using the blocking of the underlying FS
2176 * encoding. As a result, the download may *write* outside of the
2177 * given boundaries (if offset and length do not match the 32k FS
2178 * block boundaries). <p>
2179 *
2180 * The given range can be used to focus a download towards a
2181 * particular portion of the file (optimization), not to strictly
2182 * limit the download to exactly those bytes.
2183 *
2184 * @param h handle to the file sharing subsystem
2185 * @param sr the search result to use for the download (determines uri and
2186 * meta data and associations)
2187 * @param filename where to store the file, maybe NULL (then no file is
2188 * created on disk and data must be grabbed from the callbacks)
2189 * @param tempname where to store temporary file data, not used if filename is non-NULL;
2190 * can be NULL (in which case we will pick a name if needed); the temporary file
2191 * may already exist, in which case we will try to use the data that is there and
2192 * if it is not what is desired, will overwrite it
2193 * @param offset at what offset should we start the download (typically 0)
2194 * @param length how many bytes should be downloaded starting at offset
2195 * @param anonymity anonymity level to use for the download
2196 * @param options various download options
2197 * @param cctx initial value for the client context for this download
2198 * @return context that can be used to control this download
2199 */
2200struct GNUNET_FS_DownloadContext * 2135struct GNUNET_FS_DownloadContext *
2201GNUNET_FS_download_start_from_search (struct GNUNET_FS_Handle *h, 2136GNUNET_FS_download_start_from_search (struct GNUNET_FS_Handle *h,
2202 struct GNUNET_FS_SearchResult *sr, 2137 struct GNUNET_FS_SearchResult *sr,
diff --git a/src/fs/fs_file_information.c b/src/fs/fs_file_information.c
index c5faa14d4..dc5db9d3f 100644
--- a/src/fs/fs_file_information.c
+++ b/src/fs/fs_file_information.c
@@ -83,20 +83,6 @@ GNUNET_FS_file_information_set_filename (struct GNUNET_FS_FileInformation *s,
83} 83}
84 84
85 85
86/**
87 * Create an entry for a file in a publish-structure.
88 *
89 * @param h handle to the file sharing subsystem
90 * @param client_info initial value for the client-info value for this entry
91 * @param filename name of the file or directory to publish
92 * @param keywords under which keywords should this file be available
93 * directly; can be NULL
94 * @param meta metadata for the file
95 * @param do_index #GNUNET_YES for index, #GNUNET_NO for insertion,
96 * #GNUNET_SYSERR for simulation
97 * @param bo block options
98 * @return publish structure entry for the file
99 */
100struct GNUNET_FS_FileInformation * 86struct GNUNET_FS_FileInformation *
101GNUNET_FS_file_information_create_from_file ( 87GNUNET_FS_file_information_create_from_file (
102 struct GNUNET_FS_Handle *h, 88 struct GNUNET_FS_Handle *h,
@@ -157,22 +143,6 @@ GNUNET_FS_file_information_create_from_file (
157} 143}
158 144
159 145
160/**
161 * Create an entry for a file in a publish-structure.
162 *
163 * @param h handle to the file sharing subsystem
164 * @param client_info initial value for the client-info value for this entry
165 * @param length length of the file
166 * @param data data for the file (should not be used afterwards by
167 * the caller; callee will "free")
168 * @param keywords under which keywords should this file be available
169 * directly; can be NULL
170 * @param meta metadata for the file
171 * @param do_index GNUNET_YES for index, GNUNET_NO for insertion,
172 * GNUNET_SYSERR for simulation
173 * @param bo block options
174 * @return publish structure entry for the file
175 */
176struct GNUNET_FS_FileInformation * 146struct GNUNET_FS_FileInformation *
177GNUNET_FS_file_information_create_from_data ( 147GNUNET_FS_file_information_create_from_data (
178 struct GNUNET_FS_Handle *h, 148 struct GNUNET_FS_Handle *h,
@@ -202,22 +172,6 @@ GNUNET_FS_file_information_create_from_data (
202} 172}
203 173
204 174
205/**
206 * Create an entry for a file in a publish-structure.
207 *
208 * @param h handle to the file sharing subsystem
209 * @param client_info initial value for the client-info value for this entry
210 * @param length length of the file
211 * @param reader function that can be used to obtain the data for the file
212 * @param reader_cls closure for "reader"
213 * @param keywords under which keywords should this file be available
214 * directly; can be NULL
215 * @param meta metadata for the file
216 * @param do_index #GNUNET_YES for index, #GNUNET_NO for insertion,
217 * #GNUNET_SYSERR for simulation
218 * @param bo block options
219 * @return publish structure entry for the file
220 */
221struct GNUNET_FS_FileInformation * 175struct GNUNET_FS_FileInformation *
222GNUNET_FS_file_information_create_from_reader ( 176GNUNET_FS_file_information_create_from_reader (
223 struct GNUNET_FS_Handle *h, 177 struct GNUNET_FS_Handle *h,
@@ -267,18 +221,6 @@ GNUNET_FS_file_information_is_directory (
267} 221}
268 222
269 223
270/**
271 * Create an entry for an empty directory in a publish-structure.
272 *
273 * @param h handle to the file sharing subsystem
274 * @param client_info initial value for the client-info value for this entry
275 * @param meta metadata for the directory
276 * @param keywords under which keywords should this directory be available
277 * directly; can be NULL
278 * @param bo block options
279 * @param filename name of the directory; can be NULL
280 * @return publish structure entry for the directory , NULL on error
281 */
282struct GNUNET_FS_FileInformation * 224struct GNUNET_FS_FileInformation *
283GNUNET_FS_file_information_create_empty_directory ( 225GNUNET_FS_file_information_create_empty_directory (
284 struct GNUNET_FS_Handle *h, 226 struct GNUNET_FS_Handle *h,
@@ -303,17 +245,6 @@ GNUNET_FS_file_information_create_empty_directory (
303} 245}
304 246
305 247
306/**
307 * Add an entry to a directory in a publish-structure. Clients
308 * should never modify publish structures that were passed to
309 * #GNUNET_FS_publish_start already.
310 *
311 * @param dir the directory
312 * @param ent the entry to add; the entry must not have been
313 * added to any other directory at this point and
314 * must not include @a dir in its structure
315 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error
316 */
317int 248int
318GNUNET_FS_file_information_add (struct GNUNET_FS_FileInformation *dir, 249GNUNET_FS_file_information_add (struct GNUNET_FS_FileInformation *dir,
319 struct GNUNET_FS_FileInformation *ent) 250 struct GNUNET_FS_FileInformation *ent)
diff --git a/src/fs/fs_list_indexed.c b/src/fs/fs_list_indexed.c
index 0e16fb01b..6a2ddd93c 100644
--- a/src/fs/fs_list_indexed.c
+++ b/src/fs/fs_list_indexed.c
@@ -155,14 +155,6 @@ mq_error_handler (void *cls,
155} 155}
156 156
157 157
158/**
159 * Iterate over all indexed files.
160 *
161 * @param h handle to the file sharing subsystem
162 * @param iterator function to call on each indexed file
163 * @param iterator_cls closure for iterator
164 * @return NULL on error ('iter' is not called)
165 */
166struct GNUNET_FS_GetIndexedContext * 158struct GNUNET_FS_GetIndexedContext *
167GNUNET_FS_get_indexed_files (struct GNUNET_FS_Handle *h, 159GNUNET_FS_get_indexed_files (struct GNUNET_FS_Handle *h,
168 GNUNET_FS_IndexedFileProcessor iterator, 160 GNUNET_FS_IndexedFileProcessor iterator,
diff --git a/src/fs/fs_namespace.c b/src/fs/fs_namespace.c
index 155486be5..bc94dd1fc 100644
--- a/src/fs/fs_namespace.c
+++ b/src/fs/fs_namespace.c
@@ -423,21 +423,6 @@ sks_publish_cont (void *cls, const char *msg)
423} 423}
424 424
425 425
426/**
427 * Publish an SBlock on GNUnet.
428 *
429 * @param h handle to the file sharing subsystem
430 * @param ns namespace to publish in
431 * @param identifier identifier to use
432 * @param update update identifier to use
433 * @param meta metadata to use
434 * @param uri URI to refer to in the SBlock
435 * @param bo block options
436 * @param options publication options
437 * @param cont continuation
438 * @param cont_cls closure for cont
439 * @return NULL on error ('cont' will still be called)
440 */
441struct GNUNET_FS_PublishSksContext * 426struct GNUNET_FS_PublishSksContext *
442GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h, 427GNUNET_FS_publish_sks (struct GNUNET_FS_Handle *h,
443 const struct GNUNET_CRYPTO_EcdsaPrivateKey *ns, 428 const struct GNUNET_CRYPTO_EcdsaPrivateKey *ns,
diff --git a/src/fs/fs_search.c b/src/fs/fs_search.c
index 3f3d30146..5538b7838 100644
--- a/src/fs/fs_search.c
+++ b/src/fs/fs_search.c
@@ -927,7 +927,7 @@ try_reconnect (struct GNUNET_FS_SearchContext *sc);
927 * We check a result message from the service. 927 * We check a result message from the service.
928 * 928 *
929 * @param cls closure 929 * @param cls closure
930 * @param msg result message received 930 * @param cm result message received
931 */ 931 */
932static int 932static int
933check_result (void *cls, 933check_result (void *cls,
@@ -942,7 +942,7 @@ check_result (void *cls,
942 * We process a search result from the service. 942 * We process a search result from the service.
943 * 943 *
944 * @param cls closure 944 * @param cls closure
945 * @param msg result message received 945 * @param cm result message received
946 */ 946 */
947static void 947static void
948handle_result (void *cls, 948handle_result (void *cls,
diff --git a/src/fs/fs_test_lib.c b/src/fs/fs_test_lib.c
index 94bf469f7..f80a2859c 100644
--- a/src/fs/fs_test_lib.c
+++ b/src/fs/fs_test_lib.c
@@ -177,7 +177,6 @@ struct TestDownloadOperation
177 * Task scheduled to report on the completion of our publish operation. 177 * Task scheduled to report on the completion of our publish operation.
178 * 178 *
179 * @param cls the publish operation context 179 * @param cls the publish operation context
180 * @param tc scheduler context (unused)
181 */ 180 */
182static void 181static void
183report_uri (void *cls) 182report_uri (void *cls)
diff --git a/src/fs/fs_uri.c b/src/fs/fs_uri.c
index 2d5566b54..cdea8b72d 100644
--- a/src/fs/fs_uri.c
+++ b/src/fs/fs_uri.c
@@ -91,14 +91,6 @@
91#include <unistdio.h> 91#include <unistdio.h>
92 92
93 93
94/**
95 * Get a unique key from a URI. This is for putting URIs
96 * into HashMaps. The key may change between FS implementations.
97 *
98 * @param uri uri to convert to a unique key
99 * @param key where to store the unique key
100 * @return #GNUNET_OK on success
101 */
102int 94int
103GNUNET_FS_uri_to_key (const struct GNUNET_FS_Uri *uri, 95GNUNET_FS_uri_to_key (const struct GNUNET_FS_Uri *uri,
104 struct GNUNET_HashCode *key) 96 struct GNUNET_HashCode *key)
@@ -723,15 +715,6 @@ GNUNET_FS_uri_ksk_get_keyword_count (const struct GNUNET_FS_Uri *uri)
723} 715}
724 716
725 717
726/**
727 * Iterate over all keywords in this keyword URI.
728 *
729 * @param uri ksk uri to get the keywords from
730 * @param iterator function to call on each keyword
731 * @param iterator_cls closure for iterator
732 * @return -1 if this is not a keyword URI, otherwise number of
733 * keywords iterated over until iterator aborted
734 */
735int 718int
736GNUNET_FS_uri_ksk_get_keywords (const struct GNUNET_FS_Uri *uri, 719GNUNET_FS_uri_ksk_get_keywords (const struct GNUNET_FS_Uri *uri,
737 GNUNET_FS_KeywordIterator iterator, 720 GNUNET_FS_KeywordIterator iterator,
diff --git a/src/fs/gnunet-service-fs.c b/src/fs/gnunet-service-fs.c
index c22a5b5a9..7da92ed44 100644
--- a/src/fs/gnunet-service-fs.c
+++ b/src/fs/gnunet-service-fs.c
@@ -603,7 +603,7 @@ update_latencies (void *cls,
603 * Check P2P "PUT" message. 603 * Check P2P "PUT" message.
604 * 604 *
605 * @param cls closure with the `struct GSF_ConnectedPeer` 605 * @param cls closure with the `struct GSF_ConnectedPeer`
606 * @param message the actual message 606 * @param put the actual message
607 * @return #GNUNET_OK to keep the connection open, 607 * @return #GNUNET_OK to keep the connection open,
608 * #GNUNET_SYSERR to close it (signal serious error) 608 * #GNUNET_SYSERR to close it (signal serious error)
609 */ 609 */
@@ -1063,7 +1063,7 @@ hash_for_index_val (void *cls,
1063 * Handle INDEX_START-message. 1063 * Handle INDEX_START-message.
1064 * 1064 *
1065 * @param cls identification of the client 1065 * @param cls identification of the client
1066 * @param message the actual message 1066 * @param ism the actual message
1067 */ 1067 */
1068static void 1068static void
1069handle_client_index_start (void *cls, 1069handle_client_index_start (void *cls,
@@ -1144,7 +1144,7 @@ handle_client_index_list_get (void *cls,
1144 * Handle UNINDEX-message. 1144 * Handle UNINDEX-message.
1145 * 1145 *
1146 * @param cls identification of the client 1146 * @param cls identification of the client
1147 * @param message the actual message 1147 * @param um the actual message
1148 */ 1148 */
1149static void 1149static void
1150handle_client_unindex (void *cls, 1150handle_client_unindex (void *cls,
diff --git a/src/fs/gnunet-service-fs_cadet_server.c b/src/fs/gnunet-service-fs_cadet_server.c
index 395842ebb..8bfe91cf0 100644
--- a/src/fs/gnunet-service-fs_cadet_server.c
+++ b/src/fs/gnunet-service-fs_cadet_server.c
@@ -415,7 +415,6 @@ connect_cb (void *cls,
415 * 415 *
416 * @param cls our `struct CadetClient` 416 * @param cls our `struct CadetClient`
417 * @param channel channel of the disconnecting client 417 * @param channel channel of the disconnecting client
418 * @param channel_ctx
419 */ 418 */
420static void 419static void
421disconnect_cb (void *cls, 420disconnect_cb (void *cls,
diff --git a/src/fs/gnunet-service-fs_cp.c b/src/fs/gnunet-service-fs_cp.c
index 96b21783c..29e4c5910 100644
--- a/src/fs/gnunet-service-fs_cp.c
+++ b/src/fs/gnunet-service-fs_cp.c
@@ -1342,8 +1342,6 @@ handle_p2p_get (void *cls,
1342 * @param cp target peer 1342 * @param cp target peer
1343 * @param is_query is this a query (#GNUNET_YES) or content (#GNUNET_NO) or neither (#GNUNET_SYSERR) 1343 * @param is_query is this a query (#GNUNET_YES) or content (#GNUNET_NO) or neither (#GNUNET_SYSERR)
1344 * @param priority how important is this request? 1344 * @param priority how important is this request?
1345 * @param timeout when does this request timeout
1346 * @param size number of bytes we would like to send to the peer
1347 * @param env message to send 1345 * @param env message to send
1348 */ 1346 */
1349void 1347void
diff --git a/src/fs/gnunet-service-fs_push.c b/src/fs/gnunet-service-fs_push.c
index 80c2c00e6..92dbba8e6 100644
--- a/src/fs/gnunet-service-fs_push.c
+++ b/src/fs/gnunet-service-fs_push.c
@@ -210,7 +210,7 @@ find_content (void *cls);
210/** 210/**
211 * Send the given block to the given peer. 211 * Send the given block to the given peer.
212 * 212 *
213 * @param peer target peer 213 * @param mrp target peer
214 * @param block the block 214 * @param block the block
215 * @return #GNUNET_YES if the block was deleted (!) 215 * @return #GNUNET_YES if the block was deleted (!)
216 */ 216 */
diff --git a/src/fs/plugin_block_fs.c b/src/fs/plugin_block_fs.c
index 18aa289ef..11677a6b2 100644
--- a/src/fs/plugin_block_fs.c
+++ b/src/fs/plugin_block_fs.c
@@ -158,10 +158,9 @@ block_plugin_fs_get_key (void *cls,
158 * Function called to validate a query. 158 * Function called to validate a query.
159 * 159 *
160 * @param cls closure 160 * @param cls closure
161 * @param ctx block context
162 * @param type block type 161 * @param type block type
163 * @param query original query (hash) 162 * @param query original query (hash)
164 * @param xquery extrended query data (can be NULL, depending on type) 163 * @param xquery extended query data (can be NULL, depending on type)
165 * @param xquery_size number of bytes in @a xquery 164 * @param xquery_size number of bytes in @a xquery
166 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not 165 * @return #GNUNET_OK if the query is fine, #GNUNET_NO if not
167 */ 166 */
diff --git a/src/gns/gns_tld_api.c b/src/gns/gns_tld_api.c
index 1b711cf40..c88ce776e 100644
--- a/src/gns/gns_tld_api.c
+++ b/src/gns/gns_tld_api.c
@@ -186,7 +186,7 @@ lookup_with_public_key (struct GNUNET_GNS_LookupWithTldRequest *ltr,
186 * @param cls a `struct GNUNET_GNS_LookupWithTldRequest *` 186 * @param cls a `struct GNUNET_GNS_LookupWithTldRequest *`
187 * @param ego ego handle, NULL at the end of the iteration 187 * @param ego ego handle, NULL at the end of the iteration
188 * @param ctx context we could store data to associate with @e ego 188 * @param ctx context we could store data to associate with @e ego
189 * @param name name of the ego 189 * @param ego_name name of the ego
190 */ 190 */
191static void 191static void
192identity_zone_cb (void *cls, 192identity_zone_cb (void *cls,
diff --git a/src/gns/gnunet-gns-proxy.c b/src/gns/gnunet-gns-proxy.c
index a834c5c19..312fde293 100644
--- a/src/gns/gnunet-gns-proxy.c
+++ b/src/gns/gnunet-gns-proxy.c
@@ -3429,7 +3429,6 @@ do_s5r_read (void *cls)
3429 * Accept new incoming connections 3429 * Accept new incoming connections
3430 * 3430 *
3431 * @param cls the closure with the lsock4 or lsock6 3431 * @param cls the closure with the lsock4 or lsock6
3432 * @param tc the scheduler context
3433 */ 3432 */
3434static void 3433static void
3435do_accept (void *cls) 3434do_accept (void *cls)
diff --git a/src/gns/gnunet-service-gns.c b/src/gns/gnunet-service-gns.c
index b28236fed..6a11ec2ce 100644
--- a/src/gns/gnunet-service-gns.c
+++ b/src/gns/gnunet-service-gns.c
@@ -412,8 +412,7 @@ check_lookup (void *cls,
412 * Handle lookup requests from client 412 * Handle lookup requests from client
413 * 413 *
414 * @param cls the closure 414 * @param cls the closure
415 * @param client the client 415 * @param sh_msg the message
416 * @param message the message
417 */ 416 */
418static void 417static void
419handle_lookup (void *cls, 418handle_lookup (void *cls,
diff --git a/src/gns/nss/nss_gns.c b/src/gns/nss/nss_gns.c
index 77b4340ee..ff34cedd5 100644
--- a/src/gns/nss/nss_gns.c
+++ b/src/gns/nss/nss_gns.c
@@ -193,7 +193,7 @@ finish:
193 * @param result the result hostent 193 * @param result the result hostent
194 * @param buffer the result buffer 194 * @param buffer the result buffer
195 * @param buflen length of the buffer 195 * @param buflen length of the buffer
196 * @param errnop[out] the low-level error code to return to the application 196 * @param[out] errnop the low-level error code to return to the application
197 * @param h_errnop idk 197 * @param h_errnop idk
198 * @return a nss_status code 198 * @return a nss_status code
199 */ 199 */
@@ -225,7 +225,7 @@ _nss_gns_gethostbyname_r (const char *name,
225 * @param result the result hostent 225 * @param result the result hostent
226 * @param buffer the result buffer 226 * @param buffer the result buffer
227 * @param buflen length of the buffer 227 * @param buflen length of the buffer
228 * @param errnop[out] the low-level error code to return to the application 228 * @param[out] errnop the low-level error code to return to the application
229 * @param h_errnop idk 229 * @param h_errnop idk
230 * @return NSS_STATUS_UNAVAIL 230 * @return NSS_STATUS_UNAVAIL
231 */ 231 */
diff --git a/src/gns/plugin_block_gns.c b/src/gns/plugin_block_gns.c
index a683ecacc..75e182092 100644
--- a/src/gns/plugin_block_gns.c
+++ b/src/gns/plugin_block_gns.c
@@ -133,7 +133,6 @@ block_plugin_gns_get_key (void *cls,
133 * Function called to validate a query. 133 * Function called to validate a query.
134 * 134 *
135 * @param cls closure 135 * @param cls closure
136 * @param ctx block context
137 * @param type block type 136 * @param type block type
138 * @param query original query (hash) 137 * @param query original query (hash)
139 * @param xquery extrended query data (can be NULL, depending on type) 138 * @param xquery extrended query data (can be NULL, depending on type)
diff --git a/src/gns/plugin_rest_gns.c b/src/gns/plugin_rest_gns.c
index 3a35c9999..659b77493 100644
--- a/src/gns/plugin_rest_gns.c
+++ b/src/gns/plugin_rest_gns.c
@@ -159,7 +159,7 @@ static struct RequestHandle *requests_tail;
159 159
160/** 160/**
161 * Cleanup lookup handle 161 * Cleanup lookup handle
162 * @param handle Handle to clean up 162 * @param cls `struct RequestHandle` to clean up
163 */ 163 */
164static void 164static void
165cleanup_handle (void *cls) 165cleanup_handle (void *cls)
diff --git a/src/gnsrecord/gnsrecord.c b/src/gnsrecord/gnsrecord.c
index 52c480ef6..ae4223021 100644
--- a/src/gnsrecord/gnsrecord.c
+++ b/src/gnsrecord/gnsrecord.c
@@ -174,16 +174,6 @@ GNUNET_GNSRECORD_value_to_string (uint32_t type,
174} 174}
175 175
176 176
177/**
178 * Convert human-readable version of a 'value' of a record to the binary
179 * representation.
180 *
181 * @param type type of the record
182 * @param s human-readable string
183 * @param data set to value in binary encoding (will be allocated)
184 * @param data_size set to number of bytes in @a data
185 * @return #GNUNET_OK on success
186 */
187int 177int
188GNUNET_GNSRECORD_string_to_value (uint32_t type, 178GNUNET_GNSRECORD_string_to_value (uint32_t type,
189 const char *s, 179 const char *s,
@@ -207,12 +197,6 @@ GNUNET_GNSRECORD_string_to_value (uint32_t type,
207} 197}
208 198
209 199
210/**
211 * Convert a type name (e.g "AAAA") to the corresponding number.
212 *
213 * @param dns_typename name to convert
214 * @return corresponding number, UINT32_MAX on error
215 */
216uint32_t 200uint32_t
217GNUNET_GNSRECORD_typename_to_number (const char *dns_typename) 201GNUNET_GNSRECORD_typename_to_number (const char *dns_typename)
218{ 202{
diff --git a/src/gnsrecord/gnsrecord_crypto.c b/src/gnsrecord/gnsrecord_crypto.c
index b5e8be82b..6c1bc6045 100644
--- a/src/gnsrecord/gnsrecord_crypto.c
+++ b/src/gnsrecord/gnsrecord_crypto.c
@@ -868,17 +868,6 @@ block_decrypt_eddsa (const struct GNUNET_GNSRECORD_Block *block,
868} 868}
869 869
870 870
871/**
872 * Decrypt block.
873 *
874 * @param block block to decrypt
875 * @param zone_key public key of the zone
876 * @param label the name for the records
877 * @param proc function to call with the result
878 * @param proc_cls closure for proc
879 * @return #GNUNET_OK on success, #GNUNET_SYSERR if the block was
880 * not well-formed
881 */
882enum GNUNET_GenericReturnValue 871enum GNUNET_GenericReturnValue
883GNUNET_GNSRECORD_block_decrypt (const struct GNUNET_GNSRECORD_Block *block, 872GNUNET_GNSRECORD_block_decrypt (const struct GNUNET_GNSRECORD_Block *block,
884 const struct 873 const struct
@@ -946,14 +935,6 @@ GNUNET_GNSRECORD_query_from_private_key (const struct
946} 935}
947 936
948 937
949/**
950 * Calculate the DHT query for a given @a label in a given @a zone.
951 * FIXME: We may want to plugin-ize this at some point.
952 *
953 * @param pub public key of the zone
954 * @param label label of the record
955 * @param query hash to use for the query
956 */
957void 938void
958GNUNET_GNSRECORD_query_from_public_key (const struct 939GNUNET_GNSRECORD_query_from_public_key (const struct
959 GNUNET_IDENTITY_PublicKey *pub, 940 GNUNET_IDENTITY_PublicKey *pub,
diff --git a/src/gnsrecord/gnsrecord_misc.c b/src/gnsrecord/gnsrecord_misc.c
index 880fc68c6..5a24a83d3 100644
--- a/src/gnsrecord/gnsrecord_misc.c
+++ b/src/gnsrecord/gnsrecord_misc.c
@@ -62,14 +62,6 @@ GNUNET_GNSRECORD_label_check (const char*label, char **emsg)
62} 62}
63 63
64 64
65/**
66 * Convert a zone key to a string (for printing debug messages).
67 * This is one of the very few calls in the entire API that is
68 * NOT reentrant!
69 *
70 * @param z the zone key
71 * @return string form; will be overwritten by next call to #GNUNET_GNSRECORD_z2s
72 */
73const char * 65const char *
74GNUNET_GNSRECORD_z2s (const struct GNUNET_IDENTITY_PublicKey *z) 66GNUNET_GNSRECORD_z2s (const struct GNUNET_IDENTITY_PublicKey *z)
75{ 67{
diff --git a/src/gnsrecord/gnsrecord_serialization.c b/src/gnsrecord/gnsrecord_serialization.c
index 97c488c2b..ef7684892 100644
--- a/src/gnsrecord/gnsrecord_serialization.c
+++ b/src/gnsrecord/gnsrecord_serialization.c
@@ -77,14 +77,6 @@ struct NetworkRecord
77GNUNET_NETWORK_STRUCT_END 77GNUNET_NETWORK_STRUCT_END
78 78
79 79
80/**
81 * Calculate how many bytes we will need to serialize the given
82 * records.
83 *
84 * @param rd_count number of records in the rd array
85 * @param rd array of #GNUNET_GNSRECORD_Data with @a rd_count elements
86 * @return the required size to serialize, -1 on error
87 */
88ssize_t 80ssize_t
89GNUNET_GNSRECORD_records_get_size (unsigned int rd_count, 81GNUNET_GNSRECORD_records_get_size (unsigned int rd_count,
90 const struct GNUNET_GNSRECORD_Data *rd) 82 const struct GNUNET_GNSRECORD_Data *rd)
@@ -143,15 +135,6 @@ GNUNET_GNSRECORD_records_get_size (unsigned int rd_count,
143} 135}
144 136
145 137
146/**
147 * Serialize the given records to the given destination buffer.
148 *
149 * @param rd_count number of records in the rd array
150 * @param rd array of #GNUNET_GNSRECORD_Data with @a rd_count elements
151 * @param dest_size size of the destination array
152 * @param dest where to write the result
153 * @return the size of serialized records, -1 if records do not fit
154 */
155ssize_t 138ssize_t
156GNUNET_GNSRECORD_records_serialize (unsigned int rd_count, 139GNUNET_GNSRECORD_records_serialize (unsigned int rd_count,
157 const struct GNUNET_GNSRECORD_Data *rd, 140 const struct GNUNET_GNSRECORD_Data *rd,
diff --git a/src/hello/address.c b/src/hello/address.c
index e22f3850f..6a1b68029 100644
--- a/src/hello/address.c
+++ b/src/hello/address.c
@@ -59,16 +59,6 @@ GNUNET_HELLO_address_get_size (const struct GNUNET_HELLO_Address *address)
59} 59}
60 60
61 61
62/**
63 * Allocate an address struct.
64 *
65 * @param peer the peer
66 * @param transport_name plugin name
67 * @param address binary address
68 * @param address_length number of bytes in 'address'
69 * @param local_info additional local information for the address
70 * @return the address struct
71 */
72struct GNUNET_HELLO_Address * 62struct GNUNET_HELLO_Address *
73GNUNET_HELLO_address_allocate (const struct GNUNET_PeerIdentity *peer, 63GNUNET_HELLO_address_allocate (const struct GNUNET_PeerIdentity *peer,
74 const char *transport_name, 64 const char *transport_name,
@@ -118,14 +108,6 @@ GNUNET_HELLO_address_copy (const struct GNUNET_HELLO_Address *address)
118} 108}
119 109
120 110
121/**
122 * Compare two addresses. Does NOT compare the peer identity,
123 * that is assumed already to match!
124 *
125 * @param a1 first address
126 * @param a2 second address
127 * @return 0 if the addresses are equal, -1 if a1<a2, 1 if a1>a2.
128 */
129int 111int
130GNUNET_HELLO_address_cmp (const struct GNUNET_HELLO_Address *a1, 112GNUNET_HELLO_address_cmp (const struct GNUNET_HELLO_Address *a1,
131 const struct GNUNET_HELLO_Address *a2) 113 const struct GNUNET_HELLO_Address *a2)
diff --git a/src/hello/hello-ng.c b/src/hello/hello-ng.c
index 96856a692..da3a069e0 100644
--- a/src/hello/hello-ng.c
+++ b/src/hello/hello-ng.c
@@ -60,8 +60,8 @@ GNUNET_NETWORK_STRUCT_END
60 * @param nt network type of @a address 60 * @param nt network type of @a address
61 * @param mono_time monotonic time at which @a address was valid 61 * @param mono_time monotonic time at which @a address was valid
62 * @param private_key signing key to use 62 * @param private_key signing key to use
63 * @param result[out] where to write address record (allocated) 63 * @param[out] result where to write address record (allocated)
64 * @param result_size[out] set to size of @a result 64 * @param[out] result_size set to size of @a result
65 */ 65 */
66void 66void
67GNUNET_HELLO_sign_address ( 67GNUNET_HELLO_sign_address (
diff --git a/src/hello/hello.c b/src/hello/hello.c
index 12b576ceb..45d27c5d4 100644
--- a/src/hello/hello.c
+++ b/src/hello/hello.c
@@ -511,15 +511,6 @@ merge_addr (void *cls,
511} 511}
512 512
513 513
514/**
515 * Construct a HELLO message by merging the
516 * addresses in two existing HELLOs (which
517 * must be for the same peer).
518 *
519 * @param h1 first HELLO message
520 * @param h2 the second HELLO message
521 * @return the combined HELLO message
522 */
523struct GNUNET_HELLO_Message * 514struct GNUNET_HELLO_Message *
524GNUNET_HELLO_merge (const struct GNUNET_HELLO_Message *h1, 515GNUNET_HELLO_merge (const struct GNUNET_HELLO_Message *h1,
525 const struct GNUNET_HELLO_Message *h2) 516 const struct GNUNET_HELLO_Message *h2)
@@ -606,19 +597,6 @@ delta_match (void *cls,
606} 597}
607 598
608 599
609/**
610 * Iterate over addresses in @a new_hello that are NOT already present
611 * in @a old_hello. Note that if the address is present in @a old_hello
612 * but the expiration time in @a new_hello is more recent, the iterator
613 * is also called.
614 *
615 * @param new_hello a HELLO message
616 * @param old_hello a HELLO message
617 * @param expiration_limit ignore addresses in @a old_hello
618 * that expired before the given time stamp
619 * @param it iterator to call on each address
620 * @param it_cls closure for @a it
621 */
622void 600void
623GNUNET_HELLO_iterate_new_addresses (const struct 601GNUNET_HELLO_iterate_new_addresses (const struct
624 GNUNET_HELLO_Message *new_hello, 602 GNUNET_HELLO_Message *new_hello,
diff --git a/src/hostlist/gnunet-daemon-hostlist_client.c b/src/hostlist/gnunet-daemon-hostlist_client.c
index f097cecc9..399a7dc39 100644
--- a/src/hostlist/gnunet-daemon-hostlist_client.c
+++ b/src/hostlist/gnunet-daemon-hostlist_client.c
@@ -1318,8 +1318,6 @@ primary_task (void *cls, int success)
1318 * we go the stat. Initiates hostlist download scheduling. 1318 * we go the stat. Initiates hostlist download scheduling.
1319 * 1319 *
1320 * @param cls closure 1320 * @param cls closure
1321 * @param success #GNUNET_OK if statistics were
1322 * successfully obtained, #GNUNET_SYSERR if not.
1323 */ 1321 */
1324static void 1322static void
1325stat_timeout_task (void *cls) 1323stat_timeout_task (void *cls)
diff --git a/src/identity/gnunet-service-identity.c b/src/identity/gnunet-service-identity.c
index 51f897557..51fca7816 100644
--- a/src/identity/gnunet-service-identity.c
+++ b/src/identity/gnunet-service-identity.c
@@ -476,8 +476,7 @@ check_get_default_message (void *cls,
476 * default identity for some service. 476 * default identity for some service.
477 * 477 *
478 * @param cls unused 478 * @param cls unused
479 * @param client who sent the message 479 * @param gdm the message received
480 * @param message the message received
481 */ 480 */
482static void 481static void
483handle_get_default_message (void *cls, 482handle_get_default_message (void *cls,
@@ -587,8 +586,7 @@ check_set_default_message (void *cls,
587 * default identity for some service. 586 * default identity for some service.
588 * 587 *
589 * @param cls unused 588 * @param cls unused
590 * @param client who sent the message 589 * @param sdm the message received
591 * @param message the message received
592 */ 590 */
593static void 591static void
594handle_set_default_message (void *cls, 592handle_set_default_message (void *cls,
@@ -699,8 +697,7 @@ check_create_message (void *cls,
699 * Handler for CREATE message from client, creates new identity. 697 * Handler for CREATE message from client, creates new identity.
700 * 698 *
701 * @param cls unused 699 * @param cls unused
702 * @param client who sent the message 700 * @param crm the message received
703 * @param message the message received
704 */ 701 */
705static void 702static void
706handle_create_message (void *cls, 703handle_create_message (void *cls,
@@ -839,8 +836,7 @@ check_rename_message (void *cls, const struct RenameMessage *msg)
839 * new identity. 836 * new identity.
840 * 837 *
841 * @param cls unused 838 * @param cls unused
842 * @param client who sent the message 839 * @param rm the message received
843 * @param message the message received
844 */ 840 */
845static void 841static void
846handle_rename_message (void *cls, const struct RenameMessage *rm) 842handle_rename_message (void *cls, const struct RenameMessage *rm)
@@ -985,8 +981,7 @@ check_delete_message (void *cls, const struct DeleteMessage *msg)
985 * new identity. 981 * new identity.
986 * 982 *
987 * @param cls unused 983 * @param cls unused
988 * @param client who sent the message 984 * @param dm the message received
989 * @param message the message received
990 */ 985 */
991static void 986static void
992handle_delete_message (void *cls, const struct DeleteMessage *dm) 987handle_delete_message (void *cls, const struct DeleteMessage *dm)
diff --git a/src/identity/identity_api.c b/src/identity/identity_api.c
index 471569cb3..934ee31c6 100644
--- a/src/identity/identity_api.c
+++ b/src/identity/identity_api.c
@@ -661,16 +661,6 @@ GNUNET_IDENTITY_ego_get_public_key (struct GNUNET_IDENTITY_Ego *ego,
661} 661}
662 662
663 663
664/**
665 * Obtain the identity that is currently preferred/default
666 * for a service.
667 *
668 * @param h identity service to query
669 * @param service_name for which service is an identity wanted
670 * @param cb function to call with the result (will only be called once)
671 * @param cb_cls closure for @a cb
672 * @return handle to abort the operation
673 */
674struct GNUNET_IDENTITY_Operation * 664struct GNUNET_IDENTITY_Operation *
675GNUNET_IDENTITY_get (struct GNUNET_IDENTITY_Handle *h, 665GNUNET_IDENTITY_get (struct GNUNET_IDENTITY_Handle *h,
676 const char *service_name, 666 const char *service_name,
diff --git a/src/identity/plugin_rest_identity.c b/src/identity/plugin_rest_identity.c
index d9b1e7c2c..5327d0b1f 100644
--- a/src/identity/plugin_rest_identity.c
+++ b/src/identity/plugin_rest_identity.c
@@ -280,7 +280,7 @@ static struct RequestHandle *requests_tail;
280 280
281/** 281/**
282 * Cleanup lookup handle 282 * Cleanup lookup handle
283 * @param handle Handle to clean up 283 * @param cls Handle to clean up
284 */ 284 */
285static void 285static void
286cleanup_handle (void *cls) 286cleanup_handle (void *cls)
@@ -696,7 +696,7 @@ do_finished (void *cls, const char *emsg)
696 * Processing finished, when creating an ego. 696 * Processing finished, when creating an ego.
697 * 697 *
698 * @param cls request handle 698 * @param cls request handle
699 * @param private key of the ego, or NULL on error 699 * @param pk private key of the ego, or NULL on error
700 * @param emsg error message 700 * @param emsg error message
701 */ 701 */
702static void 702static void
diff --git a/src/include/block_dns.h b/src/include/block_dns.h
index 2186cb1a1..2c573fb20 100644
--- a/src/include/block_dns.h
+++ b/src/include/block_dns.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup vpn_suite
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -65,3 +68,5 @@ GNUNET_NETWORK_STRUCT_END
65#endif 68#endif
66 69
67/** @} */ /* end of group */ 70/** @} */ /* end of group */
71
72/** @} */ /* end of group addition to vpn_suite */
diff --git a/src/include/block_fs.h b/src/include/block_fs.h
index e4caf6e50..f05bb4a29 100644
--- a/src/include/block_fs.h
+++ b/src/include/block_fs.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup fs_l2
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -98,3 +101,5 @@ GNUNET_NETWORK_STRUCT_END
98#endif 101#endif
99 102
100/** @} */ /* end of group */ 103/** @} */ /* end of group */
104
105/** @} */ /* end of group addition to fs_l2 */
diff --git a/src/include/gnunet_abd_service.h b/src/include/gnunet_abd_service.h
index 21f668a8d..a52ed29ff 100644
--- a/src/include/gnunet_abd_service.h
+++ b/src/include/gnunet_abd_service.h
@@ -19,13 +19,16 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup reclaim_suite
23 * @{
24 *
22 * @author Martin Schanzenbach 25 * @author Martin Schanzenbach
23 * 26 *
24 * @file 27 * @file
25 * API to the Credential service 28 * API to the Credential service
26 * 29 *
27 * @defgroup abd Credential service 30 * @defgroup abd Credential service
28 * Credentials 31 * Credential service for Attribute-Based Decryption
29 * 32 *
30 * @{ 33 * @{
31 */ 34 */
@@ -384,7 +387,7 @@ GNUNET_ABD_remove_delegation (struct GNUNET_ABD_Handle *handle,
384 * 387 *
385 * @param issuer the ego that should be used to issue the attribute 388 * @param issuer the ego that should be used to issue the attribute
386 * @param subject the subject of the attribute 389 * @param subject the subject of the attribute
387 * @param attribute the name of the attribute 390 * @param iss_attr the name of the attribute
388 * @param expiration the TTL of the credential 391 * @param expiration the TTL of the credential
389 * @return handle to the queued request 392 * @return handle to the queued request
390 */ 393 */
@@ -415,3 +418,5 @@ GNUNET_ABD_request_cancel (struct GNUNET_ABD_Request *lr);
415#endif 418#endif
416 419
417/** @} */ /* end of group */ 420/** @} */ /* end of group */
421
422/** @} */ /* end of group addition to reclaim_suite */
diff --git a/src/include/gnunet_applications.h b/src/include/gnunet_applications.h
index 1e2ac59f7..489dc7050 100644
--- a/src/include/gnunet_applications.h
+++ b/src/include/gnunet_applications.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup Backbone
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -133,4 +136,6 @@ extern "C"
133 136
134/** @} */ /* end of group */ 137/** @} */ /* end of group */
135 138
139/** @} */ /* end of group addition to Backbone */
140
136/* end of gnunet_applications.h */ 141/* end of gnunet_applications.h */
diff --git a/src/include/gnunet_ats_service.h b/src/include/gnunet_ats_service.h
index 11a65c4f5..321e621d2 100644
--- a/src/include/gnunet_ats_service.h
+++ b/src/include/gnunet_ats_service.h
@@ -158,7 +158,7 @@ struct GNUNET_ATS_PropertiesNBO
158/** 158/**
159 * Convert ATS properties from host to network byte order. 159 * Convert ATS properties from host to network byte order.
160 * 160 *
161 * @param nbo[OUT] value written 161 * @param nbo[out] value written
162 * @param hbo value read 162 * @param hbo value read
163 */ 163 */
164void 164void
@@ -169,7 +169,7 @@ GNUNET_ATS_properties_hton (struct GNUNET_ATS_PropertiesNBO *nbo,
169/** 169/**
170 * Convert ATS properties from network to host byte order. 170 * Convert ATS properties from network to host byte order.
171 * 171 *
172 * @param hbo[OUT] value written 172 * @param hbo[out] value written
173 * @param nbo value read 173 * @param nbo value read
174 */ 174 */
175void 175void
@@ -344,7 +344,7 @@ GNUNET_ATS_address_add_session (struct GNUNET_ATS_AddressRecord *ar,
344 * @param session session handle 344 * @param session session handle
345 * @return #GNUNET_YES if the @a ar was destroyed because 345 * @return #GNUNET_YES if the @a ar was destroyed because
346 * it was an incoming address, 346 * it was an incoming address,
347 * #GNUNET_NO if the @ar was kept because we can 347 * #GNUNET_NO if the @a ar was kept because we can
348 * use it still to establish a new session 348 * use it still to establish a new session
349 */ 349 */
350int 350int
diff --git a/src/include/gnunet_block_group_lib.h b/src/include/gnunet_block_group_lib.h
index d242ceefb..53827f5f4 100644
--- a/src/include/gnunet_block_group_lib.h
+++ b/src/include/gnunet_block_group_lib.h
@@ -90,7 +90,7 @@ GNUNET_BLOCK_GROUP_bf_create (void *cls,
90 * @param bg block group to use for testing 90 * @param bg block group to use for testing
91 * @param hc hash of element to evaluate 91 * @param hc hash of element to evaluate
92 * @return #GNUNET_YES if @a hc is (likely) a duplicate 92 * @return #GNUNET_YES if @a hc is (likely) a duplicate
93 * #GNUNET_NO if @a hc was definitively not in @bg (but now is) 93 * #GNUNET_NO if @a hc was definitively not in @a bg (but now is)
94 */ 94 */
95enum GNUNET_GenericReturnValue 95enum GNUNET_GenericReturnValue
96GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg, 96GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg,
diff --git a/src/include/gnunet_block_lib.h b/src/include/gnunet_block_lib.h
index fe6c99613..6a6de712b 100644
--- a/src/include/gnunet_block_lib.h
+++ b/src/include/gnunet_block_lib.h
@@ -131,7 +131,6 @@ struct GNUNET_BLOCK_Group;
131 * 131 *
132 * @param ctx block context in which the block group is created 132 * @param ctx block context in which the block group is created
133 * @param type type of the block for which we are creating the group 133 * @param type type of the block for which we are creating the group
134 * @param nonce random value used to seed the group creation
135 * @param raw_data optional serialized prior state of the group, NULL if unavailable/fresh 134 * @param raw_data optional serialized prior state of the group, NULL if unavailable/fresh
136 * @param raw_data_size number of bytes in @a raw_data, 0 if unavailable/fresh 135 * @param raw_data_size number of bytes in @a raw_data, 0 if unavailable/fresh
137 * @param ... type-specific additional data, can be empty 136 * @param ... type-specific additional data, can be empty
@@ -272,7 +271,7 @@ GNUNET_BLOCK_group_set_seen (struct GNUNET_BLOCK_Group *bg,
272 271
273/** 272/**
274 * Try merging two block groups. Afterwards, @a bg1 should remain 273 * Try merging two block groups. Afterwards, @a bg1 should remain
275 * valid and contain the rules from both @a bg1 and @bg2, and 274 * valid and contain the rules from both @a bg1 and @a bg2, and
276 * @a bg2 should be destroyed (as part of this call). The latter 275 * @a bg2 should be destroyed (as part of this call). The latter
277 * should happen even if merging is not supported. 276 * should happen even if merging is not supported.
278 * 277 *
diff --git a/src/include/gnunet_client_lib.h b/src/include/gnunet_client_lib.h
index 3cafa7e45..321810eb4 100644
--- a/src/include/gnunet_client_lib.h
+++ b/src/include/gnunet_client_lib.h
@@ -101,8 +101,8 @@ GNUNET_CLIENT_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
101 101
102/** @} */ /* end of group client */ 102/** @} */ /* end of group client */
103 103
104/* @} */ /* end of group addition */ 104/** @} */ /* end of group addition */
105 105
106/* @} */ /* end of group addition */ 106/** @} */ /* end of group addition */
107 107
108/* end of gnunet_client_lib.h */ 108/* end of gnunet_client_lib.h */
diff --git a/src/include/gnunet_common.h b/src/include/gnunet_common.h
index 5035d6baa..8c58fd6e3 100644
--- a/src/include/gnunet_common.h
+++ b/src/include/gnunet_common.h
@@ -1510,7 +1510,7 @@ GNUNET_is_zero_ (const void *a,
1510 * will be updated to reflect the new address. The TYPE of 1510 * will be updated to reflect the new address. The TYPE of
1511 * arr is important since size is the number of elements and 1511 * arr is important since size is the number of elements and
1512 * not the size in bytes 1512 * not the size in bytes
1513 * @param len the number of elements in the existing vector (number 1513 * @param len2 the number of elements in the existing vector (number
1514 * of elements to copy over), will be updated with the new 1514 * of elements to copy over), will be updated with the new
1515 * array size 1515 * array size
1516 1516
@@ -1743,7 +1743,7 @@ GNUNET_copy_message (const struct GNUNET_MessageHeader *msg);
1743 * Set the async scope for the current thread. 1743 * Set the async scope for the current thread.
1744 * 1744 *
1745 * @param aid the async scope identifier 1745 * @param aid the async scope identifier
1746 * @param old_scope[out] location to save the old scope 1746 * @param[out] old_scope location to save the old scope
1747 */ 1747 */
1748void 1748void
1749GNUNET_async_scope_enter (const struct GNUNET_AsyncScopeId *aid, 1749GNUNET_async_scope_enter (const struct GNUNET_AsyncScopeId *aid,
diff --git a/src/include/gnunet_configuration_lib.h b/src/include/gnunet_configuration_lib.h
index ac0013e94..2d26f3c05 100644
--- a/src/include/gnunet_configuration_lib.h
+++ b/src/include/gnunet_configuration_lib.h
@@ -174,7 +174,7 @@ GNUNET_CONFIGURATION_serialize_diagnostics (
174 * @param mem the memory block of serialized configuration 174 * @param mem the memory block of serialized configuration
175 * @param size the size of the memory block 175 * @param size the size of the memory block
176 * @param source_filename source filename, will be used 176 * @param source_filename source filename, will be used
177 * to resolve relative @INLINE@ statements 177 * to resolve relative \@INLINE\@ statements
178 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error 178 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error
179 */ 179 */
180enum GNUNET_GenericReturnValue 180enum GNUNET_GenericReturnValue
diff --git a/src/include/gnunet_container_lib.h b/src/include/gnunet_container_lib.h
index 097ee040d..b31a95fac 100644
--- a/src/include/gnunet_container_lib.h
+++ b/src/include/gnunet_container_lib.h
@@ -28,24 +28,30 @@
28 * 28 *
29 * @file 29 * @file
30 * Container classes for GNUnet 30 * Container classes for GNUnet
31 * 31 *
32 * @defgroup hashmap Container library: MultiHashMap 32 * @addtogroup container
33 * Common data structures in GNUnet programs
34 * @{
35 *
36 * @defgroup hashmap MultiHashMap
33 * Hash map with multiple values per key. 37 * Hash map with multiple values per key.
34 * 38 *
35 * @see [Documentation](https://gnunet.org/util_multihashmap) 39 * @see [Documentation](https://gnunet.org/util_multihashmap)
36 * 40 *
37 * @defgroup heap Container library: Heap 41 * @defgroup heap Heap
38 * Min- or max-heap with arbitrary element removal 42 * Min- or max-heap with arbitrary element removal
39 * 43 *
40 * @defgroup bloomfilter Container library: Bloom filter 44 * @defgroup bloomfilter Bloom filter
41 * Probabilistic set tests 45 * Probabilistic set tests
42 * 46 *
43 * @defgroup dll Container library: Doubly-linked list 47 * @defgroup dll Doubly-linked list
44 * 48 *
45 * @see [Documentation](https://gnunet.org/mdll-api) 49 * @see [Documentation](https://gnunet.org/mdll-api)
46 * 50 *
47 * @defgroup metadata Container library: Metadata 51 * @defgroup metadata Metadata
48 * GNU libextractor key-value pairs 52 * GNU libextractor key-value pairs
53 *
54 * @}
49 */ 55 */
50 56
51#ifndef GNUNET_CONTAINER_LIB_H 57#ifndef GNUNET_CONTAINER_LIB_H
diff --git a/src/include/gnunet_crypto_lib.h b/src/include/gnunet_crypto_lib.h
index 7ff50dda1..36e6743b3 100644
--- a/src/include/gnunet_crypto_lib.h
+++ b/src/include/gnunet_crypto_lib.h
@@ -1431,7 +1431,7 @@ enum GNUNET_GenericReturnValue
1431GNUNET_CRYPTO_eddsa_private_key_from_string ( 1431GNUNET_CRYPTO_eddsa_private_key_from_string (
1432 const char *enc, 1432 const char *enc,
1433 size_t enclen, 1433 size_t enclen,
1434 struct GNUNET_CRYPTO_EddsaPrivateKey *pub); 1434 struct GNUNET_CRYPTO_EddsaPrivateKey *priv);
1435 1435
1436 1436
1437/** 1437/**
@@ -1683,7 +1683,7 @@ GNUNET_CRYPTO_ecc_dlog_prepare (unsigned int max,
1683 * Calculate ECC discrete logarithm for small factors. 1683 * Calculate ECC discrete logarithm for small factors.
1684 * Opposite of #GNUNET_CRYPTO_ecc_dexp(). 1684 * Opposite of #GNUNET_CRYPTO_ecc_dexp().
1685 * 1685 *
1686 * @param dlc precalculated values, determine range of factors 1686 * @param edc precalculated values, determine range of factors
1687 * @param input point on the curve to factor 1687 * @param input point on the curve to factor
1688 * @return INT_MAX if dlog failed, otherwise the factor 1688 * @return INT_MAX if dlog failed, otherwise the factor
1689 */ 1689 */
@@ -1954,7 +1954,7 @@ GNUNET_CRYPTO_ecdsa_sign_ (
1954 * 1954 *
1955 * @param priv 1955 * @param priv
1956 * @param data 1956 * @param data
1957 * @param len 1957 * @param size
1958 * @param sig 1958 * @param sig
1959 * @return enum GNUNET_GenericReturnValue 1959 * @return enum GNUNET_GenericReturnValue
1960 */ 1960 */
@@ -2239,7 +2239,7 @@ GNUNET_CRYPTO_ecdsa_public_key_derive (
2239 * @param label label to use for key deriviation 2239 * @param label label to use for key deriviation
2240 * @param context additional context to use for HKDF of 'h'; 2240 * @param context additional context to use for HKDF of 'h';
2241 * typically the name of the subsystem/application 2241 * typically the name of the subsystem/application
2242 * @param purp the signature purpose 2242 * @param purpose the signature purpose
2243 * @param sig the resulting signature 2243 * @param sig the resulting signature
2244 * @return GNUNET_OK on success 2244 * @return GNUNET_OK on success
2245 */ 2245 */
@@ -2304,7 +2304,7 @@ GNUNET_CRYPTO_eddsa_public_key_derive (
2304 * @param label label to use for key deriviation 2304 * @param label label to use for key deriviation
2305 * @param context additional context to use for HKDF of 'h'; 2305 * @param context additional context to use for HKDF of 'h';
2306 * typically the name of the subsystem/application 2306 * typically the name of the subsystem/application
2307 * @param purp the signature purpose 2307 * @param purpose the signature purpose
2308 * @param sig the resulting signature 2308 * @param sig the resulting signature
2309 * @return GNUNET_OK on success 2309 * @return GNUNET_OK on success
2310 */ 2310 */
@@ -2432,7 +2432,7 @@ GNUNET_CRYPTO_paillier_encrypt (
2432 * @param private_key Private key to use for decryption. 2432 * @param private_key Private key to use for decryption.
2433 * @param public_key Public key to use for decryption. 2433 * @param public_key Public key to use for decryption.
2434 * @param ciphertext Ciphertext to decrypt. 2434 * @param ciphertext Ciphertext to decrypt.
2435 * @param[out] m Decryption of @a ciphertext with @private_key. 2435 * @param[out] m Decryption of @a ciphertext with @a private_key.
2436 */ 2436 */
2437void 2437void
2438GNUNET_CRYPTO_paillier_decrypt ( 2438GNUNET_CRYPTO_paillier_decrypt (
@@ -2690,7 +2690,7 @@ GNUNET_CRYPTO_rsa_public_key_cmp (const struct GNUNET_CRYPTO_RsaPublicKey *p1,
2690 * Blinds the given message with the given blinding key 2690 * Blinds the given message with the given blinding key
2691 * 2691 *
2692 * @param hash hash of the message to sign 2692 * @param hash hash of the message to sign
2693 * @param bkey the blinding key 2693 * @param bks the blinding key
2694 * @param pkey the public key of the signer 2694 * @param pkey the public key of the signer
2695 * @param[out] buf set to a buffer with the blinded message to be signed 2695 * @param[out] buf set to a buffer with the blinded message to be signed
2696 * @param[out] buf_size number of bytes stored in @a buf 2696 * @param[out] buf_size number of bytes stored in @a buf
diff --git a/src/include/gnunet_curl_lib.h b/src/include/gnunet_curl_lib.h
index b5d62ba0f..92334887d 100644
--- a/src/include/gnunet_curl_lib.h
+++ b/src/include/gnunet_curl_lib.h
@@ -18,6 +18,9 @@
18 SPDX-License-Identifier: AGPL3.0-or-later 18 SPDX-License-Identifier: AGPL3.0-or-later
19 */ 19 */
20/** 20/**
21 * @addtogroup lib_extra Additional libraries
22 * @{
23 *
21 * @file src/include/gnunet_curl_lib.h 24 * @file src/include/gnunet_curl_lib.h
22 * @brief library to make it easy to download JSON replies over HTTP 25 * @brief library to make it easy to download JSON replies over HTTP
23 * @author Sree Harsha Totakura <sreeharsha@totakura.in> 26 * @author Sree Harsha Totakura <sreeharsha@totakura.in>
@@ -224,7 +227,7 @@ typedef void
224 * be executed AND cleaned up 227 * be executed AND cleaned up
225 * @param jcc callback to invoke upon completion 228 * @param jcc callback to invoke upon completion
226 * @param jcc_cls closure for @a jcc 229 * @param jcc_cls closure for @a jcc
227 * @return NULL on error (in this case, @eh is still released!) 230 * @return NULL on error (in this case, @a eh is still released!)
228 */ 231 */
229struct GNUNET_CURL_Job * 232struct GNUNET_CURL_Job *
230GNUNET_CURL_job_add (struct GNUNET_CURL_Context *ctx, 233GNUNET_CURL_job_add (struct GNUNET_CURL_Context *ctx,
@@ -246,7 +249,7 @@ GNUNET_CURL_job_add (struct GNUNET_CURL_Context *ctx,
246 * be executed AND cleaned up 249 * be executed AND cleaned up
247 * @param jcc callback to invoke upon completion 250 * @param jcc callback to invoke upon completion
248 * @param jcc_cls closure for @a jcc 251 * @param jcc_cls closure for @a jcc
249 * @return NULL on error (in this case, @eh is still released!) 252 * @return NULL on error (in this case, @a eh is still released!)
250 */ 253 */
251struct GNUNET_CURL_Job * 254struct GNUNET_CURL_Job *
252GNUNET_CURL_job_add_with_ct_json (struct GNUNET_CURL_Context *ctx, 255GNUNET_CURL_job_add_with_ct_json (struct GNUNET_CURL_Context *ctx,
@@ -304,7 +307,7 @@ GNUNET_CURL_set_tlscert (struct GNUNET_CURL_Context *ctx,
304 * @param job_headers extra headers to add for this request 307 * @param job_headers extra headers to add for this request
305 * @param jcc callback to invoke upon completion 308 * @param jcc callback to invoke upon completion
306 * @param jcc_cls closure for @a jcc 309 * @param jcc_cls closure for @a jcc
307 * @return NULL on error (in this case, @eh is still released!) 310 * @return NULL on error (in this case, @a eh is still released!)
308 */ 311 */
309struct GNUNET_CURL_Job * 312struct GNUNET_CURL_Job *
310GNUNET_CURL_job_add2 (struct GNUNET_CURL_Context *ctx, 313GNUNET_CURL_job_add2 (struct GNUNET_CURL_Context *ctx,
@@ -324,10 +327,9 @@ GNUNET_CURL_job_add2 (struct GNUNET_CURL_Context *ctx,
324 * @param eh curl easy handle for the request, will 327 * @param eh curl easy handle for the request, will
325 * be executed AND cleaned up 328 * be executed AND cleaned up
326 * @param job_headers extra headers to add for this request 329 * @param job_headers extra headers to add for this request
327 * @param max_reply_size largest acceptable response body
328 * @param jcc callback to invoke upon completion 330 * @param jcc callback to invoke upon completion
329 * @param jcc_cls closure for @a jcc 331 * @param jcc_cls closure for @a jcc
330 * @return NULL on error (in this case, @eh is still released!) 332 * @return NULL on error (in this case, @a eh is still released!)
331 */ 333 */
332struct GNUNET_CURL_Job * 334struct GNUNET_CURL_Job *
333GNUNET_CURL_job_add_raw (struct GNUNET_CURL_Context *ctx, 335GNUNET_CURL_job_add_raw (struct GNUNET_CURL_Context *ctx,
@@ -437,4 +439,6 @@ GNUNET_CURL_is_valid_scope_id (const char *scope_id);
437#endif 439#endif
438/** @} */ /* end of group */ 440/** @} */ /* end of group */
439 441
442/** @} */ /* end of group addition to lib_extra */
443
440/* end of gnunet_curl_lib.h */ 444/* end of gnunet_curl_lib.h */
diff --git a/src/include/gnunet_dhtu_plugin.h b/src/include/gnunet_dhtu_plugin.h
index fa0b5f667..81b0f1d7b 100644
--- a/src/include/gnunet_dhtu_plugin.h
+++ b/src/include/gnunet_dhtu_plugin.h
@@ -119,7 +119,7 @@ struct GNUNET_DHTU_PluginEnvironment
119 * @param cls the closure 119 * @param cls the closure
120 * @param target handle to the target, 120 * @param target handle to the target,
121 * pointer will remain valid until @e disconnect_cb is called 121 * pointer will remain valid until @e disconnect_cb is called
122 * @para pid peer identity, 122 * @param pid peer identity,
123 * pointer will remain valid until @e disconnect_cb is called 123 * pointer will remain valid until @e disconnect_cb is called
124 * @param[out] ctx storage space for DHT to use in association with this target 124 * @param[out] ctx storage space for DHT to use in association with this target
125 */ 125 */
diff --git a/src/include/gnunet_disk_lib.h b/src/include/gnunet_disk_lib.h
index 71c1f88a5..c76cdc231 100644
--- a/src/include/gnunet_disk_lib.h
+++ b/src/include/gnunet_disk_lib.h
@@ -674,7 +674,7 @@ GNUNET_DISK_directory_scan (const char *dir_name,
674 * Currently, the glob_pattern only supports asterisks in the last 674 * Currently, the glob_pattern only supports asterisks in the last
675 * path component. 675 * path component.
676 * 676 *
677 * @param glob_patterb the glob pattern to search for 677 * @param glob_pattern the glob pattern to search for
678 * @param callback the method to call for each file 678 * @param callback the method to call for each file
679 * @param callback_cls closure for @a callback 679 * @param callback_cls closure for @a callback
680 * @return the number of files found, -1 on error 680 * @return the number of files found, -1 on error
diff --git a/src/include/gnunet_dnsstub_lib.h b/src/include/gnunet_dnsstub_lib.h
index 1310ce55a..4cc5e7fd0 100644
--- a/src/include/gnunet_dnsstub_lib.h
+++ b/src/include/gnunet_dnsstub_lib.h
@@ -89,7 +89,7 @@ GNUNET_DNSSTUB_add_dns_sa (struct GNUNET_DNSSTUB_Context *ctx,
89 * Only effective for requests issued after this call. 89 * Only effective for requests issued after this call.
90 * 90 *
91 * @param ctx resolver context to modify 91 * @param ctx resolver context to modify
92 * @param retry_frequ how long to wait between retries 92 * @param retry_freq how long to wait between retries
93 */ 93 */
94void 94void
95GNUNET_DNSSTUB_set_retry (struct GNUNET_DNSSTUB_Context *ctx, 95GNUNET_DNSSTUB_set_retry (struct GNUNET_DNSSTUB_Context *ctx,
diff --git a/src/include/gnunet_friends_lib.h b/src/include/gnunet_friends_lib.h
index d591ea082..03fa6c72d 100644
--- a/src/include/gnunet_friends_lib.h
+++ b/src/include/gnunet_friends_lib.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup Backbone
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -116,3 +119,5 @@ GNUNET_FRIENDS_write (struct GNUNET_FRIENDS_Writer *w,
116#endif 119#endif
117 120
118/** @} */ /* end of group */ 121/** @} */ /* end of group */
122
123/** @} */ /* end of group addition to backbone */
diff --git a/src/include/gnunet_fs_service.h b/src/include/gnunet_fs_service.h
index 6b664169a..8ae826380 100644
--- a/src/include/gnunet_fs_service.h
+++ b/src/include/gnunet_fs_service.h
@@ -111,7 +111,7 @@ typedef int
111 * into HashMaps. The key may change between FS implementations. 111 * into HashMaps. The key may change between FS implementations.
112 * 112 *
113 * @param uri uri to convert to a unique key 113 * @param uri uri to convert to a unique key
114 * @param key wherer to store the unique key 114 * @param key where to store the unique key
115 * @return #GNUNET_OK on success 115 * @return #GNUNET_OK on success
116 */ 116 */
117int 117int
@@ -464,7 +464,7 @@ GNUNET_FS_GETOPT_KEYWORDS (char shortName,
464 * @param name long name of the option 464 * @param name long name of the option
465 * @param argumentHelp help text for the option argument 465 * @param argumentHelp help text for the option argument
466 * @param description long help text for the option 466 * @param description long help text for the option
467 * @param[out] metadata set to the desired value 467 * @param[out] meta metadata set to the desired value
468 */ 468 */
469struct GNUNET_GETOPT_CommandLineOption 469struct GNUNET_GETOPT_CommandLineOption
470GNUNET_FS_GETOPT_METADATA (char shortName, 470GNUNET_FS_GETOPT_METADATA (char shortName,
diff --git a/src/include/gnunet_getopt_lib.h b/src/include/gnunet_getopt_lib.h
index c7c1d57a3..87ad591b7 100644
--- a/src/include/gnunet_getopt_lib.h
+++ b/src/include/gnunet_getopt_lib.h
@@ -404,7 +404,6 @@ GNUNET_GETOPT_option_timestamp (char shortName,
404 * 404 *
405 * @param shortName short name of the option 405 * @param shortName short name of the option
406 * @param name long name of the option 406 * @param name long name of the option
407 * @param argumentHelp help text for the option argument
408 * @param description long help text for the option 407 * @param description long help text for the option
409 * @param[out] val set to 1 if the option is present 408 * @param[out] val set to 1 if the option is present
410 */ 409 */
diff --git a/src/include/gnunet_gns_service.h b/src/include/gnunet_gns_service.h
index d367ac076..a32bb77ae 100644
--- a/src/include/gnunet_gns_service.h
+++ b/src/include/gnunet_gns_service.h
@@ -238,3 +238,5 @@ GNUNET_GNS_lookup_with_tld_cancel (struct GNUNET_GNS_LookupWithTldRequest *ltr);
238#endif 238#endif
239 239
240/** @} */ /* end of group */ 240/** @} */ /* end of group */
241
242/** @} */ /* end of group addition */
diff --git a/src/include/gnunet_gnsrecord_lib.h b/src/include/gnunet_gnsrecord_lib.h
index 21fb610f3..357f87587 100644
--- a/src/include/gnunet_gnsrecord_lib.h
+++ b/src/include/gnunet_gnsrecord_lib.h
@@ -528,6 +528,7 @@ GNUNET_GNSRECORD_query_from_private_key (
528 528
529/** 529/**
530 * Calculate the DHT query for a given @a label in a given @a zone. 530 * Calculate the DHT query for a given @a label in a given @a zone.
531 * FIXME: We may want to plugin-ize this at some point.
531 * 532 *
532 * @param pub public key of the zone 533 * @param pub public key of the zone
533 * @param label label of the record 534 * @param label label of the record
@@ -752,7 +753,7 @@ GNUNET_GNSRECORD_is_critical (uint32_t type);
752 * @param rd input records 753 * @param rd input records
753 * @param rd_count size of the @a rd and @a rd_public arrays 754 * @param rd_count size of the @a rd and @a rd_public arrays
754 * @param rd_public where to write the converted records 755 * @param rd_public where to write the converted records
755 * @param rd_public_count number of records written to @a rd_public 756 * @param rd_count_public number of records written to @a rd_public
756 * @param min_expiry the minimum expiration of this set 757 * @param min_expiry the minimum expiration of this set
757 * @param filter the record set filter, see GNUNET_GNSRECORD_Filter. 758 * @param filter the record set filter, see GNUNET_GNSRECORD_Filter.
758 * @param emsg the error message if something went wrong 759 * @param emsg the error message if something went wrong
@@ -768,7 +769,6 @@ GNUNET_GNSRECORD_normalize_record_set (const char *label,
768 enum GNUNET_GNSRECORD_Filter filter, 769 enum GNUNET_GNSRECORD_Filter filter,
769 char **emsg); 770 char **emsg);
770 771
771
772/** 772/**
773 * Check label for invalid characters. 773 * Check label for invalid characters.
774 * 774 *
diff --git a/src/include/gnunet_hello_lib.h b/src/include/gnunet_hello_lib.h
index b12108a33..86bf35110 100644
--- a/src/include/gnunet_hello_lib.h
+++ b/src/include/gnunet_hello_lib.h
@@ -485,8 +485,8 @@ GNUNET_HELLO_parse_uri (const char *uri,
485 * @param nt network type of @a address 485 * @param nt network type of @a address
486 * @param mono_time when was @a address valid 486 * @param mono_time when was @a address valid
487 * @param private_key signing key to use 487 * @param private_key signing key to use
488 * @param result[out] where to write address record (allocated) 488 * @param[out] result where to write address record (allocated)
489 * @param result_size[out] set to size of @a result 489 * @param[out] result_size set to size of @a result
490 */ 490 */
491void 491void
492GNUNET_HELLO_sign_address ( 492GNUNET_HELLO_sign_address (
@@ -504,8 +504,8 @@ GNUNET_HELLO_sign_address (
504 * @param raw raw signed address 504 * @param raw raw signed address
505 * @param raw_size size of @a raw 505 * @param raw_size size of @a raw
506 * @param pid public key to use for signature verification 506 * @param pid public key to use for signature verification
507 * @param nt[out] set to network type 507 * @param[out] nt set to network type
508 * @param mono_time[out] when was the address generated 508 * @param[out] mono_time when was the address generated
509 * @return NULL on error, otherwise the address 509 * @return NULL on error, otherwise the address
510 */ 510 */
511char * 511char *
diff --git a/src/include/gnunet_json_lib.h b/src/include/gnunet_json_lib.h
index af63c5e42..8809afb71 100644
--- a/src/include/gnunet_json_lib.h
+++ b/src/include/gnunet_json_lib.h
@@ -129,7 +129,7 @@ struct GNUNET_JSON_Specification
129 * @param root the JSON node to start the navigation at. 129 * @param root the JSON node to start the navigation at.
130 * @param spec parse specification array 130 * @param spec parse specification array
131 * @param[out] error_json_name which JSON field was problematic 131 * @param[out] error_json_name which JSON field was problematic
132 * @param[out] which index into @a spec did we encounter an error 132 * @param[out] error_line which index into @a spec did we encounter an error
133 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error 133 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error
134 */ 134 */
135enum GNUNET_GenericReturnValue 135enum GNUNET_GenericReturnValue
@@ -338,7 +338,7 @@ GNUNET_JSON_spec_boolean (const char *name,
338 * Timestamp. 338 * Timestamp.
339 * 339 *
340 * @param name name of the JSON field 340 * @param name name of the JSON field
341 * @param[out] at where to store the absolute time found under @a name 341 * @param[out] t at where to store the absolute time found under @a name
342 */ 342 */
343struct GNUNET_JSON_Specification 343struct GNUNET_JSON_Specification
344GNUNET_JSON_spec_timestamp (const char *name, 344GNUNET_JSON_spec_timestamp (const char *name,
diff --git a/src/include/gnunet_load_lib.h b/src/include/gnunet_load_lib.h
index ef596807a..397d3aa2d 100644
--- a/src/include/gnunet_load_lib.h
+++ b/src/include/gnunet_load_lib.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup libgnunetutil
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -124,4 +127,6 @@ GNUNET_LOAD_update (struct GNUNET_LOAD_Value *load, uint64_t data);
124 127
125/** @} */ /* end of group */ 128/** @} */ /* end of group */
126 129
130/** @} */ /* end of group addition to libgnunetutil */
131
127/* end of gnunet_load_lib.h */ 132/* end of gnunet_load_lib.h */
diff --git a/src/include/gnunet_messenger_service.h b/src/include/gnunet_messenger_service.h
index f8bbc7398..12f021d35 100644
--- a/src/include/gnunet_messenger_service.h
+++ b/src/include/gnunet_messenger_service.h
@@ -613,9 +613,9 @@ typedef int
613 * @param[in] cfg Configuration to use 613 * @param[in] cfg Configuration to use
614 * @param[in] name Name to look up an ego or NULL to stay anonymous 614 * @param[in] name Name to look up an ego or NULL to stay anonymous
615 * @param[in] identity_callback Function called when the EGO of the handle changes 615 * @param[in] identity_callback Function called when the EGO of the handle changes
616 * @param[in/out] identity_cls Closure for the <i>identity_callback</i> handler 616 * @param[in,out] identity_cls Closure for the <i>identity_callback</i> handler
617 * @param[in] msg_callback Function called when a new message is sent or received 617 * @param[in] msg_callback Function called when a new message is sent or received
618 * @param[in/out] msg_cls Closure for the <i>msg_callback</i> handler 618 * @param[in,out] msg_cls Closure for the <i>msg_callback</i> handler
619 * @return Messenger handle to use, NULL on error 619 * @return Messenger handle to use, NULL on error
620 */ 620 */
621struct GNUNET_MESSENGER_Handle* 621struct GNUNET_MESSENGER_Handle*
@@ -634,7 +634,7 @@ GNUNET_MESSENGER_connect (const struct GNUNET_CONFIGURATION_Handle *cfg,
634 * Keep in mind that this will fully delete the old ego key (if any is used) even if any other service wants to use it 634 * Keep in mind that this will fully delete the old ego key (if any is used) even if any other service wants to use it
635 * as default. 635 * as default.
636 * 636 *
637 * @param[in/out] handle Messenger handle to use 637 * @param[in,out] handle Messenger handle to use
638 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure 638 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure
639 */ 639 */
640int 640int
@@ -643,7 +643,7 @@ GNUNET_MESSENGER_update (struct GNUNET_MESSENGER_Handle *handle);
643/** 643/**
644 * Disconnect all of the messengers used services and clears up its used memory. 644 * Disconnect all of the messengers used services and clears up its used memory.
645 * 645 *
646 * @param[in/out] handle Messenger handle to use 646 * @param[in,out] handle Messenger handle to use
647 */ 647 */
648void 648void
649GNUNET_MESSENGER_disconnect (struct GNUNET_MESSENGER_Handle *handle); 649GNUNET_MESSENGER_disconnect (struct GNUNET_MESSENGER_Handle *handle);
@@ -662,7 +662,7 @@ GNUNET_MESSENGER_get_name (const struct GNUNET_MESSENGER_Handle *handle);
662 * name to its new directory. If anything fails during this process the function returns #GNUNET_NO and the name for 662 * name to its new directory. If anything fails during this process the function returns #GNUNET_NO and the name for
663 * the messenger won't change as specified. 663 * the messenger won't change as specified.
664 * 664 *
665 * @param[in/out] handle Messenger handle to use 665 * @param[in,out] handle Messenger handle to use
666 * @param[in] name Name for the messenger to change to 666 * @param[in] name Name for the messenger to change to
667 * @return #GNUNET_YES on success, #GNUNET_NO on failure and #GNUNET_SYSERR if <i>handle</i> is NULL 667 * @return #GNUNET_YES on success, #GNUNET_NO on failure and #GNUNET_SYSERR if <i>handle</i> is NULL
668 */ 668 */
@@ -691,7 +691,7 @@ GNUNET_MESSENGER_get_key (const struct GNUNET_MESSENGER_Handle *handle);
691 * 691 *
692 * ( All <b>doors</b> form a ring structured network to shorten the latency sending and receiving messages. ) 692 * ( All <b>doors</b> form a ring structured network to shorten the latency sending and receiving messages. )
693 * 693 *
694 * @param[in/out] handle Messenger handle to use 694 * @param[in,out] handle Messenger handle to use
695 * @param[in] key Hash identifying the port 695 * @param[in] key Hash identifying the port
696 * @return Room handle, NULL on error 696 * @return Room handle, NULL on error
697 */ 697 */
@@ -712,7 +712,7 @@ GNUNET_MESSENGER_open_room (struct GNUNET_MESSENGER_Handle *handle,
712 * 712 *
713 * ( All <b>doors</b> form a ring structured network to shorten the latency sending and receiving messages. ) 713 * ( All <b>doors</b> form a ring structured network to shorten the latency sending and receiving messages. )
714 * 714 *
715 * @param[in/out] handle Messenger handle to use 715 * @param[in,out] handle Messenger handle to use
716 * @param[in] door Peer identity of an open <b>door</b> 716 * @param[in] door Peer identity of an open <b>door</b>
717 * @param[in] key Hash identifying the port 717 * @param[in] key Hash identifying the port
718 * @return Room handle, NULL on error 718 * @return Room handle, NULL on error
@@ -729,7 +729,7 @@ GNUNET_MESSENGER_enter_room (struct GNUNET_MESSENGER_Handle *handle,
729 * ( After a member closes a <b>door</b>, all members entered through that specific <b>door</b> have to use another one 729 * ( After a member closes a <b>door</b>, all members entered through that specific <b>door</b> have to use another one
730 * or open the room on their own. ) 730 * or open the room on their own. )
731 * 731 *
732 * @param[in/out] room Room handle 732 * @param[in,out] room Room handle
733 */ 733 */
734void 734void
735GNUNET_MESSENGER_close_room (struct GNUNET_MESSENGER_Room *room); 735GNUNET_MESSENGER_close_room (struct GNUNET_MESSENGER_Room *room);
@@ -792,7 +792,7 @@ const struct GNUNET_IDENTITY_PublicKey*
792GNUNET_MESSENGER_contact_get_key (const struct GNUNET_MESSENGER_Contact *contact); 792GNUNET_MESSENGER_contact_get_key (const struct GNUNET_MESSENGER_Contact *contact);
793 793
794/** 794/**
795 * Send a <i>message</i> into a </i>room</i>. If you opened the <i>room</i> all entered members will receive the 795 * Send a <i>message</i> into a <i>room</i>. If you opened the <i>room</i> all entered members will receive the
796 * <i>message</i>. If you entered the <i>room</i> through a <b>door</b> all so entered <b>doors</b> will receive the 796 * <i>message</i>. If you entered the <i>room</i> through a <b>door</b> all so entered <b>doors</b> will receive the
797 * <i>message</i> as well. All members receiving the <i>message</i> will also propagate this <i>message</i> recursively 797 * <i>message</i> as well. All members receiving the <i>message</i> will also propagate this <i>message</i> recursively
798 * as long as the <i>message</i> is unknown to them. 798 * as long as the <i>message</i> is unknown to them.
@@ -805,7 +805,7 @@ GNUNET_MESSENGER_contact_get_key (const struct GNUNET_MESSENGER_Contact *contact
805 * 805 *
806 * Sending a message to all members in a given room can be done by providing NULL as contact. 806 * Sending a message to all members in a given room can be done by providing NULL as contact.
807 * 807 *
808 * @param[in/out] room Room handle 808 * @param[in,out] room Room handle
809 * @param[in] message New message to send 809 * @param[in] message New message to send
810 * @param[in] contact Contact or NULL 810 * @param[in] contact Contact or NULL
811 */ 811 */
diff --git a/src/include/gnunet_mq_lib.h b/src/include/gnunet_mq_lib.h
index bf2902707..a06fb4eb7 100644
--- a/src/include/gnunet_mq_lib.h
+++ b/src/include/gnunet_mq_lib.h
@@ -390,9 +390,9 @@ typedef void
390 * FIFO of envelopes independent of MQ itself and wants to 390 * FIFO of envelopes independent of MQ itself and wants to
391 * re-use the pointers internal to @a env. Use with caution. 391 * re-use the pointers internal to @a env. Use with caution.
392 * 392 *
393 * @param[in|out] env_head of envelope DLL 393 * @param[in,out] env_head of envelope DLL
394 * @param[in|out] env_tail tail of envelope DLL 394 * @param[in,out] env_tail tail of envelope DLL
395 * @param[in|out] env element to insert at the tail 395 * @param[in,out] env element to insert at the tail
396 */ 396 */
397void 397void
398GNUNET_MQ_dll_insert_head (struct GNUNET_MQ_Envelope **env_head, 398GNUNET_MQ_dll_insert_head (struct GNUNET_MQ_Envelope **env_head,
@@ -408,9 +408,9 @@ GNUNET_MQ_dll_insert_head (struct GNUNET_MQ_Envelope **env_head,
408 * FIFO of envelopes independent of MQ itself and wants to 408 * FIFO of envelopes independent of MQ itself and wants to
409 * re-use the pointers internal to @a env. Use with caution. 409 * re-use the pointers internal to @a env. Use with caution.
410 * 410 *
411 * @param[in|out] env_head of envelope DLL 411 * @param[in,out] env_head of envelope DLL
412 * @param[in|out] env_tail tail of envelope DLL 412 * @param[in,out] env_tail tail of envelope DLL
413 * @param[in|out] env element to insert at the tail 413 * @param[in,out] env element to insert at the tail
414 */ 414 */
415void 415void
416GNUNET_MQ_dll_insert_tail (struct GNUNET_MQ_Envelope **env_head, 416GNUNET_MQ_dll_insert_tail (struct GNUNET_MQ_Envelope **env_head,
@@ -426,9 +426,9 @@ GNUNET_MQ_dll_insert_tail (struct GNUNET_MQ_Envelope **env_head,
426 * FIFO of envelopes independent of MQ itself and wants to 426 * FIFO of envelopes independent of MQ itself and wants to
427 * re-use the pointers internal to @a env. Use with caution. 427 * re-use the pointers internal to @a env. Use with caution.
428 * 428 *
429 * @param[in|out] env_head of envelope DLL 429 * @param[in,out] env_head of envelope DLL
430 * @param[in|out] env_tail tail of envelope DLL 430 * @param[in,out] env_tail tail of envelope DLL
431 * @param[in|out] env element to remove from the DLL 431 * @param[in,out] env element to remove from the DLL
432 */ 432 */
433void 433void
434GNUNET_MQ_dll_remove (struct GNUNET_MQ_Envelope **env_head, 434GNUNET_MQ_dll_remove (struct GNUNET_MQ_Envelope **env_head,
@@ -601,6 +601,7 @@ struct GNUNET_MQ_MessageHandler
601 * "context"), 601 * "context"),
602 * GNUNET_MQ_handler_end() 602 * GNUNET_MQ_handler_end()
603 * }; 603 * };
604 * </code>
604 * 605 *
605 * @param name unique basename for the functions 606 * @param name unique basename for the functions
606 * @param code message type constant 607 * @param code message type constant
diff --git a/src/include/gnunet_mst_lib.h b/src/include/gnunet_mst_lib.h
index 36b1fd8d5..43a8ab838 100644
--- a/src/include/gnunet_mst_lib.h
+++ b/src/include/gnunet_mst_lib.h
@@ -168,6 +168,8 @@ GNUNET_MST_destroy (struct GNUNET_MessageStreamTokenizer *mst);
168 168
169/** @} */ /* end of group server */ 169/** @} */ /* end of group server */
170 170
171/** @} */ /* end of group addition */ 171/** @} */ /* end of group addition to networking */
172
173/** @} */ /* end of group addition to libgnunetutil*/
172 174
173/* end of gnunet_mst_lib.h */ 175/* end of gnunet_mst_lib.h */
diff --git a/src/include/gnunet_my_lib.h b/src/include/gnunet_my_lib.h
index 0c95d50d0..96d8cab42 100644
--- a/src/include/gnunet_my_lib.h
+++ b/src/include/gnunet_my_lib.h
@@ -18,6 +18,9 @@
18 SPDX-License-Identifier: AGPL3.0-or-later 18 SPDX-License-Identifier: AGPL3.0-or-later
19 */ 19 */
20/** 20/**
21 * @addtogroup lib_extra
22 * @{
23 *
21 * @author Christian Grothoff 24 * @author Christian Grothoff
22 * @author Christophe Genevey 25 * @author Christophe Genevey
23 * 26 *
@@ -126,7 +129,7 @@ struct GNUNET_MY_QueryParam
126 * @a ptr_size bytes.FG 129 * @a ptr_size bytes.FG
127 * 130 *
128 * @param ptr pointer to the query parameter to pass 131 * @param ptr pointer to the query parameter to pass
129 * @oaran ptr_size number of bytes in @a ptr 132 * @param ptr_size number of bytes in @a ptr
130 */ 133 */
131struct GNUNET_MY_QueryParam 134struct GNUNET_MY_QueryParam
132GNUNET_MY_query_param_fixed_size (const void *ptr, 135GNUNET_MY_query_param_fixed_size (const void *ptr,
@@ -262,7 +265,7 @@ struct GNUNET_MY_ResultSpec
262 * MySQL, store in already allocated buffer at @a ptr. 265 * MySQL, store in already allocated buffer at @a ptr.
263 * 266 *
264 * @spec ptr where to write the result 267 * @spec ptr where to write the result
265 * @oaran ptr_size number of bytes available at @a ptr 268 * @param ptr_size number of bytes available at @a ptr
266 */ 269 */
267struct GNUNET_MY_ResultSpec 270struct GNUNET_MY_ResultSpec
268GNUNET_MY_result_spec_fixed_size (void *ptr, 271GNUNET_MY_result_spec_fixed_size (void *ptr,
@@ -271,7 +274,7 @@ GNUNET_MY_result_spec_fixed_size (void *ptr,
271/** 274/**
272 * Generate query parameter for a string 275 * Generate query parameter for a string
273 * 276 *
274 *@param ptr pointer to the string query parameter to pass 277 * @param ptr pointer to the string query parameter to pass
275 */ 278 */
276struct GNUNET_MY_QueryParam 279struct GNUNET_MY_QueryParam
277GNUNET_MY_query_param_string (const char *ptr); 280GNUNET_MY_query_param_string (const char *ptr);
@@ -339,7 +342,7 @@ GNUNET_MY_query_param_uint16 (const uint16_t *x);
339/** 342/**
340 * Generate query parameter for an uint32_t in host byte order 343 * Generate query parameter for an uint32_t in host byte order
341 * 344 *
342 *@param x pointer to the query parameter to pass 345 * @param x pointer to the query parameter to pass
343 */ 346 */
344struct GNUNET_MY_QueryParam 347struct GNUNET_MY_QueryParam
345GNUNET_MY_query_param_uint32 (const uint32_t *x); 348GNUNET_MY_query_param_uint32 (const uint32_t *x);
@@ -347,7 +350,7 @@ GNUNET_MY_query_param_uint32 (const uint32_t *x);
347/** 350/**
348 * Generate query parameter for an uint64_t in host byte order 351 * Generate query parameter for an uint64_t in host byte order
349 * 352 *
350 *@param x pointer to the query parameter to pass 353 * @param x pointer to the query parameter to pass
351 */ 354 */
352struct GNUNET_MY_QueryParam 355struct GNUNET_MY_QueryParam
353GNUNET_MY_query_param_uint64 (const uint64_t *x); 356GNUNET_MY_query_param_uint64 (const uint64_t *x);
@@ -367,8 +370,8 @@ GNUNET_MY_query_param_uint64 (const uint64_t *x);
367 * Variable-size result expected 370 * Variable-size result expected
368 * 371 *
369 * @param[out] dst where to store the result, allocated 372 * @param[out] dst where to store the result, allocated
370 * @param[out] sptr where to store the size of @a dst 373 * @param[out] ptr_size where to store the size of @a dst
371 * @return array entru for the result specification to use 374 * @return array entry for the result specification to use
372 */ 375 */
373struct GNUNET_MY_ResultSpec 376struct GNUNET_MY_ResultSpec
374GNUNET_MY_result_spec_variable_size (void **dst, 377GNUNET_MY_result_spec_variable_size (void **dst,
@@ -498,3 +501,5 @@ GNUNET_MY_cleanup_result (struct GNUNET_MY_ResultSpec *rs);
498#endif 501#endif
499 502
500/** @} */ /* end of group */ 503/** @} */ /* end of group */
504
505/** @} */ /* end of group addition to lib_extra */
diff --git a/src/include/gnunet_nat_auto_service.h b/src/include/gnunet_nat_auto_service.h
index 78284dc01..db3a8460d 100644
--- a/src/include/gnunet_nat_auto_service.h
+++ b/src/include/gnunet_nat_auto_service.h
@@ -26,7 +26,7 @@
26 * Service for testing and autoconfiguration of 26 * Service for testing and autoconfiguration of
27 * NAT traversal functionality 27 * NAT traversal functionality
28 * 28 *
29 * @defgroup nat NAT testing library 29 * @defgroup nat NAT library
30 * 30 *
31 * @{ 31 * @{
32 */ 32 */
diff --git a/src/include/gnunet_nc_lib.h b/src/include/gnunet_nc_lib.h
index 7eef49900..dbd2aa12f 100644
--- a/src/include/gnunet_nc_lib.h
+++ b/src/include/gnunet_nc_lib.h
@@ -104,4 +104,6 @@ GNUNET_notification_context_get_size (struct GNUNET_NotificationContext *nc);
104 104
105#endif 105#endif
106 106
107/** @} */ /* end of group mq */
108
107/** @} */ /* end of group addition */ 109/** @} */ /* end of group addition */
diff --git a/src/include/gnunet_nt_lib.h b/src/include/gnunet_nt_lib.h
index 5c3ec86af..144a3daa3 100644
--- a/src/include/gnunet_nt_lib.h
+++ b/src/include/gnunet_nt_lib.h
@@ -18,6 +18,9 @@
18 SPDX-License-Identifier: AGPL3.0-or-later 18 SPDX-License-Identifier: AGPL3.0-or-later
19 */ 19 */
20/** 20/**
21 * @addtogroup Backbone
22 * @{
23 *
21 * @file network type characterization 24 * @file network type characterization
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * @author Matthias Wachs 26 * @author Matthias Wachs
@@ -122,3 +125,5 @@ GNUNET_NT_scanner_done (struct GNUNET_NT_InterfaceScanner *is);
122#endif 125#endif
123 126
124/** @} */ /* end of group */ 127/** @} */ /* end of group */
128
129/** @} */ /* end of group addition to backbone */
diff --git a/src/include/gnunet_peerinfo_service.h b/src/include/gnunet_peerinfo_service.h
index 739e7ed24..3be4a6977 100644
--- a/src/include/gnunet_peerinfo_service.h
+++ b/src/include/gnunet_peerinfo_service.h
@@ -142,7 +142,6 @@ struct GNUNET_PEERINFO_IteratorContext;
142 * @param h handle to the peerinfo service 142 * @param h handle to the peerinfo service
143 * @param include_friend_only include HELLO messages for friends only 143 * @param include_friend_only include HELLO messages for friends only
144 * @param peer restrict iteration to this peer only (can be NULL) 144 * @param peer restrict iteration to this peer only (can be NULL)
145 * @param timeout how long to wait until timing out
146 * @param callback the method to call for each peer 145 * @param callback the method to call for each peer
147 * @param callback_cls closure for @a callback 146 * @param callback_cls closure for @a callback
148 * @return iterator context 147 * @return iterator context
diff --git a/src/include/gnunet_peerstore_service.h b/src/include/gnunet_peerstore_service.h
index deea3ae96..f9b283a9f 100644
--- a/src/include/gnunet_peerstore_service.h
+++ b/src/include/gnunet_peerstore_service.h
@@ -249,6 +249,7 @@ GNUNET_PEERSTORE_store_cancel (struct GNUNET_PEERSTORE_StoreContext *sc);
249 * @param key entry key string (can be NULL) 249 * @param key entry key string (can be NULL)
250 * @param callback function called with each matching record, all NULL's on end 250 * @param callback function called with each matching record, all NULL's on end
251 * @param callback_cls closure for @a callback 251 * @param callback_cls closure for @a callback
252 * @return Handle to iteration request
252 */ 253 */
253struct GNUNET_PEERSTORE_IterateContext * 254struct GNUNET_PEERSTORE_IterateContext *
254GNUNET_PEERSTORE_iterate (struct GNUNET_PEERSTORE_Handle *h, 255GNUNET_PEERSTORE_iterate (struct GNUNET_PEERSTORE_Handle *h,
diff --git a/src/include/gnunet_pq_lib.h b/src/include/gnunet_pq_lib.h
index 7396c6861..d52c0e40d 100644
--- a/src/include/gnunet_pq_lib.h
+++ b/src/include/gnunet_pq_lib.h
@@ -118,7 +118,7 @@ GNUNET_PQ_query_param_null (void);
118 * @a ptr_size bytes. 118 * @a ptr_size bytes.
119 * 119 *
120 * @param ptr pointer to the query parameter to pass 120 * @param ptr pointer to the query parameter to pass
121 * @oaran ptr_size number of bytes in @a ptr 121 * @param ptr_size number of bytes in @a ptr
122 * @return query parameter to use 122 * @return query parameter to use
123 */ 123 */
124struct GNUNET_PQ_QueryParam 124struct GNUNET_PQ_QueryParam
@@ -235,7 +235,7 @@ GNUNET_PQ_query_param_absolute_time_nbo (
235 */ 235 */
236struct GNUNET_PQ_QueryParam 236struct GNUNET_PQ_QueryParam
237GNUNET_PQ_query_param_timestamp_nbo ( 237GNUNET_PQ_query_param_timestamp_nbo (
238 const struct GNUNET_TIME_TimestampNBO *t); 238 const struct GNUNET_TIME_TimestampNBO *x);
239 239
240 240
241/** 241/**
@@ -861,7 +861,7 @@ GNUNET_PQ_make_try_execute (const char *sql);
861/** 861/**
862 * Request execution of an array of statements @a es from Postgres. 862 * Request execution of an array of statements @a es from Postgres.
863 * 863 *
864 * @param pq database to execute the statements in 864 * @param db database to execute the statements in
865 * @param es #GNUNET_PQ_PREPARED_STATEMENT_END-terminated array of prepared 865 * @param es #GNUNET_PQ_PREPARED_STATEMENT_END-terminated array of prepared
866 * statements. 866 * statements.
867 * @return #GNUNET_OK on success (modulo statements where errors can be ignored) 867 * @return #GNUNET_OK on success (modulo statements where errors can be ignored)
@@ -903,14 +903,14 @@ enum GNUNET_PQ_Options
903 * configuration. Initialize logging via GNUnet's log routines and disable 903 * configuration. Initialize logging via GNUnet's log routines and disable
904 * Postgres's logger. Also ensures that the statements in @a load_path and @a 904 * Postgres's logger. Also ensures that the statements in @a load_path and @a
905 * es are executed whenever we (re)connect to the database, and that the 905 * es are executed whenever we (re)connect to the database, and that the
906 * prepared statements in @a ps are "ready". If statements in @es fail that 906 * prepared statements in @a ps are "ready". If statements in @a es fail that
907 * were created with #GNUNET_PQ_make_execute(), then the entire operation 907 * were created with #GNUNET_PQ_make_execute(), then the entire operation
908 * fails. 908 * fails.
909 * 909 *
910 * In @a load_path, a list of "$XXXX.sql" files is expected where $XXXX 910 * In @a load_path, a list of "$XXXX.sql" files is expected where $XXXX
911 * must be a sequence of contiguous integer values starting at 0000. 911 * must be a sequence of contiguous integer values starting at 0000.
912 * These files are then loaded in sequence using "psql $config_str" before 912 * These files are then loaded in sequence using "psql $config_str" before
913 * running statements from @e es. The directory is inspected again on 913 * running statements from @a es. The directory is inspected again on
914 * reconnect. 914 * reconnect.
915 * 915 *
916 * @param config_str configuration to use 916 * @param config_str configuration to use
@@ -947,7 +947,7 @@ GNUNET_PQ_exec_sql (struct GNUNET_PQ_Context *db,
947 * configuration. Initialize logging via GNUnet's log routines and disable 947 * configuration. Initialize logging via GNUnet's log routines and disable
948 * Postgres's logger. Also ensures that the statements in @a load_path and @a 948 * Postgres's logger. Also ensures that the statements in @a load_path and @a
949 * es are executed whenever we (re)connect to the database, and that the 949 * es are executed whenever we (re)connect to the database, and that the
950 * prepared statements in @a ps are "ready". If statements in @es fail that 950 * prepared statements in @a ps are "ready". If statements in @a es fail that
951 * were created with #GNUNET_PQ_make_execute(), then the entire operation 951 * were created with #GNUNET_PQ_make_execute(), then the entire operation
952 * fails. 952 * fails.
953 * 953 *
diff --git a/src/include/gnunet_reclaim_lib.h b/src/include/gnunet_reclaim_lib.h
index 0d5ef59b7..35b58cd0e 100644
--- a/src/include/gnunet_reclaim_lib.h
+++ b/src/include/gnunet_reclaim_lib.h
@@ -515,7 +515,7 @@ GNUNET_RECLAIM_attribute_number_to_typename (uint32_t type);
515/** 515/**
516 * Get required size for serialization buffer 516 * Get required size for serialization buffer
517 * 517 *
518 * @param attrs the attribute list to serialize 518 * @param credentials the attribute list to serialize
519 * @return the required buffer size 519 * @return the required buffer size
520 */ 520 */
521size_t 521size_t
@@ -524,9 +524,9 @@ GNUNET_RECLAIM_credential_list_serialize_get_size (
524 524
525 525
526/** 526/**
527 * Destroy claim list 527 * Destroy credential list
528 * 528 *
529 * @param attrs list to destroy 529 * @param credentials list to destroy
530 */ 530 */
531void 531void
532GNUNET_RECLAIM_credential_list_destroy ( 532GNUNET_RECLAIM_credential_list_destroy (
@@ -551,15 +551,15 @@ GNUNET_RECLAIM_credential_list_add (
551 551
552 552
553/** 553/**
554 * Serialize an attribute list 554 * Serialize a credential list
555 * 555 *
556 * @param attrs the attribute list to serialize 556 * @param credentials the credential list to serialize
557 * @param result the serialized attribute 557 * @param result the serialized credential
558 * @return length of serialized data 558 * @return length of serialized data
559 */ 559 */
560size_t 560size_t
561GNUNET_RECLAIM_credential_list_serialize ( 561GNUNET_RECLAIM_credential_list_serialize (
562 const struct GNUNET_RECLAIM_CredentialList *attrs, 562 const struct GNUNET_RECLAIM_CredentialList *credentials,
563 char *result); 563 char *result);
564 564
565 565
diff --git a/src/include/gnunet_reclaim_service.h b/src/include/gnunet_reclaim_service.h
index 9f348a1cb..e9e0f144d 100644
--- a/src/include/gnunet_reclaim_service.h
+++ b/src/include/gnunet_reclaim_service.h
@@ -200,7 +200,7 @@ GNUNET_RECLAIM_attribute_store (
200 * 200 *
201 * @param h handle to the re:claimID service 201 * @param h handle to the re:claimID service
202 * @param pkey private key of the identity 202 * @param pkey private key of the identity
203 * @param attr the credential value 203 * @param credential the credential value
204 * @param exp_interval the relative expiration interval for the credential 204 * @param exp_interval the relative expiration interval for the credential
205 * @param cont continuation to call when done 205 * @param cont continuation to call when done
206 * @param cont_cls closure for @a cont 206 * @param cont_cls closure for @a cont
@@ -235,7 +235,7 @@ GNUNET_RECLAIM_attribute_delete (
235 GNUNET_RECLAIM_ContinuationWithStatus cont, void *cont_cls); 235 GNUNET_RECLAIM_ContinuationWithStatus cont, void *cont_cls);
236 236
237/** 237/**
238 * Delete a credential. Tickets used to share use a presentation of this 238 * Delete a credential. Tickets used to share a presentation of this
239 * credential are updated accordingly. 239 * credential are updated accordingly.
240 * 240 *
241 * @param h handle to the re:claimID service 241 * @param h handle to the re:claimID service
@@ -349,7 +349,7 @@ GNUNET_RECLAIM_get_credentials_start (
349 * Calls the record processor specified in #GNUNET_RECLAIM_get_credentials_start 349 * Calls the record processor specified in #GNUNET_RECLAIM_get_credentials_start
350 * for the next record. 350 * for the next record.
351 * 351 *
352 * @param it the iterator 352 * @param ait the iterator
353 */ 353 */
354void 354void
355GNUNET_RECLAIM_get_credentials_next ( 355GNUNET_RECLAIM_get_credentials_next (
@@ -361,7 +361,7 @@ GNUNET_RECLAIM_get_credentials_next (
361 * be called on any iteration that has not yet completed prior to calling 361 * be called on any iteration that has not yet completed prior to calling
362 * #GNUNET_RECLAIM_disconnect. 362 * #GNUNET_RECLAIM_disconnect.
363 * 363 *
364 * @param it the iterator 364 * @param ait the iterator
365 */ 365 */
366void 366void
367GNUNET_RECLAIM_get_credentials_stop ( 367GNUNET_RECLAIM_get_credentials_stop (
diff --git a/src/include/gnunet_resolver_service.h b/src/include/gnunet_resolver_service.h
index 956e4d67e..80c92dc4e 100644
--- a/src/include/gnunet_resolver_service.h
+++ b/src/include/gnunet_resolver_service.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup vpn_suite
23 * @{
24 *
22 * @author Christian Grothoff 25 * @author Christian Grothoff
23 * 26 *
24 * @file 27 * @file
@@ -178,4 +181,6 @@ GNUNET_RESOLVER_request_cancel (struct GNUNET_RESOLVER_RequestHandle *rh);
178 181
179/** @} */ /* end of group resolver */ 182/** @} */ /* end of group resolver */
180 183
184/** @} */ /* end of group addition to vpn_suite */
185
181/* end of gnunet_resolver_service.h */ 186/* end of gnunet_resolver_service.h */
diff --git a/src/include/gnunet_scalarproduct_service.h b/src/include/gnunet_scalarproduct_service.h
index 1d775f659..7f60bb325 100644
--- a/src/include/gnunet_scalarproduct_service.h
+++ b/src/include/gnunet_scalarproduct_service.h
@@ -179,7 +179,7 @@ GNUNET_SCALARPRODUCT_start_computation (
179struct GNUNET_SCALARPRODUCT_ComputationHandle * 179struct GNUNET_SCALARPRODUCT_ComputationHandle *
180GNUNET_SCALARPRODUCT_accept_computation ( 180GNUNET_SCALARPRODUCT_accept_computation (
181 const struct GNUNET_CONFIGURATION_Handle *cfg, 181 const struct GNUNET_CONFIGURATION_Handle *cfg,
182 const struct GNUNET_HashCode *key, 182 const struct GNUNET_HashCode *session_key,
183 const struct GNUNET_SCALARPRODUCT_Element *elements, 183 const struct GNUNET_SCALARPRODUCT_Element *elements,
184 uint32_t element_count, 184 uint32_t element_count,
185 GNUNET_SCALARPRODUCT_ContinuationWithStatus cont, 185 GNUNET_SCALARPRODUCT_ContinuationWithStatus cont,
diff --git a/src/include/gnunet_service_lib.h b/src/include/gnunet_service_lib.h
index 5baa9100e..8c8591af0 100644
--- a/src/include/gnunet_service_lib.h
+++ b/src/include/gnunet_service_lib.h
@@ -282,8 +282,8 @@ GNUNET_SERVICE_run_ (int argc,
282 * #GNUNET_SERVICE_client_drop(). 282 * #GNUNET_SERVICE_client_drop().
283 * 283 *
284 * @param service_name name of the service to run 284 * @param service_name name of the service to run
285 * @param options options controlling shutdown of the service 285 * @param service_options options controlling shutdown of the service
286 * @param service_init_cb function to call once the service is ready 286 * @param init_cb function to call once the service is ready
287 * @param connect_cb function to call whenever a client connects 287 * @param connect_cb function to call whenever a client connects
288 * @param disconnect_cb function to call whenever a client disconnects 288 * @param disconnect_cb function to call whenever a client disconnects
289 * @param cls closure argument for @a service_init_cb, @a connect_cb and @a disconnect_cb 289 * @param cls closure argument for @a service_init_cb, @a connect_cb and @a disconnect_cb
@@ -449,6 +449,8 @@ GNUNET_SERVICE_client_persist (struct GNUNET_SERVICE_Client *c);
449 449
450/** @} */ /* end of group service */ 450/** @} */ /* end of group service */
451 451
452/** @} */ /* end of group addition */ 452/** @} */ /* end of group addition to networking*/
453
454/** @} */ /* end of group addition to libgnunetutil */
453 455
454/* end of gnunet_service_lib.h */ 456/* end of gnunet_service_lib.h */
diff --git a/src/include/gnunet_set_service.h b/src/include/gnunet_set_service.h
index 25e3e9630..255eef265 100644
--- a/src/include/gnunet_set_service.h
+++ b/src/include/gnunet_set_service.h
@@ -368,10 +368,10 @@ GNUNET_SET_add_element (struct GNUNET_SET_Handle *set,
368 368
369 369
370/** 370/**
371 * Remove an element to the given set. 371 * Remove an element to the given set.
372 * After the element has been removed (in the sense of the 372 * After the element has been removed (in the sense of the request
373 * request being transmitted to the set service), cont will be called. 373 * being transmitted to the set service), @a cont will be called.
374 * Calls to remove_element can be queued 374 * Multiple calls to GNUNET_SET_remove_element() can be queued
375 * 375 *
376 * @param set set to remove element from 376 * @param set set to remove element from
377 * @param element element to remove from the set 377 * @param element element to remove from the set
@@ -559,7 +559,7 @@ GNUNET_SET_element_dup (const struct GNUNET_SET_Element *element);
559 * Hash a set element. 559 * Hash a set element.
560 * 560 *
561 * @param element the element that should be hashed 561 * @param element the element that should be hashed
562 * @param ret_hash a pointer to where the hash of @a element 562 * @param[out] ret_hash a pointer to where the hash of @a element
563 * should be stored 563 * should be stored
564 */ 564 */
565void 565void
diff --git a/src/include/gnunet_setu_service.h b/src/include/gnunet_setu_service.h
index fb2614bc8..89ac3cd07 100644
--- a/src/include/gnunet_setu_service.h
+++ b/src/include/gnunet_setu_service.h
@@ -291,9 +291,9 @@ GNUNET_SETU_destroy (struct GNUNET_SETU_Handle *set);
291 291
292 292
293/** 293/**
294 * Prepare a set operation to be evaluated with another peer. The evaluation 294 * Prepare a set operation to be evaluated with another peer.
295 * will not start until the client provides a local set with 295 * The evaluation will not start until the client provides a
296 * GNUNET_SETU_commit(). 296 * local set with GNUNET_SETU_commit().
297 * 297 *
298 * @param other_peer peer with the other set 298 * @param other_peer peer with the other set
299 * @param app_id hash for the application using the set 299 * @param app_id hash for the application using the set
diff --git a/src/include/gnunet_socks.h b/src/include/gnunet_socks.h
index 1a6ae1119..b82943da3 100644
--- a/src/include/gnunet_socks.h
+++ b/src/include/gnunet_socks.h
@@ -19,6 +19,9 @@
19 */ 19 */
20 20
21/** 21/**
22 * @addtogroup libgnunetutil
23 * @{
24 *
22 * @author Jeffrey Burdges 25 * @author Jeffrey Burdges
23 * 26 *
24 * @file 27 * @file
@@ -81,4 +84,6 @@ GNUNET_SOCKS_do_connect (const char *service_name,
81 84
82/** @} */ /* end of group */ 85/** @} */ /* end of group */
83 86
87/** @} */ /* end of group addition to libgnunetutil */
88
84/* end of gnunet_socks.h */ 89/* end of gnunet_socks.h */
diff --git a/src/include/gnunet_sq_lib.h b/src/include/gnunet_sq_lib.h
index 51713e755..3406b9031 100644
--- a/src/include/gnunet_sq_lib.h
+++ b/src/include/gnunet_sq_lib.h
@@ -91,7 +91,7 @@ struct GNUNET_SQ_QueryParam
91 * @a ptr_size bytes. 91 * @a ptr_size bytes.
92 * 92 *
93 * @param ptr pointer to the query parameter to pass 93 * @param ptr pointer to the query parameter to pass
94 * @oaran ptr_size number of bytes in @a ptr 94 * @param ptr_size number of bytes in @a ptr
95 */ 95 */
96struct GNUNET_SQ_QueryParam 96struct GNUNET_SQ_QueryParam
97GNUNET_SQ_query_param_fixed_size (const void *ptr, 97GNUNET_SQ_query_param_fixed_size (const void *ptr,
diff --git a/src/include/gnunet_strings_lib.h b/src/include/gnunet_strings_lib.h
index e96888db5..7e06768b8 100644
--- a/src/include/gnunet_strings_lib.h
+++ b/src/include/gnunet_strings_lib.h
@@ -403,7 +403,7 @@ GNUNET_STRINGS_base64_encode (const void *in,
403 * 403 *
404 * @param data the data to decode 404 * @param data the data to decode
405 * @param len the length of the input 405 * @param len the length of the input
406 * @param output where to write the output (*output should be NULL, 406 * @param out where to write the output (*out should be NULL,
407 * is allocated) 407 * is allocated)
408 * @return the size of the output 408 * @return the size of the output
409 */ 409 */
@@ -448,7 +448,7 @@ GNUNET_STRINGS_base64_decode (const char *data,
448 * 448 *
449 * @param data the data to decode 449 * @param data the data to decode
450 * @param len the length of the input 450 * @param len the length of the input
451 * @param output where to write the output (*output should be NULL, 451 * @param out where to write the output (*out should be NULL,
452 * is allocated) 452 * is allocated)
453 * @return the size of the output 453 * @return the size of the output
454 */ 454 */
diff --git a/src/include/gnunet_testbed_service.h b/src/include/gnunet_testbed_service.h
index 29515b7af..ef67ab8ca 100644
--- a/src/include/gnunet_testbed_service.h
+++ b/src/include/gnunet_testbed_service.h
@@ -1030,8 +1030,8 @@ enum GNUNET_TESTBED_TopologyOption
1030 * Configure overall network topology to have a particular shape. 1030 * Configure overall network topology to have a particular shape.
1031 * 1031 *
1032 * @param op_cls closure argument to give with the operation event 1032 * @param op_cls closure argument to give with the operation event
1033 * @param num_peers number of peers in 'peers' 1033 * @param num_peers number of peers in @a peers
1034 * @param peers array of 'num_peers' with the peers to configure 1034 * @param peers array of @a num_peers with the peers to configure
1035 * @param topo desired underlay topology to use 1035 * @param topo desired underlay topology to use
1036 * @param ap topology-specific options 1036 * @param ap topology-specific options
1037 * @return handle to the operation, NULL if configuring the topology 1037 * @return handle to the operation, NULL if configuring the topology
@@ -1052,8 +1052,8 @@ GNUNET_TESTBED_underlay_configure_topology_va (void *op_cls,
1052 * Configure overall network topology to have a particular shape. 1052 * Configure overall network topology to have a particular shape.
1053 * 1053 *
1054 * @param op_cls closure argument to give with the operation event 1054 * @param op_cls closure argument to give with the operation event
1055 * @param num_peers number of peers in 'peers' 1055 * @param num_peers number of peers in @a peers
1056 * @param peers array of 'num_peers' with the peers to configure 1056 * @param peers array of @a num_peers with the peers to configure
1057 * @param topo desired underlay topology to use 1057 * @param topo desired underlay topology to use
1058 * @param ... topology-specific options 1058 * @param ... topology-specific options
1059 * @return handle to the operation, NULL if configuring the topology 1059 * @return handle to the operation, NULL if configuring the topology
diff --git a/src/include/gnunet_testing_lib.h b/src/include/gnunet_testing_lib.h
index 724382c66..2f64c306b 100644
--- a/src/include/gnunet_testing_lib.h
+++ b/src/include/gnunet_testing_lib.h
@@ -401,7 +401,7 @@ typedef void
401 * Starts a peer using the given configuration and then invokes the 401 * Starts a peer using the given configuration and then invokes the
402 * given callback. This function ALSO initializes the scheduler loop 402 * given callback. This function ALSO initializes the scheduler loop
403 * and should thus be called directly from "main". The testcase 403 * and should thus be called directly from "main". The testcase
404 * should self-terminate by invoking 'GNUNET_SCHEDULER_shutdown'. 404 * should self-terminate by invoking #GNUNET_SCHEDULER_shutdown().
405 * 405 *
406 * @param testdir only the directory name without any path. This is used for 406 * @param testdir only the directory name without any path. This is used for
407 * all service homes; the directory will be created in a temporary 407 * all service homes; the directory will be created in a temporary
@@ -409,7 +409,7 @@ typedef void
409 * @param cfgfilename name of the configuration file to use; 409 * @param cfgfilename name of the configuration file to use;
410 * use NULL to only run with defaults 410 * use NULL to only run with defaults
411 * @param tm main function of the testcase 411 * @param tm main function of the testcase
412 * @param tm_cls closure for 'tm' 412 * @param tm_cls closure for @a tm
413 * @return 0 on success, 1 on error 413 * @return 0 on success, 1 on error
414 */ 414 */
415int 415int
@@ -425,7 +425,7 @@ GNUNET_TESTING_peer_run (const char *testdir,
425 * Starts a service using the given configuration and then invokes the 425 * Starts a service using the given configuration and then invokes the
426 * given callback. This function ALSO initializes the scheduler loop 426 * given callback. This function ALSO initializes the scheduler loop
427 * and should thus be called directly from "main". The testcase 427 * and should thus be called directly from "main". The testcase
428 * should self-terminate by invoking 'GNUNET_SCHEDULER_shutdown'. 428 * should self-terminate by invoking #GNUNET_SCHEDULER_shutdown().
429 * 429 *
430 * This function is useful if the testcase is for a single service 430 * This function is useful if the testcase is for a single service
431 * and if that service doesn't itself depend on other services. 431 * and if that service doesn't itself depend on other services.
diff --git a/src/include/gnunet_testing_netjail_lib.h b/src/include/gnunet_testing_netjail_lib.h
index ea44e030d..f736e1b42 100644
--- a/src/include/gnunet_testing_netjail_lib.h
+++ b/src/include/gnunet_testing_netjail_lib.h
@@ -470,12 +470,11 @@ GNUNET_TESTING_cmd_stop_testing_system (
470 const char *helper_start_label, 470 const char *helper_start_label,
471 struct GNUNET_TESTING_NetjailTopology *topology); 471 struct GNUNET_TESTING_NetjailTopology *topology);
472 472
473
474/** 473/**
475 * Create a GNUNET_CMDS_LOCAL_FINISHED message. 474 * Create a GNUNET_CMDS_LOCAL_FINISHED message.
476 * 475 *
477 * @return The GNUNET_CMDS_LOCAL_FINISHED message. 476 * @return The GNUNET_CMDS_LOCAL_FINISHED message.
478*/ 477 */
479struct GNUNET_MessageHeader * 478struct GNUNET_MessageHeader *
480GNUNET_TESTING_send_local_test_finished_msg (); 479GNUNET_TESTING_send_local_test_finished_msg ();
481 480
@@ -546,7 +545,6 @@ GNUNET_TESTING_cmd_local_test_finished (
546 * 545 *
547 * @param label name for command. 546 * @param label name for command.
548 * @param write_message Callback to write messages to the master loop. 547 * @param write_message Callback to write messages to the master loop.
549 * @param all_local_tests_prepared Flag which will be set from outside.
550 * @return command. 548 * @return command.
551 */ 549 */
552struct GNUNET_TESTING_Command 550struct GNUNET_TESTING_Command
diff --git a/src/include/gnunet_testing_ng_lib.h b/src/include/gnunet_testing_ng_lib.h
index 1bc66e59d..d810a5342 100644
--- a/src/include/gnunet_testing_ng_lib.h
+++ b/src/include/gnunet_testing_ng_lib.h
@@ -415,7 +415,7 @@ GNUNET_TESTING_interpreter_get_current_command (
415/** 415/**
416 * Check if the command is running. 416 * Check if the command is running.
417 * 417 *
418 * @param cmd The command to check. 418 * @param command The command to check.
419 * @return GNUNET_NO if the command is not running, GNUNET_YES if it is running. 419 * @return GNUNET_NO if the command is not running, GNUNET_YES if it is running.
420 */ 420 */
421enum GNUNET_GenericReturnValue 421enum GNUNET_GenericReturnValue
@@ -425,7 +425,7 @@ GNUNET_TESTING_running (const struct GNUNET_TESTING_Command *command);
425/** 425/**
426 * Check if a command is finished. 426 * Check if a command is finished.
427 * 427 *
428 * @param cmd The command to check. 428 * @param command The command to check.
429 * @return GNUNET_NO if the command is not finished, GNUNET_YES if it is finished. 429 * @return GNUNET_NO if the command is not finished, GNUNET_YES if it is finished.
430 */ 430 */
431enum GNUNET_GenericReturnValue 431enum GNUNET_GenericReturnValue
diff --git a/src/include/gnunet_time_lib.h b/src/include/gnunet_time_lib.h
index d753d62f7..e66ce6ea9 100644
--- a/src/include/gnunet_time_lib.h
+++ b/src/include/gnunet_time_lib.h
@@ -242,7 +242,7 @@ GNUNET_TIME_timestamp2s (struct GNUNET_TIME_Timestamp ts);
242 * Note that the returned value will be overwritten if this function 242 * Note that the returned value will be overwritten if this function
243 * is called again. 243 * is called again.
244 * 244 *
245 * @param t the absolute time to convert 245 * @param ts the absolute time to convert
246 * @return timestamp in human-readable form in local time 246 * @return timestamp in human-readable form in local time
247 */ 247 */
248const char * 248const char *
diff --git a/src/include/gnunet_transport_application_service.h b/src/include/gnunet_transport_application_service.h
index 5767082d9..9a6ddd36a 100644
--- a/src/include/gnunet_transport_application_service.h
+++ b/src/include/gnunet_transport_application_service.h
@@ -27,9 +27,7 @@
27 * @author Christian Grothoff 27 * @author Christian Grothoff
28 * @author Matthias Wachs 28 * @author Matthias Wachs
29 * 29 *
30 * @defgroup TRANSPORT service 30 * @defgroup transport Transport service
31 * Bandwidth allocation
32 *
33 * @{ 31 * @{
34 */ 32 */
35#ifndef GNUNET_TRANSPORT_APPLICATION_SERVICE_H 33#ifndef GNUNET_TRANSPORT_APPLICATION_SERVICE_H
diff --git a/src/include/gnunet_transport_communication_service.h b/src/include/gnunet_transport_communication_service.h
index 9b536297e..6c99de78e 100644
--- a/src/include/gnunet_transport_communication_service.h
+++ b/src/include/gnunet_transport_communication_service.h
@@ -138,7 +138,8 @@ typedef void (*GNUNET_TRANSPORT_CommunicatorNotify) (
138 * Connect to the transport service. 138 * Connect to the transport service.
139 * 139 *
140 * @param cfg configuration to use 140 * @param cfg configuration to use
141 * @param config_section section of the configuration to use for options 141 * @param config_section_name section of the configuration to use for
142 * options
142 * @param addr_prefix address prefix for addresses supported by this 143 * @param addr_prefix address prefix for addresses supported by this
143 * communicator, could be NULL for incoming-only communicators 144 * communicator, could be NULL for incoming-only communicators
144 * @param cc what characteristics does the communicator have? 145 * @param cc what characteristics does the communicator have?
@@ -283,7 +284,7 @@ GNUNET_TRANSPORT_communicator_mq_add (
283 * Notify transport service that an MQ was updated 284 * Notify transport service that an MQ was updated
284 * 285 *
285 * @param ch connection to transport service 286 * @param ch connection to transport service
286 * @param qh the queue to update 287 * @param u_qh the queue to update
287 * @param q_len number of messages that can be send through this queue 288 * @param q_len number of messages that can be send through this queue
288 * @param priority queue priority. Queues with highest priority should be 289 * @param priority queue priority. Queues with highest priority should be
289 * used 290 * used
diff --git a/src/include/gnunet_transport_service.h b/src/include/gnunet_transport_service.h
index 99246f136..daa79bf1c 100644
--- a/src/include/gnunet_transport_service.h
+++ b/src/include/gnunet_transport_service.h
@@ -360,8 +360,9 @@ typedef void
360 * @param cfg configuration to use 360 * @param cfg configuration to use
361 * @param peer a specific peer identity to obtain information for, 361 * @param peer a specific peer identity to obtain information for,
362 * NULL for all peers 362 * NULL for all peers
363 * @param one_shot #GNUNET_YES to return the current state and then end (with 363 * @param one_shot #GNUNET_YES to return the current state and
364 * NULL+NULL), #GNUNET_NO to monitor peers continuously 364 * then end (with NULL+NULL),
365 * #GNUNET_NO to monitor peers continuously
365 * @param peer_callback function to call with the results 366 * @param peer_callback function to call with the results
366 * @param peer_callback_cls closure for @a peer_callback 367 * @param peer_callback_cls closure for @a peer_callback
367 */ 368 */
diff --git a/src/messenger/gnunet-messenger.c b/src/messenger/gnunet-messenger.c
index e2d106be8..11b0e091a 100644
--- a/src/messenger/gnunet-messenger.c
+++ b/src/messenger/gnunet-messenger.c
@@ -34,7 +34,7 @@ struct GNUNET_MESSENGER_Handle *messenger;
34/** 34/**
35 * Function called whenever a message is received or sent. 35 * Function called whenever a message is received or sent.
36 * 36 *
37 * @param[in/out] cls Closure 37 * @param[in,out] cls Closure
38 * @param[in] room Room 38 * @param[in] room Room
39 * @param[in] sender Sender of message 39 * @param[in] sender Sender of message
40 * @param[in] message Message 40 * @param[in] message Message
@@ -104,7 +104,7 @@ struct GNUNET_SCHEDULER_Task *read_task;
104/** 104/**
105 * Task to shut down this application. 105 * Task to shut down this application.
106 * 106 *
107 * @param[in/out] cls Closure 107 * @param[in,out] cls Closure
108 */ 108 */
109static void 109static void
110shutdown_hook (void *cls) 110shutdown_hook (void *cls)
@@ -144,7 +144,7 @@ int private_mode;
144/** 144/**
145 * Task run in stdio mode, after some data is available at stdin. 145 * Task run in stdio mode, after some data is available at stdin.
146 * 146 *
147 * @param[in/out] cls Closure 147 * @param[in,out] cls Closure
148 */ 148 */
149static void 149static void
150read_stdio (void *cls) 150read_stdio (void *cls)
@@ -184,7 +184,7 @@ read_stdio (void *cls)
184/** 184/**
185 * Wait for input on STDIO and send it out over the #ch. 185 * Wait for input on STDIO and send it out over the #ch.
186 * 186 *
187 * @param[in/out] cls Closure 187 * @param[in,out] cls Closure
188 */ 188 */
189static void 189static void
190listen_stdio (void *cls) 190listen_stdio (void *cls)
@@ -205,7 +205,7 @@ listen_stdio (void *cls)
205/** 205/**
206 * Initial task to startup application. 206 * Initial task to startup application.
207 * 207 *
208 * @param[in/out] cls Closure 208 * @param[in,out] cls Closure
209 */ 209 */
210static void 210static void
211idle (void *cls) 211idle (void *cls)
@@ -226,8 +226,8 @@ struct GNUNET_SCHEDULER_Task *shutdown_task;
226/** 226/**
227 * Function called when an identity is retrieved. 227 * Function called when an identity is retrieved.
228 * 228 *
229 * @param[in/out] cls Closure 229 * @param[in,out] cls Closure
230 * @param[in/out] handle Handle of messenger service 230 * @param[in,out] handle Handle of messenger service
231 */ 231 */
232static void 232static void
233on_identity (void *cls, 233on_identity (void *cls,
diff --git a/src/messenger/gnunet-service-messenger_ego_store.h b/src/messenger/gnunet-service-messenger_ego_store.h
index 4ed2bbf6d..dbe6c05b9 100644
--- a/src/messenger/gnunet-service-messenger_ego_store.h
+++ b/src/messenger/gnunet-service-messenger_ego_store.h
@@ -96,7 +96,7 @@ init_ego_store (struct GNUNET_MESSENGER_EgoStore *store,
96/** 96/**
97 * Clears an EGO-store, wipes its content and deallocates its memory. 97 * Clears an EGO-store, wipes its content and deallocates its memory.
98 * 98 *
99 * @param[in/out] store EGO-store 99 * @param[in,out] store EGO-store
100 */ 100 */
101void 101void
102clear_ego_store (struct GNUNET_MESSENGER_EgoStore *store); 102clear_ego_store (struct GNUNET_MESSENGER_EgoStore *store);
@@ -105,7 +105,7 @@ clear_ego_store (struct GNUNET_MESSENGER_EgoStore *store);
105 * Creates a new EGO which will be registered to a <i>store</i> under 105 * Creates a new EGO which will be registered to a <i>store</i> under
106 * a specific <i>identifier</i>. 106 * a specific <i>identifier</i>.
107 * 107 *
108 * @param[in/out] store EGO-store 108 * @param[in,out] store EGO-store
109 * @param[in] identifier Identifier string 109 * @param[in] identifier Identifier string
110 */ 110 */
111void 111void
@@ -116,9 +116,9 @@ create_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
116 * Binds an EGO which was registered to a <i>store</i> under 116 * Binds an EGO which was registered to a <i>store</i> under
117 * a specific <i>identifier</i> to a given <i>handle</i> 117 * a specific <i>identifier</i> to a given <i>handle</i>
118 * 118 *
119 * @param[in/out] store EGO-store 119 * @param[in,out] store EGO-store
120 * @param[in] identifier Identifier string 120 * @param[in] identifier Identifier string
121 * @param[in/out] handle Handle 121 * @param[in,out] handle Handle
122 */ 122 */
123void 123void
124bind_store_ego (struct GNUNET_MESSENGER_EgoStore *store, 124bind_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
@@ -129,9 +129,9 @@ bind_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
129 * Binds an EGO which was registered to a <i>store</i> under 129 * Binds an EGO which was registered to a <i>store</i> under
130 * a specific <i>identifier</i> to a given <i>handle</i> 130 * a specific <i>identifier</i> to a given <i>handle</i>
131 * 131 *
132 * @param[in/out] store EGO-store 132 * @param[in,out] store EGO-store
133 * @param[in] identifier Identifier string 133 * @param[in] identifier Identifier string
134 * @param[in/out] handle Handle 134 * @param[in,out] handle Handle
135 */ 135 */
136void 136void
137unbind_store_ego (struct GNUNET_MESSENGER_EgoStore *store, 137unbind_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
@@ -142,7 +142,7 @@ unbind_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
142 * Lookups an EGO which was registered to a <i>store</i> under 142 * Lookups an EGO which was registered to a <i>store</i> under
143 * a specific <i>identifier</i>. 143 * a specific <i>identifier</i>.
144 * 144 *
145 * @param[in/out] store EGO-store 145 * @param[in,out] store EGO-store
146 * @param[in] identifier Identifier string 146 * @param[in] identifier Identifier string
147 * @param[in] lookup Lookup callback (non-NULL) 147 * @param[in] lookup Lookup callback (non-NULL)
148 * @param[in] cls Closure 148 * @param[in] cls Closure
@@ -157,7 +157,7 @@ lookup_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
157 * Updates the registration of an EGO to a <i>store</i> under 157 * Updates the registration of an EGO to a <i>store</i> under
158 * a specific <i>identifier</i> with a new <i>key</i>. 158 * a specific <i>identifier</i> with a new <i>key</i>.
159 * 159 *
160 * @param[in/out] store EGO-store 160 * @param[in,out] store EGO-store
161 * @param[in] identifier Identifier string 161 * @param[in] identifier Identifier string
162 * @param[in] key Private EGO key 162 * @param[in] key Private EGO key
163 * @return Updated EGO 163 * @return Updated EGO
@@ -171,7 +171,7 @@ update_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
171 * Deletes the registration of an EGO in a <i>store</i> under 171 * Deletes the registration of an EGO in a <i>store</i> under
172 * a specific <i>identifier</i>. 172 * a specific <i>identifier</i>.
173 * 173 *
174 * @param[in/out] store EGO-store 174 * @param[in,out] store EGO-store
175 * @param[in] identifier Identifier string 175 * @param[in] identifier Identifier string
176 */ 176 */
177void 177void
@@ -180,10 +180,10 @@ delete_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
180 180
181/** 181/**
182 * Updates the location of a registered EGO in a <i>store</i> to 182 * Updates the location of a registered EGO in a <i>store</i> to
183 * a different one under a specific <i>new_identifier<i> replacing 183 * a different one under a specific <i>new_identifier</i> replacing
184 * its old one. 184 * its old one.
185 * 185 *
186 * @param[in/out] store EGO-store 186 * @param[in,out] store EGO-store
187 * @param[in] old_identifier Old identifier string 187 * @param[in] old_identifier Old identifier string
188 * @param[in] new_identifier New identifier string 188 * @param[in] new_identifier New identifier string
189 */ 189 */
@@ -196,7 +196,7 @@ rename_store_ego (struct GNUNET_MESSENGER_EgoStore *store,
196 * Replaces the registered EGO in a <i>store</i> under a specific 196 * Replaces the registered EGO in a <i>store</i> under a specific
197 * <i>identifier</i> with a newly created one. 197 * <i>identifier</i> with a newly created one.
198 * 198 *
199 * @param[in/out] store EGO-store 199 * @param[in,out] store EGO-store
200 * @param[in] identifier Identifier string 200 * @param[in] identifier Identifier string
201 */ 201 */
202void 202void
diff --git a/src/messenger/gnunet-service-messenger_handle.h b/src/messenger/gnunet-service-messenger_handle.h
index 8754716e9..c596f4d3b 100644
--- a/src/messenger/gnunet-service-messenger_handle.h
+++ b/src/messenger/gnunet-service-messenger_handle.h
@@ -55,8 +55,8 @@ struct GNUNET_MESSENGER_SrvHandle
55/** 55/**
56 * Creates and allocates a new handle related to a <i>service</i> and using a given <i>mq</i> (message queue). 56 * Creates and allocates a new handle related to a <i>service</i> and using a given <i>mq</i> (message queue).
57 * 57 *
58 * @param[in/out] service MESSENGER Service 58 * @param[in,out] service MESSENGER Service
59 * @param[in/out] mq Message queue 59 * @param[in,out] mq Message queue
60 * @return New handle 60 * @return New handle
61 */ 61 */
62struct GNUNET_MESSENGER_SrvHandle* 62struct GNUNET_MESSENGER_SrvHandle*
@@ -66,7 +66,7 @@ create_srv_handle (struct GNUNET_MESSENGER_Service *service,
66/** 66/**
67 * Destroys a handle and frees its memory fully. 67 * Destroys a handle and frees its memory fully.
68 * 68 *
69 * @param[in/out] handle Handle 69 * @param[in,out] handle Handle
70 */ 70 */
71void 71void
72destroy_srv_handle (struct GNUNET_MESSENGER_SrvHandle *handle); 72destroy_srv_handle (struct GNUNET_MESSENGER_SrvHandle *handle);
@@ -103,7 +103,7 @@ get_srv_handle_member_id (const struct GNUNET_MESSENGER_SrvHandle *handle,
103 * 103 *
104 * The client connected to the <i>handle</i> will be informed afterwards automatically. 104 * The client connected to the <i>handle</i> will be informed afterwards automatically.
105 * 105 *
106 * @param[in/out] handle Handle 106 * @param[in,out] handle Handle
107 * @param[in] key Key of a room 107 * @param[in] key Key of a room
108 * @param[in] unique_id Unique member id 108 * @param[in] unique_id Unique member id
109 * @return GNUNET_OK on success, otherwise GNUNET_SYSERR 109 * @return GNUNET_OK on success, otherwise GNUNET_SYSERR
@@ -116,7 +116,7 @@ change_srv_handle_member_id (struct GNUNET_MESSENGER_SrvHandle *handle,
116/** 116/**
117 * Sets the EGO used by a given <i>handle</i>. 117 * Sets the EGO used by a given <i>handle</i>.
118 * 118 *
119 * @param[in/out] handle Handle 119 * @param[in,out] handle Handle
120 * @param[in] ego EGO key pair 120 * @param[in] ego EGO key pair
121 */ 121 */
122void 122void
@@ -135,7 +135,7 @@ get_srv_handle_ego (const struct GNUNET_MESSENGER_SrvHandle *handle);
135/** 135/**
136 * Tries to set the name and EGO key of a <i>handle</i> initially by looking up a specific <i>name</i>. 136 * Tries to set the name and EGO key of a <i>handle</i> initially by looking up a specific <i>name</i>.
137 * 137 *
138 * @param[in/out] handle Handle 138 * @param[in,out] handle Handle
139 * @param[in] name Name (optionally: valid EGO name) 139 * @param[in] name Name (optionally: valid EGO name)
140 */ 140 */
141void 141void
@@ -146,7 +146,7 @@ setup_srv_handle_name (struct GNUNET_MESSENGER_SrvHandle *handle,
146 * Tries to change the key pair of an EGO of a <i>handle</i> under the same name and informs all rooms 146 * Tries to change the key pair of an EGO of a <i>handle</i> under the same name and informs all rooms
147 * about the change automatically. 147 * about the change automatically.
148 * 148 *
149 * @param[in/out] handle Handle 149 * @param[in,out] handle Handle
150 */ 150 */
151void 151void
152update_srv_handle (struct GNUNET_MESSENGER_SrvHandle *handle); 152update_srv_handle (struct GNUNET_MESSENGER_SrvHandle *handle);
@@ -157,7 +157,7 @@ update_srv_handle (struct GNUNET_MESSENGER_SrvHandle *handle);
157 * 157 *
158 * The client connected to the <i>handle</i> will be informed afterwards automatically. 158 * The client connected to the <i>handle</i> will be informed afterwards automatically.
159 * 159 *
160 * @param[in/out] handle Handle 160 * @param[in,out] handle Handle
161 * @param[in] name New name 161 * @param[in] name New name
162 */ 162 */
163void 163void
@@ -168,7 +168,7 @@ set_srv_handle_name (struct GNUNET_MESSENGER_SrvHandle *handle,
168 * Makes a given <i>handle</i> a member of the room using a specific <i>key</i> and opens the 168 * Makes a given <i>handle</i> a member of the room using a specific <i>key</i> and opens the
169 * room from the handles service. 169 * room from the handles service.
170 * 170 *
171 * @param[in/out] handle Handle 171 * @param[in,out] handle Handle
172 * @param[in] key Key of a room 172 * @param[in] key Key of a room
173 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 173 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
174 */ 174 */
@@ -180,7 +180,7 @@ open_srv_handle_room (struct GNUNET_MESSENGER_SrvHandle *handle,
180 * Makes a given <i>handle</i> a member of the room using a specific <i>key</i> and enters the room 180 * Makes a given <i>handle</i> a member of the room using a specific <i>key</i> and enters the room
181 * through a tunnel to a peer identified by a given <i>door</i> (peer identity). 181 * through a tunnel to a peer identified by a given <i>door</i> (peer identity).
182 * 182 *
183 * @param[in/out] handle Handle 183 * @param[in,out] handle Handle
184 * @param[in] door Peer identity 184 * @param[in] door Peer identity
185 * @param[in] key Key of a room 185 * @param[in] key Key of a room
186 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 186 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
@@ -194,7 +194,7 @@ entry_srv_handle_room (struct GNUNET_MESSENGER_SrvHandle *handle,
194 * Removes the membership of the room using a specific <i>key</i> and closes it if no other handle 194 * Removes the membership of the room using a specific <i>key</i> and closes it if no other handle
195 * from this service is still a member of it. 195 * from this service is still a member of it.
196 * 196 *
197 * @param[in/out] handle Handle 197 * @param[in,out] handle Handle
198 * @param[in] key Key of a room 198 * @param[in] key Key of a room
199 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 199 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
200 */ 200 */
@@ -205,7 +205,7 @@ close_srv_handle_room (struct GNUNET_MESSENGER_SrvHandle *handle,
205/** 205/**
206 * Sends a <i>message</i> from a given <i>handle</i> to the room using a specific <i>key</i>. 206 * Sends a <i>message</i> from a given <i>handle</i> to the room using a specific <i>key</i>.
207 * 207 *
208 * @param[in/out] handle Handle 208 * @param[in,out] handle Handle
209 * @param[in] key Key of a room 209 * @param[in] key Key of a room
210 * @param[in] message Message 210 * @param[in] message Message
211 * @return #GNUNET_YES on success, #GNUNET_NO or #GNUNET_SYSERR otherwise. 211 * @return #GNUNET_YES on success, #GNUNET_NO or #GNUNET_SYSERR otherwise.
@@ -218,7 +218,7 @@ send_srv_handle_message (struct GNUNET_MESSENGER_SrvHandle *handle,
218/** 218/**
219 * Notifies the handle that a new message was received or sent. 219 * Notifies the handle that a new message was received or sent.
220 * 220 *
221 * @param[in/out] handle Handle 221 * @param[in,out] handle Handle
222 * @param[in] room Room of the message 222 * @param[in] room Room of the message
223 * @param[in] session Member session 223 * @param[in] session Member session
224 * @param[in] message Message 224 * @param[in] message Message
diff --git a/src/messenger/gnunet-service-messenger_list_handles.h b/src/messenger/gnunet-service-messenger_list_handles.h
index f4d7ca5c0..f41807d00 100644
--- a/src/messenger/gnunet-service-messenger_list_handles.h
+++ b/src/messenger/gnunet-service-messenger_list_handles.h
@@ -57,7 +57,7 @@ init_list_handles (struct GNUNET_MESSENGER_ListHandles *handles);
57/** 57/**
58 * Destroys remaining <i>handles</i> and clears the list. 58 * Destroys remaining <i>handles</i> and clears the list.
59 * 59 *
60 * @param[in/out] handles List of handles 60 * @param[in,out] handles List of handles
61 */ 61 */
62void 62void
63clear_list_handles (struct GNUNET_MESSENGER_ListHandles *handles); 63clear_list_handles (struct GNUNET_MESSENGER_ListHandles *handles);
@@ -65,8 +65,8 @@ clear_list_handles (struct GNUNET_MESSENGER_ListHandles *handles);
65/** 65/**
66 * Adds a specific <i>handle</i> to the end of the list. 66 * Adds a specific <i>handle</i> to the end of the list.
67 * 67 *
68 * @param[in/out] handles List of handles 68 * @param[in,out] handles List of handles
69 * @param[in/out] handle Handle 69 * @param[in,out] handle Handle
70 */ 70 */
71void 71void
72add_list_handle (struct GNUNET_MESSENGER_ListHandles *handles, 72add_list_handle (struct GNUNET_MESSENGER_ListHandles *handles,
@@ -76,8 +76,8 @@ add_list_handle (struct GNUNET_MESSENGER_ListHandles *handles,
76 * Removes the first entry matching with a specific <i>handle</i> from the list of 76 * Removes the first entry matching with a specific <i>handle</i> from the list of
77 * <i>handles</i> and returns #GNUNET_YES on success or #GNUNET_NO on failure. 77 * <i>handles</i> and returns #GNUNET_YES on success or #GNUNET_NO on failure.
78 * 78 *
79 * @param[in/out] handles List of handles 79 * @param[in,out] handles List of handles
80 * @param[in/out] handle Handle 80 * @param[in,out] handle Handle
81 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 81 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
82 */ 82 */
83int 83int
diff --git a/src/messenger/gnunet-service-messenger_list_messages.h b/src/messenger/gnunet-service-messenger_list_messages.h
index 7abc8c00f..e270209c8 100644
--- a/src/messenger/gnunet-service-messenger_list_messages.h
+++ b/src/messenger/gnunet-service-messenger_list_messages.h
@@ -56,7 +56,7 @@ init_list_messages (struct GNUNET_MESSENGER_ListMessages *messages);
56/** 56/**
57 * Clears the list of message hashes. 57 * Clears the list of message hashes.
58 * 58 *
59 * @param[in/out] messages List of hashes 59 * @param[in,out] messages List of hashes
60 */ 60 */
61void 61void
62clear_list_messages (struct GNUNET_MESSENGER_ListMessages *messages); 62clear_list_messages (struct GNUNET_MESSENGER_ListMessages *messages);
@@ -64,7 +64,7 @@ clear_list_messages (struct GNUNET_MESSENGER_ListMessages *messages);
64/** 64/**
65 * Adds a specific <i>hash</i> from a message to the end of the list. 65 * Adds a specific <i>hash</i> from a message to the end of the list.
66 * 66 *
67 * @param[in/out] messages List of hashes 67 * @param[in,out] messages List of hashes
68 * @param[in] hash Hash of message 68 * @param[in] hash Hash of message
69 */ 69 */
70void 70void
@@ -74,7 +74,7 @@ add_to_list_messages (struct GNUNET_MESSENGER_ListMessages *messages,
74/** 74/**
75 * Copies all message hashes from an <i>origin</i> to another list. 75 * Copies all message hashes from an <i>origin</i> to another list.
76 * 76 *
77 * @param[in/out] messages Destination list of hashes 77 * @param[in,out] messages Destination list of hashes
78 * @param[in] origin Source list of hashes 78 * @param[in] origin Source list of hashes
79 */ 79 */
80void 80void
@@ -84,7 +84,7 @@ copy_list_messages (struct GNUNET_MESSENGER_ListMessages *messages,
84/** 84/**
85 * Removes the first entry with a matching <i>hash</i> from the list. 85 * Removes the first entry with a matching <i>hash</i> from the list.
86 * 86 *
87 * @param[in/out] messages List of hashes 87 * @param[in,out] messages List of hashes
88 * @param[in] hash Hash of message 88 * @param[in] hash Hash of message
89 */ 89 */
90void 90void
diff --git a/src/messenger/gnunet-service-messenger_member.h b/src/messenger/gnunet-service-messenger_member.h
index 46269315a..0c5870fd3 100644
--- a/src/messenger/gnunet-service-messenger_member.h
+++ b/src/messenger/gnunet-service-messenger_member.h
@@ -47,7 +47,7 @@ struct GNUNET_MESSENGER_Member
47 * 47 *
48 * If the creation fails, NULL gets returned. 48 * If the creation fails, NULL gets returned.
49 * 49 *
50 * @param[in/out] store Member store 50 * @param[in,out] store Member store
51 * @param[in] id Member id or NULL 51 * @param[in] id Member id or NULL
52 * @return New member or NULL 52 * @return New member or NULL
53 */ 53 */
@@ -58,7 +58,7 @@ create_member (struct GNUNET_MESSENGER_MemberStore *store,
58/** 58/**
59 * Destroys a member and frees its memory fully. 59 * Destroys a member and frees its memory fully.
60 * 60 *
61 * @param[in/out] member Member 61 * @param[in,out] member Member
62 */ 62 */
63void 63void
64destroy_member (struct GNUNET_MESSENGER_Member *member); 64destroy_member (struct GNUNET_MESSENGER_Member *member);
@@ -88,7 +88,7 @@ load_member (struct GNUNET_MESSENGER_MemberStore *store,
88 * Loads data about next sessions from a <i>directory</i> into an empty loaded 88 * Loads data about next sessions from a <i>directory</i> into an empty loaded
89 * <i>member</i> which does not contain a fully built session graph yet. 89 * <i>member</i> which does not contain a fully built session graph yet.
90 * 90 *
91 * @param[in/out] member Member 91 * @param[in,out] member Member
92 * @param[in] directory Path to a directory 92 * @param[in] directory Path to a directory
93 */ 93 */
94void 94void
@@ -110,7 +110,7 @@ save_member (struct GNUNET_MESSENGER_Member *member,
110 * Synchronizes contacts between all sessions from a given <i>member</i> 110 * Synchronizes contacts between all sessions from a given <i>member</i>
111 * and other sessions which are linked to them. 111 * and other sessions which are linked to them.
112 * 112 *
113 * @param[in/out] member Member 113 * @param[in,out] member Member
114 */ 114 */
115void 115void
116sync_member_contacts (struct GNUNET_MESSENGER_Member *member); 116sync_member_contacts (struct GNUNET_MESSENGER_Member *member);
@@ -145,8 +145,8 @@ get_member_session_of (struct GNUNET_MESSENGER_Member *member,
145/** 145/**
146 * Adds a given member <i>session</i> to its <i>member</i>. 146 * Adds a given member <i>session</i> to its <i>member</i>.
147 * 147 *
148 * @param[in/out] member Member 148 * @param[in,out] member Member
149 * @param[in/out] session Member session 149 * @param[in,out] session Member session
150 */ 150 */
151void 151void
152add_member_session (struct GNUNET_MESSENGER_Member *member, 152add_member_session (struct GNUNET_MESSENGER_Member *member,
@@ -155,8 +155,8 @@ add_member_session (struct GNUNET_MESSENGER_Member *member,
155/** 155/**
156 * Removes a given member <i>session</i> from its <i>member</i>. 156 * Removes a given member <i>session</i> from its <i>member</i>.
157 * 157 *
158 * @param[in/out] member Member 158 * @param[in,out] member Member
159 * @param[in/out] session Member session 159 * @param[in,out] session Member session
160 */ 160 */
161void 161void
162remove_member_session (struct GNUNET_MESSENGER_Member *member, 162remove_member_session (struct GNUNET_MESSENGER_Member *member,
@@ -167,9 +167,9 @@ remove_member_session (struct GNUNET_MESSENGER_Member *member,
167 * and call the provided iterator callback with a selected closure. The function 167 * and call the provided iterator callback with a selected closure. The function
168 * will return the amount of member sessions it iterated through. 168 * will return the amount of member sessions it iterated through.
169 * 169 *
170 * @param[in/out] member Member 170 * @param[in,out] member Member
171 * @param[in] it Iterator callback 171 * @param[in] it Iterator callback
172 * @param[in/out] cls Closure 172 * @param[in,out] cls Closure
173 * @return Amount of sessions iterated through 173 * @return Amount of sessions iterated through
174 */ 174 */
175int 175int
diff --git a/src/messenger/gnunet-service-messenger_member_session.h b/src/messenger/gnunet-service-messenger_member_session.h
index 9ba801776..fcde2c3de 100644
--- a/src/messenger/gnunet-service-messenger_member_session.h
+++ b/src/messenger/gnunet-service-messenger_member_session.h
@@ -62,7 +62,7 @@ struct GNUNET_MESSENGER_MemberSession {
62 * 62 *
63 * If the creation fails, NULL gets returned. 63 * If the creation fails, NULL gets returned.
64 * 64 *
65 * @param[in/out] member Member 65 * @param[in,out] member Member
66 * @param[in] pubkey Public key of EGO 66 * @param[in] pubkey Public key of EGO
67 * @return New member session 67 * @return New member session
68 */ 68 */
@@ -77,7 +77,7 @@ create_member_session (struct GNUNET_MESSENGER_Member *member,
77 * <i>message</i> to switch session. The new session will be linked to the old 77 * <i>message</i> to switch session. The new session will be linked to the old
78 * one. 78 * one.
79 * 79 *
80 * @param[in/out] session Old member session 80 * @param[in,out] session Old member session
81 * @param[in] message Message 81 * @param[in] message Message
82 * @param[in] hash Hash of message 82 * @param[in] hash Hash of message
83 * @return New member session 83 * @return New member session
@@ -90,7 +90,7 @@ switch_member_session (struct GNUNET_MESSENGER_MemberSession *session,
90/** 90/**
91 * Destroys a member session and frees its memory fully. 91 * Destroys a member session and frees its memory fully.
92 * 92 *
93 * @param[in/out] session Member session 93 * @param[in,out] session Member session
94 */ 94 */
95void 95void
96destroy_member_session(struct GNUNET_MESSENGER_MemberSession* session); 96destroy_member_session(struct GNUNET_MESSENGER_MemberSession* session);
@@ -101,7 +101,7 @@ destroy_member_session(struct GNUNET_MESSENGER_MemberSession* session);
101 * be dropped. The member sessions messages will be cleared but old 101 * be dropped. The member sessions messages will be cleared but old
102 * history from uncompleted sessions however can be reused! 102 * history from uncompleted sessions however can be reused!
103 * 103 *
104 * @param[in/out] session Member session 104 * @param[in,out] session Member session
105 * @param[in] hash Hash of initial message (JOIN message!) 105 * @param[in] hash Hash of initial message (JOIN message!)
106 * @return #GNUNET_OK on success, #GNUNET_SYSERR otherwise 106 * @return #GNUNET_OK on success, #GNUNET_SYSERR otherwise
107 */ 107 */
@@ -116,7 +116,7 @@ reset_member_session (struct GNUNET_MESSENGER_MemberSession* session,
116 * Closing a session may complete a session and can't be used without 116 * Closing a session may complete a session and can't be used without
117 * a reset! ( @see #reset_member_session() ) 117 * a reset! ( @see #reset_member_session() )
118 * 118 *
119 * @param[in/out] session Member session 119 * @param[in,out] session Member session
120 */ 120 */
121void 121void
122close_member_session (struct GNUNET_MESSENGER_MemberSession* session); 122close_member_session (struct GNUNET_MESSENGER_MemberSession* session);
@@ -234,7 +234,7 @@ check_member_session_history (const struct GNUNET_MESSENGER_MemberSession *sessi
234 * 234 *
235 * @see #is_member_session_completed() for updating a history. 235 * @see #is_member_session_completed() for updating a history.
236 * 236 *
237 * @param[in/out] session Member session 237 * @param[in,out] session Member session
238 * @param[in] message Message 238 * @param[in] message Message
239 * @param[in] hash Hash of message 239 * @param[in] hash Hash of message
240 */ 240 */
@@ -247,7 +247,7 @@ update_member_session_history (struct GNUNET_MESSENGER_MemberSession *session,
247 * Removes a message from the history of a <i>session</i> using the messages 247 * Removes a message from the history of a <i>session</i> using the messages
248 * <i>hash</i>. 248 * <i>hash</i>.
249 * 249 *
250 * @param[in/out] session Member session 250 * @param[in,out] session Member session
251 * @param[in] hash Hash of message 251 * @param[in] hash Hash of message
252 */ 252 */
253void 253void
@@ -271,7 +271,7 @@ load_member_session (struct GNUNET_MESSENGER_Member *member,
271 * next attribute. Necessary information will be loaded from a configuration 271 * next attribute. Necessary information will be loaded from a configuration
272 * file inside of a given <i>directory</i>. 272 * file inside of a given <i>directory</i>.
273 * 273 *
274 * @param[in/out] session Member session 274 * @param[in,out] session Member session
275 * @param[in] directory Path to a directory 275 * @param[in] directory Path to a directory
276 */ 276 */
277void 277void
diff --git a/src/messenger/gnunet-service-messenger_member_store.h b/src/messenger/gnunet-service-messenger_member_store.h
index af50f0d36..c3f6d478a 100644
--- a/src/messenger/gnunet-service-messenger_member_store.h
+++ b/src/messenger/gnunet-service-messenger_member_store.h
@@ -62,7 +62,7 @@ init_member_store (struct GNUNET_MESSENGER_MemberStore *store,
62/** 62/**
63 * Clears a member <i>store</i>, wipes its content and deallocates its memory. 63 * Clears a member <i>store</i>, wipes its content and deallocates its memory.
64 * 64 *
65 * @param[in/out] store Member store 65 * @param[in,out] store Member store
66 */ 66 */
67void 67void
68clear_member_store (struct GNUNET_MESSENGER_MemberStore *store); 68clear_member_store (struct GNUNET_MESSENGER_MemberStore *store);
@@ -70,7 +70,7 @@ clear_member_store (struct GNUNET_MESSENGER_MemberStore *store);
70/** 70/**
71 * Returns the used contact store of a given member <i>store</i>. 71 * Returns the used contact store of a given member <i>store</i>.
72 * 72 *
73 * @param[in/out] store Member store 73 * @param[in,out] store Member store
74 * @return Contact store 74 * @return Contact store
75 */ 75 */
76struct GNUNET_MESSENGER_ContactStore* 76struct GNUNET_MESSENGER_ContactStore*
@@ -121,7 +121,7 @@ get_store_member (const struct GNUNET_MESSENGER_MemberStore *store,
121 * Returns the member of a <i>store</i> using a sender id of a given <i>message</i>. 121 * Returns the member of a <i>store</i> using a sender id of a given <i>message</i>.
122 * If the member does not provide a matching session, NULL gets returned. 122 * If the member does not provide a matching session, NULL gets returned.
123 * 123 *
124 * @param[in/out] store Member store 124 * @param[in,out] store Member store
125 * @param[in] message Message 125 * @param[in] message Message
126 * @return Member or NULL 126 * @return Member or NULL
127 */ 127 */
@@ -132,7 +132,7 @@ get_store_member_of (struct GNUNET_MESSENGER_MemberStore *store,
132/** 132/**
133 * Adds a member to a <i>store</i> under a specific <i>id</i> and returns it on success. 133 * Adds a member to a <i>store</i> under a specific <i>id</i> and returns it on success.
134 * 134 *
135 * @param[in/out] store Member store 135 * @param[in,out] store Member store
136 * @param[in] id Member id 136 * @param[in] id Member id
137 * @return Member or NULL 137 * @return Member or NULL
138 */ 138 */
@@ -145,9 +145,9 @@ add_store_member (struct GNUNET_MESSENGER_MemberStore *store,
145 * member <i>store</i> and call the provided iterator callback with a selected closure. 145 * member <i>store</i> and call the provided iterator callback with a selected closure.
146 * The function will return the amount of members it iterated through. 146 * The function will return the amount of members it iterated through.
147 * 147 *
148 * @param[in/out] store Member store 148 * @param[in,out] store Member store
149 * @param[in] it Iterator callback 149 * @param[in] it Iterator callback
150 * @param[in/out] cls Closure 150 * @param[in,out] cls Closure
151 * @return Amount of members iterated through 151 * @return Amount of members iterated through
152 */ 152 */
153int 153int
diff --git a/src/messenger/gnunet-service-messenger_message_handle.h b/src/messenger/gnunet-service-messenger_message_handle.h
index 0e5be3408..62940e6b6 100644
--- a/src/messenger/gnunet-service-messenger_message_handle.h
+++ b/src/messenger/gnunet-service-messenger_message_handle.h
@@ -39,8 +39,8 @@
39 * Handles a received or sent join message to make changes of current member information. 39 * Handles a received or sent join message to make changes of current member information.
40 * (add matching member and clear member info) 40 * (add matching member and clear member info)
41 * 41 *
42 * @param[in/out] room Room of the message 42 * @param[in,out] room Room of the message
43 * @param[in/out] session Member session 43 * @param[in,out] session Member session
44 * @param[in] message JOIN-Message 44 * @param[in] message JOIN-Message
45 * @param[in] hash Hash of the message 45 * @param[in] hash Hash of the message
46 */ 46 */
@@ -54,8 +54,8 @@ handle_message_join (struct GNUNET_MESSENGER_SrvRoom *room,
54 * Handles a received or sent leave message to make changes of current member information. 54 * Handles a received or sent leave message to make changes of current member information.
55 * (remove matching member and clear member info) 55 * (remove matching member and clear member info)
56 * 56 *
57 * @param[in/out] room Room of the message 57 * @param[in,out] room Room of the message
58 * @param[in/out] session Member session 58 * @param[in,out] session Member session
59 * @param[in] message LEAVE-Message 59 * @param[in] message LEAVE-Message
60 * @param[in] hash Hash of the message 60 * @param[in] hash Hash of the message
61 */ 61 */
@@ -69,8 +69,8 @@ handle_message_leave (struct GNUNET_MESSENGER_SrvRoom *room,
69 * Handles a received or sent name message to rename a current member. 69 * Handles a received or sent name message to rename a current member.
70 * (change name of matching member) 70 * (change name of matching member)
71 * 71 *
72 * @param[in/out] room Room of the message 72 * @param[in,out] room Room of the message
73 * @param[in/out] session Member session 73 * @param[in,out] session Member session
74 * @param[in] message NAME-Message 74 * @param[in] message NAME-Message
75 * @param[in] hash Hash of the message 75 * @param[in] hash Hash of the message
76 */ 76 */
@@ -84,8 +84,8 @@ handle_message_name (struct GNUNET_MESSENGER_SrvRoom *room,
84 * Handles a received or sent key message to change the key of a member and rearrange the contacts accordingly. 84 * Handles a received or sent key message to change the key of a member and rearrange the contacts accordingly.
85 * (move the member in the contacts and change its key) 85 * (move the member in the contacts and change its key)
86 * 86 *
87 * @param[in/out] room Room of the message 87 * @param[in,out] room Room of the message
88 * @param[in/out] session Member session 88 * @param[in,out] session Member session
89 * @param[in] message KEY-Message 89 * @param[in] message KEY-Message
90 * @param[in] hash Hash of the message 90 * @param[in] hash Hash of the message
91 */ 91 */
@@ -99,8 +99,8 @@ handle_message_key (struct GNUNET_MESSENGER_SrvRoom *room,
99 * Handles a received or sent peer message to make changes of the basement in the room. 99 * Handles a received or sent peer message to make changes of the basement in the room.
100 * (add a new peer to the basement and restructure connections based on updated list of peers) 100 * (add a new peer to the basement and restructure connections based on updated list of peers)
101 * 101 *
102 * @param[in/out] room Room of the message 102 * @param[in,out] room Room of the message
103 * @param[in/out] session Member session 103 * @param[in,out] session Member session
104 * @param[in] message PEER-Message 104 * @param[in] message PEER-Message
105 * @param[in] hash Hash of the message 105 * @param[in] hash Hash of the message
106 */ 106 */
@@ -114,8 +114,8 @@ handle_message_peer (struct GNUNET_MESSENGER_SrvRoom *room,
114 * Handles a received or sent id message to change a members id. 114 * Handles a received or sent id message to change a members id.
115 * (change id of matching member) 115 * (change id of matching member)
116 * 116 *
117 * @param[in/out] room Room of the message 117 * @param[in,out] room Room of the message
118 * @param[in/out] session Member session 118 * @param[in,out] session Member session
119 * @param[in] message ID-Message 119 * @param[in] message ID-Message
120 * @param[in] hash Hash of the message 120 * @param[in] hash Hash of the message
121 */ 121 */
@@ -129,8 +129,8 @@ handle_message_id (struct GNUNET_MESSENGER_SrvRoom *room,
129 * Handles a received or sent miss message to drop a peer from the basement in the room. 129 * Handles a received or sent miss message to drop a peer from the basement in the room.
130 * (remove a peer from the basement and restructure connections based on updated list of peers) 130 * (remove a peer from the basement and restructure connections based on updated list of peers)
131 * 131 *
132 * @param[in/out] room Room of the message 132 * @param[in,out] room Room of the message
133 * @param[in/out] session Member session 133 * @param[in,out] session Member session
134 * @param[in] message MISS-Message 134 * @param[in] message MISS-Message
135 * @param[in] hash Hash of the message 135 * @param[in] hash Hash of the message
136 */ 136 */
@@ -144,8 +144,8 @@ handle_message_miss (struct GNUNET_MESSENGER_SrvRoom *room,
144 * Handles a received or sent delete message to delete a specific message from the store. 144 * Handles a received or sent delete message to delete a specific message from the store.
145 * (remove a message from the store of a room under a given delay) 145 * (remove a message from the store of a room under a given delay)
146 * 146 *
147 * @param[in/out] room Room of the message 147 * @param[in,out] room Room of the message
148 * @param[in/out] session Member session 148 * @param[in,out] session Member session
149 * @param[in] message DELETE-Message 149 * @param[in] message DELETE-Message
150 * @param[in] hash Hash of the message 150 * @param[in] hash Hash of the message
151 */ 151 */
diff --git a/src/messenger/gnunet-service-messenger_message_kind.h b/src/messenger/gnunet-service-messenger_message_kind.h
index 508f19074..d07680dfc 100644
--- a/src/messenger/gnunet-service-messenger_message_kind.h
+++ b/src/messenger/gnunet-service-messenger_message_kind.h
@@ -150,7 +150,7 @@ create_message_invite (const struct GNUNET_PeerIdentity *door,
150 const struct GNUNET_HashCode *key); 150 const struct GNUNET_HashCode *key);
151 151
152/** 152/**
153 * Creates and allocates a new <i>text message containing a string representing text. 153 * Creates and allocates a new <i>text</i> message containing a string representing text.
154 * (all values are stored as copy) 154 * (all values are stored as copy)
155 * 155 *
156 * @param[in] text Text 156 * @param[in] text Text
diff --git a/src/messenger/gnunet-service-messenger_message_recv.h b/src/messenger/gnunet-service-messenger_message_recv.h
index 400c10245..b4304762b 100644
--- a/src/messenger/gnunet-service-messenger_message_recv.h
+++ b/src/messenger/gnunet-service-messenger_message_recv.h
@@ -39,8 +39,8 @@
39 * Handles a received info message to change the current member id to the one generated by 39 * Handles a received info message to change the current member id to the one generated by
40 * the host connected to. (all current tunnels will be informed about the id change) 40 * the host connected to. (all current tunnels will be informed about the id change)
41 * 41 *
42 * @param[in/out] room Room of the message 42 * @param[in,out] room Room of the message
43 * @param[in/out] tunnel Receiving connection 43 * @param[in,out] tunnel Receiving connection
44 * @param[in] message INFO-Message 44 * @param[in] message INFO-Message
45 * @param[in] hash Hash of the message 45 * @param[in] hash Hash of the message
46 * @return #GNUNET_NO to not forward the message 46 * @return #GNUNET_NO to not forward the message
@@ -55,8 +55,8 @@ recv_message_info (struct GNUNET_MESSENGER_SrvRoom *room,
55 * Handles a received peer message to link it to its origin tunnel if the peer identity matches. 55 * Handles a received peer message to link it to its origin tunnel if the peer identity matches.
56 * (the peer message and the member id can potentially be linked to the tunnel) 56 * (the peer message and the member id can potentially be linked to the tunnel)
57 * 57 *
58 * @param[in/out] room Room of the message 58 * @param[in,out] room Room of the message
59 * @param[in/out] tunnel Receiving connection 59 * @param[in,out] tunnel Receiving connection
60 * @param[in] message PEER-Message 60 * @param[in] message PEER-Message
61 * @param[in] hash Hash of the message 61 * @param[in] hash Hash of the message
62 * @return #GNUNET_YES to forward the message 62 * @return #GNUNET_YES to forward the message
@@ -72,8 +72,8 @@ recv_message_peer (struct GNUNET_MESSENGER_SrvRoom *room,
72 * if the message was found. 72 * if the message was found.
73 * (this can also cause this peer to send a new request instead of only forwarding the received one) 73 * (this can also cause this peer to send a new request instead of only forwarding the received one)
74 * 74 *
75 * @param[in/out] room Room of the message 75 * @param[in,out] room Room of the message
76 * @param[in/out] tunnel Receiving connection 76 * @param[in,out] tunnel Receiving connection
77 * @param[in] message REQUEST-Message 77 * @param[in] message REQUEST-Message
78 * @param[in] hash Hash of the message 78 * @param[in] hash Hash of the message
79 * @return #GNUNET_YES or #GNUNET_NO depending on required forwarding 79 * @return #GNUNET_YES or #GNUNET_NO depending on required forwarding
diff --git a/src/messenger/gnunet-service-messenger_message_send.h b/src/messenger/gnunet-service-messenger_message_send.h
index 232355c41..8d782c5a6 100644
--- a/src/messenger/gnunet-service-messenger_message_send.h
+++ b/src/messenger/gnunet-service-messenger_message_send.h
@@ -38,8 +38,8 @@
38 * Handles a sent join message to ensure growth of the decentralized room structure. 38 * Handles a sent join message to ensure growth of the decentralized room structure.
39 * (if the service provides a peer message for this room currently, it will be forwarded) 39 * (if the service provides a peer message for this room currently, it will be forwarded)
40 * 40 *
41 * @param[in/out] room Room of the message 41 * @param[in,out] room Room of the message
42 * @param[in/out] handle Sending handle 42 * @param[in,out] handle Sending handle
43 * @param[in] message JOIN-Message 43 * @param[in] message JOIN-Message
44 * @param[in] hash Hash of the message 44 * @param[in] hash Hash of the message
45 */ 45 */
@@ -53,8 +53,8 @@ send_message_join (struct GNUNET_MESSENGER_SrvRoom *room,
53 * Handles a sent peer message to update the rooms peer message of this service. 53 * Handles a sent peer message to update the rooms peer message of this service.
54 * (a set peer message indicates this service being a part of the decentralized room structure) 54 * (a set peer message indicates this service being a part of the decentralized room structure)
55 * 55 *
56 * @param[in/out] room Room of the message 56 * @param[in,out] room Room of the message
57 * @param[in/out] handle Sending handle 57 * @param[in,out] handle Sending handle
58 * @param[in] message PEER-Message 58 * @param[in] message PEER-Message
59 * @param[in] hash Hash of the message 59 * @param[in] hash Hash of the message
60 */ 60 */
@@ -68,8 +68,8 @@ send_message_peer (struct GNUNET_MESSENGER_SrvRoom *room,
68 * Handles a sent id message to update the handles member id in the room. 68 * Handles a sent id message to update the handles member id in the room.
69 * (changing member id is useful to prevent collisions) 69 * (changing member id is useful to prevent collisions)
70 * 70 *
71 * @param[in/out] room Room of the message 71 * @param[in,out] room Room of the message
72 * @param[in/out] handle Sending handle 72 * @param[in,out] handle Sending handle
73 * @param[in] message ID-Message 73 * @param[in] message ID-Message
74 * @param[in] hash Hash of the message 74 * @param[in] hash Hash of the message
75 */ 75 */
@@ -83,8 +83,8 @@ send_message_id (struct GNUNET_MESSENGER_SrvRoom *room,
83 * Handles a sent request message to trigger the request operation for this service. 83 * Handles a sent request message to trigger the request operation for this service.
84 * (the request operation will deactivate the possibility of spamming requests) 84 * (the request operation will deactivate the possibility of spamming requests)
85 * 85 *
86 * @param[in/out] room Room of the message 86 * @param[in,out] room Room of the message
87 * @param[in/out] handle Sending handle 87 * @param[in,out] handle Sending handle
88 * @param[in] message PEER-Message 88 * @param[in] message PEER-Message
89 * @param[in] hash Hash of the message 89 * @param[in] hash Hash of the message
90 */ 90 */
diff --git a/src/messenger/gnunet-service-messenger_message_store.h b/src/messenger/gnunet-service-messenger_message_store.h
index 476d98dd5..60efb1380 100644
--- a/src/messenger/gnunet-service-messenger_message_store.h
+++ b/src/messenger/gnunet-service-messenger_message_store.h
@@ -69,7 +69,7 @@ init_message_store (struct GNUNET_MESSENGER_MessageStore *store);
69/** 69/**
70 * Clears a message <i>store</i>, wipes its content and deallocates its memory. 70 * Clears a message <i>store</i>, wipes its content and deallocates its memory.
71 * 71 *
72 * @param[in/out] store Message store 72 * @param[in,out] store Message store
73 */ 73 */
74void 74void
75clear_message_store (struct GNUNET_MESSENGER_MessageStore *store); 75clear_message_store (struct GNUNET_MESSENGER_MessageStore *store);
@@ -115,7 +115,7 @@ contains_store_message (const struct GNUNET_MESSENGER_MessageStore *store,
115 * This function requires the message to be loaded into memory! 115 * This function requires the message to be loaded into memory!
116 * @see contains_store_message() 116 * @see contains_store_message()
117 * 117 *
118 * @param[in/out] store Message store 118 * @param[in,out] store Message store
119 * @param[in] hash Hash of message 119 * @param[in] hash Hash of message
120 * @return Message or NULL 120 * @return Message or NULL
121 */ 121 */
@@ -131,7 +131,7 @@ get_store_message (struct GNUNET_MESSENGER_MessageStore *store,
131 * hash. The link which will be returned copies link information from the message for 131 * hash. The link which will be returned copies link information from the message for
132 * temporary usage. 132 * temporary usage.
133 * 133 *
134 * @param[in/out] store Message store 134 * @param[in,out] store Message store
135 * @param[in] hash Hash of message 135 * @param[in] hash Hash of message
136 * @param[in] deleted_only Flag 136 * @param[in] deleted_only Flag
137 * @return Message link or NULL 137 * @return Message link or NULL
@@ -144,9 +144,9 @@ get_store_message_link (struct GNUNET_MESSENGER_MessageStore *store,
144/** 144/**
145 * Stores a message into the message store. The result indicates if the operation was successful. 145 * Stores a message into the message store. The result indicates if the operation was successful.
146 * 146 *
147 * @param[in/out] store Message store 147 * @param[in,out] store Message store
148 * @param[in] hash Hash of message 148 * @param[in] hash Hash of message
149 * @param[in/out] message Message 149 * @param[in,out] message Message
150 * @return #GNUNET_OK on success, otherwise #GNUNET_NO 150 * @return #GNUNET_OK on success, otherwise #GNUNET_NO
151 */ 151 */
152int 152int
@@ -158,7 +158,7 @@ put_store_message (struct GNUNET_MESSENGER_MessageStore *store,
158 * Deletes a message in the message store. It will be removed from disk space and memory. The result 158 * Deletes a message in the message store. It will be removed from disk space and memory. The result
159 * indicates if the operation was successful. 159 * indicates if the operation was successful.
160 * 160 *
161 * @param[in/out] store Message store 161 * @param[in,out] store Message store
162 * @param[in] hash Hash of message 162 * @param[in] hash Hash of message
163 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure 163 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure
164 */ 164 */
diff --git a/src/messenger/gnunet-service-messenger_operation.h b/src/messenger/gnunet-service-messenger_operation.h
index 485668548..8d09ed1b7 100644
--- a/src/messenger/gnunet-service-messenger_operation.h
+++ b/src/messenger/gnunet-service-messenger_operation.h
@@ -66,7 +66,7 @@ create_operation (const struct GNUNET_HashCode *hash);
66/** 66/**
67 * Destroys an operation and frees its memory fully. 67 * Destroys an operation and frees its memory fully.
68 * 68 *
69 * @param[in/out] op Operation 69 * @param[in,out] op Operation
70 */ 70 */
71void 71void
72destroy_operation (struct GNUNET_MESSENGER_Operation *op); 72destroy_operation (struct GNUNET_MESSENGER_Operation *op);
@@ -82,7 +82,7 @@ destroy_operation (struct GNUNET_MESSENGER_Operation *op);
82 * If the method fails to restore any valid operation from the file, 82 * If the method fails to restore any valid operation from the file,
83 * NULL gets returned instead. 83 * NULL gets returned instead.
84 * 84 *
85 * @param[in/out] store Operation store 85 * @param[in,out] store Operation store
86 * @param[in] path Path of a configuration file 86 * @param[in] path Path of a configuration file
87 */ 87 */
88struct GNUNET_MESSENGER_Operation* 88struct GNUNET_MESSENGER_Operation*
@@ -107,9 +107,9 @@ save_operation (const struct GNUNET_MESSENGER_Operation *op,
107 * operations type to process it correctly. An operation can't be 107 * operations type to process it correctly. An operation can't be
108 * started twice, it has to be stopped or fully processed first. 108 * started twice, it has to be stopped or fully processed first.
109 * 109 *
110 * @param[in/out] op Operation 110 * @param[in,out] op Operation
111 * @param[in] type Type of operation 111 * @param[in] type Type of operation
112 * @param[in/out] store Operation store 112 * @param[in,out] store Operation store
113 * @param[in] delay Delay 113 * @param[in] delay Delay
114 * @return #GNUNET_OK on success, otherwise #GNUNET_SYSERR 114 * @return #GNUNET_OK on success, otherwise #GNUNET_SYSERR
115 */ 115 */
diff --git a/src/messenger/gnunet-service-messenger_operation_store.h b/src/messenger/gnunet-service-messenger_operation_store.h
index 18eb7f8a1..db315f251 100644
--- a/src/messenger/gnunet-service-messenger_operation_store.h
+++ b/src/messenger/gnunet-service-messenger_operation_store.h
@@ -45,7 +45,7 @@ struct GNUNET_MESSENGER_OperationStore
45 * Initializes an operation <i>store</i> as fully empty with a given <i>room</i>. 45 * Initializes an operation <i>store</i> as fully empty with a given <i>room</i>.
46 * 46 *
47 * @param[out] store Operation store 47 * @param[out] store Operation store
48 * @param[in/out] room Room 48 * @param[in,out] room Room
49 */ 49 */
50void 50void
51init_operation_store (struct GNUNET_MESSENGER_OperationStore *store, 51init_operation_store (struct GNUNET_MESSENGER_OperationStore *store,
@@ -54,7 +54,7 @@ init_operation_store (struct GNUNET_MESSENGER_OperationStore *store,
54/** 54/**
55 * Clears an operation <i>store</i>, stops all operations and deallocates its memory. 55 * Clears an operation <i>store</i>, stops all operations and deallocates its memory.
56 * 56 *
57 * @param[in/out] store Operation store 57 * @param[in,out] store Operation store
58 */ 58 */
59void 59void
60clear_operation_store (struct GNUNET_MESSENGER_OperationStore *store); 60clear_operation_store (struct GNUNET_MESSENGER_OperationStore *store);
@@ -103,7 +103,7 @@ get_store_operation_type (const struct GNUNET_MESSENGER_OperationStore *store,
103 * If the new operation could be started successfully the method returns 103 * If the new operation could be started successfully the method returns
104 * #GNUNET_OK, otherwise #GNUNET_SYSERR. 104 * #GNUNET_OK, otherwise #GNUNET_SYSERR.
105 * 105 *
106 * @param[in/out] store Operation store 106 * @param[in,out] store Operation store
107 * @param[in] hash Hash of message 107 * @param[in] hash Hash of message
108 * @param[in] type Operation type 108 * @param[in] type Operation type
109 * @param[in] delay Delay 109 * @param[in] delay Delay
@@ -122,7 +122,7 @@ use_store_operation (struct GNUNET_MESSENGER_OperationStore *store,
122 * Beware that calling this method will also implicitly free the memory 122 * Beware that calling this method will also implicitly free the memory
123 * of any active operation under the given hash! 123 * of any active operation under the given hash!
124 * 124 *
125 * @param[in/out] store Operation store 125 * @param[in,out] store Operation store
126 * @param[in] hash Hash of message 126 * @param[in] hash Hash of message
127 */ 127 */
128void 128void
diff --git a/src/messenger/gnunet-service-messenger_room.h b/src/messenger/gnunet-service-messenger_room.h
index a6ae45275..6767d96cb 100644
--- a/src/messenger/gnunet-service-messenger_room.h
+++ b/src/messenger/gnunet-service-messenger_room.h
@@ -84,7 +84,7 @@ struct GNUNET_MESSENGER_SrvRoom
84/** 84/**
85 * Creates and allocates a new room for a <i>handle</i> with a given <i>key</i>. 85 * Creates and allocates a new room for a <i>handle</i> with a given <i>key</i>.
86 * 86 *
87 * @param[in/out] handle Handle 87 * @param[in,out] handle Handle
88 * @param[in] key Key of room 88 * @param[in] key Key of room
89 * @return New room 89 * @return New room
90 */ 90 */
@@ -98,7 +98,7 @@ create_srv_room (struct GNUNET_MESSENGER_SrvHandle *handle,
98 * The <i>deletion</i> flag should only be set to #GNUNET_YES if the 98 * The <i>deletion</i> flag should only be set to #GNUNET_YES if the
99 * room gets dropped by the service, otherwise #GNUNET_NO. 99 * room gets dropped by the service, otherwise #GNUNET_NO.
100 * 100 *
101 * @param[in/out] room Room 101 * @param[in,out] room Room
102 * @param[in] deletion Flag to indicate context of destruction 102 * @param[in] deletion Flag to indicate context of destruction
103 */ 103 */
104void 104void
@@ -108,7 +108,7 @@ destroy_srv_room (struct GNUNET_MESSENGER_SrvRoom *room,
108/** 108/**
109 * Returns the used member store of a given <i>room</i>. 109 * Returns the used member store of a given <i>room</i>.
110 * 110 *
111 * @param[in/out] room Room 111 * @param[in,out] room Room
112 * @return Member store 112 * @return Member store
113 */ 113 */
114struct GNUNET_MESSENGER_MemberStore* 114struct GNUNET_MESSENGER_MemberStore*
@@ -117,7 +117,7 @@ get_srv_room_member_store (struct GNUNET_MESSENGER_SrvRoom *room);
117/** 117/**
118 * Returns the used message store of a given <i>room</i>. 118 * Returns the used message store of a given <i>room</i>.
119 * 119 *
120 * @param[in/out] room Room 120 * @param[in,out] room Room
121 * @return Message store 121 * @return Message store
122 */ 122 */
123struct GNUNET_MESSENGER_MessageStore* 123struct GNUNET_MESSENGER_MessageStore*
@@ -126,7 +126,7 @@ get_srv_room_message_store (struct GNUNET_MESSENGER_SrvRoom *room);
126/** 126/**
127 * Returns the used operation store of a given <i>room</i>. 127 * Returns the used operation store of a given <i>room</i>.
128 * 128 *
129 * @param[in/out] room Room 129 * @param[in,out] room Room
130 * @return Operation store 130 * @return Operation store
131 */ 131 */
132struct GNUNET_MESSENGER_OperationStore* 132struct GNUNET_MESSENGER_OperationStore*
@@ -140,8 +140,8 @@ get_srv_room_operation_store (struct GNUNET_MESSENGER_SrvRoom *room);
140 * 140 *
141 * If the function returns #GNUNET_YES the port for this room is guaranteed to be open for incoming connections. 141 * If the function returns #GNUNET_YES the port for this room is guaranteed to be open for incoming connections.
142 * 142 *
143 * @param[in/out] room Room 143 * @param[in,out] room Room
144 * @param[in/out] handle Handle 144 * @param[in,out] handle Handle
145 * @return #GNUNET_YES on success, #GNUNET_NO on failure. 145 * @return #GNUNET_YES on success, #GNUNET_NO on failure.
146 */ 146 */
147int 147int
@@ -153,8 +153,8 @@ open_srv_room (struct GNUNET_MESSENGER_SrvRoom *room,
153 * a peer identity of a hosting peer. During the connection the handle will join the room as a member, waiting for 153 * a peer identity of a hosting peer. During the connection the handle will join the room as a member, waiting for
154 * an info message from the selected host. 154 * an info message from the selected host.
155 * 155 *
156 * @param[in/out] room Room 156 * @param[in,out] room Room
157 * @param[in/out] handle Handle 157 * @param[in,out] handle Handle
158 * @param[in] door Peer identity 158 * @param[in] door Peer identity
159 * @return #GNUNET_YES on success, #GNUNET_NO on failure. 159 * @return #GNUNET_YES on success, #GNUNET_NO on failure.
160 */ 160 */
@@ -175,7 +175,7 @@ enter_srv_room_at (struct GNUNET_MESSENGER_SrvRoom *room,
175 * 175 *
176 * @param[in] room Room 176 * @param[in] room Room
177 * @param[in] handle Handle 177 * @param[in] handle Handle
178 * @param[in/out] message Message 178 * @param[in,out] message Message
179 * @param[out] hash Hash of message 179 * @param[out] hash Hash of message
180 * @param[in] mode Packing mode 180 * @param[in] mode Packing mode
181 * @return New envelope or NULL 181 * @return New envelope or NULL
@@ -197,9 +197,9 @@ pack_srv_room_message (const struct GNUNET_MESSENGER_SrvRoom *room,
197 * The function returns #GNUNET_YES on success, #GNUNET_NO if message is null and 197 * The function returns #GNUNET_YES on success, #GNUNET_NO if message is null and
198 * #GNUNET_SYSERR if the message was known already. 198 * #GNUNET_SYSERR if the message was known already.
199 * 199 *
200 * @param[in/out] room Room 200 * @param[in,out] room Room
201 * @param[in/out] handle Handle 201 * @param[in,out] handle Handle
202 * @param[in/out] message Message 202 * @param[in,out] message Message
203 * @return #GNUNET_YES on success, #GNUNET_NO or #GNUNET_SYSERR otherwise. 203 * @return #GNUNET_YES on success, #GNUNET_NO or #GNUNET_SYSERR otherwise.
204 */ 204 */
205int 205int
@@ -210,9 +210,9 @@ send_srv_room_message (struct GNUNET_MESSENGER_SrvRoom *room,
210/** 210/**
211 * Forwards a <i>message</i> with a given <i>hash</i> to a specific <i>tunnel</i> inside of a <i>room</i>. 211 * Forwards a <i>message</i> with a given <i>hash</i> to a specific <i>tunnel</i> inside of a <i>room</i>.
212 * 212 *
213 * @param[in/out] room Room 213 * @param[in,out] room Room
214 * @param[in/out] tunnel Tunnel 214 * @param[in,out] tunnel Tunnel
215 * @param[in/out] message Message 215 * @param[in,out] message Message
216 * @param[in] hash Hash of message 216 * @param[in] hash Hash of message
217 */ 217 */
218void 218void
@@ -226,8 +226,8 @@ forward_srv_room_message (struct GNUNET_MESSENGER_SrvRoom *room,
226 * if necessary to a selected <i>tunnel</i> or to all connected tunnels if necessary or if the 226 * if necessary to a selected <i>tunnel</i> or to all connected tunnels if necessary or if the
227 * selected tunnel is NULL. 227 * selected tunnel is NULL.
228 * 228 *
229 * @param[in/out] room Room 229 * @param[in,out] room Room
230 * @param[in/out] tunnel Tunnel 230 * @param[in,out] tunnel Tunnel
231 */ 231 */
232void 232void
233check_srv_room_peer_status (struct GNUNET_MESSENGER_SrvRoom *room, 233check_srv_room_peer_status (struct GNUNET_MESSENGER_SrvRoom *room,
@@ -237,8 +237,8 @@ check_srv_room_peer_status (struct GNUNET_MESSENGER_SrvRoom *room,
237 * Reduces all current forks inside of the message history of a <i>room</i> to one remaining last message 237 * Reduces all current forks inside of the message history of a <i>room</i> to one remaining last message
238 * by merging them down. All merge messages will be sent from a given <i>handle</i>. 238 * by merging them down. All merge messages will be sent from a given <i>handle</i>.
239 * 239 *
240 * @param[in/out] room Room 240 * @param[in,out] room Room
241 * @param[in/out] handle Handle 241 * @param[in,out] handle Handle
242 */ 242 */
243void 243void
244merge_srv_room_last_messages (struct GNUNET_MESSENGER_SrvRoom *room, 244merge_srv_room_last_messages (struct GNUNET_MESSENGER_SrvRoom *room,
@@ -248,8 +248,8 @@ merge_srv_room_last_messages (struct GNUNET_MESSENGER_SrvRoom *room,
248 * Deletes a message from the <i>room</i> with a given <i>hash</i> in a specific <i>delay</i> if 248 * Deletes a message from the <i>room</i> with a given <i>hash</i> in a specific <i>delay</i> if
249 * the provided member by its session is permitted to do so. 249 * the provided member by its session is permitted to do so.
250 * 250 *
251 * @param[in/out] room Room 251 * @param[in,out] room Room
252 * @param[in/out] session Member session 252 * @param[in,out] session Member session
253 * @param[in] hash Hash of message 253 * @param[in] hash Hash of message
254 * @param[in] delay Delay of deletion 254 * @param[in] delay Delay of deletion
255 * @return #GNUNET_YES on success, #GNUNET_NO if permission gets denied, #GNUNET_SYSERR on operation failure 255 * @return #GNUNET_YES on success, #GNUNET_NO if permission gets denied, #GNUNET_SYSERR on operation failure
@@ -263,7 +263,7 @@ delete_srv_room_message (struct GNUNET_MESSENGER_SrvRoom *room,
263/** 263/**
264 * Returns the CADET handle from a rooms service. 264 * Returns the CADET handle from a rooms service.
265 * 265 *
266 * @param[in/out] room Room 266 * @param[in,out] room Room
267 * @return CADET handle 267 * @return CADET handle
268 */ 268 */
269struct GNUNET_CADET_Handle* 269struct GNUNET_CADET_Handle*
@@ -293,8 +293,8 @@ get_srv_room_tunnel (const struct GNUNET_MESSENGER_SrvRoom *room,
293/** 293/**
294 * Method called whenever a <i>message</i> is found during a request in a <i>room</i>. 294 * Method called whenever a <i>message</i> is found during a request in a <i>room</i>.
295 * 295 *
296 * @param[in/out] cls Closure from #request_room_message 296 * @param[in,out] cls Closure from #request_room_message
297 * @param[in/out] room Room 297 * @param[in,out] room Room
298 * @param[in] message Message or NULL 298 * @param[in] message Message or NULL
299 * @param[in] hash Hash of message 299 * @param[in] hash Hash of message
300 */ 300 */
@@ -314,7 +314,7 @@ typedef void (GNUNET_MESSENGER_MessageRequestCallback) (
314 * It is also possible that the given callback will not be called if the requesting session is not 314 * It is also possible that the given callback will not be called if the requesting session is not
315 * permitted! 315 * permitted!
316 * 316 *
317 * @param[in/out] room Room 317 * @param[in,out] room Room
318 * @param[in] hash Hash of message 318 * @param[in] hash Hash of message
319 * @param[in] callback Callback to process result 319 * @param[in] callback Callback to process result
320 * @param[in] cls Closure for the <i>callback</i> 320 * @param[in] cls Closure for the <i>callback</i>
@@ -331,7 +331,7 @@ request_srv_room_message (struct GNUNET_MESSENGER_SrvRoom *room,
331 * Checks for potential collisions with member ids and solves them changing active handles ids if they 331 * Checks for potential collisions with member ids and solves them changing active handles ids if they
332 * use an already used member id (comparing public key and timestamp). 332 * use an already used member id (comparing public key and timestamp).
333 * 333 *
334 * @param[in/out] room Room 334 * @param[in,out] room Room
335 * @param[in] public_key Public key of EGO 335 * @param[in] public_key Public key of EGO
336 * @param[in] member_id Member ID 336 * @param[in] member_id Member ID
337 * @param[in] timestamp Timestamp 337 * @param[in] timestamp Timestamp
@@ -346,7 +346,7 @@ solve_srv_room_member_collisions (struct GNUNET_MESSENGER_SrvRoom *room,
346 * Rebuilds the decentralized structure for a <i>room</i> by ensuring all required connections are made 346 * Rebuilds the decentralized structure for a <i>room</i> by ensuring all required connections are made
347 * depending on the amount of peers and this peers index in the list of them. 347 * depending on the amount of peers and this peers index in the list of them.
348 * 348 *
349 * @param[in/out] room Room 349 * @param[in,out] room Room
350 */ 350 */
351void 351void
352rebuild_srv_room_basement_structure (struct GNUNET_MESSENGER_SrvRoom *room); 352rebuild_srv_room_basement_structure (struct GNUNET_MESSENGER_SrvRoom *room);
diff --git a/src/messenger/gnunet-service-messenger_service.h b/src/messenger/gnunet-service-messenger_service.h
index d364a93c0..55e8b6c50 100644
--- a/src/messenger/gnunet-service-messenger_service.h
+++ b/src/messenger/gnunet-service-messenger_service.h
@@ -64,7 +64,7 @@ struct GNUNET_MESSENGER_Service
64 * Creates and allocates a new service using a given <i>config</i> and a GNUnet service handle. 64 * Creates and allocates a new service using a given <i>config</i> and a GNUnet service handle.
65 * 65 *
66 * @param[in] config Configuration 66 * @param[in] config Configuration
67 * @param[in/out] service_handle GNUnet service handle 67 * @param[in,out] service_handle GNUnet service handle
68 * @return New service 68 * @return New service
69 */ 69 */
70struct GNUNET_MESSENGER_Service* 70struct GNUNET_MESSENGER_Service*
@@ -74,7 +74,7 @@ create_service (const struct GNUNET_CONFIGURATION_Handle *config,
74/** 74/**
75 * Destroys a <i>service</i> and frees its memory fully. 75 * Destroys a <i>service</i> and frees its memory fully.
76 * 76 *
77 * @param[in/out] service Service 77 * @param[in,out] service Service
78 */ 78 */
79void 79void
80destroy_service (struct GNUNET_MESSENGER_Service *service); 80destroy_service (struct GNUNET_MESSENGER_Service *service);
@@ -82,7 +82,7 @@ destroy_service (struct GNUNET_MESSENGER_Service *service);
82/** 82/**
83 * Returns the used EGO-store of a given <i>service</i>. 83 * Returns the used EGO-store of a given <i>service</i>.
84 * 84 *
85 * @param[in/out] service Service 85 * @param[in,out] service Service
86 * @return EGO-store 86 * @return EGO-store
87 */ 87 */
88struct GNUNET_MESSENGER_EgoStore* 88struct GNUNET_MESSENGER_EgoStore*
@@ -91,7 +91,7 @@ get_service_ego_store (struct GNUNET_MESSENGER_Service *service);
91/** 91/**
92 * Returns the used contact store of a given <i>service</i>. 92 * Returns the used contact store of a given <i>service</i>.
93 * 93 *
94 * @param[in/out] service Service 94 * @param[in,out] service Service
95 * @return Contact store 95 * @return Contact store
96 */ 96 */
97struct GNUNET_MESSENGER_ContactStore* 97struct GNUNET_MESSENGER_ContactStore*
@@ -100,8 +100,8 @@ get_service_contact_store (struct GNUNET_MESSENGER_Service *service);
100/** 100/**
101 * Creates and adds a new handle to a <i>service</i> using a given message queue. 101 * Creates and adds a new handle to a <i>service</i> using a given message queue.
102 * 102 *
103 * @param[in/out] service Service 103 * @param[in,out] service Service
104 * @param[in/out] mq Message queue 104 * @param[in,out] mq Message queue
105 * @return New handle 105 * @return New handle
106 */ 106 */
107struct GNUNET_MESSENGER_SrvHandle* 107struct GNUNET_MESSENGER_SrvHandle*
@@ -111,8 +111,8 @@ add_service_handle (struct GNUNET_MESSENGER_Service *service,
111/** 111/**
112 * Removes a <i>handle</i> from a <i>service</i> and destroys it. 112 * Removes a <i>handle</i> from a <i>service</i> and destroys it.
113 * 113 *
114 * @param[in/out] service Service 114 * @param[in,out] service Service
115 * @param[in/out] handle Handle 115 * @param[in,out] handle Handle
116 */ 116 */
117void 117void
118remove_service_handle (struct GNUNET_MESSENGER_Service *service, 118remove_service_handle (struct GNUNET_MESSENGER_Service *service,
@@ -146,8 +146,8 @@ get_service_room (const struct GNUNET_MESSENGER_Service *service,
146 * Tries to open a room using a given <i>key</i> for a <i>service</i> by a specific <i>handle</i>. The room will be 146 * Tries to open a room using a given <i>key</i> for a <i>service</i> by a specific <i>handle</i>. The room will be
147 * created if necessary. If the function is successful, it returns #GNUNET_YES, otherwise #GNUNET_NO. 147 * created if necessary. If the function is successful, it returns #GNUNET_YES, otherwise #GNUNET_NO.
148 * 148 *
149 * @param[in/out] service Service 149 * @param[in,out] service Service
150 * @param[in/out] handle Handle 150 * @param[in,out] handle Handle
151 * @param[in] key Key of room 151 * @param[in] key Key of room
152 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 152 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
153 */ 153 */
@@ -163,8 +163,8 @@ open_service_room (struct GNUNET_MESSENGER_Service *service,
163 * The room will be entered through the peer identitied by the peer identity provided as <i>door</i> parameter and 163 * The room will be entered through the peer identitied by the peer identity provided as <i>door</i> parameter and
164 * a new connection will be made. 164 * a new connection will be made.
165 * 165 *
166 * @param[in/out] service Service 166 * @param[in,out] service Service
167 * @param[in/out] handle Handle 167 * @param[in,out] handle Handle
168 * @param[in] door Peer identity 168 * @param[in] door Peer identity
169 * @param[in] key Key of room 169 * @param[in] key Key of room
170 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 170 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
@@ -182,8 +182,8 @@ entry_service_room (struct GNUNET_MESSENGER_Service *service,
182 * If the specific handle is currently the host of the room for this service, a new handle which is a member will 182 * If the specific handle is currently the host of the room for this service, a new handle which is a member will
183 * take its place. Otherwise the room will be destroyed for this service. 183 * take its place. Otherwise the room will be destroyed for this service.
184 * 184 *
185 * @param[in/out] service Service 185 * @param[in,out] service Service
186 * @param[in/out] handle Handle 186 * @param[in,out] handle Handle
187 * @param[in] key Key of room 187 * @param[in] key Key of room
188 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 188 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
189 */ 189 */
@@ -196,8 +196,8 @@ close_service_room (struct GNUNET_MESSENGER_Service *service,
196 * Sends a received or sent <i>message</i> with a given <i>hash</i> to each handle of a <i>service</i> which 196 * Sends a received or sent <i>message</i> with a given <i>hash</i> to each handle of a <i>service</i> which
197 * is currently member of a specific <i>room</i> for handling it in the client API. 197 * is currently member of a specific <i>room</i> for handling it in the client API.
198 * 198 *
199 * @param[in/out] service Service 199 * @param[in,out] service Service
200 * @param[in/out] room Room 200 * @param[in,out] room Room
201 * @param[in] session Member session 201 * @param[in] session Member session
202 * @param[in] message Message 202 * @param[in] message Message
203 * @param[in] hash Hash of message 203 * @param[in] hash Hash of message
diff --git a/src/messenger/gnunet-service-messenger_tunnel.h b/src/messenger/gnunet-service-messenger_tunnel.h
index 7bd749281..13cf924f9 100644
--- a/src/messenger/gnunet-service-messenger_tunnel.h
+++ b/src/messenger/gnunet-service-messenger_tunnel.h
@@ -50,7 +50,7 @@ struct GNUNET_MESSENGER_SrvTunnel
50/** 50/**
51 * Creates and allocates a tunnel of a <i>room</i> to a specific peer identity (called <i>door</i>). 51 * Creates and allocates a tunnel of a <i>room</i> to a specific peer identity (called <i>door</i>).
52 * 52 *
53 * @param[in/out] room Room 53 * @param[in,out] room Room
54 * @param[in] door Peer identity 54 * @param[in] door Peer identity
55 * @return New tunnel 55 * @return New tunnel
56 */ 56 */
@@ -61,7 +61,7 @@ create_tunnel (struct GNUNET_MESSENGER_SrvRoom *room,
61/** 61/**
62 * Destroys a <i>tunnel</i> and frees its memory fully. 62 * Destroys a <i>tunnel</i> and frees its memory fully.
63 * 63 *
64 * @param[in/out] tunnel 64 * @param[in,out] tunnel
65 */ 65 */
66void 66void
67destroy_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel); 67destroy_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel);
@@ -70,8 +70,8 @@ destroy_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel);
70 * Binds a CADET <i>channel</i> to a <i>tunnel</i> and replaces its channel 70 * Binds a CADET <i>channel</i> to a <i>tunnel</i> and replaces its channel
71 * the tunnel is currently bound to if necessary. 71 * the tunnel is currently bound to if necessary.
72 * 72 *
73 * @param[in/out] tunnel Tunnel 73 * @param[in,out] tunnel Tunnel
74 * @param[in/out] channel CADET channel 74 * @param[in,out] channel CADET channel
75 */ 75 */
76void 76void
77bind_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel, 77bind_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel,
@@ -81,7 +81,7 @@ bind_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel,
81 * Tries to connect a <i>tunnel</i> by creating a new CADET channel and binding it. 81 * Tries to connect a <i>tunnel</i> by creating a new CADET channel and binding it.
82 * The function returns #GNUNET_YES on success, otherwise #GNUNET_NO. 82 * The function returns #GNUNET_YES on success, otherwise #GNUNET_NO.
83 * 83 *
84 * @param[in/out] tunnel Tunnel 84 * @param[in,out] tunnel Tunnel
85 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 85 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
86 */ 86 */
87int 87int
@@ -91,7 +91,7 @@ connect_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel);
91 * Disconnects and unbinds a channel from a <i>tunnel</i>. The actual disconnection 91 * Disconnects and unbinds a channel from a <i>tunnel</i>. The actual disconnection
92 * will be asynchronous. 92 * will be asynchronous.
93 * 93 *
94 * @param[in/out] tunnel Tunnel 94 * @param[in,out] tunnel Tunnel
95 */ 95 */
96void 96void
97disconnect_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel); 97disconnect_tunnel (struct GNUNET_MESSENGER_SrvTunnel *tunnel);
@@ -109,8 +109,8 @@ is_tunnel_connected (const struct GNUNET_MESSENGER_SrvTunnel *tunnel);
109 * Sends an envelope containing a <i>message</i> with a given <i>hash</i> through 109 * Sends an envelope containing a <i>message</i> with a given <i>hash</i> through
110 * a <i>tunnel</i>. 110 * a <i>tunnel</i>.
111 * 111 *
112 * @param[in/out] tunnel Tunnel 112 * @param[in,out] tunnel Tunnel
113 * @param[in/out] env Envelope 113 * @param[in,out] env Envelope
114 * @param[in] hash Hash of message 114 * @param[in] hash Hash of message
115 */ 115 */
116void 116void
@@ -123,9 +123,9 @@ send_tunnel_envelope (struct GNUNET_MESSENGER_SrvTunnel *tunnel,
123 * through the <i>tunnel</i>. The used <i>handle</i> will sign the message and 123 * through the <i>tunnel</i>. The used <i>handle</i> will sign the message and
124 * the <i>hash</i> will be calculated and stored. 124 * the <i>hash</i> will be calculated and stored.
125 * 125 *
126 * @param[in/out] tunnel Tunnel 126 * @param[in,out] tunnel Tunnel
127 * @param[in/out] handle Handle 127 * @param[in,out] handle Handle
128 * @param[in/out] message Message 128 * @param[in,out] message Message
129 * @return #GNUNET_YES on success, GNUNET_NO otherwise 129 * @return #GNUNET_YES on success, GNUNET_NO otherwise
130 */ 130 */
131int 131int
@@ -136,7 +136,7 @@ send_tunnel_message (struct GNUNET_MESSENGER_SrvTunnel *tunnel,
136/** 136/**
137 * Forwards a given <i>message</i> with a known <i>hash</i> through a <i>tunnel</i>. 137 * Forwards a given <i>message</i> with a known <i>hash</i> through a <i>tunnel</i>.
138 * 138 *
139 * @param[in/out] tunnel Tunnel 139 * @param[in,out] tunnel Tunnel
140 * @param[in] message Message 140 * @param[in] message Message
141 * @param[in] hash Hash of message 141 * @param[in] hash Hash of message
142 */ 142 */
@@ -184,7 +184,7 @@ get_tunnel_messenger_version (const struct GNUNET_MESSENGER_SrvTunnel *tunnel);
184 * it is compatible to the running peer of the service. Depending on success it 184 * it is compatible to the running peer of the service. Depending on success it
185 * returns #GNUNET_OK or #GNUNET_SYSERR on failure. 185 * returns #GNUNET_OK or #GNUNET_SYSERR on failure.
186 * 186 *
187 * @param[in/out] tunnel Tunnel 187 * @param[in,out] tunnel Tunnel
188 * @param[in] version Version of messenger 188 * @param[in] version Version of messenger
189 */ 189 */
190int 190int
diff --git a/src/messenger/messenger_api_contact.h b/src/messenger/messenger_api_contact.h
index b5410f998..6619d8fa2 100644
--- a/src/messenger/messenger_api_contact.h
+++ b/src/messenger/messenger_api_contact.h
@@ -50,7 +50,7 @@ create_contact (const struct GNUNET_IDENTITY_PublicKey *key);
50/** 50/**
51 * Destroys a contact and frees its memory fully. 51 * Destroys a contact and frees its memory fully.
52 * 52 *
53 * @param[in/out] contact Contact 53 * @param[in,out] contact Contact
54 */ 54 */
55void 55void
56destroy_contact (struct GNUNET_MESSENGER_Contact *contact); 56destroy_contact (struct GNUNET_MESSENGER_Contact *contact);
@@ -67,7 +67,7 @@ get_contact_name (const struct GNUNET_MESSENGER_Contact *contact);
67/** 67/**
68 * Changes the current name of a given <i>contact</i> by copying it from the parameter <i>name</i>. 68 * Changes the current name of a given <i>contact</i> by copying it from the parameter <i>name</i>.
69 * 69 *
70 * @param[in/out] contact Contact 70 * @param[in,out] contact Contact
71 * @param[in] name Name 71 * @param[in] name Name
72 */ 72 */
73void 73void
@@ -86,7 +86,7 @@ get_contact_key (const struct GNUNET_MESSENGER_Contact *contact);
86/** 86/**
87 * Increases the reference counter of a given <i>contact</i> which is zero as default. 87 * Increases the reference counter of a given <i>contact</i> which is zero as default.
88 * 88 *
89 * @param[in/out] contact Contact 89 * @param[in,out] contact Contact
90 */ 90 */
91void 91void
92increase_contact_rc (struct GNUNET_MESSENGER_Contact *contact); 92increase_contact_rc (struct GNUNET_MESSENGER_Contact *contact);
@@ -95,7 +95,7 @@ increase_contact_rc (struct GNUNET_MESSENGER_Contact *contact);
95 * Decreases the reference counter if possible (can not underflow!) of a given <i>contact</i> 95 * Decreases the reference counter if possible (can not underflow!) of a given <i>contact</i>
96 * and returns #GNUNET_YES if the counter is equal to zero, otherwise #GNUNET_NO. 96 * and returns #GNUNET_YES if the counter is equal to zero, otherwise #GNUNET_NO.
97 * 97 *
98 * @param[in/out] contact Contact 98 * @param[in,out] contact Contact
99 * @return #GNUNET_YES or #GNUNET_NO depending on the reference counter 99 * @return #GNUNET_YES or #GNUNET_NO depending on the reference counter
100 */ 100 */
101int 101int
@@ -106,7 +106,7 @@ decrease_contact_rc (struct GNUNET_MESSENGER_Contact *contact);
106 * 106 *
107 * @param[in] key Key of room 107 * @param[in] key Key of room
108 * @param[in] id Member id 108 * @param[in] id Member id
109 * @param[out] hash Member context 109 * @param[out] context Member context
110 */ 110 */
111void 111void
112get_context_from_member (const struct GNUNET_HashCode *key, 112get_context_from_member (const struct GNUNET_HashCode *key,
diff --git a/src/messenger/messenger_api_contact_store.h b/src/messenger/messenger_api_contact_store.h
index bdab2ceeb..1cdd3197b 100644
--- a/src/messenger/messenger_api_contact_store.h
+++ b/src/messenger/messenger_api_contact_store.h
@@ -50,7 +50,7 @@ init_contact_store (struct GNUNET_MESSENGER_ContactStore *store);
50/** 50/**
51 * Clears a contact store, wipes its content and deallocates its memory. 51 * Clears a contact store, wipes its content and deallocates its memory.
52 * 52 *
53 * @param[in/out] store Contact store 53 * @param[in,out] store Contact store
54 */ 54 */
55void 55void
56clear_contact_store (struct GNUNET_MESSENGER_ContactStore *store); 56clear_contact_store (struct GNUNET_MESSENGER_ContactStore *store);
@@ -63,7 +63,7 @@ clear_contact_store (struct GNUNET_MESSENGER_ContactStore *store);
63 * In case there is no contact stored which uses the given key or context, 63 * In case there is no contact stored which uses the given key or context,
64 * NULL gets returned. 64 * NULL gets returned.
65 * 65 *
66 * @param[in/out] store Contact store 66 * @param[in,out] store Contact store
67 * @param[in] context Member context 67 * @param[in] context Member context
68 * @param[in] key_hash Hash of public key 68 * @param[in] key_hash Hash of public key
69 */ 69 */
@@ -83,7 +83,7 @@ get_store_contact_raw (struct GNUNET_MESSENGER_ContactStore *store,
83 * The function returns NULL if an error occurs during allocation 83 * The function returns NULL if an error occurs during allocation
84 * or validation of the contacts key. 84 * or validation of the contacts key.
85 * 85 *
86 * @param[in/out] store Contact store 86 * @param[in,out] store Contact store
87 * @param[in] context Member context 87 * @param[in] context Member context
88 * @param[in] pubkey Public key of EGO 88 * @param[in] pubkey Public key of EGO
89 */ 89 */
@@ -98,8 +98,8 @@ get_store_contact (struct GNUNET_MESSENGER_ContactStore *store,
98 * 98 *
99 * This function allows changes of keys or changes of member contexts! 99 * This function allows changes of keys or changes of member contexts!
100 * 100 *
101 * @param[in/out] store Contact store 101 * @param[in,out] store Contact store
102 * @param[in/out] contact Contact 102 * @param[in,out] contact Contact
103 * @param[in] context Member context 103 * @param[in] context Member context
104 * @param[in] next_context Member context 104 * @param[in] next_context Member context
105 * @param[in] pubkey Public key of EGO 105 * @param[in] pubkey Public key of EGO
@@ -115,8 +115,8 @@ update_store_contact (struct GNUNET_MESSENGER_ContactStore *store,
115 * Removes a <i>contact</i> from the <i>store</i> which uses 115 * Removes a <i>contact</i> from the <i>store</i> which uses
116 * a given member <i>context</i>. 116 * a given member <i>context</i>.
117 * 117 *
118 * @param[in/out] store Contact store 118 * @param[in,out] store Contact store
119 * @param[in/out] contact Contact 119 * @param[in,out] contact Contact
120 * @param[in] context Member context 120 * @param[in] context Member context
121 */ 121 */
122void 122void
diff --git a/src/messenger/messenger_api_handle.h b/src/messenger/messenger_api_handle.h
index 6a43f13a6..8430f40d5 100644
--- a/src/messenger/messenger_api_handle.h
+++ b/src/messenger/messenger_api_handle.h
@@ -67,7 +67,7 @@ struct GNUNET_MESSENGER_Handle
67 * 67 *
68 * @param[in] cfg Configuration 68 * @param[in] cfg Configuration
69 * @param[in] msg_callback Message callback 69 * @param[in] msg_callback Message callback
70 * @param[in/out] msg_cls Closure 70 * @param[in,out] msg_cls Closure
71 * @return New handle 71 * @return New handle
72 */ 72 */
73struct GNUNET_MESSENGER_Handle* 73struct GNUNET_MESSENGER_Handle*
@@ -80,7 +80,7 @@ create_handle (const struct GNUNET_CONFIGURATION_Handle *cfg,
80/** 80/**
81 * Destroys a <i>handle</i> and frees its memory fully from the client API. 81 * Destroys a <i>handle</i> and frees its memory fully from the client API.
82 * 82 *
83 * @param[in/out] handle Handle 83 * @param[in,out] handle Handle
84 */ 84 */
85void 85void
86destroy_handle (struct GNUNET_MESSENGER_Handle *handle); 86destroy_handle (struct GNUNET_MESSENGER_Handle *handle);
@@ -88,7 +88,7 @@ destroy_handle (struct GNUNET_MESSENGER_Handle *handle);
88/** 88/**
89 * Sets the name of a <i>handle</i> to a specific <i>name</i>. 89 * Sets the name of a <i>handle</i> to a specific <i>name</i>.
90 * 90 *
91 * @param[in/out] handle Handle 91 * @param[in,out] handle Handle
92 * @param[in] name New name 92 * @param[in] name New name
93 */ 93 */
94void 94void
@@ -107,7 +107,7 @@ get_handle_name (const struct GNUNET_MESSENGER_Handle *handle);
107/** 107/**
108 * Sets the public key of a given <i>handle</i> to a specific public key. 108 * Sets the public key of a given <i>handle</i> to a specific public key.
109 * 109 *
110 * @param[in/out] handle Handle 110 * @param[in,out] handle Handle
111 * @param[in] pubkey Public key 111 * @param[in] pubkey Public key
112 */ 112 */
113void 113void
@@ -126,7 +126,7 @@ get_handle_key (const struct GNUNET_MESSENGER_Handle *handle);
126/** 126/**
127 * Returns the used contact store of a given <i>handle</i>. 127 * Returns the used contact store of a given <i>handle</i>.
128 * 128 *
129 * @param[in/out] handle Handle 129 * @param[in,out] handle Handle
130 * @return Contact store 130 * @return Contact store
131 */ 131 */
132struct GNUNET_MESSENGER_ContactStore* 132struct GNUNET_MESSENGER_ContactStore*
@@ -136,7 +136,7 @@ get_handle_contact_store (struct GNUNET_MESSENGER_Handle *handle);
136 * Returns the contact of a given <i>handle</i> in a room identified by a 136 * Returns the contact of a given <i>handle</i> in a room identified by a
137 * given <i>key</i>. 137 * given <i>key</i>.
138 * 138 *
139 * @param[in/out] handle Handle 139 * @param[in,out] handle Handle
140 * @param[in] key Key of room 140 * @param[in] key Key of room
141 * @return Contact 141 * @return Contact
142 */ 142 */
@@ -147,7 +147,7 @@ get_handle_contact (struct GNUNET_MESSENGER_Handle *handle,
147/** 147/**
148 * Marks a room known to a <i>handle</i> identified by a given <i>key</i> as open. 148 * Marks a room known to a <i>handle</i> identified by a given <i>key</i> as open.
149 * 149 *
150 * @param[in/out] handle Handle 150 * @param[in,out] handle Handle
151 * @param[in] key Key of room 151 * @param[in] key Key of room
152 */ 152 */
153void 153void
@@ -158,7 +158,7 @@ open_handle_room (struct GNUNET_MESSENGER_Handle *handle,
158 * Adds a tunnel for a room known to a <i>handle</i> identified by a given <i>key</i> to a 158 * Adds a tunnel for a room known to a <i>handle</i> identified by a given <i>key</i> to a
159 * list of opened connections. 159 * list of opened connections.
160 * 160 *
161 * @param[in/out] handle Handle 161 * @param[in,out] handle Handle
162 * @param[in] door Peer identity 162 * @param[in] door Peer identity
163 * @param[in] key Key of room 163 * @param[in] key Key of room
164 */ 164 */
@@ -170,7 +170,7 @@ entry_handle_room_at (struct GNUNET_MESSENGER_Handle *handle,
170/** 170/**
171 * Destroys and so implicitly closes a room known to a <i>handle</i> identified by a given <i>key</i>. 171 * Destroys and so implicitly closes a room known to a <i>handle</i> identified by a given <i>key</i>.
172 * 172 *
173 * @param[in/out] handle Handle 173 * @param[in,out] handle Handle
174 * @param[in] key Key of room 174 * @param[in] key Key of room
175 */ 175 */
176void 176void
diff --git a/src/messenger/messenger_api_list_tunnels.h b/src/messenger/messenger_api_list_tunnels.h
index 0e086ee5e..e28935c3e 100644
--- a/src/messenger/messenger_api_list_tunnels.h
+++ b/src/messenger/messenger_api_list_tunnels.h
@@ -55,7 +55,7 @@ init_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels);
55/** 55/**
56 * Clears the list of tunnels peer identities. 56 * Clears the list of tunnels peer identities.
57 * 57 *
58 * @param[in/out] tunnels List of peer identities 58 * @param[in,out] tunnels List of peer identities
59 */ 59 */
60void 60void
61clear_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels); 61clear_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels);
@@ -63,7 +63,7 @@ clear_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels);
63/** 63/**
64 * Adds a specific <i>peer</i> from a tunnel to the end of the list. 64 * Adds a specific <i>peer</i> from a tunnel to the end of the list.
65 * 65 *
66 * @param[in/out] tunnels List of peer identities 66 * @param[in,out] tunnels List of peer identities
67 * @param[in] peer Peer identity of tunnel 67 * @param[in] peer Peer identity of tunnel
68 */ 68 */
69void 69void
@@ -80,7 +80,7 @@ add_to_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels,
80 * the found element in the list. If no matching element is found, <i>index</i> will 80 * the found element in the list. If no matching element is found, <i>index</i> will
81 * contain the total amount of elements in the list. 81 * contain the total amount of elements in the list.
82 * 82 *
83 * @param[in/out] tunnels List of peer identities 83 * @param[in,out] tunnels List of peer identities
84 * @param[in] peer Peer identity of tunnel 84 * @param[in] peer Peer identity of tunnel
85 * @param[out] index Index of found element (optional) 85 * @param[out] index Index of found element (optional)
86 * @return Element in the list with matching peer identity 86 * @return Element in the list with matching peer identity
@@ -94,7 +94,7 @@ find_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels,
94 * Tests linearly if the list of tunnels peer identities contains a specific 94 * Tests linearly if the list of tunnels peer identities contains a specific
95 * <i>peer</i> identity and returns #GNUNET_YES on success, otherwise #GNUNET_NO. 95 * <i>peer</i> identity and returns #GNUNET_YES on success, otherwise #GNUNET_NO.
96 * 96 *
97 * @param[in/out] tunnels List of peer identities 97 * @param[in,out] tunnels List of peer identities
98 * @param[in] peer Peer identity of tunnel 98 * @param[in] peer Peer identity of tunnel
99 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 99 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
100 */ 100 */
@@ -106,8 +106,8 @@ contains_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels,
106 * Removes a specific <i>element</i> from the list of tunnels peer identities and returns 106 * Removes a specific <i>element</i> from the list of tunnels peer identities and returns
107 * the next element in the list. 107 * the next element in the list.
108 * 108 *
109 * @param[in/out] tunnels List of peer identities 109 * @param[in,out] tunnels List of peer identities
110 * @param[in/out] element Element of the list 110 * @param[in,out] element Element of the list
111 * @return Next element in the list 111 * @return Next element in the list
112 */ 112 */
113struct GNUNET_MESSENGER_ListTunnel* 113struct GNUNET_MESSENGER_ListTunnel*
@@ -117,7 +117,7 @@ remove_from_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels,
117/** 117/**
118 * Loads the list of tunnels peer identities from a file under a given <i>path</i>. 118 * Loads the list of tunnels peer identities from a file under a given <i>path</i>.
119 * 119 *
120 * @param[out] messages List of hashes 120 * @param[out] tunnels List of hashes
121 * @param[in] path Path of file 121 * @param[in] path Path of file
122 */ 122 */
123void 123void
@@ -127,7 +127,7 @@ load_list_tunnels (struct GNUNET_MESSENGER_ListTunnels *tunnels,
127/** 127/**
128 * Saves the list of tunnels peer identities to a file under a given <i>path</i>. 128 * Saves the list of tunnels peer identities to a file under a given <i>path</i>.
129 * 129 *
130 * @param[in] messages List of hashes 130 * @param[in] tunnels List of hashes
131 * @param[in] path Path of file 131 * @param[in] path Path of file
132 */ 132 */
133void 133void
diff --git a/src/messenger/messenger_api_message.h b/src/messenger/messenger_api_message.h
index 46c5cb024..209d80a4e 100644
--- a/src/messenger/messenger_api_message.h
+++ b/src/messenger/messenger_api_message.h
@@ -64,7 +64,7 @@ copy_message (const struct GNUNET_MESSENGER_Message *message);
64/** 64/**
65 * Frees the messages body memory. 65 * Frees the messages body memory.
66 * 66 *
67 * @param[in/out] message Message 67 * @param[in,out] message Message
68 */ 68 */
69void 69void
70cleanup_message (struct GNUNET_MESSENGER_Message *message); 70cleanup_message (struct GNUNET_MESSENGER_Message *message);
@@ -72,7 +72,7 @@ cleanup_message (struct GNUNET_MESSENGER_Message *message);
72/** 72/**
73 * Destroys a message and frees its memory fully. 73 * Destroys a message and frees its memory fully.
74 * 74 *
75 * @param[in/out] message Message 75 * @param[in,out] message Message
76 */ 76 */
77void 77void
78destroy_message (struct GNUNET_MESSENGER_Message *message); 78destroy_message (struct GNUNET_MESSENGER_Message *message);
@@ -163,7 +163,7 @@ hash_message (const struct GNUNET_MESSENGER_Message *message,
163 * Signs the <i>hash</i> of a <i>message</i> with a given <i>ego</i> and writes the signature 163 * Signs the <i>hash</i> of a <i>message</i> with a given <i>ego</i> and writes the signature
164 * into the <i>buffer</i> as well. 164 * into the <i>buffer</i> as well.
165 * 165 *
166 * @param[in/out] message Message 166 * @param[in,out] message Message
167 * @param[in] length Length of buffer 167 * @param[in] length Length of buffer
168 * @param[out] buffer Buffer 168 * @param[out] buffer Buffer
169 * @param[in] hash Hash of message 169 * @param[in] hash Hash of message
@@ -196,7 +196,7 @@ verify_message (const struct GNUNET_MESSENGER_Message *message,
196 * and kind with the now private encrypted <i>message</i>. The function returns 196 * and kind with the now private encrypted <i>message</i>. The function returns
197 * #GNUNET_YES if the operation succeeded, otherwise #GNUNET_NO. 197 * #GNUNET_YES if the operation succeeded, otherwise #GNUNET_NO.
198 * 198 *
199 * @param[in/out] message Message 199 * @param[in,out] message Message
200 * @param[in] key Public key of EGO 200 * @param[in] key Public key of EGO
201 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 201 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
202 */ 202 */
@@ -209,7 +209,7 @@ encrypt_message (struct GNUNET_MESSENGER_Message *message,
209 * and kind with the inner encrypted message. The function returns #GNUNET_YES if the 209 * and kind with the inner encrypted message. The function returns #GNUNET_YES if the
210 * operation succeeded, otherwise #GNUNET_NO. 210 * operation succeeded, otherwise #GNUNET_NO.
211 * 211 *
212 * @param[in/out] message Message 212 * @param[in,out] message Message
213 * @param[in] key Private key of EGO 213 * @param[in] key Private key of EGO
214 * @return #GNUNET_YES on success, otherwise #GNUNET_NO 214 * @return #GNUNET_YES on success, otherwise #GNUNET_NO
215 */ 215 */
diff --git a/src/messenger/messenger_api_room.h b/src/messenger/messenger_api_room.h
index 320312f0c..cf8ab782b 100644
--- a/src/messenger/messenger_api_room.h
+++ b/src/messenger/messenger_api_room.h
@@ -59,7 +59,7 @@ struct GNUNET_MESSENGER_Room
59/** 59/**
60 * Creates and allocates a new room for a <i>handle</i> with a given <i>key</i> for the client API. 60 * Creates and allocates a new room for a <i>handle</i> with a given <i>key</i> for the client API.
61 * 61 *
62 * @param[in/out] handle Handle 62 * @param[in,out] handle Handle
63 * @param[in] key Key of room 63 * @param[in] key Key of room
64 * @return New room 64 * @return New room
65 */ 65 */
@@ -70,7 +70,7 @@ create_room (struct GNUNET_MESSENGER_Handle *handle,
70/** 70/**
71 * Destroys a room and frees its memory fully from the client API. 71 * Destroys a room and frees its memory fully from the client API.
72 * 72 *
73 * @param[in/out] room Room 73 * @param[in,out] room Room
74 */ 74 */
75void 75void
76destroy_room (struct GNUNET_MESSENGER_Room *room); 76destroy_room (struct GNUNET_MESSENGER_Room *room);
@@ -106,8 +106,8 @@ get_room_sender (const struct GNUNET_MESSENGER_Room *room,
106 * The contact of the message's sender could be updated or even created. It may not be freed or destroyed though! 106 * The contact of the message's sender could be updated or even created. It may not be freed or destroyed though!
107 * (The contact may still be in use for old messages...) 107 * (The contact may still be in use for old messages...)
108 * 108 *
109 * @param[in/out] room Room 109 * @param[in,out] room Room
110 * @param[in/out] sender Contact of sender 110 * @param[in,out] sender Contact of sender
111 * @param[in] message Message 111 * @param[in] message Message
112 * @param[in] hash Hash of message 112 * @param[in] hash Hash of message
113 * @return Contact of sender 113 * @return Contact of sender
@@ -122,9 +122,9 @@ handle_room_message (struct GNUNET_MESSENGER_Room *room,
122 * Iterates through all members of a given <i>room</i> to forward each of them to a selected 122 * Iterates through all members of a given <i>room</i> to forward each of them to a selected
123 * <i>callback</i> with a custom closure. 123 * <i>callback</i> with a custom closure.
124 * 124 *
125 * @param[in/out] room Room 125 * @param[in,out] room Room
126 * @param[in] callback Function called for each member 126 * @param[in] callback Function called for each member
127 * @param[in/out] cls Closure 127 * @param[in,out] cls Closure
128 * @return Amount of members iterated 128 * @return Amount of members iterated
129 */ 129 */
130int 130int
diff --git a/src/messenger/messenger_api_util.h b/src/messenger/messenger_api_util.h
index af64790b6..0597b94a8 100644
--- a/src/messenger/messenger_api_util.h
+++ b/src/messenger/messenger_api_util.h
@@ -37,7 +37,7 @@
37/** 37/**
38 * Starts an urgent task to close a CADET channel asynchronously. 38 * Starts an urgent task to close a CADET channel asynchronously.
39 * 39 *
40 * @param[in/out] channel Channel 40 * @param[in,out] channel Channel
41 */ 41 */
42void 42void
43delayed_disconnect_channel (struct GNUNET_CADET_Channel *channel); 43delayed_disconnect_channel (struct GNUNET_CADET_Channel *channel);
diff --git a/src/messenger/testing_messenger_barrier.h b/src/messenger/testing_messenger_barrier.h
index 3062a393a..5ea0fe137 100644
--- a/src/messenger/testing_messenger_barrier.h
+++ b/src/messenger/testing_messenger_barrier.h
@@ -62,7 +62,7 @@ typedef void
62 * GNUNET_wait_barrier(). 62 * GNUNET_wait_barrier().
63 * @param cb the callback to call when the pseudo-barrier is reached or upon 63 * @param cb the callback to call when the pseudo-barrier is reached or upon
64 * error. Can be NULL. 64 * error. Can be NULL.
65 * @param cls closure for the above callback 65 * @param cb_cls closure for the above callback
66 * @return pseudo-barrier handle; NULL upon error 66 * @return pseudo-barrier handle; NULL upon error
67 */ 67 */
68struct GNUNET_BarrierHandle* 68struct GNUNET_BarrierHandle*
@@ -108,7 +108,7 @@ typedef void
108 * 108 *
109 * @param barrier the pseudo-barrier handle 109 * @param barrier the pseudo-barrier handle
110 * @param cb the pseudo-barrier wait callback 110 * @param cb the pseudo-barrier wait callback
111 * @param cls the closure for the above callback 111 * @param cb_cls the closure for the above callback
112 * @return pseudo-barrier wait handle which can be used to cancel the waiting 112 * @return pseudo-barrier wait handle which can be used to cancel the waiting
113 * at anytime before the callback is called. NULL upon error. 113 * at anytime before the callback is called. NULL upon error.
114 */ 114 */
diff --git a/src/my/my_query_helper.c b/src/my/my_query_helper.c
index 97ea04fd1..e44caad91 100644
--- a/src/my/my_query_helper.c
+++ b/src/my/my_query_helper.c
@@ -48,7 +48,7 @@ my_clean_query (void *cls,
48 * Function called to convert input argument into SQL parameters. 48 * Function called to convert input argument into SQL parameters.
49 * 49 *
50 * @param cls closure 50 * @param cls closure
51 * @param pq data about the query 51 * @param qp data about the query
52 * @param qbind array of parameters to initialize 52 * @param qbind array of parameters to initialize
53 * @return -1 on error 53 * @return -1 on error
54 */ 54 */
@@ -95,7 +95,7 @@ GNUNET_MY_query_param_fixed_size (const void *ptr,
95 * Function called to convert input argument into SQL parameters. 95 * Function called to convert input argument into SQL parameters.
96 * 96 *
97 * @param cls closure 97 * @param cls closure
98 * @param pq data about the query 98 * @param qp data about the query
99 * @param qbind array of parameters to initialize 99 * @param qbind array of parameters to initialize
100 * @return -1 on error 100 * @return -1 on error
101 */ 101 */
@@ -138,7 +138,7 @@ GNUNET_MY_query_param_string (const char *ptr)
138 * Function called to convert input argument into SQL parameters 138 * Function called to convert input argument into SQL parameters
139 * 139 *
140 * @param cls closure 140 * @param cls closure
141 * @param pq data about the query 141 * @param qp data about the query
142 * @param qbind array of parameters to initialize 142 * @param qbind array of parameters to initialize
143 * @return -1 on error 143 * @return -1 on error
144 */ 144 */
@@ -182,7 +182,7 @@ GNUNET_MY_query_param_uint16 (const uint16_t *x)
182 * Function called to convert input argument into SQL parameters 182 * Function called to convert input argument into SQL parameters
183 * 183 *
184 * @param cls closure 184 * @param cls closure
185 * @param pq data about the query 185 * @param qp data about the query
186 * @param qbind array of parameters to initialize 186 * @param qbind array of parameters to initialize
187 * @return -1 on error 187 * @return -1 on error
188 */ 188 */
@@ -226,7 +226,7 @@ GNUNET_MY_query_param_uint32 (const uint32_t *x)
226 * Function called to convert input argument into SQL parameters 226 * Function called to convert input argument into SQL parameters
227 * 227 *
228 * @param cls closure 228 * @param cls closure
229 * @param pq data about the query 229 * @param qp data about the query
230 * @param qbind array of parameters to initialize 230 * @param qbind array of parameters to initialize
231 * @return -1 on error 231 * @return -1 on error
232 */ 232 */
@@ -270,7 +270,7 @@ GNUNET_MY_query_param_uint64 (const uint64_t *x)
270 * Function called to convert input argument into SQL parameters 270 * Function called to convert input argument into SQL parameters
271 * 271 *
272 * @param cls closure 272 * @param cls closure
273 * @param pq data about the query 273 * @param qp data about the query
274 * @param qbind array of parameters to initialize 274 * @param qbind array of parameters to initialize
275 * @return -1 on error 275 * @return -1 on error
276 */ 276 */
@@ -322,7 +322,7 @@ GNUNET_MY_query_param_rsa_public_key (const struct
322 * Function called to convert input argument into SQL parameters 322 * Function called to convert input argument into SQL parameters
323 * 323 *
324 *@param cls closure 324 *@param cls closure
325 *@param pq data about the query 325 *@param qp data about the query
326 *@param qbind array of parameters to initialize 326 *@param qbind array of parameters to initialize
327 *@return -1 on error 327 *@return -1 on error
328 */ 328 */
diff --git a/src/my/my_result_helper.c b/src/my/my_result_helper.c
index 99b4229a4..e500c0b27 100644
--- a/src/my/my_result_helper.c
+++ b/src/my/my_result_helper.c
@@ -129,13 +129,6 @@ cleanup_varsize_blob (void *cls,
129} 129}
130 130
131 131
132/**
133 * Variable-size result expected
134 *
135 * @param[out] dst where to store the result, allocated
136 * @param[out] ptr_size where to store the size of @a dst
137 * @return array entru for the result specification to use
138 */
139struct GNUNET_MY_ResultSpec 132struct GNUNET_MY_ResultSpec
140GNUNET_MY_result_spec_variable_size (void **dst, 133GNUNET_MY_result_spec_variable_size (void **dst,
141 size_t *ptr_size) 134 size_t *ptr_size)
@@ -531,7 +524,7 @@ pre_extract_string (void *cls,
531 524
532 525
533/** 526/**
534 * Check size of extracted fixed size data from a Mysql database @a 527 * Check size of extracted fixed size data from a Mysql database
535 * 528 *
536 * @param cls closure 529 * @param cls closure
537 * @param[in,out] rs 530 * @param[in,out] rs
@@ -715,7 +708,6 @@ GNUNET_MY_result_spec_uint16 (uint16_t *u16)
715 * Extract data from a MYSQL database @a result at row @a row 708 * Extract data from a MYSQL database @a result at row @a row
716 * 709 *
717 * @param cls closure 710 * @param cls closure
718 * @param cls closure
719 * @param[in,out] rs 711 * @param[in,out] rs
720 * @param stmt the mysql statement that is being run 712 * @param stmt the mysql statement that is being run
721 * @param column the column that is being processed 713 * @param column the column that is being processed
@@ -746,7 +738,6 @@ pre_extract_uint32 (void *cls,
746 * Extract data from a MYSQL database @a result at row @a row 738 * Extract data from a MYSQL database @a result at row @a row
747 * 739 *
748 * @param cls closure 740 * @param cls closure
749 * @param cls closure
750 * @param[in,out] rs 741 * @param[in,out] rs
751 * @param stmt the mysql statement that is being run 742 * @param stmt the mysql statement that is being run
752 * @param column the column that is being processed 743 * @param column the column that is being processed
diff --git a/src/mysql/mysql.c b/src/mysql/mysql.c
index 738659864..4c701905c 100644
--- a/src/mysql/mysql.c
+++ b/src/mysql/mysql.c
@@ -430,7 +430,6 @@ GNUNET_MYSQL_statement_run (struct GNUNET_MYSQL_Context *mc, const char *sql)
430/** 430/**
431 * Prepare a statement for running. 431 * Prepare a statement for running.
432 * 432 *
433 * @param mc mysql context
434 * @param sh statement handle to prepare 433 * @param sh statement handle to prepare
435 * @return #GNUNET_OK on success 434 * @return #GNUNET_OK on success
436 */ 435 */
diff --git a/src/namecache/gnunet-service-namecache.c b/src/namecache/gnunet-service-namecache.c
index 07bf30de9..0d95cddfb 100644
--- a/src/namecache/gnunet-service-namecache.c
+++ b/src/namecache/gnunet-service-namecache.c
@@ -211,7 +211,7 @@ handle_lookup_block_it (void *cls,
211 * Handles a #GNUNET_MESSAGE_TYPE_NAMECACHE_LOOKUP_BLOCK message 211 * Handles a #GNUNET_MESSAGE_TYPE_NAMECACHE_LOOKUP_BLOCK message
212 * 212 *
213 * @param cls a `struct NamecacheClient *` 213 * @param cls a `struct NamecacheClient *`
214 * @param the inbound message 214 * @param ln_msg the inbound message
215 */ 215 */
216static void 216static void
217handle_lookup_block (void *cls, 217handle_lookup_block (void *cls,
diff --git a/src/namecache/namecache_api.c b/src/namecache/namecache_api.c
index 70c848037..5e820f8cc 100644
--- a/src/namecache/namecache_api.c
+++ b/src/namecache/namecache_api.c
@@ -259,7 +259,6 @@ handle_lookup_block_response (void *cls,
259 * 259 *
260 * @param cls the `struct GNUNET_NAMECACHE_Handle` 260 * @param cls the `struct GNUNET_NAMECACHE_Handle`
261 * @param msg the message we received 261 * @param msg the message we received
262 * @param size the message size
263 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error and we did NOT notify the client 262 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error and we did NOT notify the client
264 */ 263 */
265static void 264static void
diff --git a/src/namestore/gnunet-namestore-fcfsd.c b/src/namestore/gnunet-namestore-fcfsd.c
index 7e96ffa43..4a9c6e874 100644
--- a/src/namestore/gnunet-namestore-fcfsd.c
+++ b/src/namestore/gnunet-namestore-fcfsd.c
@@ -1137,7 +1137,7 @@ run_service (void *cls,
1137 * The main function of the fcfs daemon. 1137 * The main function of the fcfs daemon.
1138 * 1138 *
1139 * @param argc number of arguments from the command line 1139 * @param argc number of arguments from the command line
1140 * @parsm argv the command line arguments 1140 * @param argv the command line arguments
1141 * @return 0 successful exit, a different value otherwise 1141 * @return 0 successful exit, a different value otherwise
1142 */ 1142 */
1143int 1143int
diff --git a/src/namestore/gnunet-namestore.c b/src/namestore/gnunet-namestore.c
index af40f2dbe..9ed8f400c 100644
--- a/src/namestore/gnunet-namestore.c
+++ b/src/namestore/gnunet-namestore.c
@@ -849,8 +849,8 @@ del_monitor (void *cls,
849 * Parse expiration time. 849 * Parse expiration time.
850 * 850 *
851 * @param expirationstring text to parse 851 * @param expirationstring text to parse
852 * @param etime_is_rel[out] set to #GNUNET_YES if time is relative 852 * @param[out] etime_is_rel set to #GNUNET_YES if time is relative
853 * @param etime[out] set to expiration time (abs or rel) 853 * @param[out] etime set to expiration time (abs or rel)
854 * @return #GNUNET_OK on success 854 * @return #GNUNET_OK on success
855 */ 855 */
856static int 856static int
diff --git a/src/namestore/gnunet-service-namestore.c b/src/namestore/gnunet-service-namestore.c
index 305fe79f0..9b6428872 100644
--- a/src/namestore/gnunet-service-namestore.c
+++ b/src/namestore/gnunet-service-namestore.c
@@ -604,8 +604,8 @@ get_nick_record (const struct GNUNET_IDENTITY_PrivateKey *zone)
604 * @param nick_rd the nick record to integrate 604 * @param nick_rd the nick record to integrate
605 * @param rd2_length length of the @a rd2 array 605 * @param rd2_length length of the @a rd2 array
606 * @param rd2 array of records 606 * @param rd2 array of records
607 * @param rdc_res[out] length of the resulting @a rd_res array 607 * @param[out] rdc_res length of the resulting @a rd_res array
608 * @param rd_res[out] set to an array of records, 608 * @param[out] rd_res set to an array of records,
609 * including @a nick_rd and @a rd2; 609 * including @a nick_rd and @a rd2;
610 * all of the variable-size 'data' fields in @a rd2 are 610 * all of the variable-size 'data' fields in @a rd2 are
611 * allocated in the same chunk of memory! 611 * allocated in the same chunk of memory!
@@ -824,7 +824,7 @@ send_lookup_response (struct NamestoreClient *nc,
824/** 824/**
825 * Send response to the store request to the client. 825 * Send response to the store request to the client.
826 * 826 *
827 * @param client client to talk to 827 * @param nc client to talk to
828 * @param res status of the operation 828 * @param res status of the operation
829 * @param rid client's request ID 829 * @param rid client's request ID
830 */ 830 */
@@ -1195,7 +1195,7 @@ struct RecordLookupContext
1195 * 1195 *
1196 * @param cls closure with a `struct RecordLookupContext` 1196 * @param cls closure with a `struct RecordLookupContext`
1197 * @param seq unique serial number of the record, MUST NOT BE ZERO 1197 * @param seq unique serial number of the record, MUST NOT BE ZERO
1198 * @param zone_key private key of the zone 1198 * @param private_key private key of the zone
1199 * @param label name that is being mapped (at most 255 characters long) 1199 * @param label name that is being mapped (at most 255 characters long)
1200 * @param rd_count number of entries in @a rd array 1200 * @param rd_count number of entries in @a rd array
1201 * @param rd array of records with data to store 1201 * @param rd array of records with data to store
@@ -2123,7 +2123,7 @@ handle_iteration_stop (void *cls,
2123 * Handles a #GNUNET_MESSAGE_TYPE_NAMESTORE_ZONE_ITERATION_NEXT message 2123 * Handles a #GNUNET_MESSAGE_TYPE_NAMESTORE_ZONE_ITERATION_NEXT message
2124 * 2124 *
2125 * @param cls the client sending the message 2125 * @param cls the client sending the message
2126 * @param message message from the client 2126 * @param zis_msg message from the client
2127 */ 2127 */
2128static void 2128static void
2129handle_iteration_next (void *cls, 2129handle_iteration_next (void *cls,
diff --git a/src/namestore/gnunet-zoneimport.c b/src/namestore/gnunet-zoneimport.c
index 68b43a016..9ae0fb146 100644
--- a/src/namestore/gnunet-zoneimport.c
+++ b/src/namestore/gnunet-zoneimport.c
@@ -437,7 +437,7 @@ get_label (struct Request *req)
437 * Build DNS query for @a hostname. 437 * Build DNS query for @a hostname.
438 * 438 *
439 * @param hostname host to build query for 439 * @param hostname host to build query for
440 * @param raw_size[out] number of bytes in the query 440 * @param[out] raw_size number of bytes in the query
441 * @return NULL on error, otherwise pointer to statically (!) 441 * @return NULL on error, otherwise pointer to statically (!)
442 * allocated query buffer 442 * allocated query buffer
443 */ 443 */
diff --git a/src/namestore/plugin_namestore_flat.c b/src/namestore/plugin_namestore_flat.c
new file mode 100644
index 000000000..3249d524a
--- /dev/null
+++ b/src/namestore/plugin_namestore_flat.c
@@ -0,0 +1,818 @@
1/*
2 * This file is part of GNUnet
3 * Copyright (C) 2009-2015, 2018, 2019 GNUnet e.V.
4 *
5 * GNUnet is free software: you can redistribute it and/or modify it
6 * under the terms of the GNU Affero General Public License as published
7 * by the Free Software Foundation, either version 3 of the License,
8 * or (at your option) any later version.
9 *
10 * GNUnet is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Affero General Public License for more details.
14 *
15 * You should have received a copy of the GNU Affero General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17
18 SPDX-License-Identifier: AGPL3.0-or-later
19 */
20/**
21 * @file namestore/plugin_namestore_flat.c
22 * @brief file-based namestore backend
23 * @author Martin Schanzenbach
24 * @author Christian Grothoff
25 */
26
27#include "platform.h"
28#include "gnunet_namestore_plugin.h"
29#include "gnunet_namestore_service.h"
30#include "gnunet_gnsrecord_lib.h"
31#include "namestore.h"
32
33/**
34 * Context for all functions in this plugin.
35 */
36struct Plugin
37{
38 const struct GNUNET_CONFIGURATION_Handle *cfg;
39
40 /**
41 * Database filename.
42 */
43 char *fn;
44
45 /**
46 * HashMap
47 */
48 struct GNUNET_CONTAINER_MultiHashMap *hm;
49};
50
51
52struct FlatFileEntry
53{
54 /**
55 * Entry zone
56 */
57 struct GNUNET_IDENTITY_PrivateKey private_key;
58
59 /**
60 * Record count.
61 */
62 uint32_t record_count;
63
64 /**
65 * Rvalue
66 */
67 uint64_t rvalue;
68
69 /**
70 * Record data
71 */
72 struct GNUNET_GNSRECORD_Data *record_data;
73
74 /**
75 * Label
76 */
77 char *label;
78};
79
80
81/**
82 * Hash contactenation of @a pkey and @a label into @a h
83 *
84 * @param pkey a key
85 * @param label a label
86 * @param[out] h initialized hash
87 */
88static void
89hash_pkey_and_label (const struct GNUNET_IDENTITY_PrivateKey *pkey,
90 const char *label,
91 struct GNUNET_HashCode *h)
92{
93 char *key;
94 size_t label_len;
95 size_t key_len;
96
97 label_len = strlen (label);
98 key_len = label_len + sizeof(struct GNUNET_IDENTITY_PrivateKey);
99 key = GNUNET_malloc (key_len);
100 GNUNET_memcpy (key,
101 label,
102 label_len);
103 GNUNET_memcpy (key + label_len,
104 pkey,
105 sizeof(struct GNUNET_IDENTITY_PrivateKey));
106 GNUNET_CRYPTO_hash (key,
107 key_len,
108 h);
109 GNUNET_free (key);
110}
111
112
113/**
114 * Initialize the database connections and associated
115 * data structures (create tables and indices
116 * as needed as well).
117 *
118 * @param plugin the plugin context (state for this module)
119 * @return #GNUNET_OK on success
120 */
121static int
122database_setup (struct Plugin *plugin)
123{
124 char *flatdbfile;
125 char *record_data;
126 char *zone_private_key;
127 char *record_data_b64;
128 char *buffer;
129 char *line;
130 char *label;
131 char *rvalue;
132 char *record_count;
133 size_t record_data_size;
134 uint64_t size;
135 struct GNUNET_HashCode hkey;
136 struct GNUNET_DISK_FileHandle *fh;
137 struct FlatFileEntry *entry;
138 struct GNUNET_DISK_MapHandle *mh;
139
140 if (GNUNET_OK !=
141 GNUNET_CONFIGURATION_get_value_filename (plugin->cfg,
142 "namestore-flat",
143 "FILENAME",
144 &flatdbfile))
145 {
146 GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
147 "namestore-flat",
148 "FILENAME");
149 return GNUNET_SYSERR;
150 }
151 if (GNUNET_OK !=
152 GNUNET_DISK_file_test (flatdbfile))
153 {
154 if (GNUNET_OK !=
155 GNUNET_DISK_directory_create_for_file (flatdbfile))
156 {
157 GNUNET_break (0);
158 GNUNET_free (flatdbfile);
159 return GNUNET_SYSERR;
160 }
161 }
162 /* flatdbfile should be UTF-8-encoded. If it isn't, it's a bug */
163 plugin->fn = flatdbfile;
164
165 /* Load data from file into hashmap */
166 plugin->hm = GNUNET_CONTAINER_multihashmap_create (10,
167 GNUNET_NO);
168 fh = GNUNET_DISK_file_open (flatdbfile,
169 GNUNET_DISK_OPEN_CREATE
170 | GNUNET_DISK_OPEN_READWRITE,
171 GNUNET_DISK_PERM_USER_WRITE
172 | GNUNET_DISK_PERM_USER_READ);
173 if (NULL == fh)
174 {
175 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
176 _ ("Unable to initialize file: %s.\n"),
177 flatdbfile);
178 return GNUNET_SYSERR;
179 }
180 if (GNUNET_SYSERR ==
181 GNUNET_DISK_file_size (flatdbfile,
182 &size,
183 GNUNET_YES,
184 GNUNET_YES))
185 {
186 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
187 _ ("Unable to get filesize: %s.\n"),
188 flatdbfile);
189 GNUNET_DISK_file_close (fh);
190 return GNUNET_SYSERR;
191 }
192 if (size > SIZE_MAX)
193 {
194 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
195 _ ("File too big to map: %llu bytes.\n"),
196 (unsigned long long) size);
197 GNUNET_DISK_file_close (fh);
198 return GNUNET_SYSERR;
199 }
200 if (0 == size)
201 {
202 GNUNET_DISK_file_close (fh);
203 return GNUNET_OK;
204 }
205 buffer = GNUNET_DISK_file_map (fh,
206 &mh,
207 GNUNET_DISK_MAP_TYPE_READ,
208 size);
209 if (NULL == buffer)
210 {
211 GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR,
212 "mmap");
213 GNUNET_DISK_file_close (fh);
214 return GNUNET_SYSERR;
215 }
216 if ('\0' != buffer[size - 1])
217 {
218 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
219 _ ("Namestore database file `%s' malformed\n"),
220 flatdbfile);
221 GNUNET_DISK_file_unmap (mh);
222 GNUNET_DISK_file_close (fh);
223 return GNUNET_SYSERR;
224 }
225
226 line = strtok (buffer, "\n");
227 while (NULL != line)
228 {
229 zone_private_key = strtok (line, ",");
230 if (NULL == zone_private_key)
231 break;
232 rvalue = strtok (NULL, ",");
233 if (NULL == rvalue)
234 break;
235 record_count = strtok (NULL, ",");
236 if (NULL == record_count)
237 break;
238 record_data_b64 = strtok (NULL, ",");
239 if (NULL == record_data_b64)
240 break;
241 label = strtok (NULL, ",");
242 if (NULL == label)
243 break;
244 line = strtok (NULL, "\n");
245 entry = GNUNET_new (struct FlatFileEntry);
246 {
247 unsigned long long ll;
248
249 if (1 != sscanf (rvalue,
250 "%llu",
251 &ll))
252 {
253 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
254 "Error parsing entry\n");
255 GNUNET_free (entry);
256 break;
257 }
258 entry->rvalue = (uint64_t) ll;
259 }
260 {
261 unsigned int ui;
262
263 if (1 != sscanf (record_count,
264 "%u",
265 &ui))
266 {
267 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
268 "Error parsing entry\n");
269 GNUNET_free (entry);
270 break;
271 }
272 entry->record_count = (uint32_t) ui;
273 }
274 entry->label = GNUNET_strdup (label);
275 record_data_size
276 = GNUNET_STRINGS_base64_decode (record_data_b64,
277 strlen (record_data_b64),
278 (void **) &record_data);
279 entry->record_data =
280 GNUNET_new_array (entry->record_count,
281 struct GNUNET_GNSRECORD_Data);
282 if (GNUNET_OK !=
283 GNUNET_GNSRECORD_records_deserialize (record_data_size,
284 record_data,
285 entry->record_count,
286 entry->record_data))
287 {
288 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
289 "Unable to deserialize record %s\n",
290 label);
291 GNUNET_free (entry->label);
292 GNUNET_free (entry);
293 GNUNET_free (record_data);
294 break;
295 }
296 GNUNET_free (record_data);
297
298 {
299 struct GNUNET_IDENTITY_PrivateKey *private_key;
300
301 GNUNET_STRINGS_base64_decode (zone_private_key,
302 strlen (zone_private_key),
303 (void **) &private_key);
304 entry->private_key = *private_key;
305 GNUNET_free (private_key);
306 }
307
308 hash_pkey_and_label (&entry->private_key,
309 label,
310 &hkey);
311 if (GNUNET_OK !=
312 GNUNET_CONTAINER_multihashmap_put (plugin->hm,
313 &hkey,
314 entry,
315 GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY))
316 {
317 GNUNET_free (entry);
318 GNUNET_break (0);
319 }
320 }
321 GNUNET_DISK_file_unmap (mh);
322 GNUNET_DISK_file_close (fh);
323 return GNUNET_OK;
324}
325
326
327/**
328 * Store values in hashmap in file and free data
329 *
330 * @param plugin the plugin context
331 * @param key key in the map
332 * @param value a `struct FlatFileEntry`
333 */
334static int
335store_and_free_entries (void *cls,
336 const struct GNUNET_HashCode *key,
337 void *value)
338{
339 struct GNUNET_DISK_FileHandle *fh = cls;
340 struct FlatFileEntry *entry = value;
341 char *line;
342 char *zone_private_key;
343 char *record_data_b64;
344 ssize_t data_size;
345
346 (void) key;
347 GNUNET_STRINGS_base64_encode (&entry->private_key,
348 sizeof(struct GNUNET_IDENTITY_PrivateKey),
349 &zone_private_key);
350 data_size = GNUNET_GNSRECORD_records_get_size (entry->record_count,
351 entry->record_data);
352 if (data_size < 0)
353 {
354 GNUNET_break (0);
355 GNUNET_free (zone_private_key);
356 return GNUNET_SYSERR;
357 }
358 if (data_size >= UINT16_MAX)
359 {
360 GNUNET_break (0);
361 GNUNET_free (zone_private_key);
362 return GNUNET_SYSERR;
363 }
364 {
365 char data[data_size];
366 ssize_t ret;
367
368 ret = GNUNET_GNSRECORD_records_serialize (entry->record_count,
369 entry->record_data,
370 data_size,
371 data);
372 if ((ret < 0) ||
373 (data_size != ret))
374 {
375 GNUNET_break (0);
376 GNUNET_free (zone_private_key);
377 return GNUNET_SYSERR;
378 }
379 GNUNET_STRINGS_base64_encode (data,
380 data_size,
381 &record_data_b64);
382 }
383 GNUNET_asprintf (&line,
384 "%s,%llu,%u,%s,%s\n",
385 zone_private_key,
386 (unsigned long long) entry->rvalue,
387 (unsigned int) entry->record_count,
388 record_data_b64,
389 entry->label);
390 GNUNET_free (record_data_b64);
391 GNUNET_free (zone_private_key);
392
393 GNUNET_DISK_file_write (fh,
394 line,
395 strlen (line));
396
397 GNUNET_free (line);
398 GNUNET_free (entry->label);
399 GNUNET_free (entry->record_data);
400 GNUNET_free (entry);
401 return GNUNET_YES;
402}
403
404
405/**
406 * Shutdown database connection and associate data
407 * structures.
408 * @param plugin the plugin context (state for this module)
409 */
410static void
411database_shutdown (struct Plugin *plugin)
412{
413 struct GNUNET_DISK_FileHandle *fh;
414
415 fh = GNUNET_DISK_file_open (plugin->fn,
416 GNUNET_DISK_OPEN_CREATE
417 | GNUNET_DISK_OPEN_TRUNCATE
418 | GNUNET_DISK_OPEN_READWRITE,
419 GNUNET_DISK_PERM_USER_WRITE
420 | GNUNET_DISK_PERM_USER_READ);
421 if (NULL == fh)
422 {
423 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
424 _ ("Unable to initialize file: %s.\n"),
425 plugin->fn);
426 return;
427 }
428
429 GNUNET_CONTAINER_multihashmap_iterate (plugin->hm,
430 &store_and_free_entries,
431 fh);
432 GNUNET_CONTAINER_multihashmap_destroy (plugin->hm);
433 /* append 0-terminator */
434 GNUNET_DISK_file_write (fh,
435 "",
436 1);
437 GNUNET_DISK_file_close (fh);
438}
439
440
441/**
442 * Store a record in the datastore. Removes any existing record in the
443 * same zone with the same name.
444 *
445 * @param cls closure (internal context for the plugin)
446 * @param zone_key private key of the zone
447 * @param label name that is being mapped (at most 255 characters long)
448 * @param rd_count number of entries in @a rd array
449 * @param rd array of records with data to store
450 * @return #GNUNET_OK on success, else #GNUNET_SYSERR
451 */
452static int
453namestore_flat_store_records (void *cls,
454 const struct
455 GNUNET_IDENTITY_PrivateKey *zone_key,
456 const char *label,
457 unsigned int rd_count,
458 const struct GNUNET_GNSRECORD_Data *rd)
459{
460 struct Plugin *plugin = cls;
461 uint64_t rvalue;
462 struct GNUNET_HashCode hkey;
463 struct FlatFileEntry *entry;
464
465 rvalue = GNUNET_CRYPTO_random_u64 (GNUNET_CRYPTO_QUALITY_WEAK,
466 UINT64_MAX);
467 hash_pkey_and_label (zone_key,
468 label,
469 &hkey);
470 GNUNET_CONTAINER_multihashmap_remove_all (plugin->hm,
471 &hkey);
472 if (0 == rd_count)
473 {
474 GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG,
475 "sqlite",
476 "Record deleted\n");
477 return GNUNET_OK;
478 }
479 entry = GNUNET_new (struct FlatFileEntry);
480 GNUNET_asprintf (&entry->label,
481 label,
482 strlen (label));
483 GNUNET_memcpy (&entry->private_key,
484 zone_key,
485 sizeof(struct GNUNET_IDENTITY_PrivateKey));
486 entry->rvalue = rvalue;
487 entry->record_count = rd_count;
488 entry->record_data = GNUNET_new_array (rd_count,
489 struct GNUNET_GNSRECORD_Data);
490 for (unsigned int i = 0; i < rd_count; i++)
491 {
492 entry->record_data[i].expiration_time = rd[i].expiration_time;
493 entry->record_data[i].record_type = rd[i].record_type;
494 entry->record_data[i].flags = rd[i].flags;
495 entry->record_data[i].data_size = rd[i].data_size;
496 entry->record_data[i].data = GNUNET_malloc (rd[i].data_size);
497 GNUNET_memcpy ((char *) entry->record_data[i].data,
498 rd[i].data,
499 rd[i].data_size);
500 }
501 return GNUNET_CONTAINER_multihashmap_put (plugin->hm,
502 &hkey,
503 entry,
504 GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_ONLY);
505}
506
507
508/**
509 * Lookup records in the datastore for which we are the authority.
510 *
511 * @param cls closure (internal context for the plugin)
512 * @param zone private key of the zone
513 * @param label name of the record in the zone
514 * @param iter function to call with the result
515 * @param iter_cls closure for @a iter
516 * @return #GNUNET_OK on success, #GNUNET_NO for no results, else #GNUNET_SYSERR
517 */
518static int
519namestore_flat_lookup_records (void *cls,
520 const struct GNUNET_IDENTITY_PrivateKey *zone,
521 const char *label,
522 GNUNET_NAMESTORE_RecordIterator iter,
523 void *iter_cls)
524{
525 struct Plugin *plugin = cls;
526 struct FlatFileEntry *entry;
527 struct GNUNET_HashCode hkey;
528
529 if (NULL == zone)
530 {
531 GNUNET_break (0);
532 return GNUNET_SYSERR;
533 }
534 hash_pkey_and_label (zone,
535 label,
536 &hkey);
537 entry = GNUNET_CONTAINER_multihashmap_get (plugin->hm,
538 &hkey);
539
540 if (NULL == entry)
541 return GNUNET_NO;
542 if (NULL != iter)
543 iter (iter_cls,
544 1, /* zero is illegal */
545 &entry->private_key,
546 entry->label,
547 entry->record_count,
548 entry->record_data);
549 return GNUNET_YES;
550}
551
552
553/**
554 * Closure for #iterate_zones.
555 */
556struct IterateContext
557{
558 /**
559 * How many more records should we skip before returning results?
560 */
561 uint64_t offset;
562
563 /**
564 * How many more records should we return?
565 */
566 uint64_t limit;
567
568 /**
569 * What is the position of the current entry, counting
570 * starts from 1.
571 */
572 uint64_t pos;
573
574 /**
575 * Target zone.
576 */
577 const struct GNUNET_IDENTITY_PrivateKey *zone;
578
579 /**
580 * Function to call on each record.
581 */
582 GNUNET_NAMESTORE_RecordIterator iter;
583
584 /**
585 * Closure for @e iter.
586 */
587 void *iter_cls;
588};
589
590
591/**
592 * Helper function for #namestore_flat_iterate_records().
593 *
594 * @param cls a `struct IterateContext`
595 * @param key unused
596 * @param value a `struct FlatFileEntry`
597 * @return #GNUNET_YES to continue the iteration
598 */
599static int
600iterate_zones (void *cls,
601 const struct GNUNET_HashCode *key,
602 void *value)
603{
604 struct IterateContext *ic = cls;
605 struct FlatFileEntry *entry = value;
606
607 (void) key;
608 if (0 == ic->limit)
609 return GNUNET_NO;
610 if ((NULL != ic->zone) &&
611 (0 != GNUNET_memcmp (&entry->private_key,
612 ic->zone)))
613 return GNUNET_YES;
614 ic->pos++;
615 if (ic->offset > 0)
616 {
617 ic->offset--;
618 return GNUNET_YES;
619 }
620 ic->iter (ic->iter_cls,
621 ic->pos,
622 (NULL == ic->zone)
623 ? &entry->private_key
624 : ic->zone,
625 entry->label,
626 entry->record_count,
627 entry->record_data);
628 ic->limit--;
629 if (0 == ic->limit)
630 return GNUNET_NO;
631 return GNUNET_YES;
632}
633
634
635/**
636 * Iterate over the results for a particular key and zone in the
637 * datastore. Will return at most one result to the iterator.
638 *
639 * @param cls closure (internal context for the plugin)
640 * @param zone hash of public key of the zone, NULL to iterate over all zones
641 * @param serial serial number to exclude in the list of all matching records
642 * @param limit maximum number of results to return to @a iter
643 * @param iter function to call with the result
644 * @param iter_cls closure for @a iter
645 * @return #GNUNET_OK on success, #GNUNET_NO if there were no more results, #GNUNET_SYSERR on error
646 */
647static int
648namestore_flat_iterate_records (void *cls,
649 const struct
650 GNUNET_IDENTITY_PrivateKey *zone,
651 uint64_t serial,
652 uint64_t limit,
653 GNUNET_NAMESTORE_RecordIterator iter,
654 void *iter_cls)
655{
656 struct Plugin *plugin = cls;
657 struct IterateContext ic;
658
659 ic.offset = serial;
660 ic.pos = 0;
661 ic.limit = limit;
662 ic.iter = iter;
663 ic.iter_cls = iter_cls;
664 ic.zone = zone;
665 GNUNET_CONTAINER_multihashmap_iterate (plugin->hm,
666 &iterate_zones,
667 &ic);
668 return (0 == ic.limit) ? GNUNET_OK : GNUNET_NO;
669}
670
671
672/**
673 * Closure for #zone_to_name.
674 */
675struct ZoneToNameContext
676{
677 const struct GNUNET_IDENTITY_PrivateKey *zone;
678 const struct GNUNET_IDENTITY_PublicKey *value_zone;
679 GNUNET_NAMESTORE_RecordIterator iter;
680 void *iter_cls;
681
682 int result_found;
683};
684
685
686static int
687zone_to_name (void *cls,
688 const struct GNUNET_HashCode *key,
689 void *value)
690{
691 struct ZoneToNameContext *ztn = cls;
692 struct FlatFileEntry *entry = value;
693
694 (void) key;
695 if (0 != GNUNET_memcmp (&entry->private_key,
696 ztn->zone))
697 return GNUNET_YES;
698
699 for (unsigned int i = 0; i < entry->record_count; i++)
700 {
701 if (GNUNET_NO ==
702 GNUNET_GNSRECORD_is_zonekey_type (entry->record_data[i].record_type))
703 continue;
704 if (ztn->value_zone->type != entry->record_data[i].record_type)
705 continue;
706 if (0 == memcmp (ztn->value_zone,
707 entry->record_data[i].data,
708 entry->record_data[i].data_size))
709 {
710 ztn->iter (ztn->iter_cls,
711 i + 1, /* zero is illegal! */
712 &entry->private_key,
713 entry->label,
714 entry->record_count,
715 entry->record_data);
716 ztn->result_found = GNUNET_YES;
717 }
718 }
719 return GNUNET_YES;
720}
721
722
723/**
724 * Look for an existing PKEY delegation record for a given public key.
725 * Returns at most one result to the iterator.
726 *
727 * @param cls closure (internal context for the plugin)
728 * @param zone private key of the zone to look up in, never NULL
729 * @param value_zone public key of the target zone (value), never NULL
730 * @param iter function to call with the result
731 * @param iter_cls closure for @a iter
732 * @return #GNUNET_OK on success, #GNUNET_NO if there were no results, #GNUNET_SYSERR on error
733 */
734static int
735namestore_flat_zone_to_name (void *cls,
736 const struct GNUNET_IDENTITY_PrivateKey *zone,
737 const struct
738 GNUNET_IDENTITY_PublicKey *value_zone,
739 GNUNET_NAMESTORE_RecordIterator iter,
740 void *iter_cls)
741{
742 struct Plugin *plugin = cls;
743 struct ZoneToNameContext ztn = {
744 .iter = iter,
745 .iter_cls = iter_cls,
746 .zone = zone,
747 .value_zone = value_zone,
748 .result_found = GNUNET_NO
749 };
750
751 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
752 "Performing reverse lookup for `%s'\n",
753 GNUNET_GNSRECORD_z2s (value_zone));
754 GNUNET_CONTAINER_multihashmap_iterate (plugin->hm,
755 &zone_to_name,
756 &ztn);
757 return ztn.result_found;
758}
759
760
761/**
762 * Entry point for the plugin.
763 *
764 * @param cls the "struct GNUNET_NAMESTORE_PluginEnvironment*"
765 * @return NULL on error, otherwise the plugin context
766 */
767void *
768libgnunet_plugin_namestore_flat_init (void *cls)
769{
770 static struct Plugin plugin;
771 const struct GNUNET_CONFIGURATION_Handle *cfg = cls;
772 struct GNUNET_NAMESTORE_PluginFunctions *api;
773
774 if (NULL != plugin.cfg)
775 return NULL; /* can only initialize once! */
776 memset (&plugin,
777 0,
778 sizeof(struct Plugin));
779 plugin.cfg = cfg;
780 if (GNUNET_OK != database_setup (&plugin))
781 {
782 database_shutdown (&plugin);
783 return NULL;
784 }
785 api = GNUNET_new (struct GNUNET_NAMESTORE_PluginFunctions);
786 api->cls = &plugin;
787 api->store_records = &namestore_flat_store_records;
788 api->iterate_records = &namestore_flat_iterate_records;
789 api->zone_to_name = &namestore_flat_zone_to_name;
790 api->lookup_records = &namestore_flat_lookup_records;
791 GNUNET_log (GNUNET_ERROR_TYPE_INFO,
792 _ ("Flat file database running\n"));
793 return api;
794}
795
796
797/**
798 * Exit point from the plugin.
799 *
800 * @param cls the plugin context (as returned by "init")
801 * @return always NULL
802 */
803void *
804libgnunet_plugin_namestore_flat_done (void *cls)
805{
806 struct GNUNET_NAMESTORE_PluginFunctions *api = cls;
807 struct Plugin *plugin = api->cls;
808
809 database_shutdown (plugin);
810 plugin->cfg = NULL;
811 GNUNET_free (api);
812 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
813 "Flat file plugin is finished\n");
814 return NULL;
815}
816
817
818/* end of plugin_namestore_flat.c */
diff --git a/src/namestore/plugin_namestore_postgres.c b/src/namestore/plugin_namestore_postgres.c
index 147dda0e6..240cc40ec 100644
--- a/src/namestore/plugin_namestore_postgres.c
+++ b/src/namestore/plugin_namestore_postgres.c
@@ -399,8 +399,8 @@ struct ParserContext
399 * call the @a iter in @a cls with the result. 399 * call the @a iter in @a cls with the result.
400 * 400 *
401 * @param cls closure of type `struct ParserContext *` 401 * @param cls closure of type `struct ParserContext *`
402 * @param result the postgres result 402 * @param res the postgres result
403 * @param num_result the number of results in @a result 403 * @param num_results the number of results in @a result
404 */ 404 */
405static void 405static void
406parse_result_call_iterator (void *cls, 406parse_result_call_iterator (void *cls,
diff --git a/src/namestore/plugin_rest_namestore.c b/src/namestore/plugin_rest_namestore.c
index 04ac95ee9..5a5fdb9a8 100644
--- a/src/namestore/plugin_rest_namestore.c
+++ b/src/namestore/plugin_rest_namestore.c
@@ -305,7 +305,7 @@ static struct RequestHandle *requests_tail;
305 305
306/** 306/**
307 * Cleanup lookup handle 307 * Cleanup lookup handle
308 * @param handle Handle to clean up 308 * @param cls Handle to clean up
309 */ 309 */
310static void 310static void
311cleanup_handle (void *cls) 311cleanup_handle (void *cls)
diff --git a/src/nat-auto/gnunet-nat-server.c b/src/nat-auto/gnunet-nat-server.c
index e091ab3b0..0ff71ca8c 100644
--- a/src/nat-auto/gnunet-nat-server.c
+++ b/src/nat-auto/gnunet-nat-server.c
@@ -261,7 +261,7 @@ try_send_udp (uint32_t dst_ipv4,
261 * traversal. Do it. 261 * traversal. Do it.
262 * 262 *
263 * @param cls handle to client (we always close) 263 * @param cls handle to client (we always close)
264 * @param msg message with details about what to test 264 * @param tm message with details about what to test
265 */ 265 */
266static void 266static void
267handle_test (void *cls, 267handle_test (void *cls,
diff --git a/src/nat-auto/nat_auto_api_test.c b/src/nat-auto/nat_auto_api_test.c
index b62d08683..9067aafda 100644
--- a/src/nat-auto/nat_auto_api_test.c
+++ b/src/nat-auto/nat_auto_api_test.c
@@ -333,7 +333,7 @@ mq_error_handler (void *cls, enum GNUNET_MQ_Error error)
333 * Address-callback, used to send message to gnunet-nat-server. 333 * Address-callback, used to send message to gnunet-nat-server.
334 * 334 *
335 * @param cls closure 335 * @param cls closure
336 * @param app_ctx[in,out] location where the app can store stuff 336 * @param[in,out] app_ctx location where the app can store stuff
337 * on add and retrieve it on remove 337 * on add and retrieve it on remove
338 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean 338 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean
339 * the previous (now invalid) one 339 * the previous (now invalid) one
diff --git a/src/nat/gnunet-nat.c b/src/nat/gnunet-nat.c
index 0743a478d..fd85549d6 100644
--- a/src/nat/gnunet-nat.c
+++ b/src/nat/gnunet-nat.c
@@ -110,7 +110,7 @@ test_finished ()
110 * a function to call whenever our set of 'valid' addresses changes. 110 * a function to call whenever our set of 'valid' addresses changes.
111 * 111 *
112 * @param cls closure, NULL 112 * @param cls closure, NULL
113 * @param app_ctx[in,out] location where the app can store stuff 113 * @param[in,out] app_ctx location where the app can store stuff
114 * on add and retrieve it on remove 114 * on add and retrieve it on remove
115 * @param add_remove #GNUNET_YES to add a new public IP address, 115 * @param add_remove #GNUNET_YES to add a new public IP address,
116 * #GNUNET_NO to remove a previous (now invalid) one 116 * #GNUNET_NO to remove a previous (now invalid) one
diff --git a/src/nat/gnunet-service-nat.c b/src/nat/gnunet-service-nat.c
index 4dcc0312f..dde269819 100644
--- a/src/nat/gnunet-service-nat.c
+++ b/src/nat/gnunet-service-nat.c
@@ -1185,7 +1185,7 @@ upnp_addr_change_cb (void *cls,
1185 * port number has already been parsed, this task is 1185 * port number has already been parsed, this task is
1186 * responsible for periodically doing a DNS lookup. 1186 * responsible for periodically doing a DNS lookup.
1187 * 1187 *
1188 * @param ch client handle to act upon 1188 * @param cls client handle to act upon
1189 */ 1189 */
1190static void 1190static void
1191dyndns_lookup (void *cls); 1191dyndns_lookup (void *cls);
diff --git a/src/nat/gnunet-service-nat_helper.c b/src/nat/gnunet-service-nat_helper.c
index bd1645d25..d92f5a99c 100644
--- a/src/nat/gnunet-service-nat_helper.c
+++ b/src/nat/gnunet-service-nat_helper.c
@@ -265,16 +265,6 @@ restart_nat_server (void *cls)
265} 265}
266 266
267 267
268/**
269 * Start the gnunet-helper-nat-server and process incoming
270 * requests.
271 *
272 * @param internal_address
273 * @param cb function to call if we receive a request
274 * @param cb_cls closure for @a cb
275 * @param cfg Handle to the GNUnet configuration
276 * @return NULL on error
277 */
278struct HelperContext * 268struct HelperContext *
279GN_start_gnunet_nat_server_ (const struct in_addr *internal_address, 269GN_start_gnunet_nat_server_ (const struct in_addr *internal_address,
280 GN_ReversalCallback cb, 270 GN_ReversalCallback cb,
diff --git a/src/nat/gnunet-service-nat_mini.c b/src/nat/gnunet-service-nat_mini.c
index ba43946cd..1e13e3814 100644
--- a/src/nat/gnunet-service-nat_mini.c
+++ b/src/nat/gnunet-service-nat_mini.c
@@ -639,14 +639,6 @@ process_unmap_output (void *cls, const char *line)
639} 639}
640 640
641 641
642/**
643 * Remove a mapping created with (mini)upnpc. Calling
644 * this function will give 'upnpc' 1s to remove tha mapping,
645 * so while this function is non-blocking, a task will be
646 * left with the scheduler for up to 1s past this call.
647 *
648 * @param mini the handle
649 */
650void 642void
651GNUNET_NAT_mini_map_stop (struct GNUNET_NAT_MiniHandle *mini) 643GNUNET_NAT_mini_map_stop (struct GNUNET_NAT_MiniHandle *mini)
652{ 644{
diff --git a/src/nat/nat_api.c b/src/nat/nat_api.c
index 20e7b6ec6..7cf7e6bb3 100644
--- a/src/nat/nat_api.c
+++ b/src/nat/nat_api.c
@@ -362,26 +362,6 @@ do_connect (void *cls)
362} 362}
363 363
364 364
365/**
366 * Attempt to enable port redirection and detect public IP address
367 * contacting UPnP or NAT-PMP routers on the local network. Use @a
368 * addr to specify to which of the local host's addresses should the
369 * external port be mapped. The port is taken from the corresponding
370 * sockaddr_in[6] field. The NAT module should call the given @a
371 * address_callback for any 'plausible' external address.
372 *
373 * @param cfg configuration to use
374 * @param config_section name of the configuration section for optionsx
375 * @param proto protocol this is about, IPPROTO_TCP or IPPROTO_UDP
376 * @param num_addrs number of addresses in @a addrs
377 * @param addrs list of local addresses packets should be redirected to
378 * @param addrlens actual lengths of the addresses in @a addrs
379 * @param address_callback function to call every time the public IP address changes
380 * @param reversal_callback function to call if someone wants connection reversal from us,
381 * NULL if connection reversal is not supported
382 * @param callback_cls closure for callbacks
383 * @return NULL on error, otherwise handle that can be used to unregister
384 */
385struct GNUNET_NAT_Handle * 365struct GNUNET_NAT_Handle *
386GNUNET_NAT_register (const struct GNUNET_CONFIGURATION_Handle *cfg, 366GNUNET_NAT_register (const struct GNUNET_CONFIGURATION_Handle *cfg,
387 const char *config_section, 367 const char *config_section,
diff --git a/src/nat/nat_api_stun.c b/src/nat/nat_api_stun.c
index 0bc2c5fbd..94adc3d6c 100644
--- a/src/nat/nat_api_stun.c
+++ b/src/nat/nat_api_stun.c
@@ -112,7 +112,7 @@ encode_message (enum StunClasses msg_class,
112/** 112/**
113 * Fill the stun_header with a random request_id 113 * Fill the stun_header with a random request_id
114 * 114 *
115 * @param req, stun header to be filled 115 * @param req stun header to be filled
116 */ 116 */
117static void 117static void
118generate_request_id (struct stun_header *req) 118generate_request_id (struct stun_header *req)
diff --git a/src/nse/gnunet-service-nse.c b/src/nse/gnunet-service-nse.c
index 56014752d..ee1cb025f 100644
--- a/src/nse/gnunet-service-nse.c
+++ b/src/nse/gnunet-service-nse.c
@@ -1199,7 +1199,7 @@ handle_core_connect (void *cls,
1199 * 1199 *
1200 * @param cls closure 1200 * @param cls closure
1201 * @param peer peer identity this notification is about 1201 * @param peer peer identity this notification is about
1202 * @parma internal_cls the `struct NSEPeerEntry` for the @a peer 1202 * @param internal_cls the `struct NSEPeerEntry` for the @a peer
1203 */ 1203 */
1204static void 1204static void
1205handle_core_disconnect (void *cls, 1205handle_core_disconnect (void *cls,
diff --git a/src/nt/nt.c b/src/nt/nt.c
index 98653f641..8dfacb02b 100644
--- a/src/nt/nt.c
+++ b/src/nt/nt.c
@@ -34,12 +34,6 @@
34 GNUNET_TIME_UNIT_MINUTES, 2) 34 GNUNET_TIME_UNIT_MINUTES, 2)
35 35
36 36
37/**
38 * Convert a `enum GNUNET_NetworkType` to a string
39 *
40 * @param net the network type
41 * @return a string or NULL if invalid
42 */
43const char * 37const char *
44GNUNET_NT_to_string (enum GNUNET_NetworkType net) 38GNUNET_NT_to_string (enum GNUNET_NetworkType net)
45{ 39{
diff --git a/src/peerinfo/peerinfo_api.c b/src/peerinfo/peerinfo_api.c
index b73d9d927..65e429bef 100644
--- a/src/peerinfo/peerinfo_api.c
+++ b/src/peerinfo/peerinfo_api.c
@@ -119,13 +119,6 @@ static void
119reconnect (struct GNUNET_PEERINFO_Handle *h); 119reconnect (struct GNUNET_PEERINFO_Handle *h);
120 120
121 121
122/**
123 * Connect to the peerinfo service.
124 *
125 * @param cfg configuration to use
126 * @return NULL on error (configuration related, actual connection
127 * establishment may happen asynchronously).
128 */
129struct GNUNET_PEERINFO_Handle * 122struct GNUNET_PEERINFO_Handle *
130GNUNET_PEERINFO_connect (const struct GNUNET_CONFIGURATION_Handle *cfg) 123GNUNET_PEERINFO_connect (const struct GNUNET_CONFIGURATION_Handle *cfg)
131{ 124{
@@ -467,22 +460,6 @@ reconnect (struct GNUNET_PEERINFO_Handle *h)
467} 460}
468 461
469 462
470/**
471 * Call a method for each known matching host. The callback method
472 * will be invoked once for each matching host and then finally once
473 * with a NULL pointer. After that final invocation, the iterator
474 * context must no longer be used.
475 *
476 * Instead of calling this function with `peer == NULL` it is often
477 * better to use #GNUNET_PEERINFO_notify().
478 *
479 * @param h handle to the peerinfo service
480 * @param include_friend_only include HELLO messages for friends only
481 * @param peer restrict iteration to this peer only (can be NULL)
482 * @param callback the method to call for each peer
483 * @param callback_cls closure for @a callback
484 * @return iterator context
485 */
486struct GNUNET_PEERINFO_IteratorContext * 463struct GNUNET_PEERINFO_IteratorContext *
487GNUNET_PEERINFO_iterate (struct GNUNET_PEERINFO_Handle *h, 464GNUNET_PEERINFO_iterate (struct GNUNET_PEERINFO_Handle *h,
488 int include_friend_only, 465 int include_friend_only,
diff --git a/src/peerstore/peerstore_api.c b/src/peerstore/peerstore_api.c
index d0c72acf1..b3e793d93 100644
--- a/src/peerstore/peerstore_api.c
+++ b/src/peerstore/peerstore_api.c
@@ -693,17 +693,6 @@ GNUNET_PEERSTORE_iterate_cancel (struct GNUNET_PEERSTORE_IterateContext *ic)
693} 693}
694 694
695 695
696/**
697 * Iterate over records matching supplied key information
698 *
699 * @param h handle to the PEERSTORE service
700 * @param sub_system name of sub system
701 * @param peer Peer identity (can be NULL)
702 * @param key entry key string (can be NULL)
703 * @param callback function called with each matching record, all NULL's on end
704 * @param callback_cls closure for @a callback
705 * @return Handle to iteration request
706 */
707struct GNUNET_PEERSTORE_IterateContext * 696struct GNUNET_PEERSTORE_IterateContext *
708GNUNET_PEERSTORE_iterate (struct GNUNET_PEERSTORE_Handle *h, 697GNUNET_PEERSTORE_iterate (struct GNUNET_PEERSTORE_Handle *h,
709 const char *sub_system, 698 const char *sub_system,
diff --git a/src/peerstore/peerstore_common.c b/src/peerstore/peerstore_common.c
index 0f6a73fa6..070a2a16e 100644
--- a/src/peerstore/peerstore_common.c
+++ b/src/peerstore/peerstore_common.c
@@ -118,12 +118,6 @@ PEERSTORE_create_record_mq_envelope (const char *sub_system,
118} 118}
119 119
120 120
121/**
122 * Parses a message carrying a record
123 *
124 * @param srm the actual message
125 * @return Pointer to record or NULL if error
126 */
127struct GNUNET_PEERSTORE_Record * 121struct GNUNET_PEERSTORE_Record *
128PEERSTORE_parse_record_message (const struct StoreRecordMessage *srm) 122PEERSTORE_parse_record_message (const struct StoreRecordMessage *srm)
129{ 123{
diff --git a/src/pq/pq_event.c b/src/pq/pq_event.c
index aff52dd5c..0e56c8b70 100644
--- a/src/pq/pq_event.c
+++ b/src/pq/pq_event.c
@@ -384,7 +384,7 @@ manage_subscribe (struct GNUNET_PQ_Context *db,
384 * 384 *
385 * @param cls the DB context 385 * @param cls the DB context
386 * @param sh the short hash of the channel 386 * @param sh the short hash of the channel
387 * @param eh the event handler 387 * @param value the event handler
388 * @return #GNUNET_OK to continue to iterate 388 * @return #GNUNET_OK to continue to iterate
389 */ 389 */
390static int 390static int
diff --git a/src/pq/pq_exec.c b/src/pq/pq_exec.c
index 62dd577ad..33fe8733d 100644
--- a/src/pq/pq_exec.c
+++ b/src/pq/pq_exec.c
@@ -63,15 +63,6 @@ GNUNET_PQ_make_try_execute (const char *sql)
63} 63}
64 64
65 65
66/**
67 * Request execution of an array of statements @a es from Postgres.
68 *
69 * @param db database to execute the statements with
70 * @param es #GNUNET_PQ_PREPARED_STATEMENT_END-terminated array of prepared
71 * statements.
72 * @return #GNUNET_OK on success (modulo statements where errors can be ignored)
73 * #GNUNET_SYSERR on error
74 */
75enum GNUNET_GenericReturnValue 66enum GNUNET_GenericReturnValue
76GNUNET_PQ_exec_statements (struct GNUNET_PQ_Context *db, 67GNUNET_PQ_exec_statements (struct GNUNET_PQ_Context *db,
77 const struct GNUNET_PQ_ExecuteStatement *es) 68 const struct GNUNET_PQ_ExecuteStatement *es)
diff --git a/src/pq/pq_result_helper.c b/src/pq/pq_result_helper.c
index f3d246c36..f945c5d2e 100644
--- a/src/pq/pq_result_helper.c
+++ b/src/pq/pq_result_helper.c
@@ -67,7 +67,7 @@ clean_varsize_blob (void *cls,
67 * 67 *
68 * @param cls closure 68 * @param cls closure
69 * @param result where to extract data from 69 * @param result where to extract data from
70 * @param int row to extract data from 70 * @param row row to extract data from
71 * @param fname name (or prefix) of the fields to extract from 71 * @param fname name (or prefix) of the fields to extract from
72 * @param[in,out] dst_size where to store size of result, may be NULL 72 * @param[in,out] dst_size where to store size of result, may be NULL
73 * @param[out] dst where to store the result 73 * @param[out] dst where to store the result
@@ -144,7 +144,7 @@ GNUNET_PQ_result_spec_variable_size (const char *name,
144 * 144 *
145 * @param cls closure 145 * @param cls closure
146 * @param result where to extract data from 146 * @param result where to extract data from
147 * @param int row to extract data from 147 * @param row row to extract data from
148 * @param fname name (or prefix) of the fields to extract from 148 * @param fname name (or prefix) of the fields to extract from
149 * @param[in] dst_size desired size, never NULL 149 * @param[in] dst_size desired size, never NULL
150 * @param[out] dst where to store the result 150 * @param[out] dst where to store the result
@@ -226,7 +226,7 @@ GNUNET_PQ_result_spec_fixed_size (const char *name,
226 * 226 *
227 * @param cls closure 227 * @param cls closure
228 * @param result where to extract data from 228 * @param result where to extract data from
229 * @param int row to extract data from 229 * @param row row to extract data from
230 * @param fname name (or prefix) of the fields to extract from 230 * @param fname name (or prefix) of the fields to extract from
231 * @param[in,out] dst_size where to store size of result, may be NULL 231 * @param[in,out] dst_size where to store size of result, may be NULL
232 * @param[out] dst where to store the result 232 * @param[out] dst where to store the result
@@ -322,7 +322,7 @@ GNUNET_PQ_result_spec_rsa_public_key (const char *name,
322 * 322 *
323 * @param cls closure 323 * @param cls closure
324 * @param result where to extract data from 324 * @param result where to extract data from
325 * @param int row to extract data from 325 * @param row row to extract data from
326 * @param fname name (or prefix) of the fields to extract from 326 * @param fname name (or prefix) of the fields to extract from
327 * @param[in,out] dst_size where to store size of result, may be NULL 327 * @param[in,out] dst_size where to store size of result, may be NULL
328 * @param[out] dst where to store the result 328 * @param[out] dst where to store the result
@@ -417,7 +417,7 @@ GNUNET_PQ_result_spec_rsa_signature (const char *name,
417 * 417 *
418 * @param cls closure 418 * @param cls closure
419 * @param result where to extract data from 419 * @param result where to extract data from
420 * @param int row to extract data from 420 * @param row row to extract data from
421 * @param fname name (or prefix) of the fields to extract from 421 * @param fname name (or prefix) of the fields to extract from
422 * @param[in,out] dst_size where to store size of result, may be NULL 422 * @param[in,out] dst_size where to store size of result, may be NULL
423 * @param[out] dst where to store the result 423 * @param[out] dst where to store the result
@@ -512,7 +512,7 @@ GNUNET_PQ_result_spec_string (const char *name,
512 * 512 *
513 * @param cls closure 513 * @param cls closure
514 * @param result where to extract data from 514 * @param result where to extract data from
515 * @param int row to extract data from 515 * @param row row to extract data from
516 * @param fname name (or prefix) of the fields to extract from 516 * @param fname name (or prefix) of the fields to extract from
517 * @param[in,out] dst_size where to store size of result, may be NULL 517 * @param[in,out] dst_size where to store size of result, may be NULL
518 * @param[out] dst where to store the result 518 * @param[out] dst where to store the result
@@ -582,7 +582,7 @@ GNUNET_PQ_result_spec_bool (const char *name,
582 * 582 *
583 * @param cls closure 583 * @param cls closure
584 * @param result where to extract data from 584 * @param result where to extract data from
585 * @param int row to extract data from 585 * @param row row to extract data from
586 * @param fname name (or prefix) of the fields to extract from 586 * @param fname name (or prefix) of the fields to extract from
587 * @param[in,out] dst_size where to store size of result, may be NULL 587 * @param[in,out] dst_size where to store size of result, may be NULL
588 * @param[out] dst where to store the result 588 * @param[out] dst where to store the result
@@ -659,7 +659,7 @@ GNUNET_PQ_result_spec_relative_time (const char *name,
659 * 659 *
660 * @param cls closure 660 * @param cls closure
661 * @param result where to extract data from 661 * @param result where to extract data from
662 * @param int row to extract data from 662 * @param row row to extract data from
663 * @param fname name (or prefix) of the fields to extract from 663 * @param fname name (or prefix) of the fields to extract from
664 * @param[in,out] dst_size where to store size of result, may be NULL 664 * @param[in,out] dst_size where to store size of result, may be NULL
665 * @param[out] dst where to store the result 665 * @param[out] dst where to store the result
@@ -748,7 +748,7 @@ GNUNET_PQ_result_spec_absolute_time_nbo (const char *name,
748 * 748 *
749 * @param cls closure 749 * @param cls closure
750 * @param result where to extract data from 750 * @param result where to extract data from
751 * @param int row to extract data from 751 * @param row row to extract data from
752 * @param fname name (or prefix) of the fields to extract from 752 * @param fname name (or prefix) of the fields to extract from
753 * @param[in,out] dst_size where to store size of result, may be NULL 753 * @param[in,out] dst_size where to store size of result, may be NULL
754 * @param[out] dst where to store the result 754 * @param[out] dst where to store the result
@@ -837,7 +837,7 @@ GNUNET_PQ_result_spec_timestamp (const char *name,
837 * 837 *
838 * @param cls closure 838 * @param cls closure
839 * @param result where to extract data from 839 * @param result where to extract data from
840 * @param int row to extract data from 840 * @param row row to extract data from
841 * @param fname name (or prefix) of the fields to extract from 841 * @param fname name (or prefix) of the fields to extract from
842 * @param[in,out] dst_size where to store size of result, may be NULL 842 * @param[in,out] dst_size where to store size of result, may be NULL
843 * @param[out] dst where to store the result 843 * @param[out] dst where to store the result
@@ -890,7 +890,7 @@ GNUNET_PQ_result_spec_timestamp_nbo (const char *name,
890 * 890 *
891 * @param cls closure 891 * @param cls closure
892 * @param result where to extract data from 892 * @param result where to extract data from
893 * @param int row to extract data from 893 * @param row row to extract data from
894 * @param fname name (or prefix) of the fields to extract from 894 * @param fname name (or prefix) of the fields to extract from
895 * @param[in,out] dst_size where to store size of result, may be NULL 895 * @param[in,out] dst_size where to store size of result, may be NULL
896 * @param[out] dst where to store the result 896 * @param[out] dst where to store the result
@@ -964,7 +964,7 @@ GNUNET_PQ_result_spec_uint16 (const char *name,
964 * 964 *
965 * @param cls closure 965 * @param cls closure
966 * @param result where to extract data from 966 * @param result where to extract data from
967 * @param int row to extract data from 967 * @param row row to extract data from
968 * @param fname name (or prefix) of the fields to extract from 968 * @param fname name (or prefix) of the fields to extract from
969 * @param[in,out] dst_size where to store size of result, may be NULL 969 * @param[in,out] dst_size where to store size of result, may be NULL
970 * @param[out] dst where to store the result 970 * @param[out] dst where to store the result
@@ -1038,7 +1038,7 @@ GNUNET_PQ_result_spec_uint32 (const char *name,
1038 * 1038 *
1039 * @param cls closure 1039 * @param cls closure
1040 * @param result where to extract data from 1040 * @param result where to extract data from
1041 * @param int row to extract data from 1041 * @param row row to extract data from
1042 * @param fname name (or prefix) of the fields to extract from 1042 * @param fname name (or prefix) of the fields to extract from
1043 * @param[in,out] dst_size where to store size of result, may be NULL 1043 * @param[in,out] dst_size where to store size of result, may be NULL
1044 * @param[out] dst where to store the result 1044 * @param[out] dst where to store the result
diff --git a/src/reclaim/did.h b/src/reclaim/did.h
index fc465da3b..42f65db26 100644
--- a/src/reclaim/did.h
+++ b/src/reclaim/did.h
@@ -25,7 +25,7 @@
25 25
26/** 26/**
27 * Create a DID string from an ego in the format 27 * Create a DID string from an ego in the format
28 * did:gns:<pubkey> 28 * did:gns:\<pubkey\>
29 * 29 *
30 * @param ego the Ego to use 30 * @param ego the Ego to use
31 * @return the DID string 31 * @return the DID string
@@ -36,7 +36,7 @@ DID_ego_to_did (struct GNUNET_IDENTITY_Ego *ego);
36 36
37/** 37/**
38 * Extract the public key from a DID 38 * Extract the public key from a DID
39 * in the format did:gns:<pubkey> 39 * in the format did:gns:\<pubkey\>
40 * 40 *
41 * @param did the DID parse 41 * @param did the DID parse
42 * @param pk where to store the public key 42 * @param pk where to store the public key
diff --git a/src/reclaim/gnunet-service-reclaim.c b/src/reclaim/gnunet-service-reclaim.c
index 84a98d1e4..5290621d6 100644
--- a/src/reclaim/gnunet-service-reclaim.c
+++ b/src/reclaim/gnunet-service-reclaim.c
@@ -522,7 +522,7 @@ cleanup_adh (struct AttributeDeleteHandle *adh)
522/** 522/**
523 * Cleanup attribute store handle 523 * Cleanup attribute store handle
524 * 524 *
525 * @param handle handle to clean up 525 * @param ash handle to clean up
526 */ 526 */
527static void 527static void
528cleanup_as_handle (struct AttributeStoreHandle *ash) 528cleanup_as_handle (struct AttributeStoreHandle *ash)
@@ -723,8 +723,8 @@ issue_ticket_result_cb (void *cls,
723/** 723/**
724 * Check issue ticket message 724 * Check issue ticket message
725 * 725 *
726 * @cls unused 726 * @param cls unused
727 * @im message to check 727 * @param im message to check
728 * @return GNUNET_OK if message is ok 728 * @return GNUNET_OK if message is ok
729 */ 729 */
730static int 730static int
@@ -937,7 +937,7 @@ check_consume_ticket_message (void *cls, const struct ConsumeTicketMessage *cm)
937 * Handle a consume ticket message 937 * Handle a consume ticket message
938 * 938 *
939 * @param cls our client handle 939 * @param cls our client handle
940 * @cm the message to handle 940 * @param cm the message to handle
941 */ 941 */
942static void 942static void
943handle_consume_ticket_message (void *cls, const struct ConsumeTicketMessage *cm) 943handle_consume_ticket_message (void *cls, const struct ConsumeTicketMessage *cm)
@@ -1686,8 +1686,8 @@ attr_delete_cont (void *cls, int32_t success, const char *emsg)
1686/** 1686/**
1687 * Check attribute delete message format 1687 * Check attribute delete message format
1688 * 1688 *
1689 * @cls unused 1689 * @param cls unused
1690 * @dam message to check 1690 * @param dam message to check
1691 */ 1691 */
1692static int 1692static int
1693check_attribute_delete_message (void *cls, 1693check_attribute_delete_message (void *cls,
@@ -1777,8 +1777,8 @@ cred_delete_cont (void *cls, int32_t success, const char *emsg)
1777/** 1777/**
1778 * Check credential delete message format 1778 * Check credential delete message format
1779 * 1779 *
1780 * @cls unused 1780 * @param cls unused
1781 * @dam message to check 1781 * @param dam message to check
1782 */ 1782 */
1783static int 1783static int
1784check_credential_delete_message (void *cls, 1784check_credential_delete_message (void *cls,
diff --git a/src/reclaim/gnunet-service-reclaim_tickets.c b/src/reclaim/gnunet-service-reclaim_tickets.c
index 23b617a7f..a17dfb0e2 100644
--- a/src/reclaim/gnunet-service-reclaim_tickets.c
+++ b/src/reclaim/gnunet-service-reclaim_tickets.c
@@ -485,7 +485,7 @@ rvk_ticket_update_finished (void *cls)
485 * @param cls handle to the operation 485 * @param cls handle to the operation
486 * @param zone ticket issuer private key 486 * @param zone ticket issuer private key
487 * @param label ticket rnd 487 * @param label ticket rnd
488 * @param rd_cound size of record set 488 * @param rd_count size of record set
489 * @param rd record set 489 * @param rd record set
490 */ 490 */
491static void 491static void
@@ -568,9 +568,8 @@ rvk_ns_err (void *cls)
568 * want to revoke. 568 * want to revoke.
569 * When we are done, we need to update any other ticket which 569 * When we are done, we need to update any other ticket which
570 * included references to any of the changed attributes. 570 * included references to any of the changed attributes.
571 * (Implementation further below)
572 * 571 *
573 * @param rvk handle to the operation 572 * @param rh handle to the operation
574 */ 573 */
575static void 574static void
576move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rh); 575move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rh);
@@ -757,14 +756,6 @@ rvk_move_attr_cb (void *cls,
757} 756}
758 757
759 758
760/**
761 * We change every attribute ID of the ticket attributes we
762 * want to revoke.
763 * When we are done, we need to update any other ticket which
764 * included references to any of the changed attributes.
765 *
766 * @param rvk handle to the operation
767 */
768static void 759static void
769move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rvk) 760move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rvk)
770{ 761{
@@ -844,7 +835,7 @@ remove_ticket_cont (void *cls, int32_t success, const char *emsg)
844 * @param cls handle to the operation 835 * @param cls handle to the operation
845 * @param zone the issuer key 836 * @param zone the issuer key
846 * @param label ticket rnd 837 * @param label ticket rnd
847 * @param rd_cound size of record set 838 * @param rd_count size of record set
848 * @param rd record set 839 * @param rd record set
849 */ 840 */
850static void 841static void
@@ -995,7 +986,7 @@ cleanup_cth (struct RECLAIM_TICKETS_ConsumeHandle *cth)
995 * We found an attribute record. 986 * We found an attribute record.
996 * 987 *
997 * @param cls handle to the operation 988 * @param cls handle to the operation
998 * @param rd_cound size of record set 989 * @param rd_count size of record set
999 * @param rd record set 990 * @param rd record set
1000 */ 991 */
1001static void 992static void
@@ -1083,7 +1074,7 @@ abort_parallel_lookups (void *cls)
1083 * attribute record under the referenced label. 1074 * attribute record under the referenced label.
1084 * 1075 *
1085 * @param cls handle to the operation 1076 * @param cls handle to the operation
1086 * @param rd_cound size of the record set 1077 * @param rd_count size of the record set
1087 * @param rd record set 1078 * @param rd record set
1088 */ 1079 */
1089static void 1080static void
@@ -1671,7 +1662,7 @@ cleanup_iter (struct RECLAIM_TICKETS_Iterator *iter)
1671 1662
1672 1663
1673/** 1664/**
1674 * Return each record of type @GNUNET_GNSRECORD_TYPE_RECLAIM_TICKET 1665 * Return each record of type #GNUNET_GNSRECORD_TYPE_RECLAIM_TICKET
1675 * to the caller and proceed with the iteration. 1666 * to the caller and proceed with the iteration.
1676 * FIXME: Should we _not_ proceed automatically here? 1667 * FIXME: Should we _not_ proceed automatically here?
1677 * 1668 *
diff --git a/src/reclaim/oidc_helper.c b/src/reclaim/oidc_helper.c
index 11963c345..90c33375f 100644
--- a/src/reclaim/oidc_helper.c
+++ b/src/reclaim/oidc_helper.c
@@ -423,17 +423,6 @@ generate_id_token_body (const struct GNUNET_IDENTITY_PublicKey *aud_key,
423} 423}
424 424
425 425
426/**
427 * Create a JWT using RSA256 algorithm from attributes
428 *
429 * @param aud_key the public of the audience
430 * @param sub_key the public key of the subject
431 * @param attrs the attribute list
432 * @param presentations credential presentation list (may be empty)
433 * @param expiration_time the validity of the token
434 * @param secret_rsa_key the key used to sign the JWT
435 * @return a new base64-encoded JWT string.
436 */
437char * 426char *
438OIDC_generate_id_token_rsa (const struct GNUNET_IDENTITY_PublicKey *aud_key, 427OIDC_generate_id_token_rsa (const struct GNUNET_IDENTITY_PublicKey *aud_key,
439 const struct GNUNET_IDENTITY_PublicKey *sub_key, 428 const struct GNUNET_IDENTITY_PublicKey *sub_key,
diff --git a/src/reclaim/oidc_helper.h b/src/reclaim/oidc_helper.h
index b134c71ad..81eadf2ed 100644
--- a/src/reclaim/oidc_helper.h
+++ b/src/reclaim/oidc_helper.h
@@ -50,14 +50,14 @@ enum OIDC_VerificationOptions
50}; 50};
51 51
52/** 52/**
53 * Create a JWT using RSA256 from attributes 53 * Create a JWT using RSA256 algorithm from attributes
54 * 54 *
55 * @param aud_key the public of the audience 55 * @param aud_key the public of the audience
56 * @param sub_key the public key of the subject 56 * @param sub_key the public key of the subject
57 * @param attrs the attribute list 57 * @param attrs the attribute list
58 * @param presentations credential presentation list (may be empty) 58 * @param presentations credential presentation list (may be empty)
59 * @param expiration_time the validity of the token 59 * @param expiration_time the validity of the token
60 * @param secret_key the key used to sign the JWT 60 * @param secret_rsa_key the key used to sign the JWT
61 * @return a new base64-encoded JWT string. 61 * @return a new base64-encoded JWT string.
62 */ 62 */
63char * 63char *
@@ -162,7 +162,7 @@ OIDC_access_token_new (const struct GNUNET_RECLAIM_Ticket *ticket);
162 * Parse an access token 162 * Parse an access token
163 */ 163 */
164int 164int
165OIDC_access_token_parse (const char*token, 165OIDC_access_token_parse (const char *token,
166 struct GNUNET_RECLAIM_Ticket **ticket); 166 struct GNUNET_RECLAIM_Ticket **ticket);
167 167
168 168
diff --git a/src/reclaim/reclaim_api.c b/src/reclaim/reclaim_api.c
index bc6b835c9..6f55d62e4 100644
--- a/src/reclaim/reclaim_api.c
+++ b/src/reclaim/reclaim_api.c
@@ -1076,14 +1076,6 @@ GNUNET_RECLAIM_connect (const struct GNUNET_CONFIGURATION_Handle *cfg)
1076} 1076}
1077 1077
1078 1078
1079/**
1080 * Cancel an operation. Note that the operation MAY still
1081 * be executed; this merely cancels the continuation; if the request
1082 * was already transmitted, the service may still choose to complete
1083 * the operation.
1084 *
1085 * @param op operation to cancel
1086 */
1087void 1079void
1088GNUNET_RECLAIM_cancel (struct GNUNET_RECLAIM_Operation *op) 1080GNUNET_RECLAIM_cancel (struct GNUNET_RECLAIM_Operation *op)
1089{ 1081{
@@ -1210,23 +1202,11 @@ GNUNET_RECLAIM_attribute_delete (
1210} 1202}
1211 1203
1212 1204
1213/**
1214 * Store an credential. If the credential is already present,
1215 * it is replaced with the new credential.
1216 *
1217 * @param h handle to the re:claimID service
1218 * @param pkey private key of the identity
1219 * @param attr the credential value
1220 * @param exp_interval the relative expiration interval for the credential
1221 * @param cont continuation to call when done
1222 * @param cont_cls closure for @a cont
1223 * @return handle to abort the request
1224 */
1225struct GNUNET_RECLAIM_Operation * 1205struct GNUNET_RECLAIM_Operation *
1226GNUNET_RECLAIM_credential_store ( 1206GNUNET_RECLAIM_credential_store (
1227 struct GNUNET_RECLAIM_Handle *h, 1207 struct GNUNET_RECLAIM_Handle *h,
1228 const struct GNUNET_IDENTITY_PrivateKey *pkey, 1208 const struct GNUNET_IDENTITY_PrivateKey *pkey,
1229 const struct GNUNET_RECLAIM_Credential *attr, 1209 const struct GNUNET_RECLAIM_Credential *credential,
1230 const struct GNUNET_TIME_Relative *exp_interval, 1210 const struct GNUNET_TIME_Relative *exp_interval,
1231 GNUNET_RECLAIM_ContinuationWithStatus cont, 1211 GNUNET_RECLAIM_ContinuationWithStatus cont,
1232 void *cont_cls) 1212 void *cont_cls)
@@ -1241,7 +1221,7 @@ GNUNET_RECLAIM_credential_store (
1241 op->cls = cont_cls; 1221 op->cls = cont_cls;
1242 op->r_id = h->r_id_gen++; 1222 op->r_id = h->r_id_gen++;
1243 GNUNET_CONTAINER_DLL_insert_tail (h->op_head, h->op_tail, op); 1223 GNUNET_CONTAINER_DLL_insert_tail (h->op_head, h->op_tail, op);
1244 attr_len = GNUNET_RECLAIM_credential_serialize_get_size (attr); 1224 attr_len = GNUNET_RECLAIM_credential_serialize_get_size (credential);
1245 op->env = GNUNET_MQ_msg_extra (sam, 1225 op->env = GNUNET_MQ_msg_extra (sam,
1246 attr_len, 1226 attr_len,
1247 GNUNET_MESSAGE_TYPE_RECLAIM_CREDENTIAL_STORE); 1227 GNUNET_MESSAGE_TYPE_RECLAIM_CREDENTIAL_STORE);
@@ -1249,7 +1229,7 @@ GNUNET_RECLAIM_credential_store (
1249 sam->id = htonl (op->r_id); 1229 sam->id = htonl (op->r_id);
1250 sam->exp = GNUNET_htonll (exp_interval->rel_value_us); 1230 sam->exp = GNUNET_htonll (exp_interval->rel_value_us);
1251 1231
1252 GNUNET_RECLAIM_credential_serialize (attr, (char *) &sam[1]); 1232 GNUNET_RECLAIM_credential_serialize (credential, (char *) &sam[1]);
1253 1233
1254 sam->attr_len = htons (attr_len); 1234 sam->attr_len = htons (attr_len);
1255 if (NULL != h->mq) 1235 if (NULL != h->mq)
@@ -1258,17 +1238,6 @@ GNUNET_RECLAIM_credential_store (
1258} 1238}
1259 1239
1260 1240
1261/**
1262 * Delete an credential. Tickets used to share this credential are updated
1263 * accordingly.
1264 *
1265 * @param h handle to the re:claimID service
1266 * @param pkey Private key of the identity to add an attribute to
1267 * @param attr The credential
1268 * @param cont Continuation to call when done
1269 * @param cont_cls Closure for @a cont
1270 * @return handle Used to to abort the request
1271 */
1272struct GNUNET_RECLAIM_Operation * 1241struct GNUNET_RECLAIM_Operation *
1273GNUNET_RECLAIM_credential_delete ( 1242GNUNET_RECLAIM_credential_delete (
1274 struct GNUNET_RECLAIM_Handle *h, 1243 struct GNUNET_RECLAIM_Handle *h,
@@ -1366,12 +1335,6 @@ GNUNET_RECLAIM_get_attributes_start (
1366} 1335}
1367 1336
1368 1337
1369/**
1370 * Calls the record processor specified in #GNUNET_RECLAIM_get_attributes_start
1371 * for the next record.
1372 *
1373 * @param it the iterator
1374 */
1375void 1338void
1376GNUNET_RECLAIM_get_attributes_next (struct GNUNET_RECLAIM_AttributeIterator *it) 1339GNUNET_RECLAIM_get_attributes_next (struct GNUNET_RECLAIM_AttributeIterator *it)
1377{ 1340{
@@ -1476,12 +1439,6 @@ GNUNET_RECLAIM_get_credentials_start (
1476} 1439}
1477 1440
1478 1441
1479/**
1480 * Calls the record processor specified in #GNUNET_RECLAIM_get_credential_start
1481 * for the next record.
1482 *
1483 * @param it the iterator
1484 */
1485void 1442void
1486GNUNET_RECLAIM_get_credentials_next (struct 1443GNUNET_RECLAIM_get_credentials_next (struct
1487 GNUNET_RECLAIM_CredentialIterator *ait) 1444 GNUNET_RECLAIM_CredentialIterator *ait)
@@ -1497,13 +1454,6 @@ GNUNET_RECLAIM_get_credentials_next (struct
1497} 1454}
1498 1455
1499 1456
1500/**
1501 * Stops iteration and releases the handle for further calls. Must
1502 * be called on any iteration that has not yet completed prior to calling
1503 * #GNUNET_RECLAIM_disconnect.
1504 *
1505 * @param it the iterator
1506 */
1507void 1457void
1508GNUNET_RECLAIM_get_credentials_stop (struct 1458GNUNET_RECLAIM_get_credentials_stop (struct
1509 GNUNET_RECLAIM_CredentialIterator *ait) 1459 GNUNET_RECLAIM_CredentialIterator *ait)
@@ -1524,19 +1474,6 @@ GNUNET_RECLAIM_get_credentials_stop (struct
1524} 1474}
1525 1475
1526 1476
1527/**
1528 * Issues a ticket to another relying party. The identity may use
1529 * @GNUNET_RECLAIM_ticket_consume to consume the ticket
1530 * and retrieve the attributes specified in the attribute list.
1531 *
1532 * @param h the reclaim to use
1533 * @param iss the issuing identity (= the user)
1534 * @param rp the subject of the ticket (= the relying party)
1535 * @param attrs the attributes that the relying party is given access to
1536 * @param cb the callback
1537 * @param cb_cls the callback closure
1538 * @return handle to abort the operation
1539 */
1540struct GNUNET_RECLAIM_Operation * 1477struct GNUNET_RECLAIM_Operation *
1541GNUNET_RECLAIM_ticket_issue ( 1478GNUNET_RECLAIM_ticket_issue (
1542 struct GNUNET_RECLAIM_Handle *h, 1479 struct GNUNET_RECLAIM_Handle *h,
diff --git a/src/reclaim/reclaim_attribute.c b/src/reclaim/reclaim_attribute.c
index 560267578..b5c41b2d1 100644
--- a/src/reclaim/reclaim_attribute.c
+++ b/src/reclaim/reclaim_attribute.c
@@ -282,14 +282,6 @@ GNUNET_RECLAIM_attribute_new (const char *attr_name,
282} 282}
283 283
284 284
285/**
286 * Add a new attribute to a claim list
287 *
288 * @param attr_name the name of the new attribute claim
289 * @param type the type of the claim
290 * @param data claim payload
291 * @param data_size claim payload size
292 */
293void 285void
294GNUNET_RECLAIM_attribute_list_add ( 286GNUNET_RECLAIM_attribute_list_add (
295 struct GNUNET_RECLAIM_AttributeList *al, 287 struct GNUNET_RECLAIM_AttributeList *al,
@@ -333,16 +325,9 @@ GNUNET_RECLAIM_attribute_list_serialize_get_size (
333} 325}
334 326
335 327
336/**
337 * Serialize an attribute list
338 *
339 * @param attrs the attribute list to serialize
340 * @param result the serialized attribute
341 * @return length of serialized data
342 */
343size_t 328size_t
344GNUNET_RECLAIM_attribute_list_serialize ( 329GNUNET_RECLAIM_attribute_list_serialize (
345 const struct GNUNET_RECLAIM_AttributeList *al, 330 const struct GNUNET_RECLAIM_AttributeList *attrs,
346 char *result) 331 char *result)
347{ 332{
348 struct GNUNET_RECLAIM_AttributeListEntry *ale; 333 struct GNUNET_RECLAIM_AttributeListEntry *ale;
@@ -351,7 +336,7 @@ GNUNET_RECLAIM_attribute_list_serialize (
351 char *write_ptr; 336 char *write_ptr;
352 write_ptr = result; 337 write_ptr = result;
353 total_len = 0; 338 total_len = 0;
354 for (ale = al->list_head; NULL != ale; ale = ale->next) 339 for (ale = attrs->list_head; NULL != ale; ale = ale->next)
355 { 340 {
356 GNUNET_assert (NULL != ale->attribute); 341 GNUNET_assert (NULL != ale->attribute);
357 len = GNUNET_RECLAIM_attribute_serialize (ale->attribute, write_ptr); 342 len = GNUNET_RECLAIM_attribute_serialize (ale->attribute, write_ptr);
@@ -404,21 +389,16 @@ GNUNET_RECLAIM_attribute_list_deserialize (const char *data, size_t data_size)
404} 389}
405 390
406 391
407/**
408 * Make a (deep) copy of a claim list
409 * @param attrs claim list to copy
410 * @return copied claim list
411 */
412struct GNUNET_RECLAIM_AttributeList * 392struct GNUNET_RECLAIM_AttributeList *
413GNUNET_RECLAIM_attribute_list_dup ( 393GNUNET_RECLAIM_attribute_list_dup (
414 const struct GNUNET_RECLAIM_AttributeList *al) 394 const struct GNUNET_RECLAIM_AttributeList *attrs)
415{ 395{
416 struct GNUNET_RECLAIM_AttributeListEntry *ale; 396 struct GNUNET_RECLAIM_AttributeListEntry *ale;
417 struct GNUNET_RECLAIM_AttributeListEntry *result_ale; 397 struct GNUNET_RECLAIM_AttributeListEntry *result_ale;
418 struct GNUNET_RECLAIM_AttributeList *result; 398 struct GNUNET_RECLAIM_AttributeList *result;
419 399
420 result = GNUNET_new (struct GNUNET_RECLAIM_AttributeList); 400 result = GNUNET_new (struct GNUNET_RECLAIM_AttributeList);
421 for (ale = al->list_head; NULL != ale; ale = ale->next) 401 for (ale = attrs->list_head; NULL != ale; ale = ale->next)
422 { 402 {
423 result_ale = GNUNET_new (struct GNUNET_RECLAIM_AttributeListEntry); 403 result_ale = GNUNET_new (struct GNUNET_RECLAIM_AttributeListEntry);
424 GNUNET_assert (NULL != ale->attribute); 404 GNUNET_assert (NULL != ale->attribute);
@@ -441,11 +421,6 @@ GNUNET_RECLAIM_attribute_list_dup (
441} 421}
442 422
443 423
444/**
445 * Destroy claim list
446 *
447 * @param attrs list to destroy
448 */
449void 424void
450GNUNET_RECLAIM_attribute_list_destroy ( 425GNUNET_RECLAIM_attribute_list_destroy (
451 struct GNUNET_RECLAIM_AttributeList *al) 426 struct GNUNET_RECLAIM_AttributeList *al)
diff --git a/src/reclaim/reclaim_credential.c b/src/reclaim/reclaim_credential.c
index b4aeedf29..6dc1a1fcf 100644
--- a/src/reclaim/reclaim_credential.c
+++ b/src/reclaim/reclaim_credential.c
@@ -250,15 +250,6 @@ GNUNET_RECLAIM_credential_value_to_string (uint32_t type,
250} 250}
251 251
252 252
253/**
254 * Create a new credential.
255 *
256 * @param attr_name the credential name
257 * @param type the credential type
258 * @param data the credential value
259 * @param data_size the credential value size
260 * @return the new credential
261 */
262struct GNUNET_RECLAIM_Credential * 253struct GNUNET_RECLAIM_Credential *
263GNUNET_RECLAIM_credential_new (const char *attr_name, 254GNUNET_RECLAIM_credential_new (const char *attr_name,
264 uint32_t type, 255 uint32_t type,
@@ -310,13 +301,6 @@ GNUNET_RECLAIM_credential_list_serialize_get_size (
310} 301}
311 302
312 303
313/**
314 * Serialize an attribute list
315 *
316 * @param attrs the attribute list to serialize
317 * @param result the serialized attribute
318 * @return length of serialized data
319 */
320size_t 304size_t
321GNUNET_RECLAIM_credential_list_serialize ( 305GNUNET_RECLAIM_credential_list_serialize (
322 const struct GNUNET_RECLAIM_CredentialList *credentials, 306 const struct GNUNET_RECLAIM_CredentialList *credentials,
@@ -339,13 +323,6 @@ GNUNET_RECLAIM_credential_list_serialize (
339} 323}
340 324
341 325
342/**
343 * Deserialize an credential list
344 *
345 * @param data the serialized attribute list
346 * @param data_size the length of the serialized data
347 * @return a GNUNET_IDENTITY_PROVIDER_AttributeList, must be free'd by caller
348 */
349struct GNUNET_RECLAIM_CredentialList * 326struct GNUNET_RECLAIM_CredentialList *
350GNUNET_RECLAIM_credential_list_deserialize (const char *data, size_t data_size) 327GNUNET_RECLAIM_credential_list_deserialize (const char *data, size_t data_size)
351{ 328{
@@ -415,19 +392,14 @@ GNUNET_RECLAIM_credential_list_dup (
415} 392}
416 393
417 394
418/**
419 * Destroy credential list
420 *
421 * @param attrs list to destroy
422 */
423void 395void
424GNUNET_RECLAIM_credential_list_destroy ( 396GNUNET_RECLAIM_credential_list_destroy (
425 struct GNUNET_RECLAIM_CredentialList *al) 397 struct GNUNET_RECLAIM_CredentialList *credentials)
426{ 398{
427 struct GNUNET_RECLAIM_CredentialListEntry *ale; 399 struct GNUNET_RECLAIM_CredentialListEntry *ale;
428 struct GNUNET_RECLAIM_CredentialListEntry *tmp_ale; 400 struct GNUNET_RECLAIM_CredentialListEntry *tmp_ale;
429 401
430 for (ale = al->list_head; NULL != ale;) 402 for (ale = credentials->list_head; NULL != ale;)
431 { 403 {
432 if (NULL != ale->credential) 404 if (NULL != ale->credential)
433 GNUNET_free (ale->credential); 405 GNUNET_free (ale->credential);
@@ -435,7 +407,7 @@ GNUNET_RECLAIM_credential_list_destroy (
435 ale = ale->next; 407 ale = ale->next;
436 GNUNET_free (tmp_ale); 408 GNUNET_free (tmp_ale);
437 } 409 }
438 GNUNET_free (al); 410 GNUNET_free (credentials);
439} 411}
440 412
441 413
@@ -454,13 +426,6 @@ GNUNET_RECLAIM_credential_serialize_get_size (
454} 426}
455 427
456 428
457/**
458 * Serialize an credential
459 *
460 * @param attr the credential to serialize
461 * @param result the serialized credential
462 * @return length of serialized data
463 */
464size_t 429size_t
465GNUNET_RECLAIM_credential_serialize ( 430GNUNET_RECLAIM_credential_serialize (
466 const struct GNUNET_RECLAIM_Credential *credential, 431 const struct GNUNET_RECLAIM_Credential *credential,
@@ -627,12 +592,6 @@ GNUNET_RECLAIM_presentation_typename_to_number (const char *typename)
627} 592}
628 593
629 594
630/**
631 * Convert an presentation type number to the corresponding presentation type string
632 *
633 * @param type number of a type
634 * @return corresponding typestring, NULL on error
635 */
636const char * 595const char *
637GNUNET_RECLAIM_presentation_number_to_typename (uint32_t type) 596GNUNET_RECLAIM_presentation_number_to_typename (uint32_t type)
638{ 597{
@@ -758,13 +717,6 @@ GNUNET_RECLAIM_presentation_list_serialize_get_size (
758} 717}
759 718
760 719
761/**
762 * Serialize an attribute list
763 *
764 * @param attrs the attribute list to serialize
765 * @param result the serialized attribute
766 * @return length of serialized data
767 */
768size_t 720size_t
769GNUNET_RECLAIM_presentation_list_serialize ( 721GNUNET_RECLAIM_presentation_list_serialize (
770 const struct GNUNET_RECLAIM_PresentationList *presentations, 722 const struct GNUNET_RECLAIM_PresentationList *presentations,
@@ -862,19 +814,14 @@ GNUNET_RECLAIM_presentation_list_dup (
862} 814}
863 815
864 816
865/**
866 * Destroy presentation list
867 *
868 * @param attrs list to destroy
869 */
870void 817void
871GNUNET_RECLAIM_presentation_list_destroy ( 818GNUNET_RECLAIM_presentation_list_destroy (
872 struct GNUNET_RECLAIM_PresentationList *al) 819 struct GNUNET_RECLAIM_PresentationList *presentations)
873{ 820{
874 struct GNUNET_RECLAIM_PresentationListEntry *ale; 821 struct GNUNET_RECLAIM_PresentationListEntry *ale;
875 struct GNUNET_RECLAIM_PresentationListEntry *tmp_ale; 822 struct GNUNET_RECLAIM_PresentationListEntry *tmp_ale;
876 823
877 for (ale = al->list_head; NULL != ale;) 824 for (ale = presentations->list_head; NULL != ale;)
878 { 825 {
879 if (NULL != ale->presentation) 826 if (NULL != ale->presentation)
880 GNUNET_free (ale->presentation); 827 GNUNET_free (ale->presentation);
@@ -882,7 +829,7 @@ GNUNET_RECLAIM_presentation_list_destroy (
882 ale = ale->next; 829 ale = ale->next;
883 GNUNET_free (tmp_ale); 830 GNUNET_free (tmp_ale);
884 } 831 }
885 GNUNET_free (al); 832 GNUNET_free (presentations);
886} 833}
887 834
888 835
@@ -900,13 +847,6 @@ GNUNET_RECLAIM_presentation_serialize_get_size (
900} 847}
901 848
902 849
903/**
904 * Serialize an presentation
905 *
906 * @param attr the presentation to serialize
907 * @param result the serialized presentation
908 * @return length of serialized data
909 */
910size_t 850size_t
911GNUNET_RECLAIM_presentation_serialize ( 851GNUNET_RECLAIM_presentation_serialize (
912 const struct GNUNET_RECLAIM_Presentation *presentation, 852 const struct GNUNET_RECLAIM_Presentation *presentation,
diff --git a/src/regex/gnunet-regex-profiler.c b/src/regex/gnunet-regex-profiler.c
index 721b77756..8238ad3df 100644
--- a/src/regex/gnunet-regex-profiler.c
+++ b/src/regex/gnunet-regex-profiler.c
@@ -963,7 +963,6 @@ daemon_started (void *cls,
963 * into the DHT. 963 * into the DHT.
964 * 964 *
965 * @param cls NULL 965 * @param cls NULL
966 * @param tc the task context
967 */ 966 */
968static void 967static void
969do_announce (void *cls) 968do_announce (void *cls)
diff --git a/src/regex/gnunet-service-regex.c b/src/regex/gnunet-service-regex.c
index deaa6112e..c25ef9eda 100644
--- a/src/regex/gnunet-service-regex.c
+++ b/src/regex/gnunet-service-regex.c
@@ -124,7 +124,7 @@ reannounce (void *cls)
124 * 124 *
125 * @param cls identification of the client 125 * @param cls identification of the client
126 * @param am the actual message 126 * @param am the actual message
127 * @return #GNUNET_OK if @am is well-formed 127 * @return #GNUNET_OK if @a am is well-formed
128 */ 128 */
129static int 129static int
130check_announce (void *cls, 130check_announce (void *cls,
@@ -238,7 +238,7 @@ handle_search_result (void *cls,
238 * Check SEARCH message. 238 * Check SEARCH message.
239 * 239 *
240 * @param cls identification of the client 240 * @param cls identification of the client
241 * @param message the actual message 241 * @param sm the actual message
242 */ 242 */
243static int 243static int
244check_search (void *cls, 244check_search (void *cls,
@@ -269,7 +269,7 @@ check_search (void *cls,
269 * Handle SEARCH message. 269 * Handle SEARCH message.
270 * 270 *
271 * @param cls identification of the client 271 * @param cls identification of the client
272 * @param message the actual message 272 * @param sm the actual message
273 */ 273 */
274static void 274static void
275handle_search (void *cls, 275handle_search (void *cls,
diff --git a/src/regex/regex_api_announce.c b/src/regex/regex_api_announce.c
index ad8a4fab9..12f173476 100644
--- a/src/regex/regex_api_announce.c
+++ b/src/regex/regex_api_announce.c
@@ -169,11 +169,6 @@ GNUNET_REGEX_announce (const struct GNUNET_CONFIGURATION_Handle *cfg,
169} 169}
170 170
171 171
172/**
173 * Stop announcing the regex specified by the given handle.
174 *
175 * @param a handle returned by a previous #GNUNET_REGEX_announce() call.
176 */
177void 172void
178GNUNET_REGEX_announce_cancel (struct GNUNET_REGEX_Announcement *a) 173GNUNET_REGEX_announce_cancel (struct GNUNET_REGEX_Announcement *a)
179{ 174{
diff --git a/src/regex/regex_api_search.c b/src/regex/regex_api_search.c
index 960719cbd..71219cbdd 100644
--- a/src/regex/regex_api_search.c
+++ b/src/regex/regex_api_search.c
@@ -185,18 +185,6 @@ search_reconnect (struct GNUNET_REGEX_Search *s)
185} 185}
186 186
187 187
188/**
189 * Search for a peer offering a regex matching certain string in the DHT.
190 * The search runs until #GNUNET_REGEX_search_cancel() is called, even if results
191 * are returned.
192 *
193 * @param cfg configuration to use
194 * @param string String to match against the regexes in the DHT.
195 * @param callback Callback for found peers.
196 * @param callback_cls Closure for @c callback.
197 * @return Handle to stop search and free resources.
198 * Must be freed by calling #GNUNET_REGEX_search_cancel().
199 */
200struct GNUNET_REGEX_Search * 188struct GNUNET_REGEX_Search *
201GNUNET_REGEX_search (const struct GNUNET_CONFIGURATION_Handle *cfg, 189GNUNET_REGEX_search (const struct GNUNET_CONFIGURATION_Handle *cfg,
202 const char *string, 190 const char *string,
@@ -233,11 +221,6 @@ GNUNET_REGEX_search (const struct GNUNET_CONFIGURATION_Handle *cfg,
233} 221}
234 222
235 223
236/**
237 * Stop search and free all data used by a #GNUNET_REGEX_search() call.
238 *
239 * @param s Handle returned by a previous #GNUNET_REGEX_search() call.
240 */
241void 224void
242GNUNET_REGEX_search_cancel (struct GNUNET_REGEX_Search *s) 225GNUNET_REGEX_search_cancel (struct GNUNET_REGEX_Search *s)
243{ 226{
diff --git a/src/regex/regex_block_lib.c b/src/regex/regex_block_lib.c
index cbfb553ce..048d6d743 100644
--- a/src/regex/regex_block_lib.c
+++ b/src/regex/regex_block_lib.c
@@ -110,14 +110,6 @@ GNUNET_BLOCK_is_accepting (const struct RegexBlock *block,
110} 110}
111 111
112 112
113/**
114 * Check if the given 'proof' matches the given 'key'.
115 *
116 * @param proof partial regex of a state
117 * @param proof_len number of bytes in 'proof'
118 * @param key hash of a state.
119 * @return #GNUNET_OK if the proof is valid for the given key.
120 */
121int 113int
122REGEX_BLOCK_check_proof (const char *proof, 114REGEX_BLOCK_check_proof (const char *proof,
123 size_t proof_len, 115 size_t proof_len,
@@ -187,18 +179,6 @@ check_edge (void *cls,
187} 179}
188 180
189 181
190/**
191 * Check if the regex block is well formed, including all edges.
192 *
193 * @param block The start of the block.
194 * @param size The size of the block.
195 * @param query the query for the block
196 * @param xquery String describing the edge we are looking for.
197 * Can be NULL in case this is a put block.
198 * @return #GNUNET_OK in case it's fine.
199 * #GNUNET_NO in case the xquery exists and is not found (IRRELEVANT).
200 * #GNUNET_SYSERR if the block is invalid.
201 */
202int 182int
203REGEX_BLOCK_check (const struct RegexBlock *block, 183REGEX_BLOCK_check (const struct RegexBlock *block,
204 size_t size, 184 size_t size,
@@ -246,14 +226,6 @@ REGEX_BLOCK_check (const struct RegexBlock *block,
246} 226}
247 227
248 228
249/**
250 * Obtain the key that a particular block is to be stored under.
251 *
252 * @param block block to get the key from
253 * @param block_len number of bytes in block
254 * @param key where to store the key
255 * @return #GNUNET_OK on success, #GNUNET_SYSERR if the block is malformed
256 */
257int 229int
258REGEX_BLOCK_get_key (const struct RegexBlock *block, 230REGEX_BLOCK_get_key (const struct RegexBlock *block,
259 size_t block_len, 231 size_t block_len,
@@ -289,21 +261,6 @@ REGEX_BLOCK_get_key (const struct RegexBlock *block,
289} 261}
290 262
291 263
292/**
293 * Iterate over all edges of a block of a regex state.
294 *
295 * @param block Block to iterate over.
296 * @param size Size of @a block.
297 * @param iterator Function to call on each edge in the block.
298 * @param iter_cls Closure for the @a iterator.
299 * @return #GNUNET_SYSERR if an error has been encountered.
300 * #GNUNET_OK if no error has been encountered.
301 * Note that if the iterator stops the iteration by returning
302 * #GNUNET_NO, the block will no longer be checked for further errors.
303 * The return value will be GNUNET_OK meaning that no errors were
304 * found until the edge last notified to the iterator, but there might
305 * be errors in further edges.
306 */
307int 264int
308REGEX_BLOCK_iterate (const struct RegexBlock *block, 265REGEX_BLOCK_iterate (const struct RegexBlock *block,
309 size_t size, 266 size_t size,
diff --git a/src/regex/regex_internal.c b/src/regex/regex_internal.c
index aa40851a9..c4fab6b56 100644
--- a/src/regex/regex_internal.c
+++ b/src/regex/regex_internal.c
@@ -501,19 +501,6 @@ automaton_state_traverse (struct REGEX_INTERNAL_State *s,
501} 501}
502 502
503 503
504/**
505 * Traverses the given automaton using depth-first-search (DFS) from it's start
506 * state, visiting all reachable states and calling 'action' on each one of
507 * them.
508 *
509 * @param a automaton to be traversed.
510 * @param start start state, pass a->start or NULL to traverse the whole automaton.
511 * @param check function that is checked before advancing on each transition
512 * in the DFS.
513 * @param check_cls closure for @a check.
514 * @param action action to be performed on each state.
515 * @param action_cls closure for @a action
516 */
517void 504void
518REGEX_INTERNAL_automaton_traverse (const struct REGEX_INTERNAL_Automaton *a, 505REGEX_INTERNAL_automaton_traverse (const struct REGEX_INTERNAL_Automaton *a,
519 struct REGEX_INTERNAL_State *start, 506 struct REGEX_INTERNAL_State *start,
@@ -3041,23 +3028,6 @@ construct_dfa_states (struct REGEX_INTERNAL_Context *ctx,
3041} 3028}
3042 3029
3043 3030
3044/**
3045 * Construct DFA for the given 'regex' of length 'len'.
3046 *
3047 * Path compression means, that for example a DFA o -> a -> b -> c -> o will be
3048 * compressed to o -> abc -> o. Note that this parameter influences the
3049 * non-determinism of states of the resulting NFA in the DHT (number of outgoing
3050 * edges with the same label). For example for an application that stores IPv4
3051 * addresses as bitstrings it could make sense to limit the path compression to
3052 * 4 or 8.
3053 *
3054 * @param regex regular expression string.
3055 * @param len length of the regular expression.
3056 * @param max_path_len limit the path compression length to the
3057 * given value. If set to 1, no path compression is applied. Set to 0 for
3058 * maximal possible path compression (generally not desirable).
3059 * @return DFA, needs to be freed using REGEX_INTERNAL_automaton_destroy.
3060 */
3061struct REGEX_INTERNAL_Automaton * 3031struct REGEX_INTERNAL_Automaton *
3062REGEX_INTERNAL_construct_dfa (const char *regex, 3032REGEX_INTERNAL_construct_dfa (const char *regex,
3063 const size_t len, 3033 const size_t len,
@@ -3118,12 +3088,6 @@ REGEX_INTERNAL_construct_dfa (const char *regex,
3118} 3088}
3119 3089
3120 3090
3121/**
3122 * Free the memory allocated by constructing the REGEX_INTERNAL_Automaton data
3123 * structure.
3124 *
3125 * @param a automaton to be destroyed
3126 */
3127void 3091void
3128REGEX_INTERNAL_automaton_destroy (struct REGEX_INTERNAL_Automaton *a) 3092REGEX_INTERNAL_automaton_destroy (struct REGEX_INTERNAL_Automaton *a)
3129{ 3093{
@@ -3251,13 +3215,6 @@ evaluate_nfa (struct REGEX_INTERNAL_Automaton *a, const char *string)
3251} 3215}
3252 3216
3253 3217
3254/**
3255 * Evaluates the given @a string against the given compiled regex @a a
3256 *
3257 * @param a automaton
3258 * @param string string to check
3259 * @return 0 if string matches, non-0 otherwise
3260 */
3261int 3218int
3262REGEX_INTERNAL_eval (struct REGEX_INTERNAL_Automaton *a, const char *string) 3219REGEX_INTERNAL_eval (struct REGEX_INTERNAL_Automaton *a, const char *string)
3263{ 3220{
@@ -3284,17 +3241,6 @@ REGEX_INTERNAL_eval (struct REGEX_INTERNAL_Automaton *a, const char *string)
3284} 3241}
3285 3242
3286 3243
3287/**
3288 * Get the canonical regex of the given automaton.
3289 * When constructing the automaton a proof is computed for each state,
3290 * consisting of the regular expression leading to this state. A complete
3291 * regex for the automaton can be computed by combining these proofs.
3292 * As of now this function is only useful for testing.
3293 *
3294 * @param a automaton for which the canonical regex should be returned.
3295 *
3296 * @return
3297 */
3298const char * 3244const char *
3299REGEX_INTERNAL_get_canonical_regex (struct REGEX_INTERNAL_Automaton *a) 3245REGEX_INTERNAL_get_canonical_regex (struct REGEX_INTERNAL_Automaton *a)
3300{ 3246{
@@ -3685,16 +3631,6 @@ iterate_reachables (void *cls, const struct GNUNET_HashCode *key, void *value)
3685} 3631}
3686 3632
3687 3633
3688/**
3689 * Iterate over all edges of automaton 'a' that are reachable from a state with
3690 * a proof of at least GNUNET_REGEX_INITIAL_BYTES characters.
3691 *
3692 * Call the iterator for each such edge.
3693 *
3694 * @param a automaton.
3695 * @param iterator iterator called for each reachable edge.
3696 * @param iterator_cls closure.
3697 */
3698void 3634void
3699REGEX_INTERNAL_iterate_reachable_edges (struct REGEX_INTERNAL_Automaton *a, 3635REGEX_INTERNAL_iterate_reachable_edges (struct REGEX_INTERNAL_Automaton *a,
3700 REGEX_INTERNAL_KeyIterator iterator, 3636 REGEX_INTERNAL_KeyIterator iterator,
diff --git a/src/regex/regex_internal.h b/src/regex/regex_internal.h
index 5b434b30c..8d4526d1f 100644
--- a/src/regex/regex_internal.h
+++ b/src/regex/regex_internal.h
@@ -368,9 +368,9 @@ typedef void
368 * @param start start state, pass a->start or NULL to traverse the whole automaton. 368 * @param start start state, pass a->start or NULL to traverse the whole automaton.
369 * @param check function that is checked before advancing on each transition 369 * @param check function that is checked before advancing on each transition
370 * in the DFS. 370 * in the DFS.
371 * @param check_cls closure for check. 371 * @param check_cls closure for @a check.
372 * @param action action to be performed on each state. 372 * @param action action to be performed on each state.
373 * @param action_cls closure for action 373 * @param action_cls closure for @a action
374 */ 374 */
375void 375void
376REGEX_INTERNAL_automaton_traverse (const struct REGEX_INTERNAL_Automaton *a, 376REGEX_INTERNAL_automaton_traverse (const struct REGEX_INTERNAL_Automaton *a,
diff --git a/src/regex/regex_internal_dht.c b/src/regex/regex_internal_dht.c
index e578fba2c..bda979edb 100644
--- a/src/regex/regex_internal_dht.c
+++ b/src/regex/regex_internal_dht.c
@@ -216,12 +216,6 @@ REGEX_INTERNAL_announce (struct GNUNET_DHT_Handle *dht,
216} 216}
217 217
218 218
219/**
220 * Announce again a regular expression previously announced.
221 * Does use caching to speed up process.
222 *
223 * @param h Handle returned by a previous #REGEX_INTERNAL_announce call().
224 */
225void 219void
226REGEX_INTERNAL_reannounce (struct REGEX_INTERNAL_Announcement *h) 220REGEX_INTERNAL_reannounce (struct REGEX_INTERNAL_Announcement *h)
227{ 221{
diff --git a/src/rest/gnunet-rest-server.c b/src/rest/gnunet-rest-server.c
index b3ca6382a..1ea4471d1 100644
--- a/src/rest/gnunet-rest-server.c
+++ b/src/rest/gnunet-rest-server.c
@@ -905,7 +905,6 @@ do_httpd (void *cls)
905 * Accept new incoming connections 905 * Accept new incoming connections
906 * 906 *
907 * @param cls the closure with the lsock4 or lsock6 907 * @param cls the closure with the lsock4 or lsock6
908 * @param tc the scheduler context
909 */ 908 */
910static void 909static void
911do_accept (void *cls) 910do_accept (void *cls)
diff --git a/src/rest/plugin_rest_config.c b/src/rest/plugin_rest_config.c
index b0f18754c..826188702 100644
--- a/src/rest/plugin_rest_config.c
+++ b/src/rest/plugin_rest_config.c
@@ -113,7 +113,6 @@ cleanup_handle (struct RequestHandle *handle)
113 * Task run on shutdown. Cleans up everything. 113 * Task run on shutdown. Cleans up everything.
114 * 114 *
115 * @param cls unused 115 * @param cls unused
116 * @param tc scheduler context
117 */ 116 */
118static void 117static void
119do_error (void *cls) 118do_error (void *cls)
diff --git a/src/rest/rest.c b/src/rest/rest.c
index 930f66243..757c0b979 100644
--- a/src/rest/rest.c
+++ b/src/rest/rest.c
@@ -33,13 +33,6 @@
33 * REST Utilities 33 * REST Utilities
34 */ 34 */
35 35
36/**
37 * Check if namespace is in URL.
38 *
39 * @param url URL to check
40 * @param namespace namespace to check against
41 * @return GNUNET_YES if namespace matches
42 */
43int 36int
44GNUNET_REST_namespace_match (const char *url, const char *namespace) 37GNUNET_REST_namespace_match (const char *url, const char *namespace)
45{ 38{
@@ -47,12 +40,6 @@ GNUNET_REST_namespace_match (const char *url, const char *namespace)
47} 40}
48 41
49 42
50/**
51 * Create MHD response
52 *
53 * @param data result
54 * @return MHD response
55 */
56struct MHD_Response* 43struct MHD_Response*
57GNUNET_REST_create_response (const char *data) 44GNUNET_REST_create_response (const char *data)
58{ 45{
diff --git a/src/revocation/revocation_api.c b/src/revocation/revocation_api.c
index b8c458e4f..78b3c083a 100644
--- a/src/revocation/revocation_api.c
+++ b/src/revocation/revocation_api.c
@@ -371,11 +371,6 @@ GNUNET_REVOCATION_revoke (const struct GNUNET_CONFIGURATION_Handle *cfg,
371} 371}
372 372
373 373
374/**
375 * Cancel key revocation.
376 *
377 * @param h operation to cancel
378 */
379void 374void
380GNUNET_REVOCATION_revoke_cancel (struct GNUNET_REVOCATION_Handle *h) 375GNUNET_REVOCATION_revoke_cancel (struct GNUNET_REVOCATION_Handle *h)
381{ 376{
@@ -623,15 +618,6 @@ GNUNET_REVOCATION_pow_init (const struct GNUNET_IDENTITY_PrivateKey *key,
623} 618}
624 619
625 620
626/**
627 * Starts a proof-of-work calculation given the pow object as well as
628 * target epochs and difficulty.
629 *
630 * @param pow the PoW to based calculations on.
631 * @param epochs the number of epochs for which the PoW must be valid.
632 * @param difficulty the base difficulty of the PoW.
633 * @return a handle for use in PoW rounds
634 */
635struct GNUNET_REVOCATION_PowCalculationHandle* 621struct GNUNET_REVOCATION_PowCalculationHandle*
636GNUNET_REVOCATION_pow_start (struct GNUNET_REVOCATION_PowP *pow, 622GNUNET_REVOCATION_pow_start (struct GNUNET_REVOCATION_PowP *pow,
637 int epochs, 623 int epochs,
diff --git a/src/rps/gnunet-rps-profiler.c b/src/rps/gnunet-rps-profiler.c
index 6d1236f08..df10ad5da 100644
--- a/src/rps/gnunet-rps-profiler.c
+++ b/src/rps/gnunet-rps-profiler.c
@@ -2206,7 +2206,7 @@ get_idx_of_pid (const struct GNUNET_PeerIdentity *pid)
2206 * @brief Counts number of peers in view of a that have b in their view 2206 * @brief Counts number of peers in view of a that have b in their view
2207 * 2207 *
2208 * @param a 2208 * @param a
2209 * @param uint32_tb 2209 * @param b
2210 * 2210 *
2211 * @return 2211 * @return
2212 */ 2212 */
diff --git a/src/rps/gnunet-rps.c b/src/rps/gnunet-rps.c
index 33c03f006..f90fc0d88 100644
--- a/src/rps/gnunet-rps.c
+++ b/src/rps/gnunet-rps.c
@@ -149,7 +149,7 @@ view_update_handle (void *cls,
149/** 149/**
150 * Callback called on receipt of peer from biased stream 150 * Callback called on receipt of peer from biased stream
151 * 151 *
152 * @param n number of peers 152 * @param num_peers number of peers
153 * @param recv_peers the received peers 153 * @param recv_peers the received peers
154 */ 154 */
155static void 155static void
diff --git a/src/rps/gnunet-service-rps.c b/src/rps/gnunet-service-rps.c
index f6fcf3ae7..be9324af9 100644
--- a/src/rps/gnunet-service-rps.c
+++ b/src/rps/gnunet-service-rps.c
@@ -1191,7 +1191,7 @@ check_operation_scheduled (const struct PeerContext *peer_ctx,
1191/** 1191/**
1192 * @brief Callback for scheduler to destroy a channel 1192 * @brief Callback for scheduler to destroy a channel
1193 * 1193 *
1194 * @param cls Context of the channel 1194 * @param channel_ctx Context of the channel
1195 */ 1195 */
1196static void 1196static void
1197destroy_channel (struct ChannelCtx *channel_ctx) 1197destroy_channel (struct ChannelCtx *channel_ctx)
@@ -3324,7 +3324,7 @@ check_client_seed (void *cls, const struct GNUNET_RPS_CS_SeedMessage *msg)
3324 * Handle seed from the client. 3324 * Handle seed from the client.
3325 * 3325 *
3326 * @param cls closure 3326 * @param cls closure
3327 * @param message the actual message 3327 * @param msg the actual message
3328 */ 3328 */
3329static void 3329static void
3330handle_client_seed (void *cls, 3330handle_client_seed (void *cls,
@@ -3362,7 +3362,7 @@ handle_client_seed (void *cls,
3362 * Handle RPS request from the client. 3362 * Handle RPS request from the client.
3363 * 3363 *
3364 * @param cls Client context 3364 * @param cls Client context
3365 * @param message Message containing the number of updates the client wants to 3365 * @param msg Message containing the number of updates the client wants to
3366 * receive 3366 * receive
3367 */ 3367 */
3368static void 3368static void
@@ -3416,7 +3416,7 @@ handle_client_view_cancel (void *cls,
3416 * Handle RPS request for biased stream from the client. 3416 * Handle RPS request for biased stream from the client.
3417 * 3417 *
3418 * @param cls Client context 3418 * @param cls Client context
3419 * @param message unused 3419 * @param msg unused
3420 */ 3420 */
3421static void 3421static void
3422handle_client_stream_request (void *cls, 3422handle_client_stream_request (void *cls,
@@ -4691,7 +4691,7 @@ valid_peers_iterator (void *cls,
4691 * @param cls Closure - Sub 4691 * @param cls Closure - Sub
4692 * @param peer id of the peer, NULL for last call 4692 * @param peer id of the peer, NULL for last call
4693 * @param hello hello message for the peer (can be NULL) 4693 * @param hello hello message for the peer (can be NULL)
4694 * @param error message 4694 * @param err_msg error message
4695 */ 4695 */
4696void 4696void
4697process_peerinfo_peers (void *cls, 4697process_peerinfo_peers (void *cls,
@@ -4823,7 +4823,7 @@ client_connect_cb (void *cls,
4823 * Callback called when a client disconnected from the service 4823 * Callback called when a client disconnected from the service
4824 * 4824 *
4825 * @param cls closure for the service 4825 * @param cls closure for the service
4826 * @param c the client that disconnected 4826 * @param client the client that disconnected
4827 * @param internal_cls should be equal to @a c 4827 * @param internal_cls should be equal to @a c
4828 */ 4828 */
4829static void 4829static void
diff --git a/src/rps/gnunet-service-rps_sampler_elem.c b/src/rps/gnunet-service-rps_sampler_elem.c
index aa8b72445..a6dc755a3 100644
--- a/src/rps/gnunet-service-rps_sampler_elem.c
+++ b/src/rps/gnunet-service-rps_sampler_elem.c
@@ -44,7 +44,7 @@
44/** 44/**
45 * Reinitialise a previously initialised sampler element. 45 * Reinitialise a previously initialised sampler element.
46 * 46 *
47 * @param sampler_el The sampler element to (re-) initialise 47 * @param sampler_elem The sampler element to (re-) initialise
48 */ 48 */
49void 49void
50RPS_sampler_elem_reinit (struct RPS_SamplerElement *sampler_elem) 50RPS_sampler_elem_reinit (struct RPS_SamplerElement *sampler_elem)
diff --git a/src/rps/rps-sampler_common.c b/src/rps/rps-sampler_common.c
index a30ba06a1..e3fb79501 100644
--- a/src/rps/rps-sampler_common.c
+++ b/src/rps/rps-sampler_common.c
@@ -191,15 +191,6 @@ RPS_sampler_set_desired_probability (struct RPS_Sampler *sampler,
191} 191}
192 192
193 193
194/**
195 * @brief Set the deficiency factor.
196 *
197 * Only used/useful with the client sampler
198 * (Maybe move to rps-sampler_client.{h|c} ?)
199 *
200 * @param sampler
201 * @param desired_probability
202 */
203void 194void
204RPS_sampler_set_deficiency_factor (struct RPS_Sampler *sampler, 195RPS_sampler_set_deficiency_factor (struct RPS_Sampler *sampler,
205 double deficiency_factor) 196 double deficiency_factor)
@@ -440,7 +431,6 @@ RPS_sampler_resize (struct RPS_Sampler *sampler, unsigned int new_size)
440 * Empty the sampler. 431 * Empty the sampler.
441 * 432 *
442 * @param sampler the sampler to empty. 433 * @param sampler the sampler to empty.
443 * @param new_size the new size of the sampler
444 */ 434 */
445static void 435static void
446sampler_empty (struct RPS_Sampler *sampler) 436sampler_empty (struct RPS_Sampler *sampler)
@@ -555,18 +545,6 @@ check_peer_info_ready (void *cls,
555} 545}
556 546
557 547
558/**
559 * Get n random peers out of the sampled peers.
560 *
561 * We might want to reinitialise this sampler after giving the
562 * corrsponding peer to the client.
563 * Random with or without consumption?
564 *
565 * @param sampler the sampler to get peers from.
566 * @param cb callback that will be called once the ids are ready.
567 * @param cls closure given to @a cb
568 * @param num_peers the number of peers requested
569 */
570struct RPS_SamplerRequestHandle * 548struct RPS_SamplerRequestHandle *
571RPS_sampler_get_n_rand_peers (struct RPS_Sampler *sampler, 549RPS_sampler_get_n_rand_peers (struct RPS_Sampler *sampler,
572 uint32_t num_peers, 550 uint32_t num_peers,
diff --git a/src/rps/rps-sampler_common.h b/src/rps/rps-sampler_common.h
index c60d37217..94727028a 100644
--- a/src/rps/rps-sampler_common.h
+++ b/src/rps/rps-sampler_common.h
@@ -325,8 +325,6 @@ RPS_sampler_resize (struct RPS_Sampler *sampler, unsigned int new_size);
325 * @param sampler the sampler to get peers from. 325 * @param sampler the sampler to get peers from.
326 * @param cb callback that will be called once the ids are ready. 326 * @param cb callback that will be called once the ids are ready.
327 * @param cls closure given to @a cb 327 * @param cls closure given to @a cb
328 * @param for_client #GNUNET_YES if result is used for client,
329 * #GNUNET_NO if used internally
330 * @param num_peers the number of peers requested 328 * @param num_peers the number of peers requested
331 */ 329 */
332struct RPS_SamplerRequestHandle * 330struct RPS_SamplerRequestHandle *
diff --git a/src/rps/rps_api.c b/src/rps/rps_api.c
index bb4c3597e..c4166745a 100644
--- a/src/rps/rps_api.c
+++ b/src/rps/rps_api.c
@@ -745,7 +745,7 @@ mq_error_handler (void *cls,
745 * (-group) 745 * (-group)
746 * 746 *
747 * @param share_val Share value 747 * @param share_val Share value
748 * @param hash[out] Pointer to the location in which the hash will be stored. 748 * @param[out] hash Pointer to the location in which the hash will be stored.
749 */ 749 */
750static void 750static void
751hash_from_share_val (const char *share_val, 751hash_from_share_val (const char *share_val,
diff --git a/src/scalarproduct/gnunet-scalarproduct.c b/src/scalarproduct/gnunet-scalarproduct.c
index 14495de05..07af916b1 100644
--- a/src/scalarproduct/gnunet-scalarproduct.c
+++ b/src/scalarproduct/gnunet-scalarproduct.c
@@ -190,7 +190,6 @@ requester_callback (void *cls,
190 * Task run during shutdown. 190 * Task run during shutdown.
191 * 191 *
192 * @param cls unused 192 * @param cls unused
193 * @param tc unused
194 */ 193 */
195static void 194static void
196shutdown_task (void *cls) 195shutdown_task (void *cls)
diff --git a/src/scalarproduct/gnunet-service-scalarproduct-ecc_alice.c b/src/scalarproduct/gnunet-service-scalarproduct-ecc_alice.c
index dc43b5a54..c43a7e854 100644
--- a/src/scalarproduct/gnunet-service-scalarproduct-ecc_alice.c
+++ b/src/scalarproduct/gnunet-service-scalarproduct-ecc_alice.c
@@ -761,7 +761,7 @@ cb_intersection_request_alice (void *cls,
761/** 761/**
762 * Our client has finished sending us its multipart message. 762 * Our client has finished sending us its multipart message.
763 * 763 *
764 * @param session the service session context 764 * @param s the service session context
765 */ 765 */
766static void 766static void
767client_request_complete_alice (struct AliceServiceSession *s) 767client_request_complete_alice (struct AliceServiceSession *s)
diff --git a/src/scalarproduct/gnunet-service-scalarproduct-ecc_bob.c b/src/scalarproduct/gnunet-service-scalarproduct-ecc_bob.c
index 02a62c164..1945f1937 100644
--- a/src/scalarproduct/gnunet-service-scalarproduct-ecc_bob.c
+++ b/src/scalarproduct/gnunet-service-scalarproduct-ecc_bob.c
@@ -208,7 +208,7 @@ free_element_cb (void *cls,
208/** 208/**
209 * Destroy session state, we are done with it. 209 * Destroy session state, we are done with it.
210 * 210 *
211 * @param session the session to free elements from 211 * @param s the session to free elements from
212 */ 212 */
213static void 213static void
214destroy_service_session (struct BobServiceSession *s) 214destroy_service_session (struct BobServiceSession *s)
@@ -297,8 +297,6 @@ prepare_client_end_notification (struct BobServiceSession *session)
297 * 297 *
298 * @param cls the `struct BobServiceSession` 298 * @param cls the `struct BobServiceSession`
299 * @param channel connection to the other end (henceforth invalid) 299 * @param channel connection to the other end (henceforth invalid)
300 * @param channel_ctx place where local state associated
301 * with the channel is stored
302 */ 300 */
303static void 301static void
304cb_channel_destruction (void *cls, 302cb_channel_destruction (void *cls,
diff --git a/src/scalarproduct/gnunet-service-scalarproduct_alice.c b/src/scalarproduct/gnunet-service-scalarproduct_alice.c
index 665d2ad7f..59c3c6f6c 100644
--- a/src/scalarproduct/gnunet-service-scalarproduct_alice.c
+++ b/src/scalarproduct/gnunet-service-scalarproduct_alice.c
@@ -672,7 +672,7 @@ handle_bobs_cryptodata_multipart (
672 * calculate a scalarproduct with. 672 * calculate a scalarproduct with.
673 * 673 *
674 * @param cls our `struct AliceServiceSession` 674 * @param cls our `struct AliceServiceSession`
675 * @param message the actual message 675 * @param msg the actual message
676 * @return #GNUNET_OK to keep the connection open, 676 * @return #GNUNET_OK to keep the connection open,
677 * #GNUNET_SYSERR to close it (we are done) 677 * #GNUNET_SYSERR to close it (we are done)
678 */ 678 */
diff --git a/src/scalarproduct/gnunet-service-scalarproduct_bob.c b/src/scalarproduct/gnunet-service-scalarproduct_bob.c
index b0299779d..15ad3038e 100644
--- a/src/scalarproduct/gnunet-service-scalarproduct_bob.c
+++ b/src/scalarproduct/gnunet-service-scalarproduct_bob.c
@@ -563,7 +563,7 @@ compute_square_sum (const gcry_mpi_t *vector,
563 * S: $S := E_A(sum (r_i + b_i)^2)$ 563 * S: $S := E_A(sum (r_i + b_i)^2)$
564 * S': $S' := E_A(sum r_i^2)$ 564 * S': $S' := E_A(sum r_i^2)$
565 * 565 *
566 * @param request the requesting session + bob's requesting peer 566 * @param session the requesting session + bob's requesting peer
567 * @return #GNUNET_OK on success 567 * @return #GNUNET_OK on success
568 */ 568 */
569static int 569static int
diff --git a/src/scalarproduct/scalarproduct_api.c b/src/scalarproduct/scalarproduct_api.c
index 44d6bd812..8c667a72e 100644
--- a/src/scalarproduct/scalarproduct_api.c
+++ b/src/scalarproduct/scalarproduct_api.c
@@ -140,7 +140,7 @@ process_status_message (struct GNUNET_SCALARPRODUCT_ComputationHandle *h,
140 * handles the response to the client which used the API. 140 * handles the response to the client which used the API.
141 * 141 *
142 * @param cls Pointer to the Master Context 142 * @param cls Pointer to the Master Context
143 * @param msg Pointer to the data received in response 143 * @param message Pointer to the data received in response
144 */ 144 */
145static void 145static void
146handle_response (void *cls, 146handle_response (void *cls,
@@ -210,17 +210,6 @@ mq_error_handler (void *cls,
210} 210}
211 211
212 212
213/**
214 * Used by Bob's client to cooperate with Alice,
215 *
216 * @param cfg the gnunet configuration handle
217 * @param key Session key unique to the requesting client
218 * @param elements Array of elements of the vector
219 * @param element_count Number of elements in the @a elements vector
220 * @param cont Callback function
221 * @param cont_cls Closure for @a cont
222 * @return a new handle for this computation
223 */
224struct GNUNET_SCALARPRODUCT_ComputationHandle * 213struct GNUNET_SCALARPRODUCT_ComputationHandle *
225GNUNET_SCALARPRODUCT_accept_computation ( 214GNUNET_SCALARPRODUCT_accept_computation (
226 const struct GNUNET_CONFIGURATION_Handle *cfg, 215 const struct GNUNET_CONFIGURATION_Handle *cfg,
@@ -368,18 +357,6 @@ process_result_message (struct GNUNET_SCALARPRODUCT_ComputationHandle *h,
368} 357}
369 358
370 359
371/**
372 * Request by Alice's client for computing a scalar product
373 *
374 * @param cfg the gnunet configuration handle
375 * @param session_key Session key should be unique to the requesting client
376 * @param peer PeerID of the other peer
377 * @param elements Array of elements of the vector
378 * @param element_count Number of elements in the @a elements vector
379 * @param cont Callback function
380 * @param cont_cls Closure for @a cont
381 * @return a new handle for this computation
382 */
383struct GNUNET_SCALARPRODUCT_ComputationHandle * 360struct GNUNET_SCALARPRODUCT_ComputationHandle *
384GNUNET_SCALARPRODUCT_start_computation ( 361GNUNET_SCALARPRODUCT_start_computation (
385 const struct GNUNET_CONFIGURATION_Handle *cfg, 362 const struct GNUNET_CONFIGURATION_Handle *cfg,
diff --git a/src/secretsharing/gnunet-service-secretsharing.c b/src/secretsharing/gnunet-service-secretsharing.c
index 939b7827d..84338bd11 100644
--- a/src/secretsharing/gnunet-service-secretsharing.c
+++ b/src/secretsharing/gnunet-service-secretsharing.c
@@ -653,7 +653,6 @@ keygen_session_destroy (struct KeygenSession *ks)
653 * Task run during shutdown. 653 * Task run during shutdown.
654 * 654 *
655 * @param cls unused 655 * @param cls unused
656 * @param tc unused
657 */ 656 */
658static void 657static void
659cleanup_task (void *cls) 658cleanup_task (void *cls)
diff --git a/src/secretsharing/secretsharing_api.c b/src/secretsharing/secretsharing_api.c
index 98f800c95..595af751f 100644
--- a/src/secretsharing/secretsharing_api.c
+++ b/src/secretsharing/secretsharing_api.c
@@ -316,19 +316,6 @@ handle_decrypt_done (void *cls,
316} 316}
317 317
318 318
319/**
320 * Publish the given ciphertext for decryption. Once a sufficient (>=k) number of peers has
321 * published the same value, it will be decrypted.
322 *
323 * When the operation is canceled, the decrypt_cb is not called anymore, but the calling
324 * peer may already have irrevocably contributed its share for the decryption of the value.
325 *
326 * @param share our secret share to use for decryption
327 * @param ciphertext ciphertext to publish in order to decrypt it (if enough peers agree)
328 * @param decrypt_cb callback called once the decryption succeeded
329 * @param decrypt_cb_cls closure for @a decrypt_cb
330 * @return handle to cancel the operation
331 */
332struct GNUNET_SECRETSHARING_DecryptionHandle * 319struct GNUNET_SECRETSHARING_DecryptionHandle *
333GNUNET_SECRETSHARING_decrypt (const struct GNUNET_CONFIGURATION_Handle *cfg, 320GNUNET_SECRETSHARING_decrypt (const struct GNUNET_CONFIGURATION_Handle *cfg,
334 struct GNUNET_SECRETSHARING_Share *share, 321 struct GNUNET_SECRETSHARING_Share *share,
@@ -431,19 +418,6 @@ GNUNET_SECRETSHARING_plaintext_generate_i (struct
431} 418}
432 419
433 420
434/**
435 * Encrypt a value. This operation is executed locally, no communication is
436 * necessary.
437 *
438 * This is a helper function, encryption can be done solely with a session's public key
439 * and the crypto system parameters.
440 *
441 * @param public_key public key to use for decryption
442 * @param message message to encrypt
443 * @param message_size number of bytes in @a message
444 * @param result_ciphertext pointer to store the resulting ciphertext
445 * @return #GNUNET_YES on success, #GNUNET_SYSERR if the message is invalid (invalid range)
446 */
447int 421int
448GNUNET_SECRETSHARING_encrypt (const struct 422GNUNET_SECRETSHARING_encrypt (const struct
449 GNUNET_SECRETSHARING_PublicKey *public_key, 423 GNUNET_SECRETSHARING_PublicKey *public_key,
diff --git a/src/secretsharing/secretsharing_protocol.h b/src/secretsharing/secretsharing_protocol.h
index d4aaecb6c..e6f3ba286 100644
--- a/src/secretsharing/secretsharing_protocol.h
+++ b/src/secretsharing/secretsharing_protocol.h
@@ -108,22 +108,22 @@ struct GNUNET_SECRETSHARING_DecryptData
108 */ 108 */
109 struct GNUNET_PeerIdentity peer; 109 struct GNUNET_PeerIdentity peer;
110 /** 110 /**
111 * Partial decryption, computed as c_1^{s_i} 111 * Partial decryption, computed as \f$c_1^{s_i}\f$
112 */ 112 */
113 struct GNUNET_SECRETSHARING_FieldElement partial_decryption; 113 struct GNUNET_SECRETSHARING_FieldElement partial_decryption;
114 /** 114 /**
115 * Commitment for the non-interactive zero knowledge proof. 115 * Commitment for the non-interactive zero knowledge proof.
116 * g^\beta, with \beta < q 116 * \f$g^\beta\f$, with \f$\beta < q\f$
117 */ 117 */
118 struct GNUNET_SECRETSHARING_FieldElement nizk_commit1; 118 struct GNUNET_SECRETSHARING_FieldElement nizk_commit1;
119 /** 119 /**
120 * Commitment for the non-interactive zero knowledge proof. 120 * Commitment for the non-interactive zero knowledge proof.
121 * c_1^\beta, with \beta < q 121 * \f$c_1^\beta\f$, with \f$\beta < q\f$
122 */ 122 */
123 struct GNUNET_SECRETSHARING_FieldElement nizk_commit2; 123 struct GNUNET_SECRETSHARING_FieldElement nizk_commit2;
124 /** 124 /**
125 * Response to the challenge computed from the protocol transcript. 125 * Response to the challenge computed from the protocol transcript.
126 * r = \beta + challenge \cdot share_i 126 * \f$r = \beta + challenge \cdot share_i\f$
127 */ 127 */
128 struct GNUNET_SECRETSHARING_FieldElement nizk_response; 128 struct GNUNET_SECRETSHARING_FieldElement nizk_response;
129}; 129};
diff --git a/src/set/gnunet-service-set.c b/src/set/gnunet-service-set.c
index 2b859d81a..208c63a1a 100644
--- a/src/set/gnunet-service-set.c
+++ b/src/set/gnunet-service-set.c
@@ -176,7 +176,6 @@ static uint32_t suggest_id;
176/** 176/**
177 * Get the incoming socket associated with the given id. 177 * Get the incoming socket associated with the given id.
178 * 178 *
179 * @param listener the listener to look in
180 * @param id id to look for 179 * @param id id to look for
181 * @return the incoming socket associated with the id, 180 * @return the incoming socket associated with the id,
182 * or NULL if there is none 181 * or NULL if there is none
@@ -1006,7 +1005,7 @@ handle_client_iterate (void *cls, const struct GNUNET_MessageHeader *m)
1006 * operation to be performed. 1005 * operation to be performed.
1007 * 1006 *
1008 * @param cls client that sent the message 1007 * @param cls client that sent the message
1009 * @param m message sent by the client 1008 * @param msg message sent by the client
1010 */ 1009 */
1011static void 1010static void
1012handle_client_create_set (void *cls, const struct GNUNET_SET_CreateMessage *msg) 1011handle_client_create_set (void *cls, const struct GNUNET_SET_CreateMessage *msg)
@@ -1066,7 +1065,6 @@ handle_client_create_set (void *cls, const struct GNUNET_SET_CreateMessage *msg)
1066 * - we got the channel from a peer but no #GNUNET_MESSAGE_TYPE_SET_P2P_OPERATION_REQUEST 1065 * - we got the channel from a peer but no #GNUNET_MESSAGE_TYPE_SET_P2P_OPERATION_REQUEST
1067 * 1066 *
1068 * @param cls channel context 1067 * @param cls channel context
1069 * @param tc context information (why was this task triggered now)
1070 */ 1068 */
1071static void 1069static void
1072incoming_timeout_cb (void *cls) 1070incoming_timeout_cb (void *cls)
diff --git a/src/set/gnunet-service-set_intersection.c b/src/set/gnunet-service-set_intersection.c
index 9313483bb..51a8d0dbc 100644
--- a/src/set/gnunet-service-set_intersection.c
+++ b/src/set/gnunet-service-set_intersection.c
@@ -754,13 +754,6 @@ begin_bf_exchange (struct Operation *op)
754} 754}
755 755
756 756
757/**
758 * Handle the initial `struct IntersectionElementInfoMessage` from a
759 * remote peer.
760 *
761 * @param cls the intersection operation
762 * @param mh the header of the message
763 */
764void 757void
765handle_intersection_p2p_element_info (void *cls, 758handle_intersection_p2p_element_info (void *cls,
766 const struct 759 const struct
@@ -1039,7 +1032,7 @@ filter_all (void *cls,
1039 * Handle a done message from a remote peer 1032 * Handle a done message from a remote peer
1040 * 1033 *
1041 * @param cls the intersection operation 1034 * @param cls the intersection operation
1042 * @param mh the message 1035 * @param idm the message
1043 */ 1036 */
1044void 1037void
1045handle_intersection_p2p_done (void *cls, 1038handle_intersection_p2p_done (void *cls,
diff --git a/src/set/gnunet-service-set_intersection.h b/src/set/gnunet-service-set_intersection.h
index 200e8f5ff..d8884d0a7 100644
--- a/src/set/gnunet-service-set_intersection.h
+++ b/src/set/gnunet-service-set_intersection.h
@@ -57,7 +57,7 @@ handle_intersection_p2p_bf (void *cls,
57 * remote peer. 57 * remote peer.
58 * 58 *
59 * @param cls the intersection operation 59 * @param cls the intersection operation
60 * @param mh the header of the message 60 * @param msg the header of the message
61 */ 61 */
62void 62void
63handle_intersection_p2p_element_info (void *cls, 63handle_intersection_p2p_element_info (void *cls,
diff --git a/src/set/gnunet-service-set_union.c b/src/set/gnunet-service-set_union.c
index d762e4bba..3a2bc8bd7 100644
--- a/src/set/gnunet-service-set_union.c
+++ b/src/set/gnunet-service-set_union.c
@@ -2194,12 +2194,6 @@ handle_union_p2p_done (void *cls,
2194} 2194}
2195 2195
2196 2196
2197/**
2198 * Handle a over message from a remote peer
2199 *
2200 * @param cls the union operation
2201 * @param mh the message
2202 */
2203void 2197void
2204handle_union_p2p_over (void *cls, 2198handle_union_p2p_over (void *cls,
2205 const struct GNUNET_MessageHeader *mh) 2199 const struct GNUNET_MessageHeader *mh)
diff --git a/src/set/gnunet-service-set_union_strata_estimator.c b/src/set/gnunet-service-set_union_strata_estimator.c
index 97b4a1f98..6de9fb5eb 100644
--- a/src/set/gnunet-service-set_union_strata_estimator.c
+++ b/src/set/gnunet-service-set_union_strata_estimator.c
@@ -155,12 +155,6 @@ strata_estimator_insert (struct StrataEstimator *se,
155} 155}
156 156
157 157
158/**
159 * Remove a key from the strata estimator.
160 *
161 * @param se strata estimator to remove the key from
162 * @param key key to remove
163 */
164void 158void
165strata_estimator_remove (struct StrataEstimator *se, 159strata_estimator_remove (struct StrataEstimator *se,
166 struct IBF_Key key) 160 struct IBF_Key key)
diff --git a/src/set/set_api.c b/src/set/set_api.c
index 6b3dc940c..4f73ff06c 100644
--- a/src/set/set_api.c
+++ b/src/set/set_api.c
@@ -296,7 +296,7 @@ check_iter_element (void *cls,
296 * iterator and sends an acknowledgement to the service. 296 * iterator and sends an acknowledgement to the service.
297 * 297 *
298 * @param cls the `struct GNUNET_SET_Handle *` 298 * @param cls the `struct GNUNET_SET_Handle *`
299 * @param mh the message 299 * @param msg the message
300 */ 300 */
301static void 301static void
302handle_iter_element (void *cls, 302handle_iter_element (void *cls,
@@ -669,19 +669,6 @@ GNUNET_SET_create (const struct GNUNET_CONFIGURATION_Handle *cfg,
669} 669}
670 670
671 671
672/**
673 * Add an element to the given set. After the element has been added
674 * (in the sense of being transmitted to the set service), @a cont
675 * will be called. Multiple calls to GNUNET_SET_add_element() can be
676 * queued.
677 *
678 * @param set set to add element to
679 * @param element element to add to the set
680 * @param cont continuation called after the element has been added
681 * @param cont_cls closure for @a cont
682 * @return #GNUNET_OK on success, #GNUNET_SYSERR if the
683 * set is invalid (e.g. the set service crashed)
684 */
685int 672int
686GNUNET_SET_add_element (struct GNUNET_SET_Handle *set, 673GNUNET_SET_add_element (struct GNUNET_SET_Handle *set,
687 const struct GNUNET_SET_Element *element, 674 const struct GNUNET_SET_Element *element,
@@ -716,19 +703,6 @@ GNUNET_SET_add_element (struct GNUNET_SET_Handle *set,
716} 703}
717 704
718 705
719/**
720 * Remove an element to the given set. After the element has been
721 * removed (in the sense of the request being transmitted to the set
722 * service), @a cont will be called. Multiple calls to
723 * GNUNET_SET_remove_element() can be queued
724 *
725 * @param set set to remove element from
726 * @param element element to remove from the set
727 * @param cont continuation called after the element has been removed
728 * @param cont_cls closure for @a cont
729 * @return #GNUNET_OK on success, #GNUNET_SYSERR if the
730 * set is invalid (e.g. the set service crashed)
731 */
732int 706int
733GNUNET_SET_remove_element (struct GNUNET_SET_Handle *set, 707GNUNET_SET_remove_element (struct GNUNET_SET_Handle *set,
734 const struct GNUNET_SET_Element *element, 708 const struct GNUNET_SET_Element *element,
@@ -794,20 +768,6 @@ GNUNET_SET_destroy (struct GNUNET_SET_Handle *set)
794} 768}
795 769
796 770
797/**
798 * Prepare a set operation to be evaluated with another peer.
799 * The evaluation will not start until the client provides
800 * a local set with #GNUNET_SET_commit().
801 *
802 * @param other_peer peer with the other set
803 * @param app_id hash for the application using the set
804 * @param context_msg additional information for the request
805 * @param result_mode specified how results will be returned,
806 * see `enum GNUNET_SET_ResultMode`.
807 * @param result_cb called on error or success
808 * @param result_cls closure for @e result_cb
809 * @return a handle to cancel the operation
810 */
811struct GNUNET_SET_OperationHandle * 771struct GNUNET_SET_OperationHandle *
812GNUNET_SET_prepare (const struct GNUNET_PeerIdentity *other_peer, 772GNUNET_SET_prepare (const struct GNUNET_PeerIdentity *other_peer,
813 const struct GNUNET_HashCode *app_id, 773 const struct GNUNET_HashCode *app_id,
@@ -1066,20 +1026,6 @@ GNUNET_SET_listen_cancel (struct GNUNET_SET_ListenHandle *lh)
1066} 1026}
1067 1027
1068 1028
1069/**
1070 * Accept a request we got via #GNUNET_SET_listen. Must be called during
1071 * #GNUNET_SET_listen, as the 'struct GNUNET_SET_Request' becomes invalid
1072 * afterwards.
1073 * Call #GNUNET_SET_commit to provide the local set to use for the operation,
1074 * and to begin the exchange with the remote peer.
1075 *
1076 * @param request request to accept
1077 * @param result_mode specified how results will be returned,
1078 * see `enum GNUNET_SET_ResultMode`.
1079 * @param result_cb callback for the results
1080 * @param result_cls closure for @a result_cb
1081 * @return a handle to cancel the operation
1082 */
1083struct GNUNET_SET_OperationHandle * 1029struct GNUNET_SET_OperationHandle *
1084GNUNET_SET_accept (struct GNUNET_SET_Request *request, 1030GNUNET_SET_accept (struct GNUNET_SET_Request *request,
1085 enum GNUNET_SET_ResultMode result_mode, 1031 enum GNUNET_SET_ResultMode result_mode,
@@ -1234,13 +1180,6 @@ GNUNET_SET_element_dup (const struct GNUNET_SET_Element *element)
1234} 1180}
1235 1181
1236 1182
1237/**
1238 * Hash a set element.
1239 *
1240 * @param element the element that should be hashed
1241 * @param[out] ret_hash a pointer to where the hash of @a element
1242 * should be stored
1243 */
1244void 1183void
1245GNUNET_SET_element_hash (const struct GNUNET_SET_Element *element, 1184GNUNET_SET_element_hash (const struct GNUNET_SET_Element *element,
1246 struct GNUNET_HashCode *ret_hash) 1185 struct GNUNET_HashCode *ret_hash)
diff --git a/src/seti/seti_api.c b/src/seti/seti_api.c
index 933aec0e1..6522236c6 100644
--- a/src/seti/seti_api.c
+++ b/src/seti/seti_api.c
@@ -509,19 +509,6 @@ GNUNET_SETI_destroy (struct GNUNET_SETI_Handle *set)
509} 509}
510 510
511 511
512/**
513 * Prepare a set operation to be evaluated with another peer.
514 * The evaluation will not start until the client provides
515 * a local set with #GNUNET_SETI_commit().
516 *
517 * @param other_peer peer with the other set
518 * @param app_id hash for the application using the set
519 * @param context_msg additional information for the request
520 * @param options options to use when processing the request
521 * @param result_cb called on error or success
522 * @param result_cls closure for @e result_cb
523 * @return a handle to cancel the operation
524 */
525struct GNUNET_SETI_OperationHandle * 512struct GNUNET_SETI_OperationHandle *
526GNUNET_SETI_prepare (const struct GNUNET_PeerIdentity *other_peer, 513GNUNET_SETI_prepare (const struct GNUNET_PeerIdentity *other_peer,
527 const struct GNUNET_HashCode *app_id, 514 const struct GNUNET_HashCode *app_id,
@@ -763,19 +750,6 @@ GNUNET_SETI_listen_cancel (struct GNUNET_SETI_ListenHandle *lh)
763} 750}
764 751
765 752
766/**
767 * Accept a request we got via #GNUNET_SETI_listen. Must be called during
768 * #GNUNET_SETI_listen, as the 'struct GNUNET_SETI_Request' becomes invalid
769 * afterwards.
770 * Call #GNUNET_SETI_commit to provide the local set to use for the operation,
771 * and to begin the exchange with the remote peer.
772 *
773 * @param request request to accept
774 * @param options options to use when processing the request
775 * @param result_cb callback for the results
776 * @param result_cls closure for @a result_cb
777 * @return a handle to cancel the operation
778 */
779struct GNUNET_SETI_OperationHandle * 753struct GNUNET_SETI_OperationHandle *
780GNUNET_SETI_accept (struct GNUNET_SETI_Request *request, 754GNUNET_SETI_accept (struct GNUNET_SETI_Request *request,
781 const struct GNUNET_SETI_Option options[], 755 const struct GNUNET_SETI_Option options[],
diff --git a/src/setu/ibf.c b/src/setu/ibf.c
index dbd23c320..3978aa3c6 100644
--- a/src/setu/ibf.c
+++ b/src/setu/ibf.c
@@ -216,18 +216,6 @@ ibf_is_empty (struct InvertibleBloomFilter *ibf)
216} 216}
217 217
218 218
219/**
220 * Decode and remove an element from the IBF, if possible.
221 *
222 * @param ibf the invertible bloom filter to decode
223 * @param ret_side sign of the cell's count where the decoded element came from.
224 * A negative sign indicates that the element was recovered
225 * resides in an IBF that was previously subtracted from.
226 * @param ret_id receives the hash code of the decoded element, if successful
227 * @return #GNUNET_YES if decoding an element was successful,
228 * #GNUNET_NO if the IBF is empty,
229 * #GNUNET_SYSERR if the decoding has failed
230 */
231int 219int
232ibf_decode (struct InvertibleBloomFilter *ibf, 220ibf_decode (struct InvertibleBloomFilter *ibf,
233 int *ret_side, 221 int *ret_side,
@@ -355,15 +343,6 @@ ibf_write_slice (const struct InvertibleBloomFilter *ibf,
355} 343}
356 344
357 345
358/**
359 * Packs the counter to transmit only the smallest possible amount of bytes and
360 * preventing overflow of the counter
361 * @param ibf the ibf to write
362 * @param start with which bucket to start
363 * @param count how many buckets to write
364 * @param buf buffer to write the data to
365 * @param max bit length of a counter for unpacking
366 */
367 346
368void 347void
369pack_counter (const struct InvertibleBloomFilter *ibf, 348pack_counter (const struct InvertibleBloomFilter *ibf,
@@ -428,15 +407,6 @@ pack_counter (const struct InvertibleBloomFilter *ibf,
428} 407}
429 408
430 409
431/**
432 * Unpacks the counter to transmit only the smallest possible amount of bytes and
433 * preventing overflow of the counter
434 * @param ibf the ibf to write
435 * @param start with which bucket to start
436 * @param count how many buckets to write
437 * @param buf buffer to write the data to
438 * @param max bit length of a counter for unpacking
439 */
440 410
441void 411void
442unpack_counter (const struct InvertibleBloomFilter *ibf, 412unpack_counter (const struct InvertibleBloomFilter *ibf,
diff --git a/src/setu/setu_api.c b/src/setu/setu_api.c
index faa57aaba..7fa144590 100644
--- a/src/setu/setu_api.c
+++ b/src/setu/setu_api.c
@@ -493,18 +493,6 @@ GNUNET_SETU_destroy (struct GNUNET_SETU_Handle *set)
493} 493}
494 494
495 495
496/**
497 * Prepare a set operation to be evaluated with another peer.
498 * The evaluation will not start until the client provides
499 * a local set with #GNUNET_SETU_commit().
500 *
501 * @param other_peer peer with the other set
502 * @param app_id hash for the application using the set
503 * @param context_msg additional information for the request
504 * @param result_cb called on error or success
505 * @param result_cls closure for @e result_cb
506 * @return a handle to cancel the operation
507 */
508struct GNUNET_SETU_OperationHandle * 496struct GNUNET_SETU_OperationHandle *
509GNUNET_SETU_prepare (const struct GNUNET_PeerIdentity *other_peer, 497GNUNET_SETU_prepare (const struct GNUNET_PeerIdentity *other_peer,
510 const struct GNUNET_HashCode *app_id, 498 const struct GNUNET_HashCode *app_id,
@@ -777,20 +765,6 @@ GNUNET_SETU_listen_cancel (struct GNUNET_SETU_ListenHandle *lh)
777} 765}
778 766
779 767
780/**
781 * Accept a request we got via #GNUNET_SETU_listen. Must be called during
782 * #GNUNET_SETU_listen, as the 'struct GNUNET_SETU_Request' becomes invalid
783 * afterwards.
784 * Call #GNUNET_SETU_commit to provide the local set to use for the operation,
785 * and to begin the exchange with the remote peer.
786 *
787 * @param request request to accept
788 * @param result_mode specified how results will be returned,
789 * see `enum GNUNET_SETU_ResultMode`.
790 * @param result_cb callback for the results
791 * @param result_cls closure for @a result_cb
792 * @return a handle to cancel the operation
793 */
794struct GNUNET_SETU_OperationHandle * 768struct GNUNET_SETU_OperationHandle *
795GNUNET_SETU_accept (struct GNUNET_SETU_Request *request, 769GNUNET_SETU_accept (struct GNUNET_SETU_Request *request,
796 const struct GNUNET_SETU_Option options[], 770 const struct GNUNET_SETU_Option options[],
diff --git a/src/sq/sq.c b/src/sq/sq.c
index 7641cbacd..777fb6311 100644
--- a/src/sq/sq.c
+++ b/src/sq/sq.c
@@ -26,13 +26,6 @@
26#include "gnunet_sq_lib.h" 26#include "gnunet_sq_lib.h"
27 27
28 28
29/**
30 * Execute a prepared statement.
31 *
32 * @param db_conn database connection
33 * @param params parameters to the statement
34 * @return #GNUNET_OK on success, #GNUNET_SYSERR on error
35 */
36int 29int
37GNUNET_SQ_bind (sqlite3_stmt *stmt, 30GNUNET_SQ_bind (sqlite3_stmt *stmt,
38 const struct GNUNET_SQ_QueryParam *params) 31 const struct GNUNET_SQ_QueryParam *params)
@@ -107,12 +100,6 @@ GNUNET_SQ_extract_result (sqlite3_stmt *result,
107} 100}
108 101
109 102
110/**
111 * Free all memory that was allocated in @a rs during
112 * #GNUNET_SQ_extract_result().
113 *
114 * @param rs reult specification to clean up
115 */
116void 103void
117GNUNET_SQ_cleanup_result (struct GNUNET_SQ_ResultSpec *rs) 104GNUNET_SQ_cleanup_result (struct GNUNET_SQ_ResultSpec *rs)
118{ 105{
diff --git a/src/sq/sq_prepare.c b/src/sq/sq_prepare.c
index e1e1834b7..b3825ee71 100644
--- a/src/sq/sq_prepare.c
+++ b/src/sq/sq_prepare.c
@@ -46,14 +46,6 @@ GNUNET_SQ_make_prepare (const char *sql,
46} 46}
47 47
48 48
49/**
50 * Prepare all statements given in the (NULL,NULL)-terminated
51 * array at @a ps
52 *
53 * @param dbh database to use
54 * @param ps array of statements to prepare
55 * @return #GNUNET_OK on success
56 */
57int 49int
58GNUNET_SQ_prepare (sqlite3 *dbh, 50GNUNET_SQ_prepare (sqlite3 *dbh,
59 const struct GNUNET_SQ_PrepareStatement *ps) 51 const struct GNUNET_SQ_PrepareStatement *ps)
diff --git a/src/sq/sq_query_helper.c b/src/sq/sq_query_helper.c
index 1f7662b95..ead1b5bdd 100644
--- a/src/sq/sq_query_helper.c
+++ b/src/sq/sq_query_helper.c
@@ -60,7 +60,7 @@ bind_fixed_blob (void *cls,
60 * @a ptr_size bytes. 60 * @a ptr_size bytes.
61 * 61 *
62 * @param ptr pointer to the query parameter to pass 62 * @param ptr pointer to the query parameter to pass
63 * @oaran ptr_size number of bytes in @a ptr 63 * @param ptr_size number of bytes in @a ptr
64 */ 64 */
65struct GNUNET_SQ_QueryParam 65struct GNUNET_SQ_QueryParam
66GNUNET_SQ_query_param_fixed_size (const void *ptr, 66GNUNET_SQ_query_param_fixed_size (const void *ptr,
diff --git a/src/statistics/gnunet-service-statistics.c b/src/statistics/gnunet-service-statistics.c
index 31c367e91..37cf524d0 100644
--- a/src/statistics/gnunet-service-statistics.c
+++ b/src/statistics/gnunet-service-statistics.c
@@ -327,7 +327,7 @@ save ()
327/** 327/**
328 * Transmit the given stats value. 328 * Transmit the given stats value.
329 * 329 *
330 * @param client receiver of the value 330 * @param ce receiver of the value
331 * @param e value to transmit 331 * @param e value to transmit
332 */ 332 */
333static void 333static void
@@ -541,9 +541,9 @@ find_subsystem_entry (struct ClientEntry *ce, const char *service)
541/** 541/**
542 * Find the statistics entry of the given subsystem. 542 * Find the statistics entry of the given subsystem.
543 * 543 *
544 * @param subsystem subsystem to look in 544 * @param se subsystem to look in
545 * @param name name of the entry to look for 545 * @param name name of the entry to look for
546 * @return statistis entry, or NULL if not found 546 * @return statistics entry, or NULL if not found
547 */ 547 */
548static struct StatsEntry * 548static struct StatsEntry *
549find_stat_entry (struct SubsystemEntry *se, const char *name) 549find_stat_entry (struct SubsystemEntry *se, const char *name)
@@ -561,7 +561,7 @@ find_stat_entry (struct SubsystemEntry *se, const char *name)
561 * Check format of SET-message. 561 * Check format of SET-message.
562 * 562 *
563 * @param cls the `struct ClientEntry` 563 * @param cls the `struct ClientEntry`
564 * @param message the actual message 564 * @param msg the actual message
565 * @return #GNUNET_OK if message is well-formed 565 * @return #GNUNET_OK if message is well-formed
566 */ 566 */
567static int 567static int
@@ -589,7 +589,7 @@ check_set (void *cls, const struct GNUNET_STATISTICS_SetMessage *msg)
589 * Handle SET-message. 589 * Handle SET-message.
590 * 590 *
591 * @param cls the `struct ClientEntry` 591 * @param cls the `struct ClientEntry`
592 * @param message the actual message 592 * @param msg the actual message
593 */ 593 */
594static void 594static void
595handle_set (void *cls, const struct GNUNET_STATISTICS_SetMessage *msg) 595handle_set (void *cls, const struct GNUNET_STATISTICS_SetMessage *msg)
diff --git a/src/statistics/statistics_api.c b/src/statistics/statistics_api.c
index 6e6acb3e5..88f127da8 100644
--- a/src/statistics/statistics_api.c
+++ b/src/statistics/statistics_api.c
@@ -446,7 +446,7 @@ check_statistics_value (void *cls,
446 * Process a #GNUNET_MESSAGE_TYPE_STATISTICS_VALUE message. 446 * Process a #GNUNET_MESSAGE_TYPE_STATISTICS_VALUE message.
447 * 447 *
448 * @param cls statistics handle 448 * @param cls statistics handle
449 * @param msg message received from the service, never NULL 449 * @param smsg message received from the service, never NULL
450 * @return #GNUNET_OK if the message was well-formed 450 * @return #GNUNET_OK if the message was well-formed
451 */ 451 */
452static void 452static void
@@ -492,7 +492,7 @@ handle_statistics_value (void *cls,
492 * We have received a watch value from the service. Process it. 492 * We have received a watch value from the service. Process it.
493 * 493 *
494 * @param cls statistics handle 494 * @param cls statistics handle
495 * @param msg the watch value message 495 * @param wvm the watch value message
496 */ 496 */
497static void 497static void
498handle_statistics_watch_value (void *cls, 498handle_statistics_watch_value (void *cls,
@@ -1061,18 +1061,6 @@ schedule_action (void *cls)
1061} 1061}
1062 1062
1063 1063
1064/**
1065 * Get statistic from the peer.
1066 *
1067 * @param handle identification of the statistics service
1068 * @param subsystem limit to the specified subsystem, NULL for our subsystem
1069 * @param name name of the statistic value, NULL for all values
1070 * @param cont continuation to call when done (can be NULL)
1071 * This callback CANNOT destroy the statistics handle in the same call.
1072 * @param proc function to call on each value
1073 * @param cls closure for @a cont and @a proc
1074 * @return NULL on error
1075 */
1076struct GNUNET_STATISTICS_GetHandle * 1064struct GNUNET_STATISTICS_GetHandle *
1077GNUNET_STATISTICS_get (struct GNUNET_STATISTICS_Handle *handle, 1065GNUNET_STATISTICS_get (struct GNUNET_STATISTICS_Handle *handle,
1078 const char *subsystem, 1066 const char *subsystem,
@@ -1114,12 +1102,6 @@ GNUNET_STATISTICS_get (struct GNUNET_STATISTICS_Handle *handle,
1114} 1102}
1115 1103
1116 1104
1117/**
1118 * Cancel a 'get' request. Must be called before the 'cont'
1119 * function is called.
1120 *
1121 * @param gh handle of the request to cancel
1122 */
1123void 1105void
1124GNUNET_STATISTICS_get_cancel (struct GNUNET_STATISTICS_GetHandle *gh) 1106GNUNET_STATISTICS_get_cancel (struct GNUNET_STATISTICS_GetHandle *gh)
1125{ 1107{
@@ -1321,15 +1303,6 @@ add_setter_action (struct GNUNET_STATISTICS_Handle *h,
1321} 1303}
1322 1304
1323 1305
1324/**
1325 * Set statistic value for the peer. Will always use our
1326 * subsystem (the argument used when "handle" was created).
1327 *
1328 * @param handle identification of the statistics service
1329 * @param name name of the statistic value
1330 * @param value new value to set
1331 * @param make_persistent should the value be kept across restarts?
1332 */
1333void 1306void
1334GNUNET_STATISTICS_set (struct GNUNET_STATISTICS_Handle *handle, 1307GNUNET_STATISTICS_set (struct GNUNET_STATISTICS_Handle *handle,
1335 const char *name, 1308 const char *name,
@@ -1347,15 +1320,6 @@ GNUNET_STATISTICS_set (struct GNUNET_STATISTICS_Handle *handle,
1347} 1320}
1348 1321
1349 1322
1350/**
1351 * Set statistic value for the peer. Will always use our
1352 * subsystem (the argument used when "handle" was created).
1353 *
1354 * @param handle identification of the statistics service
1355 * @param name name of the statistic value
1356 * @param delta change in value (added to existing value)
1357 * @param make_persistent should the value be kept across restarts?
1358 */
1359void 1323void
1360GNUNET_STATISTICS_update (struct GNUNET_STATISTICS_Handle *handle, 1324GNUNET_STATISTICS_update (struct GNUNET_STATISTICS_Handle *handle,
1361 const char *name, 1325 const char *name,
diff --git a/src/testbed-logger/testbed_logger_api.c b/src/testbed-logger/testbed_logger_api.c
index 1d6074d13..d67bdba8b 100644
--- a/src/testbed-logger/testbed_logger_api.c
+++ b/src/testbed-logger/testbed_logger_api.c
@@ -297,13 +297,6 @@ GNUNET_TESTBED_LOGGER_write (struct GNUNET_TESTBED_LOGGER_Handle *h,
297} 297}
298 298
299 299
300/**
301 * Flush the buffered data to the logger service
302 *
303 * @param h the logger handle
304 * @param cb the callback to call after the data is flushed
305 * @param cb_cls the closure for the above callback
306 */
307void 300void
308GNUNET_TESTBED_LOGGER_flush (struct GNUNET_TESTBED_LOGGER_Handle *h, 301GNUNET_TESTBED_LOGGER_flush (struct GNUNET_TESTBED_LOGGER_Handle *h,
309 GNUNET_TESTBED_LOGGER_FlushCompletion cb, 302 GNUNET_TESTBED_LOGGER_FlushCompletion cb,
diff --git a/src/testbed/gnunet-service-testbed.c b/src/testbed/gnunet-service-testbed.c
index 3ef99ae25..b2f04d5d8 100644
--- a/src/testbed/gnunet-service-testbed.c
+++ b/src/testbed/gnunet-service-testbed.c
@@ -295,11 +295,6 @@ GST_forwarded_operation_reply_relay (void *cls,
295} 295}
296 296
297 297
298/**
299 * Task to free resources when forwarded operation has been timed out
300 *
301 * @param cls the ForwardedOperationContext
302 */
303void 298void
304GST_forwarded_operation_timeout (void *cls) 299GST_forwarded_operation_timeout (void *cls)
305{ 300{
@@ -384,7 +379,7 @@ parse_shared_services (char *ss_str,
384 * Check #GNUNET_MESSAGE_TYPE_TESTBED_INIT messages 379 * Check #GNUNET_MESSAGE_TYPE_TESTBED_INIT messages
385 * 380 *
386 * @param cls identification of the client 381 * @param cls identification of the client
387 * @param message the actual message 382 * @param msg the actual message
388 * @return #GNUNET_OK if @a message is well-formed 383 * @return #GNUNET_OK if @a message is well-formed
389 */ 384 */
390static int 385static int
@@ -409,7 +404,7 @@ check_init (void *cls,
409 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_INIT messages 404 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_INIT messages
410 * 405 *
411 * @param cls identification of the client 406 * @param cls identification of the client
412 * @param message the actual message 407 * @param msg the actual message
413 */ 408 */
414static void 409static void
415handle_init (void *cls, 410handle_init (void *cls,
diff --git a/src/testbed/gnunet-service-testbed.h b/src/testbed/gnunet-service-testbed.h
index 1c6aadb59..67dfbf253 100644
--- a/src/testbed/gnunet-service-testbed.h
+++ b/src/testbed/gnunet-service-testbed.h
@@ -570,10 +570,9 @@ GST_forwarded_operation_reply_relay (void *cls,
570 570
571 571
572/** 572/**
573 * Task to free resources when forwarded operation has been timedout 573 * Task to free resources when forwarded operation has been timed out.
574 * 574 *
575 * @param cls the ForwardedOperationContext 575 * @param cls the ForwardedOperationContext
576 * @param tc the task context from scheduler
577 */ 576 */
578void 577void
579GST_forwarded_operation_timeout (void *cls); 578GST_forwarded_operation_timeout (void *cls);
@@ -669,7 +668,7 @@ check_peer_create (void *cls,
669 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_CREATEPEER messages 668 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_CREATEPEER messages
670 * 669 *
671 * @param cls identification of the client 670 * @param cls identification of the client
672 * @param message the actual message 671 * @param msg the actual message
673 */ 672 */
674void 673void
675handle_peer_create (void *cls, 674handle_peer_create (void *cls,
@@ -688,7 +687,7 @@ handle_peer_destroy (void *cls,
688 687
689 688
690/** 689/**
691 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_DESTROYPEER messages 690 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_START_PEER messages
692 * 691 *
693 * @param cls identification of the client 692 * @param cls identification of the client
694 * @param msg the actual message 693 * @param msg the actual message
@@ -702,7 +701,7 @@ handle_peer_start (void *cls,
702 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_DESTROYPEER messages 701 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_DESTROYPEER messages
703 * 702 *
704 * @param cls identification of the client 703 * @param cls identification of the client
705 * @param message the actual message 704 * @param msg the actual message
706 */ 705 */
707void 706void
708handle_peer_stop (void *cls, 707handle_peer_stop (void *cls,
@@ -746,7 +745,7 @@ check_manage_peer_service (void *cls,
746 745
747 746
748/** 747/**
749 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_MANAGE_PEER_SERVICE message 748 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_MANAGE_PEER_SERVICE messages
750 * 749 *
751 * @param cls identification of client 750 * @param cls identification of client
752 * @param msg the actual message 751 * @param msg the actual message
diff --git a/src/testbed/gnunet-service-testbed_barriers.c b/src/testbed/gnunet-service-testbed_barriers.c
index be33bd131..bc6148087 100644
--- a/src/testbed/gnunet-service-testbed_barriers.c
+++ b/src/testbed/gnunet-service-testbed_barriers.c
@@ -328,7 +328,7 @@ send_barrier_status_msg (struct Barrier *barrier,
328 * Check #GNUNET_MESSAGE_TYPE_TESTBED_BARRIER_WAIT messages. 328 * Check #GNUNET_MESSAGE_TYPE_TESTBED_BARRIER_WAIT messages.
329 * 329 *
330 * @param cls identification of the client 330 * @param cls identification of the client
331 * @param message the actual message 331 * @param msg the actual message
332 */ 332 */
333static int 333static int
334check_barrier_wait (void *cls, 334check_barrier_wait (void *cls,
@@ -347,7 +347,7 @@ check_barrier_wait (void *cls,
347 * either from the testbed driver or from a high level controller 347 * either from the testbed driver or from a high level controller
348 * 348 *
349 * @param cls identification of the client 349 * @param cls identification of the client
350 * @param message the actual message 350 * @param msg the actual message
351 */ 351 */
352static void 352static void
353handle_barrier_wait (void *cls, 353handle_barrier_wait (void *cls,
diff --git a/src/testbed/gnunet-service-testbed_peers.c b/src/testbed/gnunet-service-testbed_peers.c
index 0bfeb4583..154a6d4ec 100644
--- a/src/testbed/gnunet-service-testbed_peers.c
+++ b/src/testbed/gnunet-service-testbed_peers.c
@@ -428,12 +428,6 @@ check_peer_create (void *cls,
428} 428}
429 429
430 430
431/**
432 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_CREATEPEER messages
433 *
434 * @param cls identification of the client
435 * @param msg the actual message
436 */
437void 431void
438handle_peer_create (void *cls, 432handle_peer_create (void *cls,
439 const struct GNUNET_TESTBED_PeerCreateMessage *msg) 433 const struct GNUNET_TESTBED_PeerCreateMessage *msg)
@@ -644,12 +638,6 @@ start_peer (struct Peer *peer)
644} 638}
645 639
646 640
647/**
648 * Message handler for #GNUNET_MESSAGE_TYPE_TESTBED_START_PEER messages
649 *
650 * @param cls identification of the client
651 * @param msg the actual message
652 */
653void 641void
654handle_peer_start (void *cls, 642handle_peer_start (void *cls,
655 const struct GNUNET_TESTBED_PeerStartMessage *msg) 643 const struct GNUNET_TESTBED_PeerStartMessage *msg)
@@ -1301,12 +1289,6 @@ check_manage_peer_service (void *cls,
1301} 1289}
1302 1290
1303 1291
1304/**
1305 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_MANAGE_PEER_SERVICE messages
1306 *
1307 * @param cls identification of client
1308 * @param msg the actual message
1309 */
1310void 1292void
1311handle_manage_peer_service (void *cls, 1293handle_manage_peer_service (void *cls,
1312 const struct 1294 const struct
diff --git a/src/testbed/testbed_api.c b/src/testbed/testbed_api.c
index 18bb0c3f6..2ae0a1703 100644
--- a/src/testbed/testbed_api.c
+++ b/src/testbed/testbed_api.c
@@ -407,7 +407,7 @@ handle_add_host_confirm (void *cls,
407/** 407/**
408 * Handler for forwarded operations 408 * Handler for forwarded operations
409 * 409 *
410 * @param c the controller handle 410 * @param cls the controller handle
411 * @param opc the operation context 411 * @param opc the operation context
412 * @param msg the message 412 * @param msg the message
413 */ 413 */
@@ -432,7 +432,7 @@ handle_forwarded_operation_msg (void *cls,
432 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_ADD_HOST_SUCCESS message from 432 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_ADD_HOST_SUCCESS message from
433 * controller (testbed service) 433 * controller (testbed service)
434 * 434 *
435 * @param c the controller handler 435 * @param cls the controller handler
436 * @param msg message received 436 * @param msg message received
437 */ 437 */
438static void 438static void
@@ -536,7 +536,7 @@ handle_opsuccess (
536 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_CREATE_PEER_SUCCESS message from 536 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_CREATE_PEER_SUCCESS message from
537 * controller (testbed service) 537 * controller (testbed service)
538 * 538 *
539 * @param c the controller handle 539 * @param cls the controller handle
540 * @param msg message received 540 * @param msg message received
541 */ 541 */
542static void 542static void
@@ -594,7 +594,7 @@ handle_peer_create_success (
594 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_EVENT message from 594 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_EVENT message from
595 * controller (testbed service) 595 * controller (testbed service)
596 * 596 *
597 * @param c the controller handler 597 * @param cls the controller handler
598 * @param msg message received 598 * @param msg message received
599 */ 599 */
600static void 600static void
@@ -675,7 +675,7 @@ handle_peer_event (void *cls, const struct GNUNET_TESTBED_PeerEventMessage *msg)
675 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_CONNECT_EVENT message from 675 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_CONNECT_EVENT message from
676 * controller (testbed service) 676 * controller (testbed service)
677 * 677 *
678 * @param c the controller handler 678 * @param cls the controller handler
679 * @param msg message received 679 * @param msg message received
680 */ 680 */
681static void 681static void
@@ -751,7 +751,7 @@ handle_peer_conevent (void *cls,
751 * Validate #GNUNET_MESSAGE_TYPE_TESTBED_PEER_INFORMATION message from 751 * Validate #GNUNET_MESSAGE_TYPE_TESTBED_PEER_INFORMATION message from
752 * controller (testbed service) 752 * controller (testbed service)
753 * 753 *
754 * @param c the controller handler 754 * @param cls the controller handler
755 * @param msg message received 755 * @param msg message received
756 */ 756 */
757static int 757static int
@@ -768,7 +768,7 @@ check_peer_config (
768 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_INFORMATION message from 768 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_PEER_INFORMATION message from
769 * controller (testbed service) 769 * controller (testbed service)
770 * 770 *
771 * @param c the controller handler 771 * @param cls the controller handler
772 * @param msg message received 772 * @param msg message received
773 */ 773 */
774static void 774static void
@@ -840,7 +840,7 @@ handle_peer_config (
840 * Validate #GNUNET_MESSAGE_TYPE_TESTBED_OPERATION_FAIL_EVENT message from 840 * Validate #GNUNET_MESSAGE_TYPE_TESTBED_OPERATION_FAIL_EVENT message from
841 * controller (testbed service) 841 * controller (testbed service)
842 * 842 *
843 * @param c the controller handler 843 * @param cls the controller handler
844 * @param msg message received 844 * @param msg message received
845 * @return #GNUNET_OK if message is well-formed 845 * @return #GNUNET_OK if message is well-formed
846 */ 846 */
@@ -858,7 +858,7 @@ check_op_fail_event (
858 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_OPERATION_FAIL_EVENT message from 858 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_OPERATION_FAIL_EVENT message from
859 * controller (testbed service) 859 * controller (testbed service)
860 * 860 *
861 * @param c the controller handler 861 * @param cls the controller handler
862 * @param msg message received 862 * @param msg message received
863 */ 863 */
864static void 864static void
@@ -1037,7 +1037,7 @@ check_slave_config (void *cls,
1037 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_SLAVE_CONFIGURATION message from controller 1037 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_SLAVE_CONFIGURATION message from controller
1038 * (testbed service) 1038 * (testbed service)
1039 * 1039 *
1040 * @param c the controller handler 1040 * @param cls the controller handler
1041 * @param msg message received 1041 * @param msg message received
1042 */ 1042 */
1043static void 1043static void
@@ -1099,7 +1099,7 @@ check_link_controllers_result (
1099 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_LINK_CONTROLLERS_RESULT message from controller 1099 * Handler for #GNUNET_MESSAGE_TYPE_TESTBED_LINK_CONTROLLERS_RESULT message from controller
1100 * (testbed service) 1100 * (testbed service)
1101 * 1101 *
1102 * @param c the controller handler 1102 * @param cls the controller handler
1103 * @param msg message received 1103 * @param msg message received
1104 */ 1104 */
1105static void 1105static void
@@ -1917,21 +1917,6 @@ GNUNET_TESTBED_get_slave_config_ (void *op_cls,
1917} 1917}
1918 1918
1919 1919
1920/**
1921 * Function to acquire the configuration of a running slave controller. The
1922 * completion of the operation is signalled through the controller_cb from
1923 * GNUNET_TESTBED_controller_connect(). If the operation is successful the
1924 * handle to the configuration is available in the generic pointer of
1925 * operation_finished field of struct GNUNET_TESTBED_EventInformation.
1926 *
1927 * @param op_cls the closure for the operation
1928 * @param master the handle to master controller
1929 * @param slave_host the host where the slave controller is running; the handle
1930 * to the slave_host should remain valid until this operation is
1931 * cancelled or marked as finished
1932 * @return the operation handle; NULL if the slave_host is not registered at
1933 * master
1934 */
1935struct GNUNET_TESTBED_Operation * 1920struct GNUNET_TESTBED_Operation *
1936GNUNET_TESTBED_get_slave_config (void *op_cls, 1921GNUNET_TESTBED_get_slave_config (void *op_cls,
1937 struct GNUNET_TESTBED_Controller *master, 1922 struct GNUNET_TESTBED_Controller *master,
@@ -1946,15 +1931,6 @@ GNUNET_TESTBED_get_slave_config (void *op_cls,
1946} 1931}
1947 1932
1948 1933
1949/**
1950 * Ask the testbed controller to write the current overlay topology to
1951 * a file. Naturally, the file will only contain a snapshot as the
1952 * topology may evolve all the time.
1953 *
1954 * @param controller overlay controller to inspect
1955 * @param filename name of the file the topology should
1956 * be written to.
1957 */
1958void 1934void
1959GNUNET_TESTBED_overlay_write_topology_to_file ( 1935GNUNET_TESTBED_overlay_write_topology_to_file (
1960 struct GNUNET_TESTBED_Controller *controller, 1936 struct GNUNET_TESTBED_Controller *controller,
@@ -2170,13 +2146,6 @@ GNUNET_TESTBED_extract_config_ (const struct GNUNET_MessageHeader *msg)
2170} 2146}
2171 2147
2172 2148
2173/**
2174 * Checks the integrity of the OperationFailureEventMessage and if good returns
2175 * the error message it contains.
2176 *
2177 * @param msg the OperationFailureEventMessage
2178 * @return the error message
2179 */
2180const char * 2149const char *
2181GNUNET_TESTBED_parse_error_string_ ( 2150GNUNET_TESTBED_parse_error_string_ (
2182 const struct GNUNET_TESTBED_OperationFailureEventMessage *msg) 2151 const struct GNUNET_TESTBED_OperationFailureEventMessage *msg)
@@ -2351,22 +2320,6 @@ GNUNET_TESTBED_barrier_remove_ (struct GNUNET_TESTBED_Barrier *barrier)
2351} 2320}
2352 2321
2353 2322
2354/**
2355 * Initialise a barrier and call the given callback when the required percentage
2356 * of peers (quorum) reach the barrier OR upon error.
2357 *
2358 * @param controller the handle to the controller
2359 * @param name identification name of the barrier
2360 * @param quorum the percentage of peers that is required to reach the barrier.
2361 * Peers signal reaching a barrier by calling
2362 * GNUNET_TESTBED_barrier_reached().
2363 * @param cb the callback to call when the barrier is reached or upon error.
2364 * Cannot be NULL.
2365 * @param cls closure for the above callback
2366 * @param echo GNUNET_YES to echo the barrier crossed status message back to the
2367 * controller
2368 * @return barrier handle; NULL upon error
2369 */
2370struct GNUNET_TESTBED_Barrier * 2323struct GNUNET_TESTBED_Barrier *
2371GNUNET_TESTBED_barrier_init_ (struct GNUNET_TESTBED_Controller *controller, 2324GNUNET_TESTBED_barrier_init_ (struct GNUNET_TESTBED_Controller *controller,
2372 const char *name, 2325 const char *name,
@@ -2431,7 +2384,7 @@ GNUNET_TESTBED_barrier_init_ (struct GNUNET_TESTBED_Controller *controller,
2431 * GNUNET_TESTBED_barrier_reached(). 2384 * GNUNET_TESTBED_barrier_reached().
2432 * @param cb the callback to call when the barrier is reached or upon error. 2385 * @param cb the callback to call when the barrier is reached or upon error.
2433 * Cannot be NULL. 2386 * Cannot be NULL.
2434 * @param cls closure for the above callback 2387 * @param cb_cls closure for the above callback
2435 * @return barrier handle; NULL upon error 2388 * @return barrier handle; NULL upon error
2436 */ 2389 */
2437struct GNUNET_TESTBED_Barrier * 2390struct GNUNET_TESTBED_Barrier *
@@ -2439,13 +2392,13 @@ GNUNET_TESTBED_barrier_init (struct GNUNET_TESTBED_Controller *controller,
2439 const char *name, 2392 const char *name,
2440 unsigned int quorum, 2393 unsigned int quorum,
2441 GNUNET_TESTBED_barrier_status_cb cb, 2394 GNUNET_TESTBED_barrier_status_cb cb,
2442 void *cls) 2395 void *cb_cls)
2443{ 2396{
2444 return GNUNET_TESTBED_barrier_init_ (controller, 2397 return GNUNET_TESTBED_barrier_init_ (controller,
2445 name, 2398 name,
2446 quorum, 2399 quorum,
2447 cb, 2400 cb,
2448 cls, 2401 cb_cls,
2449 GNUNET_YES); 2402 GNUNET_YES);
2450} 2403}
2451 2404
diff --git a/src/testbed/testbed_api_barriers.c b/src/testbed/testbed_api_barriers.c
index 61578c1e6..6074beb12 100644
--- a/src/testbed/testbed_api_barriers.c
+++ b/src/testbed/testbed_api_barriers.c
@@ -160,17 +160,6 @@ mq_error_handler (void *cls,
160} 160}
161 161
162 162
163/**
164 * Wait for a barrier to be crossed. This function should be called by the
165 * peers which have been started by the testbed. If the peer is not started by
166 * testbed this function may return error
167 *
168 * @param name the name of the barrier
169 * @param cb the barrier wait callback
170 * @param cb_cls the closure for @a cb
171 * @return barrier wait handle which can be used to cancel the waiting at
172 * anytime before the callback is called. NULL upon error.
173 */
174struct GNUNET_TESTBED_BarrierWaitHandle * 163struct GNUNET_TESTBED_BarrierWaitHandle *
175GNUNET_TESTBED_barrier_wait (const char *name, 164GNUNET_TESTBED_barrier_wait (const char *name,
176 GNUNET_TESTBED_barrier_wait_cb cb, 165 GNUNET_TESTBED_barrier_wait_cb cb,
diff --git a/src/testbed/testbed_api_hosts.c b/src/testbed/testbed_api_hosts.c
index 8dd0a4893..824bd0187 100644
--- a/src/testbed/testbed_api_hosts.c
+++ b/src/testbed/testbed_api_hosts.c
@@ -215,13 +215,6 @@ GNUNET_TESTBED_host_create_by_id_ (
215} 215}
216 216
217 217
218/**
219 * Obtain the host's unique global ID.
220 *
221 * @param host handle to the host, NULL means 'localhost'
222 * @return id global host ID assigned to the host (0 is
223 * 'localhost', but then obviously not globally unique)
224 */
225uint32_t 218uint32_t
226GNUNET_TESTBED_host_get_id_ (const struct GNUNET_TESTBED_Host *host) 219GNUNET_TESTBED_host_get_id_ (const struct GNUNET_TESTBED_Host *host)
227{ 220{
@@ -393,17 +386,6 @@ GNUNET_TESTBED_host_create (const char *hostname,
393} 386}
394 387
395 388
396/**
397 * Load a set of hosts from a configuration file.
398 *
399 * @param filename file with the host specification
400 * @param cfg the configuration to use as a template while starting a controller
401 * on any of the loaded hosts. Operation queue sizes specific to a host
402 * are also read from this configuration handle
403 * @param hosts set to the hosts found in the file; caller must free this if
404 * number of hosts returned is greater than 0
405 * @return number of hosts returned in 'hosts', 0 on error
406 */
407unsigned int 389unsigned int
408GNUNET_TESTBED_hosts_load_from_file ( 390GNUNET_TESTBED_hosts_load_from_file (
409 const char *filename, 391 const char *filename,
@@ -936,7 +918,6 @@ gen_rsh_suffix_args (const char *const *append_args)
936 * Do not call GNUNET_SERVER_mst_destroy in callback 918 * Do not call GNUNET_SERVER_mst_destroy in callback
937 * 919 *
938 * @param cls closure 920 * @param cls closure
939 * @param client identification of the client
940 * @param message the actual message 921 * @param message the actual message
941 * 922 *
942 * @return #GNUNET_OK on success, #GNUNET_SYSERR to stop further processing 923 * @return #GNUNET_OK on success, #GNUNET_SYSERR to stop further processing
diff --git a/src/testbed/testbed_api_operations.c b/src/testbed/testbed_api_operations.c
index a23f8c666..ea7e71496 100644
--- a/src/testbed/testbed_api_operations.c
+++ b/src/testbed/testbed_api_operations.c
@@ -1039,14 +1039,6 @@ GNUNET_TESTBED_operation_create_ (void *cls, OperationStart start,
1039} 1039}
1040 1040
1041 1041
1042/**
1043 * Create an operation queue.
1044 *
1045 * @param type the type of operation queue
1046 * @param max_active maximum number of operations in this
1047 * queue that can be active in parallel at the same time
1048 * @return handle to the queue
1049 */
1050struct OperationQueue * 1042struct OperationQueue *
1051GNUNET_TESTBED_operation_queue_create_ (enum OperationQueueType type, 1043GNUNET_TESTBED_operation_queue_create_ (enum OperationQueueType type,
1052 unsigned int max_active) 1044 unsigned int max_active)
diff --git a/src/testbed/testbed_api_operations.h b/src/testbed/testbed_api_operations.h
index d9de5c011..2dba9c14d 100644
--- a/src/testbed/testbed_api_operations.h
+++ b/src/testbed/testbed_api_operations.h
@@ -60,8 +60,8 @@ enum OperationQueueType
60 * Create an operation queue. 60 * Create an operation queue.
61 * 61 *
62 * @param type the type of operation queue 62 * @param type the type of operation queue
63 * @param max_active maximum number of operations in this queue that can be 63 * @param max_active maximum number of operations in this
64 * active in parallel at the same time. 64 * queue that can be active in parallel at the same time.
65 * @return handle to the queue 65 * @return handle to the queue
66 */ 66 */
67struct OperationQueue * 67struct OperationQueue *
diff --git a/src/testbed/testbed_api_peers.c b/src/testbed/testbed_api_peers.c
index 99d30e85b..b8e428441 100644
--- a/src/testbed/testbed_api_peers.c
+++ b/src/testbed/testbed_api_peers.c
@@ -661,18 +661,6 @@ GNUNET_TESTBED_peer_start (void *op_cls, struct GNUNET_TESTBED_Peer *peer,
661} 661}
662 662
663 663
664/**
665 * Stop the given peer. The handle remains valid (use
666 * "GNUNET_TESTBED_peer_destroy" to fully clean up the
667 * state of the peer).
668 *
669 * @param op_cls the closure for this operation; will be set in the event
670 * information
671 * @param peer peer to stop
672 * @param pcc function to call upon completion
673 * @param pcc_cls closure for 'pcc'
674 * @return handle to the operation
675 */
676struct GNUNET_TESTBED_Operation * 664struct GNUNET_TESTBED_Operation *
677GNUNET_TESTBED_peer_stop (void *op_cls, 665GNUNET_TESTBED_peer_stop (void *op_cls,
678 struct GNUNET_TESTBED_Peer *peer, 666 struct GNUNET_TESTBED_Peer *peer,
@@ -701,20 +689,6 @@ GNUNET_TESTBED_peer_stop (void *op_cls,
701} 689}
702 690
703 691
704/**
705 * Request information about a peer. The controller callback will not be called
706 * with event type GNUNET_TESTBED_ET_OPERATION_FINISHED when result for this
707 * operation is available. Instead, the GNUNET_TESTBED_PeerInfoCallback() will
708 * be called.
709 * The peer information in the callback is valid until the operation is canceled.
710 *
711 * @param peer peer to request information about
712 * @param pit desired information
713 * @param cb the convenience callback to be called when results for this
714 * operation are available
715 * @param cb_cls the closure for the above callback
716 * @return handle to the operation
717 */
718struct GNUNET_TESTBED_Operation * 692struct GNUNET_TESTBED_Operation *
719GNUNET_TESTBED_peer_get_information (struct GNUNET_TESTBED_Peer *peer, 693GNUNET_TESTBED_peer_get_information (struct GNUNET_TESTBED_Peer *peer,
720 enum GNUNET_TESTBED_PeerInformationType 694 enum GNUNET_TESTBED_PeerInformationType
@@ -847,20 +821,6 @@ GNUNET_TESTBED_underlay_configure_link (void *op_cls,
847} 821}
848 822
849 823
850/**
851 * Both peers must have been started before calling this function.
852 * This function then obtains a HELLO from 'p1', gives it to 'p2'
853 * and asks 'p2' to connect to 'p1'.
854 *
855 * @param op_cls closure argument to give with the operation event
856 * @param cb the callback to call when this operation has finished
857 * @param cb_cls the closure for the above callback
858 * @param p1 first peer
859 * @param p2 second peer
860 * @return handle to the operation, NULL if connecting these two
861 * peers is fundamentally not possible at this time (peers
862 * not running or underlay disallows)
863 */
864struct GNUNET_TESTBED_Operation * 824struct GNUNET_TESTBED_Operation *
865GNUNET_TESTBED_overlay_connect (void *op_cls, 825GNUNET_TESTBED_overlay_connect (void *op_cls,
866 GNUNET_TESTBED_OperationCompletionCallback cb, 826 GNUNET_TESTBED_OperationCompletionCallback cb,
@@ -957,21 +917,6 @@ oprelease_manage_service (void *cls)
957} 917}
958 918
959 919
960/**
961 * Start or stop given service at a peer. This should not be called to
962 * start/stop the peer's ARM service. Use GNUNET_TESTBED_peer_start(),
963 * GNUNET_TESTBED_peer_stop() for starting/stopping peer's ARM service. Success
964 * or failure of the generated operation is signalled through the controller
965 * event callback and/or operation completion callback.
966 *
967 * @param op_cls the closure for the operation
968 * @param peer the peer whose service is to be started/stopped
969 * @param service_name the name of the service
970 * @param cb the operation completion callback
971 * @param cb_cls the closure for the operation completion callback
972 * @param start 1 to start the service; 0 to stop the service
973 * @return an operation handle; NULL upon error (peer not running)
974 */
975struct GNUNET_TESTBED_Operation * 920struct GNUNET_TESTBED_Operation *
976GNUNET_TESTBED_peer_manage_service (void *op_cls, 921GNUNET_TESTBED_peer_manage_service (void *op_cls,
977 struct GNUNET_TESTBED_Peer *peer, 922 struct GNUNET_TESTBED_Peer *peer,
diff --git a/src/testbed/testbed_api_testbed.c b/src/testbed/testbed_api_testbed.c
index e0b76ad78..8e75daae3 100644
--- a/src/testbed/testbed_api_testbed.c
+++ b/src/testbed/testbed_api_testbed.c
@@ -1005,11 +1005,6 @@ host_registration_completion (void *cls, const char *emsg)
1005} 1005}
1006 1006
1007 1007
1008/**
1009 * Task to register all hosts available in the global host list
1010 *
1011 * @param cls RunContext
1012 */
1013static void 1008static void
1014register_hosts (void *cls) 1009register_hosts (void *cls)
1015{ 1010{
diff --git a/src/testbed/testbed_api_topology.c b/src/testbed/testbed_api_topology.c
index e68e449ad..f73be378e 100644
--- a/src/testbed/testbed_api_topology.c
+++ b/src/testbed/testbed_api_topology.c
@@ -637,18 +637,6 @@ gen_topo_ring (struct TopologyContext *tc)
637} 637}
638 638
639 639
640/**
641 * Returns the number of links that are required to generate a 2d torus for the
642 * given number of peers. Also returns the arrangement (number of rows and the
643 * length of each row)
644 *
645 * @param num_peers number of peers
646 * @param rows number of rows in the 2d torus. Can be NULL
647 * @param rows_len the length of each row. This array will be allocated
648 * fresh. The caller should free it. Can be NULL
649 * @return the number of links that are required to generate a 2d torus for the
650 * given number of peers
651 */
652unsigned int 640unsigned int
653GNUNET_TESTBED_2dtorus_calc_links (unsigned int num_peers, unsigned int *rows, 641GNUNET_TESTBED_2dtorus_calc_links (unsigned int num_peers, unsigned int *rows,
654 unsigned int **rows_len) 642 unsigned int **rows_len)
@@ -1250,17 +1238,6 @@ gen_topo_clique (struct TopologyContext *tc)
1250} 1238}
1251 1239
1252 1240
1253/**
1254 * Configure overall network topology to have a particular shape.
1255 *
1256 * @param op_cls closure argument to give with the operation event
1257 * @param num_peers number of peers in @a peers
1258 * @param peers array of @a num_peers with the peers to configure
1259 * @param topo desired underlay topology to use
1260 * @param ap topology-specific options
1261 * @return handle to the operation, NULL if configuring the topology
1262 * is not allowed at this time
1263 */
1264struct GNUNET_TESTBED_Operation * 1241struct GNUNET_TESTBED_Operation *
1265GNUNET_TESTBED_underlay_configure_topology_va (void *op_cls, 1242GNUNET_TESTBED_underlay_configure_topology_va (void *op_cls,
1266 unsigned int num_peers, 1243 unsigned int num_peers,
@@ -1275,17 +1252,6 @@ GNUNET_TESTBED_underlay_configure_topology_va (void *op_cls,
1275} 1252}
1276 1253
1277 1254
1278/**
1279 * Configure overall network topology to have a particular shape.
1280 *
1281 * @param op_cls closure argument to give with the operation event
1282 * @param num_peers number of peers in @a peers
1283 * @param peers array of @a num_peers with the peers to configure
1284 * @param topo desired underlay topology to use
1285 * @param ... topology-specific options
1286 * @return handle to the operation, NULL if configuring the topology
1287 * is not allowed at this time
1288 */
1289struct GNUNET_TESTBED_Operation * 1255struct GNUNET_TESTBED_Operation *
1290GNUNET_TESTBED_underlay_configure_topology (void *op_cls, 1256GNUNET_TESTBED_underlay_configure_topology (void *op_cls,
1291 unsigned int num_peers, 1257 unsigned int num_peers,
@@ -1298,26 +1264,6 @@ GNUNET_TESTBED_underlay_configure_topology (void *op_cls,
1298} 1264}
1299 1265
1300 1266
1301/**
1302 * All peers must have been started before calling this function.
1303 * This function then connects the given peers in the P2P overlay
1304 * using the given topology.
1305 *
1306 * @param op_cls closure argument to give with the peer connect operation events
1307 * generated through this function
1308 * @param num_peers number of peers in @a peers
1309 * @param peers array of @a num_peers with the peers to configure
1310 * @param max_connections the maximums number of overlay connections that will
1311 * be made to achieve the given topology
1312 * @param comp_cb the completion callback to call when the topology generation
1313 * is completed
1314 * @param comp_cb_cls closure for the above completion callback
1315 * @param topo desired underlay topology to use
1316 * @param va topology-specific options
1317 * @return handle to the operation, NULL if connecting these
1318 * peers is fundamentally not possible at this time (peers
1319 * not running or underlay disallows) or if num_peers is less than 2
1320 */
1321struct GNUNET_TESTBED_Operation * 1267struct GNUNET_TESTBED_Operation *
1322GNUNET_TESTBED_overlay_configure_topology_va (void *op_cls, 1268GNUNET_TESTBED_overlay_configure_topology_va (void *op_cls,
1323 unsigned int num_peers, 1269 unsigned int num_peers,
@@ -1496,15 +1442,6 @@ GNUNET_TESTBED_overlay_configure_topology (void *op_cls,
1496} 1442}
1497 1443
1498 1444
1499/**
1500 * Get a topology from a string input.
1501 *
1502 * @param topology where to write the retrieved topology
1503 * @param topology_string The string to attempt to
1504 * get a configuration value from
1505 * @return #GNUNET_YES if topology string matched a
1506 * known topology, #GNUNET_NO if not
1507 */
1508int 1445int
1509GNUNET_TESTBED_topology_get_ (enum GNUNET_TESTBED_TopologyOption *topology, 1446GNUNET_TESTBED_topology_get_ (enum GNUNET_TESTBED_TopologyOption *topology,
1510 const char *topology_string) 1447 const char *topology_string)
diff --git a/src/testbed/testbed_api_topology.h b/src/testbed/testbed_api_topology.h
index 564fa421f..ffa32dfa5 100644
--- a/src/testbed/testbed_api_topology.h
+++ b/src/testbed/testbed_api_topology.h
@@ -36,6 +36,8 @@
36 * @param rows number of rows in the 2d torus. Can be NULL. 36 * @param rows number of rows in the 2d torus. Can be NULL.
37 * @param rows_len the length of each row. This array will be allocated 37 * @param rows_len the length of each row. This array will be allocated
38 * fresh. The caller should free it. Can be NULL. 38 * fresh. The caller should free it. Can be NULL.
39 * @return the number of links that are required to generate a 2d torus for the
40 * given number of peers
39 */ 41 */
40unsigned int 42unsigned int
41GNUNET_TESTBED_2dtorus_calc_links (unsigned int num_peers, unsigned int *rows, 43GNUNET_TESTBED_2dtorus_calc_links (unsigned int num_peers, unsigned int *rows,
@@ -48,8 +50,8 @@ GNUNET_TESTBED_2dtorus_calc_links (unsigned int num_peers, unsigned int *rows,
48 * @param topology where to write the retrieved topology 50 * @param topology where to write the retrieved topology
49 * @param topology_string The string to attempt to 51 * @param topology_string The string to attempt to
50 * get a configuration value from 52 * get a configuration value from
51 * @return GNUNET_YES if topology string matched a 53 * @return #GNUNET_YES if topology string matched a
52 * known topology, GNUNET_NO if not 54 * known topology, #GNUNET_NO if not
53 */ 55 */
54int 56int
55GNUNET_TESTBED_topology_get_ (enum GNUNET_TESTBED_TopologyOption *topology, 57GNUNET_TESTBED_topology_get_ (enum GNUNET_TESTBED_TopologyOption *topology,
diff --git a/src/testing/testing.c b/src/testing/testing.c
index 95651830f..22375bc98 100644
--- a/src/testing/testing.c
+++ b/src/testing/testing.c
@@ -1503,17 +1503,6 @@ disconn_status (void *cls, int connected)
1503} 1503}
1504 1504
1505 1505
1506/**
1507 * Stop a peer asynchronously using ARM API. Peer's shutdown is signaled
1508 * through the GNUNET_TESTING_PeerStopCallback().
1509 *
1510 * @param peer the peer to stop
1511 * @param cb the callback to signal peer shutdown
1512 * @param cb_cls closure for the above callback
1513 * @return #GNUNET_OK upon successfully giving the request to the ARM API (this
1514 * does not mean that the peer is successfully stopped); #GNUNET_SYSERR
1515 * upon any error.
1516 */
1517int 1506int
1518GNUNET_TESTING_peer_stop_async (struct GNUNET_TESTING_Peer *peer, 1507GNUNET_TESTING_peer_stop_async (struct GNUNET_TESTING_Peer *peer,
1519 GNUNET_TESTING_PeerStopCallback cb, 1508 GNUNET_TESTING_PeerStopCallback cb,
@@ -1581,22 +1570,6 @@ GNUNET_TESTING_peer_destroy (struct GNUNET_TESTING_Peer *peer)
1581} 1570}
1582 1571
1583 1572
1584/**
1585 * Start a single peer and run a test using the testing library.
1586 * Starts a peer using the given configuration and then invokes the
1587 * given callback. This function ALSO initializes the scheduler loop
1588 * and should thus be called directly from "main". The testcase
1589 * should self-terminate by invoking #GNUNET_SCHEDULER_shutdown().
1590 *
1591 * @param testdir only the directory name without any path. This is used for
1592 * all service homes; the directory will be created in a temporary
1593 * location depending on the underlying OS
1594 * @param cfgfilename name of the configuration file to use;
1595 * use NULL to only run with defaults
1596 * @param tm main function of the testcase
1597 * @param tm_cls closure for @a tm
1598 * @return 0 on success, 1 on error
1599 */
1600int 1573int
1601GNUNET_TESTING_peer_run (const char *testdir, 1574GNUNET_TESTING_peer_run (const char *testdir,
1602 const char *cfgfilename, 1575 const char *cfgfilename,
@@ -1648,27 +1621,6 @@ service_run_main (void *cls)
1648} 1621}
1649 1622
1650 1623
1651/**
1652 * Start a single service (no ARM, except of course if the given
1653 * service name is 'arm') and run a test using the testing library.
1654 * Starts a service using the given configuration and then invokes the
1655 * given callback. This function ALSO initializes the scheduler loop
1656 * and should thus be called directly from "main". The testcase
1657 * should self-terminate by invoking #GNUNET_SCHEDULER_shutdown().
1658 *
1659 * This function is useful if the testcase is for a single service
1660 * and if that service doesn't itself depend on other services.
1661 *
1662 * @param testdir only the directory name without any path. This is used for
1663 * all service homes; the directory will be created in a temporary
1664 * location depending on the underlying OS
1665 * @param service_name name of the service to run
1666 * @param cfgfilename name of the configuration file to use;
1667 * use NULL to only run with defaults
1668 * @param tm main function of the testcase
1669 * @param tm_cls closure for @a tm
1670 * @return 0 on success, 1 on error
1671 */
1672int 1624int
1673GNUNET_TESTING_service_run (const char *testdir, 1625GNUNET_TESTING_service_run (const char *testdir,
1674 const char *service_name, 1626 const char *service_name,
@@ -2208,13 +2160,6 @@ GNUNET_TESTING_get_connections (unsigned int num,
2208} 2160}
2209 2161
2210 2162
2211/**
2212 * Retrieve the public key from the test system with the unique node id.
2213 *
2214 * @param num The unique node id.
2215 * @param tl_system The test system.
2216 * @return The peer identity wrapping the public key.
2217 */
2218struct GNUNET_PeerIdentity * 2163struct GNUNET_PeerIdentity *
2219GNUNET_TESTING_get_pub_key (unsigned int num, 2164GNUNET_TESTING_get_pub_key (unsigned int num,
2220 const struct GNUNET_TESTING_System *tl_system) 2165 const struct GNUNET_TESTING_System *tl_system)
@@ -2418,11 +2363,6 @@ GNUNET_TESTING_get_additional_connects (unsigned int num,
2418} 2363}
2419 2364
2420 2365
2421/**
2422 * Create a GNUNET_CMDS_LOCAL_FINISHED message.
2423 *
2424 * @return The GNUNET_CMDS_LOCAL_FINISHED message.
2425*/
2426struct GNUNET_MessageHeader * 2366struct GNUNET_MessageHeader *
2427GNUNET_TESTING_send_local_test_finished_msg () 2367GNUNET_TESTING_send_local_test_finished_msg ()
2428{ 2368{
diff --git a/src/testing/testing_api_cmd_local_test_prepared.c b/src/testing/testing_api_cmd_local_test_prepared.c
index 1f470a6c1..e71d3ef45 100644
--- a/src/testing/testing_api_cmd_local_test_prepared.c
+++ b/src/testing/testing_api_cmd_local_test_prepared.c
@@ -92,14 +92,6 @@ local_test_prepared_run (void *cls,
92} 92}
93 93
94 94
95/**
96 * Create command.
97 *
98 * @param label name for command.
99 * @param write_message Callback to write messages to the master loop.
100 * @param all_local_tests_prepared Flag which will be set from outside.
101 * @return command.
102 */
103struct GNUNET_TESTING_Command 95struct GNUNET_TESTING_Command
104GNUNET_TESTING_cmd_local_test_prepared (const char *label, 96GNUNET_TESTING_cmd_local_test_prepared (const char *label,
105 TESTING_CMD_HELPER_write_cb 97 TESTING_CMD_HELPER_write_cb
diff --git a/src/testing/testing_api_loop.c b/src/testing/testing_api_loop.c
index 283284f26..90713e45e 100644
--- a/src/testing/testing_api_loop.c
+++ b/src/testing/testing_api_loop.c
@@ -429,12 +429,6 @@ do_timeout (void *cls)
429} 429}
430 430
431 431
432/**
433 * Check if the command is running.
434 *
435 * @param cmd The command to check.
436 * @return GNUNET_NO if the command is not running, GNUNET_YES if it is running.
437 */
438enum GNUNET_GenericReturnValue 432enum GNUNET_GenericReturnValue
439GNUNET_TESTING_running (const struct GNUNET_TESTING_Command *command) 433GNUNET_TESTING_running (const struct GNUNET_TESTING_Command *command)
440{ 434{
@@ -443,12 +437,6 @@ GNUNET_TESTING_running (const struct GNUNET_TESTING_Command *command)
443} 437}
444 438
445 439
446/**
447 * Check if a command is finished.
448 *
449 * @param cmd The command to check.
450 * @return GNUNET_NO if the command is not finished, GNUNET_YES if it is finished.
451 */
452enum GNUNET_GenericReturnValue 440enum GNUNET_GenericReturnValue
453GNUNET_TESTING_finished (struct GNUNET_TESTING_Command *command) 441GNUNET_TESTING_finished (struct GNUNET_TESTING_Command *command)
454{ 442{
diff --git a/src/transport/gnunet-communicator-tcp.c b/src/transport/gnunet-communicator-tcp.c
index 2a5290bf9..4820caf70 100644
--- a/src/transport/gnunet-communicator-tcp.c
+++ b/src/transport/gnunet-communicator-tcp.c
@@ -981,7 +981,7 @@ queue_destroy (struct Queue *queue)
981 * @param[in,out] hmac_secret secret for HMAC calculation 981 * @param[in,out] hmac_secret secret for HMAC calculation
982 * @param buf buffer to MAC 982 * @param buf buffer to MAC
983 * @param buf_size number of bytes in @a buf 983 * @param buf_size number of bytes in @a buf
984 * @param smac[out] where to write the HMAC 984 * @param[out] smac where to write the HMAC
985 */ 985 */
986static void 986static void
987calculate_hmac (struct GNUNET_HashCode *hmac_secret, 987calculate_hmac (struct GNUNET_HashCode *hmac_secret,
@@ -1155,8 +1155,8 @@ pass_plaintext_to_core (struct Queue *queue,
1155 * 1155 *
1156 * @param dh shared secret 1156 * @param dh shared secret
1157 * @param pid decrypting peer's identity 1157 * @param pid decrypting peer's identity
1158 * @param cipher[out] cipher to initialize 1158 * @param[out] cipher cipher to initialize
1159 * @param hmac_key[out] HMAC key to initialize 1159 * @param[out] hmac_key HMAC key to initialize
1160 */ 1160 */
1161static void 1161static void
1162setup_cipher (const struct GNUNET_HashCode *dh, 1162setup_cipher (const struct GNUNET_HashCode *dh,
@@ -1287,7 +1287,7 @@ rekey_monotime_cb (void *cls,
1287 * Setup cipher of @a queue for decryption. 1287 * Setup cipher of @a queue for decryption.
1288 * 1288 *
1289 * @param ephemeral ephemeral key we received from the other peer 1289 * @param ephemeral ephemeral key we received from the other peer
1290 * @param queue[in,out] queue to initialize decryption cipher for 1290 * @param[in,out] queue queue to initialize decryption cipher for
1291 */ 1291 */
1292static void 1292static void
1293setup_in_cipher (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral, 1293setup_in_cipher (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral,
@@ -1448,8 +1448,8 @@ handshake_ack_monotime_cb (void *cls,
1448 * @param queue The queue context. 1448 * @param queue The queue context.
1449 */ 1449 */
1450static void 1450static void
1451send_challenge (struct GNUNET_CRYPTO_ChallengeNonceP challenge, struct 1451send_challenge (struct GNUNET_CRYPTO_ChallengeNonceP challenge,
1452 Queue *queue) 1452 struct Queue *queue)
1453{ 1453{
1454 struct TCPConfirmationAck tca; 1454 struct TCPConfirmationAck tca;
1455 struct TcpHandshakeAckSignature thas; 1455 struct TcpHandshakeAckSignature thas;
@@ -2613,7 +2613,7 @@ handshake_monotime_cb (void *cls,
2613 * Note that #setup_in_cipher() must have already been called. 2613 * Note that #setup_in_cipher() must have already been called.
2614 * 2614 *
2615 * @param queue queue to decrypt initial bytes from other peer for 2615 * @param queue queue to decrypt initial bytes from other peer for
2616 * @param tc[out] where to store the result 2616 * @param[out] tc where to store the result
2617 * @param ibuf incoming data, of size 2617 * @param ibuf incoming data, of size
2618 * `INITIAL_KX_SIZE` 2618 * `INITIAL_KX_SIZE`
2619 * @return #GNUNET_OK if the signature was OK, #GNUNET_SYSERR if not 2619 * @return #GNUNET_OK if the signature was OK, #GNUNET_SYSERR if not
@@ -3179,7 +3179,7 @@ enc_notify_cb (void *cls,
3179 * a function to call whenever our set of 'valid' addresses changes. 3179 * a function to call whenever our set of 'valid' addresses changes.
3180 * 3180 *
3181 * @param cls closure 3181 * @param cls closure
3182 * @param app_ctx[in,out] location where the app can store stuff 3182 * @param[in,out] app_ctx location where the app can store stuff
3183 * on add and retrieve it on remove 3183 * on add and retrieve it on remove
3184 * @param add_remove #GNUNET_YES to add a new public IP address, 3184 * @param add_remove #GNUNET_YES to add a new public IP address,
3185 * #GNUNET_NO to remove a previous (now invalid) one 3185 * #GNUNET_NO to remove a previous (now invalid) one
diff --git a/src/transport/gnunet-communicator-udp.c b/src/transport/gnunet-communicator-udp.c
index 07beeac38..2748a6594 100644
--- a/src/transport/gnunet-communicator-udp.c
+++ b/src/transport/gnunet-communicator-udp.c
@@ -998,7 +998,7 @@ kce_destroy (struct KeyCacheEntry *kce)
998 * 998 *
999 * @param msec master secret for HMAC calculation 999 * @param msec master secret for HMAC calculation
1000 * @param serial number for the @a smac calculation 1000 * @param serial number for the @a smac calculation
1001 * @param kid[out] where to write the key ID 1001 * @param[out] kid where to write the key ID
1002 */ 1002 */
1003static void 1003static void
1004get_kid (const struct GNUNET_HashCode *msec, 1004get_kid (const struct GNUNET_HashCode *msec,
@@ -1130,8 +1130,8 @@ sender_destroy (struct SenderAddress *sender)
1130 * 1130 *
1131 * @param msec master secret for calculation 1131 * @param msec master secret for calculation
1132 * @param serial number for the @a smac calculation 1132 * @param serial number for the @a smac calculation
1133 * @param key[out] where to write the decryption key 1133 * @param[out] key where to write the decryption key
1134 * @param iv[out] where to write the IV 1134 * @param[out] iv where to write the IV
1135 */ 1135 */
1136static void 1136static void
1137get_iv_key (const struct GNUNET_HashCode *msec, 1137get_iv_key (const struct GNUNET_HashCode *msec,
@@ -1237,7 +1237,7 @@ check_timeouts (void *cls)
1237/** 1237/**
1238 * Calculate cmac from master in @a ss. 1238 * Calculate cmac from master in @a ss.
1239 * 1239 *
1240 * @param ss[in,out] data structure to complete 1240 * @param[in,out] ss data structure to complete
1241 */ 1241 */
1242static void 1242static void
1243calculate_cmac (struct SharedSecret *ss) 1243calculate_cmac (struct SharedSecret *ss)
@@ -1397,7 +1397,7 @@ setup_shared_secret_dec (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral)
1397 * Setup shared secret for encryption. 1397 * Setup shared secret for encryption.
1398 * 1398 *
1399 * @param ephemeral ephemeral key we are sending to the other peer 1399 * @param ephemeral ephemeral key we are sending to the other peer
1400 * @param receiver[in,out] queue to initialize encryption key for 1400 * @param[in,out] receiver queue to initialize encryption key for
1401 * @return new shared secret 1401 * @return new shared secret
1402 */ 1402 */
1403static struct SharedSecret * 1403static struct SharedSecret *
@@ -2198,7 +2198,7 @@ setup_sender (const struct GNUNET_PeerIdentity *target,
2198/** 2198/**
2199 * Check signature from @a uc against @a ephemeral. 2199 * Check signature from @a uc against @a ephemeral.
2200 * 2200 *
2201 * @param ephermal key that is signed 2201 * @param ephemeral key that is signed
2202 * @param uc signature of claimant 2202 * @param uc signature of claimant
2203 * @return #GNUNET_OK if signature is valid 2203 * @return #GNUNET_OK if signature is valid
2204 */ 2204 */
diff --git a/src/transport/gnunet-service-tng.c b/src/transport/gnunet-service-tng.c
index ae4d65bcf..5976bd5b1 100644
--- a/src/transport/gnunet-service-tng.c
+++ b/src/transport/gnunet-service-tng.c
@@ -3296,7 +3296,7 @@ struct MonitorEvent
3296 3296
3297 3297
3298/** 3298/**
3299 * Free a @dvh. Callers MAY want to check if this was the last path to the 3299 * Free a @a dvh. Callers MAY want to check if this was the last path to the
3300 * `target`, and if so call #free_dv_route to also free the associated DV 3300 * `target`, and if so call #free_dv_route to also free the associated DV
3301 * entry in #dv_routes (if not, the associated scheduler job should eventually 3301 * entry in #dv_routes (if not, the associated scheduler job should eventually
3302 * take care of it). 3302 * take care of it).
@@ -4136,7 +4136,7 @@ client_send_response (struct PendingMessage *pm)
4136 * 4136 *
4137 * @param dv data structure to pick paths from 4137 * @param dv data structure to pick paths from
4138 * @param options constraints to satisfy 4138 * @param options constraints to satisfy
4139 * @param hops_array[out] set to the result 4139 * @param[out] hops_array set to the result
4140 * @param hops_array_length length of the @a hops_array 4140 * @param hops_array_length length of the @a hops_array
4141 * @return number of entries set in @a hops_array 4141 * @return number of entries set in @a hops_array
4142 */ 4142 */
@@ -4404,7 +4404,7 @@ check_communicator_backchannel (
4404 * Ensure ephemeral keys in our @a dv are current. If no current one exists, 4404 * Ensure ephemeral keys in our @a dv are current. If no current one exists,
4405 * set it up. 4405 * set it up.
4406 * 4406 *
4407 * @param dv[in,out] virtual link to update ephemeral for 4407 * @param[in,out] dv virtual link to update ephemeral for
4408 */ 4408 */
4409static void 4409static void
4410update_ephemeral (struct DistanceVector *dv) 4410update_ephemeral (struct DistanceVector *dv)
@@ -4637,7 +4637,7 @@ struct DVKeyState
4637 * 4637 *
4638 * @param km raw master secret 4638 * @param km raw master secret
4639 * @param iv initialization vector 4639 * @param iv initialization vector
4640 * @param key[out] symmetric cipher and HMAC state to generate 4640 * @param[out] key symmetric cipher and HMAC state to generate
4641 */ 4641 */
4642static void 4642static void
4643dv_setup_key_state_from_km (const struct GNUNET_HashCode *km, 4643dv_setup_key_state_from_km (const struct GNUNET_HashCode *km,
@@ -4679,7 +4679,7 @@ dv_setup_key_state_from_km (const struct GNUNET_HashCode *km,
4679 * @param priv_ephemeral ephemeral private key to use 4679 * @param priv_ephemeral ephemeral private key to use
4680 * @param target the target peer to encrypt to 4680 * @param target the target peer to encrypt to
4681 * @param iv unique IV to use 4681 * @param iv unique IV to use
4682 * @param key[out] set to the key material 4682 * @param[out] key set to the key material
4683 */ 4683 */
4684static void 4684static void
4685dh_key_derive_eph_pid ( 4685dh_key_derive_eph_pid (
@@ -4704,7 +4704,7 @@ dh_key_derive_eph_pid (
4704 * @param priv_ephemeral ephemeral private key to use 4704 * @param priv_ephemeral ephemeral private key to use
4705 * @param target the target peer to encrypt to 4705 * @param target the target peer to encrypt to
4706 * @param iv unique IV to use 4706 * @param iv unique IV to use
4707 * @param key[out] set to the key material 4707 * @param[out] key set to the key material
4708 */ 4708 */
4709static void 4709static void
4710dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral, 4710dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral,
@@ -4725,7 +4725,7 @@ dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral,
4725 * material from @a key. 4725 * material from @a key.
4726 * 4726 *
4727 * @param key key material (from DH) 4727 * @param key key material (from DH)
4728 * @param hmac[out] set to the HMAC 4728 * @param[out] hmac set to the HMAC
4729 * @param data data to perform HMAC calculation over 4729 * @param data data to perform HMAC calculation over
4730 * @param data_size number of bytes in @a data 4730 * @param data_size number of bytes in @a data
4731 */ 4731 */
@@ -4743,7 +4743,7 @@ dv_hmac (const struct DVKeyState *key,
4743 * Perform backchannel encryption using symmetric secret in @a key 4743 * Perform backchannel encryption using symmetric secret in @a key
4744 * to encrypt data from @a in to @a dst. 4744 * to encrypt data from @a in to @a dst.
4745 * 4745 *
4746 * @param key[in,out] key material to use 4746 * @param[in,out] key key material to use
4747 * @param dst where to write the result 4747 * @param dst where to write the result
4748 * @param in input data to encrypt (plaintext) 4748 * @param in input data to encrypt (plaintext)
4749 * @param in_size number of bytes of input in @a in and available at @a dst 4749 * @param in_size number of bytes of input in @a in and available at @a dst
@@ -4760,9 +4760,9 @@ dv_encrypt (struct DVKeyState *key, const void *in, void *dst, size_t in_size)
4760 * Perform backchannel encryption using symmetric secret in @a key 4760 * Perform backchannel encryption using symmetric secret in @a key
4761 * to encrypt data from @a in to @a dst. 4761 * to encrypt data from @a in to @a dst.
4762 * 4762 *
4763 * @param key[in,out] key material to use 4763 * @param[in,out] key key material to use
4764 * @param ciph cipher text to decrypt 4764 * @param ciph cipher text to decrypt
4765 * @param out[out] output data to generate (plaintext) 4765 * @param[out] out output data to generate (plaintext)
4766 * @param out_size number of bytes of input in @a ciph and available in @a out 4766 * @param out_size number of bytes of input in @a ciph and available in @a out
4767 */ 4767 */
4768static void 4768static void
@@ -4815,7 +4815,7 @@ typedef void (*DVMessageHandler) (void *cls,
4815 * @param use function to call with the encapsulated message 4815 * @param use function to call with the encapsulated message
4816 * @param use_cls closure for @a use 4816 * @param use_cls closure for @a use
4817 * @param options whether path must be confirmed or not, to be passed to @a use 4817 * @param options whether path must be confirmed or not, to be passed to @a use
4818 * @param shall this TransportDVBoxMessage be forwarded without flow control. 4818 * @param without_fc shall this TransportDVBoxMessage be forwarded without flow control.
4819 * @return expected RTT for transmission, #GNUNET_TIME_UNIT_FOREVER_REL if sending failed 4819 * @return expected RTT for transmission, #GNUNET_TIME_UNIT_FOREVER_REL if sending failed
4820 */ 4820 */
4821static struct GNUNET_TIME_Relative 4821static struct GNUNET_TIME_Relative
@@ -6274,7 +6274,7 @@ handle_reliability_box (void *cls,
6274 * so, purge ancient statistics (more than GOODPUT_AGING_SLOTS before 6274 * so, purge ancient statistics (more than GOODPUT_AGING_SLOTS before
6275 * the current age) 6275 * the current age)
6276 * 6276 *
6277 * @param pd[in,out] data to update 6277 * @param[in,out] pd data to update
6278 * @param age current age 6278 * @param age current age
6279 */ 6279 */
6280static void 6280static void
@@ -6300,7 +6300,7 @@ update_pd_age (struct PerformanceData *pd, unsigned int age)
6300 * Update @a pd based on the latest @a rtt and the number of bytes 6300 * Update @a pd based on the latest @a rtt and the number of bytes
6301 * that were confirmed to be successfully transmitted. 6301 * that were confirmed to be successfully transmitted.
6302 * 6302 *
6303 * @param pd[in,out] data to update 6303 * @param[in,out] pd data to update
6304 * @param rtt latest round-trip time 6304 * @param rtt latest round-trip time
6305 * @param bytes_transmitted_ok number of bytes receiver confirmed as received 6305 * @param bytes_transmitted_ok number of bytes receiver confirmed as received
6306 */ 6306 */
@@ -7817,7 +7817,7 @@ check_dv_box (void *cls, const struct TransportDVBoxMessage *dvb)
7817 7817
7818/** 7818/**
7819 * Create a DV Box message and queue it for transmission to 7819 * Create a DV Box message and queue it for transmission to
7820 * @ea next_hop. 7820 * @a next_hop.
7821 * 7821 *
7822 * @param next_hop peer to receive the message next 7822 * @param next_hop peer to receive the message next
7823 * @param total_hops how many hops did the message take so far 7823 * @param total_hops how many hops did the message take so far
@@ -8371,7 +8371,7 @@ handle_dv_box (void *cls, const struct TransportDVBoxMessage *dvb)
8371 * Client notified us about transmission from a peer. Process the request. 8371 * Client notified us about transmission from a peer. Process the request.
8372 * 8372 *
8373 * @param cls a `struct TransportClient` which sent us the message 8373 * @param cls a `struct TransportClient` which sent us the message
8374 * @param obm the send message that was sent 8374 * @param im the send message that was sent
8375 * @return #GNUNET_YES if message is well-formed 8375 * @return #GNUNET_YES if message is well-formed
8376 */ 8376 */
8377static int 8377static int
@@ -9597,7 +9597,7 @@ struct PendingMessageScoreContext
9597 * Select the best pending message from @a vl for transmission 9597 * Select the best pending message from @a vl for transmission
9598 * via @a queue. 9598 * via @a queue.
9599 * 9599 *
9600 * @param sc[in,out] best message so far (NULL for none), plus scoring data 9600 * @param[in,out] sc best message so far (NULL for none), plus scoring data
9601 * @param queue the queue that will be used for transmission 9601 * @param queue the queue that will be used for transmission
9602 * @param vl the virtual link providing the messages 9602 * @param vl the virtual link providing the messages
9603 * @param dvh path we are currently considering, or NULL for none 9603 * @param dvh path we are currently considering, or NULL for none
diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index 345a0d949..93790e293 100644
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -2120,7 +2120,7 @@ free_blacklist_entry (void *cls,
2120 * Set traffic metric to manipulate 2120 * Set traffic metric to manipulate
2121 * 2121 *
2122 * @param cls closure 2122 * @param cls closure
2123 * @param message containing information 2123 * @param tm message containing information
2124 */ 2124 */
2125static void 2125static void
2126handle_client_set_metric (void *cls, const struct TrafficMetricMessage *tm) 2126handle_client_set_metric (void *cls, const struct TrafficMetricMessage *tm)
@@ -2486,11 +2486,6 @@ GST_blacklist_test_allowed (const struct GNUNET_PeerIdentity *peer,
2486} 2486}
2487 2487
2488 2488
2489/**
2490 * Cancel a blacklist check.
2491 *
2492 * @param bc check to cancel
2493 */
2494void 2489void
2495GST_blacklist_test_cancel (struct GST_BlacklistCheck *bc) 2490GST_blacklist_test_cancel (struct GST_BlacklistCheck *bc)
2496{ 2491{
diff --git a/src/transport/gnunet-service-transport_ats.c b/src/transport/gnunet-service-transport_ats.c
index 130311e15..2438a0a48 100644
--- a/src/transport/gnunet-service-transport_ats.c
+++ b/src/transport/gnunet-service-transport_ats.c
@@ -477,13 +477,6 @@ GST_ats_add_inbound_address (const struct GNUNET_HELLO_Address *address,
477} 477}
478 478
479 479
480/**
481 * Notify ATS about the new address including the network this address is
482 * located in. The address must NOT be inbound and must be new to ATS.
483 *
484 * @param address the address
485 * @param prop performance information
486 */
487void 480void
488GST_ats_add_address (const struct GNUNET_HELLO_Address *address, 481GST_ats_add_address (const struct GNUNET_HELLO_Address *address,
489 const struct GNUNET_ATS_Properties *prop) 482 const struct GNUNET_ATS_Properties *prop)
@@ -755,13 +748,6 @@ GST_ats_update_distance (const struct GNUNET_HELLO_Address *address,
755} 748}
756 749
757 750
758/**
759 * Notify ATS about @a delay changes to properties of an @a address.
760 * Does nothing if the @a address is not known to us.
761 *
762 * @param address the address
763 * @param delay new delay value
764 */
765void 751void
766GST_ats_update_delay (const struct GNUNET_HELLO_Address *address, 752GST_ats_update_delay (const struct GNUNET_HELLO_Address *address,
767 struct GNUNET_TIME_Relative delay) 753 struct GNUNET_TIME_Relative delay)
diff --git a/src/transport/gnunet-service-transport_ats.h b/src/transport/gnunet-service-transport_ats.h
index d536714ec..ca972d1cc 100644
--- a/src/transport/gnunet-service-transport_ats.h
+++ b/src/transport/gnunet-service-transport_ats.h
@@ -110,7 +110,7 @@ GST_ats_add_inbound_address (const struct GNUNET_HELLO_Address *address,
110 110
111 111
112/** 112/**
113 * Notify ATS about a new address including the network this address is 113 * Notify ATS about a new address including the network the address is
114 * located in. The address must NOT be inbound and must be new to ATS. 114 * located in. The address must NOT be inbound and must be new to ATS.
115 * 115 *
116 * @param address the address 116 * @param address the address
@@ -154,7 +154,6 @@ GST_ats_update_utilization (const struct GNUNET_HELLO_Address *address,
154 * Does nothing if the @a address is not known to us. 154 * Does nothing if the @a address is not known to us.
155 * 155 *
156 * @param address the address 156 * @param address the address
157 * @param session the session
158 * @param delay new delay value 157 * @param delay new delay value
159 */ 158 */
160void 159void
diff --git a/src/transport/gnunet-service-transport_hello.c b/src/transport/gnunet-service-transport_hello.c
index 472c77c27..1e5e8a225 100644
--- a/src/transport/gnunet-service-transport_hello.c
+++ b/src/transport/gnunet-service-transport_hello.c
@@ -334,16 +334,6 @@ GST_hello_modify_addresses (int addremove,
334} 334}
335 335
336 336
337/**
338 * Test if a particular address is one of ours.
339 *
340 * @param address address to test
341 * @param sig location where to cache PONG signatures for this address [set]
342 * @param sig_expiration how long until the current 'sig' expires?
343 * (ZERO if sig was never created) [set]
344 * @return #GNUNET_YES if this is one of our addresses,
345 * #GNUNET_NO if not
346 */
347int 337int
348GST_hello_test_address (const struct GNUNET_HELLO_Address *address, 338GST_hello_test_address (const struct GNUNET_HELLO_Address *address,
349 struct GNUNET_CRYPTO_EddsaSignature **sig, 339 struct GNUNET_CRYPTO_EddsaSignature **sig,
diff --git a/src/transport/gnunet-service-transport_manipulation.c b/src/transport/gnunet-service-transport_manipulation.c
index 04d1774c0..9f39b2dca 100644
--- a/src/transport/gnunet-service-transport_manipulation.c
+++ b/src/transport/gnunet-service-transport_manipulation.c
@@ -168,7 +168,7 @@ static struct GNUNET_SCHEDULER_Task *generic_send_delay_task;
168/** 168/**
169 * Set traffic metric to manipulate 169 * Set traffic metric to manipulate
170 * 170 *
171 * @param message containing information 171 * @param tm message containing information
172 */ 172 */
173void 173void
174GST_manipulation_set_metric (const struct TrafficMetricMessage *tm) 174GST_manipulation_set_metric (const struct TrafficMetricMessage *tm)
@@ -349,7 +349,7 @@ GST_manipulation_send (const struct GNUNET_PeerIdentity *target,
349 * 349 *
350 * @param address binary address 350 * @param address binary address
351 * @param session the session 351 * @param session the session
352 * @param prop[IN|OUT] metrics to modify 352 * @param[in,out] prop metrics to modify
353 */ 353 */
354void 354void
355GST_manipulation_manipulate_metrics (const struct GNUNET_HELLO_Address *address, 355GST_manipulation_manipulate_metrics (const struct GNUNET_HELLO_Address *address,
diff --git a/src/transport/gnunet-service-transport_neighbours.c b/src/transport/gnunet-service-transport_neighbours.c
index ca1b4d1da..e61441d9f 100644
--- a/src/transport/gnunet-service-transport_neighbours.c
+++ b/src/transport/gnunet-service-transport_neighbours.c
@@ -1768,16 +1768,6 @@ GST_neighbours_calculate_receive_delay (const struct
1768} 1768}
1769 1769
1770 1770
1771/**
1772 * Transmit a message to the given target using the active connection.
1773 *
1774 * @param target destination
1775 * @param msg message to send
1776 * @param msg_size number of bytes in msg
1777 * @param timeout when to fail with timeout
1778 * @param cont function to call when done
1779 * @param cont_cls closure for @a cont
1780 */
1781void 1771void
1782GST_neighbours_send (const struct GNUNET_PeerIdentity *target, 1772GST_neighbours_send (const struct GNUNET_PeerIdentity *target,
1783 const void *msg, 1773 const void *msg,
@@ -3019,13 +3009,6 @@ GST_neighbours_notify_data_sent (const struct GNUNET_HELLO_Address *address,
3019} 3009}
3020 3010
3021 3011
3022/**
3023 * Master task run for every neighbour. Performs all of the time-related
3024 * activities (keep alive, send next message, disconnect if idle, finish
3025 * clean up after disconnect).
3026 *
3027 * @param cls the 'struct NeighbourMapEntry' for which we are running
3028 */
3029static void 3012static void
3030master_task (void *cls) 3013master_task (void *cls)
3031{ 3014{
@@ -3646,13 +3629,6 @@ delayed_disconnect (void *cls)
3646} 3629}
3647 3630
3648 3631
3649/**
3650 * We received a quota message from the given peer,
3651 * validate and process.
3652 *
3653 * @param peer sender of the message
3654 * @param msg the quota message
3655 */
3656void 3632void
3657GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer, 3633GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer,
3658 const struct GNUNET_MessageHeader *msg) 3634 const struct GNUNET_MessageHeader *msg)
diff --git a/src/transport/gnunet-service-transport_neighbours.h b/src/transport/gnunet-service-transport_neighbours.h
index 13aeab4e6..7ce911aa1 100644
--- a/src/transport/gnunet-service-transport_neighbours.h
+++ b/src/transport/gnunet-service-transport_neighbours.h
@@ -292,7 +292,7 @@ GST_neighbour_get_current_address (const struct GNUNET_PeerIdentity *peer);
292 292
293 293
294/** 294/**
295 * We received a quoat message from the given peer, 295 * We received a quota message from the given peer,
296 * validate and process. 296 * validate and process.
297 * 297 *
298 * @param peer sender of the message 298 * @param peer sender of the message
diff --git a/src/transport/gnunet-service-transport_plugins.c b/src/transport/gnunet-service-transport_plugins.c
index c88532806..218ef80ab 100644
--- a/src/transport/gnunet-service-transport_plugins.c
+++ b/src/transport/gnunet-service-transport_plugins.c
@@ -83,7 +83,6 @@ static struct TransportPlugin *plugins_tail;
83 * 83 *
84 * @param cls closure 84 * @param cls closure
85 * @param address address to update metrics for 85 * @param address address to update metrics for
86 * @param session the session
87 * @param distance new distance 86 * @param distance new distance
88 */ 87 */
89static void 88static void
@@ -121,18 +120,6 @@ plugin_env_address_to_type (void *cls,
121} 120}
122 121
123 122
124/**
125 * Load and initialize all plugins. The respective functions will be
126 * invoked by the plugins when the respective events happen. The
127 * closure will be set to a 'const char*' containing the name of the
128 * plugin that caused the call.
129 *
130 * @param recv_cb function to call when data is received
131 * @param address_cb function to call when our public addresses changed
132 * @param session_start_cb function to call when a session was created
133 * @param session_end_cb function to call when a session was terminated
134 * @param address_type_cb function to call when a address type is requested
135 */
136void 123void
137GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb, 124GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb,
138 GNUNET_TRANSPORT_AddressNotification address_cb, 125 GNUNET_TRANSPORT_AddressNotification address_cb,
@@ -431,12 +418,6 @@ GST_plugins_a2s (const struct GNUNET_HELLO_Address *address)
431} 418}
432 419
433 420
434/**
435 * Register callback with all plugins to monitor their status.
436 *
437 * @param cb callback to register, NULL to unsubscribe
438 * @param cb_cls closure for @a cb
439 */
440void 421void
441GST_plugins_monitor_subscribe (GNUNET_TRANSPORT_SessionInfoCallback cb, 422GST_plugins_monitor_subscribe (GNUNET_TRANSPORT_SessionInfoCallback cb,
442 void *cb_cls) 423 void *cb_cls)
diff --git a/src/transport/gnunet-service-transport_plugins.h b/src/transport/gnunet-service-transport_plugins.h
index 0e69da074..fdd819fc5 100644
--- a/src/transport/gnunet-service-transport_plugins.h
+++ b/src/transport/gnunet-service-transport_plugins.h
@@ -40,13 +40,9 @@
40 * plugin that caused the call. 40 * plugin that caused the call.
41 * 41 *
42 * @param recv_cb function to call when data is received 42 * @param recv_cb function to call when data is received
43 * @param register_quota_cb function to call to register a quota callback
44 * @param unregister_quota_cb function to call to unregister a quota callback
45 * @param address_cb function to call when our public addresses changed 43 * @param address_cb function to call when our public addresses changed
46 * @param session_start_cb function to call when a session was created 44 * @param session_start_cb function to call when a session was created
47 * @param session_end_cb function to call when a session was terminated 45 * @param session_end_cb function to call when a session was terminated
48 * @param address_type_cb function to call when a address type is requested
49 * @param metric_update_cb function to call when address metrics change
50 */ 46 */
51void 47void
52GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb, 48GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb,
diff --git a/src/transport/plugin_transport_http_client.c b/src/transport/plugin_transport_http_client.c
index 476a3cd52..82468992b 100644
--- a/src/transport/plugin_transport_http_client.c
+++ b/src/transport/plugin_transport_http_client.c
@@ -556,7 +556,6 @@ client_reschedule_session_timeout (struct GNUNET_ATS_Session *s)
556 * Task performing curl operations 556 * Task performing curl operations
557 * 557 *
558 * @param cls plugin as closure 558 * @param cls plugin as closure
559 * @param tc gnunet scheduler task context
560 */ 559 */
561static void 560static void
562client_run (void *cls); 561client_run (void *cls);
@@ -1289,11 +1288,6 @@ client_receive (void *stream,
1289} 1288}
1290 1289
1291 1290
1292/**
1293 * Task performing curl operations
1294 *
1295 * @param cls plugin as closure
1296 */
1297static void 1291static void
1298client_run (void *cls) 1292client_run (void *cls)
1299{ 1293{
diff --git a/src/transport/plugin_transport_http_common.c b/src/transport/plugin_transport_http_common.c
index 75bf8b74a..40353daeb 100644
--- a/src/transport/plugin_transport_http_common.c
+++ b/src/transport/plugin_transport_http_common.c
@@ -407,20 +407,6 @@ http_common_dns_ip_lookup (const char *name,
407} 407}
408 408
409 409
410/**
411 * Convert the transports address to a nice, human-readable
412 * format.
413 *
414 * @param cls closure
415 * @param type name of the transport that generated the address
416 * @param addr one of the addresses of the host, NULL for the last address
417 * the specific address format depends on the transport
418 * @param addrlen length of the @a addr
419 * @param numeric should (IP) addresses be displayed in numeric form?
420 * @param timeout after how long should we give up?
421 * @param asc function to call on each string
422 * @param asc_cls closure for @a asc
423 */
424void 410void
425http_common_plugin_address_pretty_printer (void *cls, const char *type, 411http_common_plugin_address_pretty_printer (void *cls, const char *type,
426 const void *addr, 412 const void *addr,
@@ -597,17 +583,6 @@ http_common_plugin_address_to_url (void *cls,
597} 583}
598 584
599 585
600/**
601 * Function called for a quick conversion of the binary address to
602 * a numeric address. Note that the caller must not free the
603 * address and that the next call to this function is allowed
604 * to override the address again.
605 *
606 * @param plugin the name of the plugin
607 * @param addr binary address
608 * @param addrlen length of the address
609 * @return string representing the same address
610 */
611const char * 586const char *
612http_common_plugin_address_to_string (const char *plugin, 587http_common_plugin_address_to_string (const char *plugin,
613 const void *addr, 588 const void *addr,
@@ -642,18 +617,6 @@ http_common_plugin_address_to_string (const char *plugin,
642} 617}
643 618
644 619
645/**
646 * Function called to convert a string address to
647 * a binary address.
648 *
649 * @param cls closure ('struct Plugin*')
650 * @param addr string address
651 * @param addrlen length of the @a addr
652 * @param buf location to store the buffer
653 * If the function returns #GNUNET_SYSERR, its contents are undefined.
654 * @param added length of created address
655 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure
656 */
657int 620int
658http_common_plugin_string_to_address (void *cls, 621http_common_plugin_string_to_address (void *cls,
659 const char *addr, 622 const char *addr,
@@ -721,14 +684,6 @@ http_common_plugin_string_to_address (void *cls,
721} 684}
722 685
723 686
724/**
725 * Create a HTTP address from a socketaddr
726 *
727 * @param protocol protocol
728 * @param addr sockaddr * address
729 * @param addrlen length of the address
730 * @return the HttpAddress
731 */
732struct HttpAddress * 687struct HttpAddress *
733http_common_address_from_socket (const char *protocol, 688http_common_address_from_socket (const char *protocol,
734 const struct sockaddr *addr, 689 const struct sockaddr *addr,
diff --git a/src/transport/plugin_transport_http_common.h b/src/transport/plugin_transport_http_common.h
index 299dc0e68..7a532249d 100644
--- a/src/transport/plugin_transport_http_common.h
+++ b/src/transport/plugin_transport_http_common.h
@@ -137,7 +137,7 @@ http_split_address (const char *addr);
137 * @param type name of the transport that generated the address 137 * @param type name of the transport that generated the address
138 * @param addr one of the addresses of the host, NULL for the last address 138 * @param addr one of the addresses of the host, NULL for the last address
139 * the specific address format depends on the transport 139 * the specific address format depends on the transport
140 * @param addrlen length of the address 140 * @param addrlen length of @a addr
141 * @param numeric should (IP) addresses be displayed in numeric form? 141 * @param numeric should (IP) addresses be displayed in numeric form?
142 * @param timeout after how long should we give up? 142 * @param timeout after how long should we give up?
143 * @param asc function to call on each string 143 * @param asc function to call on each string
@@ -178,7 +178,7 @@ http_common_plugin_address_to_string (const char *plugin,
178 * 178 *
179 * @param cls closure (`struct Plugin*`) 179 * @param cls closure (`struct Plugin*`)
180 * @param addr string address 180 * @param addr string address
181 * @param addrlen length of the address 181 * @param addrlen length of @a addr
182 * @param buf location to store the buffer 182 * @param buf location to store the buffer
183 * If the function returns #GNUNET_SYSERR, its contents are undefined. 183 * If the function returns #GNUNET_SYSERR, its contents are undefined.
184 * @param added length of created address 184 * @param added length of created address
@@ -198,7 +198,7 @@ http_common_plugin_string_to_address (void *cls,
198 * @param protocol protocol 198 * @param protocol protocol
199 * @param addr `sockaddr *` address 199 * @param addr `sockaddr *` address
200 * @param addrlen length of the @a addr 200 * @param addrlen length of the @a addr
201 * @return the string 201 * @return A pointer to a `struct HttpAddress` derived from @a addr
202 */ 202 */
203struct HttpAddress * 203struct HttpAddress *
204http_common_address_from_socket (const char *protocol, 204http_common_address_from_socket (const char *protocol,
diff --git a/src/transport/plugin_transport_http_server.c b/src/transport/plugin_transport_http_server.c
index 78b030e9a..3ad2356b0 100644
--- a/src/transport/plugin_transport_http_server.c
+++ b/src/transport/plugin_transport_http_server.c
@@ -2563,7 +2563,7 @@ server_remove_address (void *cls,
2563 * Our external IP address/port mapping has changed. 2563 * Our external IP address/port mapping has changed.
2564 * 2564 *
2565 * @param cls closure, the 'struct LocalAddrList' 2565 * @param cls closure, the 'struct LocalAddrList'
2566 * @param app_ctx[in,out] location where the app can store stuff 2566 * @param[in,out] app_ctx location where the app can store stuff
2567 * on add and retrieve it on remove 2567 * on add and retrieve it on remove
2568 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean 2568 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean
2569 * the previous (now invalid) one 2569 * the previous (now invalid) one
diff --git a/src/transport/plugin_transport_tcp.c b/src/transport/plugin_transport_tcp.c
index ac4cc672f..ceae64709 100644
--- a/src/transport/plugin_transport_tcp.c
+++ b/src/transport/plugin_transport_tcp.c
@@ -1418,7 +1418,7 @@ notify_session_monitor (struct Plugin *plugin,
1418 * Our external IP address/port mapping has changed. 1418 * Our external IP address/port mapping has changed.
1419 * 1419 *
1420 * @param cls closure, the `struct Plugin` 1420 * @param cls closure, the `struct Plugin`
1421 * @param app_ctx[in,out] location where the app can store stuff 1421 * @param[in,out] app_ctx location where the app can store stuff
1422 * on add and retrieve it on remove 1422 * on add and retrieve it on remove
1423 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean 1423 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean
1424 * the previous (now invalid) one 1424 * the previous (now invalid) one
diff --git a/src/transport/plugin_transport_udp.c b/src/transport/plugin_transport_udp.c
index 2db31caa3..0d3ca449d 100644
--- a/src/transport/plugin_transport_udp.c
+++ b/src/transport/plugin_transport_udp.c
@@ -1254,7 +1254,7 @@ udp_plugin_check_address (void *cls, const void *addr, size_t addrlen)
1254 * Our external IP address/port mapping has changed. 1254 * Our external IP address/port mapping has changed.
1255 * 1255 *
1256 * @param cls closure, the `struct Plugin` 1256 * @param cls closure, the `struct Plugin`
1257 * @param app_ctx[in,out] location where the app can store stuff 1257 * @param[in,out] app_ctx location where the app can store stuff
1258 * on add and retrieve it on remove 1258 * on add and retrieve it on remove
1259 * @param add_remove #GNUNET_YES to mean the new public IP address, 1259 * @param add_remove #GNUNET_YES to mean the new public IP address,
1260 * #GNUNET_NO to mean the previous (now invalid) one 1260 * #GNUNET_NO to mean the previous (now invalid) one
diff --git a/src/transport/tcp_server_legacy.c b/src/transport/tcp_server_legacy.c
index f4d48d4f6..bb572c843 100644
--- a/src/transport/tcp_server_legacy.c
+++ b/src/transport/tcp_server_legacy.c
@@ -699,11 +699,6 @@ GNUNET_SERVER_suspend (struct GNUNET_SERVER_Handle *server)
699} 699}
700 700
701 701
702/**
703 * Resume accepting connections from the listen socket.
704 *
705 * @param server server to stop accepting connections.
706 */
707void 702void
708GNUNET_SERVER_resume (struct GNUNET_SERVER_Handle *server) 703GNUNET_SERVER_resume (struct GNUNET_SERVER_Handle *server)
709{ 704{
@@ -1620,21 +1615,6 @@ transmit_ready_callback_wrapper (void *cls, size_t size, void *buf)
1620} 1615}
1621 1616
1622 1617
1623/**
1624 * Notify us when the server has enough space to transmit
1625 * a message of the given size to the given client.
1626 *
1627 * @param client client to transmit message to
1628 * @param size requested amount of buffer space
1629 * @param timeout after how long should we give up (and call
1630 * notify with buf NULL and size 0)?
1631 * @param callback function to call when space is available
1632 * @param callback_cls closure for @a callback
1633 * @return non-NULL if the notify callback was queued; can be used
1634 * to cancel the request using
1635 * #GNUNET_SERVER_notify_transmit_ready_cancel().
1636 * NULL if we are already going to notify someone else (busy)
1637 */
1638struct GNUNET_SERVER_TransmitHandle * 1618struct GNUNET_SERVER_TransmitHandle *
1639GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client, 1619GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client,
1640 size_t size, 1620 size_t size,
diff --git a/src/transport/transport-testing-cmds.h b/src/transport/transport-testing-cmds.h
index 5a3fb22d6..c577feb34 100644
--- a/src/transport/transport-testing-cmds.h
+++ b/src/transport/transport-testing-cmds.h
@@ -227,9 +227,9 @@ GNUNET_TRANSPORT_cmd_stop_peer (const char *label,
227 * 227 *
228 * @param label name for command 228 * @param label name for command
229 * @param start_peer_label Label of the cmd to start a peer. 229 * @param start_peer_label Label of the cmd to start a peer.
230 * @param create_peer_label Label of the cmd which started the test system. 230 * @param create_label Label of the cmd which started the test system.
231 * @param num Number globally identifying the node. 231 * @param num Number globally identifying the node.
232 * @param The topology for the test setup. 232 * @param topology The topology for the test setup.
233 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd. 233 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd.
234 * @return command. 234 * @return command.
235 */ 235 */
@@ -248,9 +248,9 @@ GNUNET_TRANSPORT_cmd_connect_peers (
248 * 248 *
249 * @param label name for command. 249 * @param label name for command.
250 * @param start_peer_label Label of the cmd to start a peer. 250 * @param start_peer_label Label of the cmd to start a peer.
251 * @param create_peer_label Label of the cmd which started the test system. 251 * @param create_label Label of the cmd which started the test system.
252 * @param num Number globally identifying the node. 252 * @param num Number globally identifying the node.
253 * @param The topology for the test setup. 253 * @param topology The topology for the test setup.
254 * @return command. 254 * @return command.
255 */ 255 */
256struct GNUNET_TESTING_Command 256struct GNUNET_TESTING_Command
@@ -271,7 +271,7 @@ GNUNET_TRANSPORT_cmd_send_simple (const char *label,
271 * @param num Number globally identifying the node. 271 * @param num Number globally identifying the node.
272 * @param node_n The number of the node in a network namespace. 272 * @param node_n The number of the node in a network namespace.
273 * @param namespace_n The number of the network namespace. 273 * @param namespace_n The number of the network namespace.
274 * @param The topology for the test setup. 274 * @param topology The topology for the test setup.
275 * @return command. 275 * @return command.
276 */ 276 */
277struct GNUNET_TESTING_Command 277struct GNUNET_TESTING_Command
diff --git a/src/transport/transport-testing-communicator.c b/src/transport/transport-testing-communicator.c
index ce4af01f2..1bf88bb3d 100644
--- a/src/transport/transport-testing-communicator.c
+++ b/src/transport/transport-testing-communicator.c
@@ -232,7 +232,7 @@ check_communicator_backchannel (void *cls,
232 * Pass the message to the client. 232 * Pass the message to the client.
233 * 233 *
234 * @param cls Closure - communicator handle 234 * @param cls Closure - communicator handle
235 * @param msg Message 235 * @param bc_msg Message
236 */ 236 */
237static void 237static void
238handle_communicator_backchannel (void *cls, 238handle_communicator_backchannel (void *cls,
@@ -283,7 +283,7 @@ handle_communicator_backchannel (void *cls,
283 * Address of our peer added. Test message is well-formed. 283 * Address of our peer added. Test message is well-formed.
284 * 284 *
285 * @param cls the client 285 * @param cls the client
286 * @param aam the send message that was sent 286 * @param msg the send message that was sent
287 * @return #GNUNET_OK if message is well-formed 287 * @return #GNUNET_OK if message is well-formed
288 */ 288 */
289static int 289static int
@@ -365,7 +365,7 @@ check_incoming_msg (void *cls,
365 * Pass the message to the client. 365 * Pass the message to the client.
366 * 366 *
367 * @param cls Closure - communicator handle 367 * @param cls Closure - communicator handle
368 * @param msg Message 368 * @param inc_msg Message
369 */ 369 */
370static void 370static void
371handle_incoming_msg (void *cls, 371handle_incoming_msg (void *cls,
@@ -1146,15 +1146,6 @@ GNUNET_TRANSPORT_TESTING_transport_communicator_open_queue (
1146} 1146}
1147 1147
1148 1148
1149/**
1150 * @brief Instruct communicator to send data
1151 *
1152 * @param tc_queue The queue to use for sending
1153 * @param cont function to call when done sending
1154 * @param cont_cls closure for @a cont
1155 * @param payload Data to send
1156 * @param payload_size Size of the @a payload
1157 */
1158void 1149void
1159GNUNET_TRANSPORT_TESTING_transport_communicator_send 1150GNUNET_TRANSPORT_TESTING_transport_communicator_send
1160 (struct GNUNET_TRANSPORT_TESTING_TransportCommunicatorHandle *tc_h, 1151 (struct GNUNET_TRANSPORT_TESTING_TransportCommunicatorHandle *tc_h,
diff --git a/src/transport/transport-testing-filenames.c b/src/transport/transport-testing-filenames.c
index 7c136b690..70c1ee55a 100644
--- a/src/transport/transport-testing-filenames.c
+++ b/src/transport/transport-testing-filenames.c
@@ -61,13 +61,6 @@ extract_filename (const char *file)
61} 61}
62 62
63 63
64/**
65 * Extracts the test filename from an absolute file name and removes
66 * the extension
67 *
68 * @param file absolute file name
69 * @return the result
70 */
71char * 64char *
72GNUNET_TRANSPORT_TESTING_get_test_name (const char *file) 65GNUNET_TRANSPORT_TESTING_get_test_name (const char *file)
73{ 66{
@@ -96,12 +89,6 @@ GNUNET_TRANSPORT_TESTING_get_test_name (const char *file)
96} 89}
97 90
98 91
99/**
100 * Extracts the filename from an absolute file name and removes the extension
101 *
102 * @param file absolute file name
103 * @return the result
104 */
105char * 92char *
106GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file) 93GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file)
107{ 94{
@@ -115,13 +102,6 @@ GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file)
115} 102}
116 103
117 104
118/**
119 * Extracts the plugin name from an absolute file name and the test name
120 *
121 * @param file absolute file name
122 * @param test test name
123 * @return the result
124 */
125char * 105char *
126GNUNET_TRANSPORT_TESTING_get_test_plugin_name (const char *file, 106GNUNET_TRANSPORT_TESTING_get_test_plugin_name (const char *file,
127 const char *test) 107 const char *test)
@@ -161,14 +141,6 @@ suc:
161} 141}
162 142
163 143
164/**
165 * This function takes the filename (e.g. argv[0), removes a "lt-"-prefix and
166 * if existing ".exe"-prefix and adds the peer-number
167 *
168 * @param file filename of the test, e.g. argv[0]
169 * @param count peer number
170 * @return the result
171 */
172char * 144char *
173GNUNET_TRANSPORT_TESTING_get_config_name (const char *file, 145GNUNET_TRANSPORT_TESTING_get_config_name (const char *file,
174 int count) 146 int count)
diff --git a/src/transport/transport-testing-main.c b/src/transport/transport-testing-main.c
index 20c58eeee..8d1727d77 100644
--- a/src/transport/transport-testing-main.c
+++ b/src/transport/transport-testing-main.c
@@ -253,7 +253,7 @@ my_nc (void *cls,
253 * 253 *
254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` 254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *`
255 * @param peer peer we got disconnected from 255 * @param peer peer we got disconnected from
256 * @param custom_cls return value from @my_nc 256 * @param custom_cls return value from @a my_nc
257 */ 257 */
258static void 258static void
259my_nd (void *cls, 259my_nd (void *cls,
diff --git a/src/transport/transport-testing-main2.c b/src/transport/transport-testing-main2.c
index 62aa3ceb7..de0b7f4cd 100644
--- a/src/transport/transport-testing-main2.c
+++ b/src/transport/transport-testing-main2.c
@@ -253,7 +253,7 @@ my_nc (void *cls,
253 * 253 *
254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` 254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *`
255 * @param peer peer we got disconnected from 255 * @param peer peer we got disconnected from
256 * @param custom_cls return value from @my_nc 256 * @param custom_cls return value from @a my_nc
257 */ 257 */
258static void 258static void
259my_nd (void *cls, 259my_nd (void *cls,
diff --git a/src/transport/transport-testing2.c b/src/transport/transport-testing2.c
index 6d41ec098..f0dee7388 100644
--- a/src/transport/transport-testing2.c
+++ b/src/transport/transport-testing2.c
@@ -379,19 +379,6 @@ retrieve_hello (void *cls)
379} 379}
380 380
381 381
382/**
383 * Start a peer with the given configuration
384 * @param tth the testing handle
385 * @param cfgname configuration file
386 * @param peer_id a unique number to identify the peer
387 * @param handlers functions for receiving messages
388 * @param nc connect callback
389 * @param nd disconnect callback
390 * @param cb_cls closure for callback
391 * @param start_cb start callback
392 * @param start_cb_cls closure for callback
393 * @return the peer context
394 */
395struct GNUNET_TRANSPORT_TESTING_PeerContext * 382struct GNUNET_TRANSPORT_TESTING_PeerContext *
396GNUNET_TRANSPORT_TESTING_start_peer (struct 383GNUNET_TRANSPORT_TESTING_start_peer (struct
397 GNUNET_TRANSPORT_TESTING_Handle *tth, 384 GNUNET_TRANSPORT_TESTING_Handle *tth,
@@ -545,14 +532,6 @@ GNUNET_TRANSPORT_TESTING_start_peer (struct
545} 532}
546 533
547 534
548/**
549 * Stops and restarts the given peer, sleeping (!) for 5s in between.
550 *
551 * @param p the peer
552 * @param restart_cb callback to call when restarted
553 * @param restart_cb_cls callback closure
554 * @return #GNUNET_OK in success otherwise #GNUNET_SYSERR
555 */
556int 535int
557GNUNET_TRANSPORT_TESTING_restart_peer (struct 536GNUNET_TRANSPORT_TESTING_restart_peer (struct
558 GNUNET_TRANSPORT_TESTING_PeerContext *p, 537 GNUNET_TRANSPORT_TESTING_PeerContext *p,
@@ -751,11 +730,6 @@ GNUNET_TRANSPORT_TESTING_stop_peer (struct
751 }*/ 730 }*/
752 731
753 732
754/**
755 * Offer the current HELLO of P2 to P1.
756 *
757 * @param cls our `struct GNUNET_TRANSPORT_TESTING_ConnectRequest`
758 */
759static void 733static void
760offer_hello (void *cls) 734offer_hello (void *cls)
761{ 735{
@@ -859,13 +833,6 @@ GNUNET_TRANSPORT_TESTING_connect_peers (struct
859} 833}
860 834
861 835
862/**
863 * Cancel the request to connect two peers
864 * Tou MUST cancel the request if you stop the peers before the peers connected successfully
865 *
866 * @param tth transport testing handle
867 * @param cc a connect request handle
868 */
869void 836void
870GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct 837GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct
871 GNUNET_TRANSPORT_TESTING_ConnectRequest 838 GNUNET_TRANSPORT_TESTING_ConnectRequest
diff --git a/src/transport/transport-testing2.h b/src/transport/transport-testing2.h
index e2167ca7e..b5db28500 100644
--- a/src/transport/transport-testing2.h
+++ b/src/transport/transport-testing2.h
@@ -288,7 +288,7 @@ GNUNET_TRANSPORT_TESTING_done (struct GNUNET_TRANSPORT_TESTING_Handle *tth);
288 * 288 *
289 * @param tth the testing handle 289 * @param tth the testing handle
290 * @param cfgname configuration file 290 * @param cfgname configuration file
291 * @param peer_id the peer_id 291 * @param peer_id an identification number for the peer
292 * @param handlers functions for receiving messages 292 * @param handlers functions for receiving messages
293 * @param nc connect callback 293 * @param nc connect callback
294 * @param nd disconnect callback 294 * @param nd disconnect callback
diff --git a/src/transport/transport_api2_communication.c b/src/transport/transport_api2_communication.c
index 5bcfb30c7..b79f0d8bf 100644
--- a/src/transport/transport_api2_communication.c
+++ b/src/transport/transport_api2_communication.c
@@ -802,24 +802,6 @@ reconnect (struct GNUNET_TRANSPORT_CommunicatorHandle *ch)
802} 802}
803 803
804 804
805/**
806 * Connect to the transport service.
807 *
808 * @param cfg configuration to use
809 * @param config_section section of the configuration to use for options
810 * @param addr_prefix address prefix for addresses supported by this
811 * communicator, could be NULL for incoming-only communicators
812 * @param cc what characteristics does the communicator have?
813 * @param mtu maximum message size supported by communicator, 0 if
814 * sending is not supported, SIZE_MAX for no MTU
815 * @param mq_init function to call to initialize a message queue given
816 * the address of another peer, can be NULL if the
817 * communicator only supports receiving messages
818 * @param mq_init_cls closure for @a mq_init
819 * @param notify_cb function to pass backchannel messages to communicator
820 * @param notify_cb_cls closure for @a notify_cb
821 * @return NULL on error
822 */
823struct GNUNET_TRANSPORT_CommunicatorHandle * 805struct GNUNET_TRANSPORT_CommunicatorHandle *
824GNUNET_TRANSPORT_communicator_connect ( 806GNUNET_TRANSPORT_communicator_connect (
825 const struct GNUNET_CONFIGURATION_Handle *cfg, 807 const struct GNUNET_CONFIGURATION_Handle *cfg,
@@ -880,26 +862,6 @@ GNUNET_TRANSPORT_communicator_disconnect (
880/* ************************* Receiving *************************** */ 862/* ************************* Receiving *************************** */
881 863
882 864
883/**
884 * Notify transport service that the communicator has received
885 * a message.
886 *
887 * @param ch connection to transport service
888 * @param sender presumed sender of the message (details to be checked
889 * by higher layers)
890 * @param msg the message
891 * @param expected_addr_validity how long does the communicator believe it
892 * will continue to be able to receive messages from the same address
893 * on which it received this message?
894 * @param cb function to call once handling the message is done, NULL if
895 * flow control is not supported by this communicator
896 * @param cb_cls closure for @a cb
897 * @return #GNUNET_OK if all is well, #GNUNET_NO if the message was
898 * immediately dropped due to memory limitations (communicator
899 * should try to apply back pressure),
900 * #GNUNET_SYSERR if the message could not be delivered because
901 * the transport service is not yet up
902 */
903int 865int
904GNUNET_TRANSPORT_communicator_receive ( 866GNUNET_TRANSPORT_communicator_receive (
905 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 867 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -970,25 +932,6 @@ GNUNET_TRANSPORT_communicator_receive (
970/* ************************* Discovery *************************** */ 932/* ************************* Discovery *************************** */
971 933
972 934
973/**
974 * Notify transport service that an MQ became available due to an
975 * "inbound" connection or because the communicator discovered the
976 * presence of another peer.
977 *
978 * @param ch connection to transport service
979 * @param peer peer with which we can now communicate
980 * @param address address in human-readable format, 0-terminated, UTF-8
981 * @param mtu maximum message size supported by queue, 0 if
982 * sending is not supported, SIZE_MAX for no MTU
983 * @param q_len number of messages that can be send through this queue
984 * @param priority queue priority. Queues with highest priority should be
985 * used
986 * @param nt which network type does the @a address belong to?
987 * @param cc what characteristics does the communicator have?
988 * @param cs what is the connection status of the queue?
989 * @param mq message queue of the @a peer
990 * @return API handle identifying the new MQ
991 */
992struct GNUNET_TRANSPORT_QueueHandle * 935struct GNUNET_TRANSPORT_QueueHandle *
993GNUNET_TRANSPORT_communicator_mq_add ( 936GNUNET_TRANSPORT_communicator_mq_add (
994 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 937 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -1023,15 +966,6 @@ GNUNET_TRANSPORT_communicator_mq_add (
1023} 966}
1024 967
1025 968
1026/**
1027 * Notify transport service that an MQ was updated
1028 *
1029 * @param ch connection to transport service
1030 * @param qh the queue to update
1031 * @param q_len number of messages that can be send through this queue
1032 * @param priority queue priority. Queues with highest priority should be
1033 * used
1034 */
1035void 969void
1036GNUNET_TRANSPORT_communicator_mq_update ( 970GNUNET_TRANSPORT_communicator_mq_update (
1037 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 971 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -1149,20 +1083,6 @@ GNUNET_TRANSPORT_communicator_address_remove_all (
1149/* ************************* Backchannel *************************** */ 1083/* ************************* Backchannel *************************** */
1150 1084
1151 1085
1152/**
1153 * The communicator asks the transport service to route a message via
1154 * a different path to another communicator service at another peer.
1155 * This must only be done for special control traffic (as there is no
1156 * flow control for this API), such as acknowledgements, and generally
1157 * only be done if the communicator is uni-directional (i.e. cannot
1158 * send the message back itself).
1159 *
1160 * @param ch handle of this communicator
1161 * @param pid peer to send the message to
1162 * @param comm name of the communicator to send the message to
1163 * @param header header of the message to transmit and pass via the
1164 * notify-API to @a pid's communicator @a comm
1165 */
1166void 1086void
1167GNUNET_TRANSPORT_communicator_notify ( 1087GNUNET_TRANSPORT_communicator_notify (
1168 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 1088 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
diff --git a/src/transport/transport_api_address_to_string.c b/src/transport/transport_api_address_to_string.c
index c7de39ea8..5b234f802 100644
--- a/src/transport/transport_api_address_to_string.c
+++ b/src/transport/transport_api_address_to_string.c
@@ -56,7 +56,7 @@ struct GNUNET_TRANSPORT_AddressToStringContext
56 * Function called with responses from the service. 56 * Function called with responses from the service.
57 * 57 *
58 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *` 58 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *`
59 * @param msg message with the human-readable address 59 * @param atsm message with the human-readable address
60 * @return #GNUNET_OK if message is well-formed 60 * @return #GNUNET_OK if message is well-formed
61 */ 61 */
62static int 62static int
@@ -97,7 +97,7 @@ check_reply (void *cls,
97 * Function called with responses from the service. 97 * Function called with responses from the service.
98 * 98 *
99 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *` 99 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *`
100 * @param msg message with the human-readable address 100 * @param atsm message with the human-readable address
101 */ 101 */
102static void 102static void
103handle_reply (void *cls, 103handle_reply (void *cls,
diff --git a/src/transport/transport_api_cmd_backchannel_check.c b/src/transport/transport_api_cmd_backchannel_check.c
index b285d7abf..1edd6cb7e 100644
--- a/src/transport/transport_api_cmd_backchannel_check.c
+++ b/src/transport/transport_api_cmd_backchannel_check.c
@@ -522,18 +522,6 @@ backchannel_check_cleanup (void *cls)
522} 522}
523 523
524 524
525/**
526 * Create command.
527 *
528 * @param label name for command.
529 * @param start_peer_label Label of the cmd to start a peer.
530 * @param create_label Label of the cmd to create the testing system.
531 * @param num Number globally identifying the node.
532 * @param node_n The number of the node in a network namespace.
533 * @param namespace_n The number of the network namespace.
534 * @param The topology for the test setup.
535 * @return command.
536 */
537struct GNUNET_TESTING_Command 525struct GNUNET_TESTING_Command
538GNUNET_TRANSPORT_cmd_backchannel_check (const char *label, 526GNUNET_TRANSPORT_cmd_backchannel_check (const char *label,
539 const char *start_peer_label, 527 const char *start_peer_label,
diff --git a/src/transport/transport_api_cmd_connecting_peers.c b/src/transport/transport_api_cmd_connecting_peers.c
index 4d9e9c3ab..a6006f698 100644
--- a/src/transport/transport_api_cmd_connecting_peers.c
+++ b/src/transport/transport_api_cmd_connecting_peers.c
@@ -220,17 +220,6 @@ connect_peers_traits (void *cls,
220} 220}
221 221
222 222
223/**
224 * Create command
225 *
226 * @param label name for command
227 * @param start_peer_label Label of the cmd to start a peer.
228 * @param create_peer_label Label of the cmd which started the test system.
229 * @param num Number globally identifying the node.
230 * @param The topology for the test setup.
231 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd.
232 * @return command.
233 */
234struct GNUNET_TESTING_Command 223struct GNUNET_TESTING_Command
235GNUNET_TRANSPORT_cmd_connect_peers (const char *label, 224GNUNET_TRANSPORT_cmd_connect_peers (const char *label,
236 const char *start_peer_label, 225 const char *start_peer_label,
diff --git a/src/transport/transport_api_cmd_send_simple.c b/src/transport/transport_api_cmd_send_simple.c
index a00e1b922..c71c952aa 100644
--- a/src/transport/transport_api_cmd_send_simple.c
+++ b/src/transport/transport_api_cmd_send_simple.c
@@ -137,16 +137,6 @@ send_simple_run (void *cls,
137} 137}
138 138
139 139
140/**
141 * Create command.
142 *
143 * @param label name for command.
144 * @param start_peer_label Label of the cmd to start a peer.
145 * @param start_peer_label Label of the cmd which started the test system.
146 * @param num Number globally identifying the node.
147 * @param The topology for the test setup.
148 * @return command.
149 */
150struct GNUNET_TESTING_Command 140struct GNUNET_TESTING_Command
151GNUNET_TRANSPORT_cmd_send_simple (const char *label, 141GNUNET_TRANSPORT_cmd_send_simple (const char *label,
152 const char *start_peer_label, 142 const char *start_peer_label,
diff --git a/src/transport/transport_api_core.c b/src/transport/transport_api_core.c
index 0ffaeb444..12612de09 100644
--- a/src/transport/transport_api_core.c
+++ b/src/transport/transport_api_core.c
@@ -713,7 +713,7 @@ handle_recv (void *cls, const struct InboundMessage *im)
713 * Function we use for handling incoming set quota messages. 713 * Function we use for handling incoming set quota messages.
714 * 714 *
715 * @param cls closure, a `struct GNUNET_TRANSPORT_CoreHandle *` 715 * @param cls closure, a `struct GNUNET_TRANSPORT_CoreHandle *`
716 * @param msg message received 716 * @param qm message received
717 */ 717 */
718static void 718static void
719handle_set_quota (void *cls, const struct QuotaSetMessage *qm) 719handle_set_quota (void *cls, const struct QuotaSetMessage *qm)
diff --git a/src/transport/transport_api_monitor_peers.c b/src/transport/transport_api_monitor_peers.c
index 2f0f07f23..ef1dc6087 100644
--- a/src/transport/transport_api_monitor_peers.c
+++ b/src/transport/transport_api_monitor_peers.c
@@ -389,32 +389,6 @@ do_peer_connect (void *cls)
389} 389}
390 390
391 391
392/**
393 * Return information about a specific peer or all peers currently known to
394 * transport service once or in monitoring mode. To obtain information about
395 * a specific peer, a peer identity can be passed. To obtain information about
396 * all peers currently known to transport service, NULL can be passed as peer
397 * identity.
398 *
399 * For each peer, the callback is called with information about the address used
400 * to communicate with this peer, the state this peer is currently in and the
401 * the current timeout for this state.
402 *
403 * Upon completion, the 'GNUNET_TRANSPORT_PeerIterateCallback' is called one
404 * more time with 'NULL'. After this, the operation must no longer be
405 * explicitly canceled.
406 *
407 * The #GNUNET_TRANSPORT_monitor_peers_cancel call MUST not be called in the
408 * the peer_callback!
409 *
410 * @param cfg configuration to use
411 * @param peer a specific peer identity to obtain information for,
412 * NULL for all peers
413 * @param one_shot #GNUNET_YES to return the current state and then end (with NULL+NULL),
414 * #GNUNET_NO to monitor peers continuously
415 * @param peer_callback function to call with the results
416 * @param peer_callback_cls closure for @a peer_address_callback
417 */
418struct GNUNET_TRANSPORT_PeerMonitoringContext * 392struct GNUNET_TRANSPORT_PeerMonitoringContext *
419GNUNET_TRANSPORT_monitor_peers (const struct GNUNET_CONFIGURATION_Handle *cfg, 393GNUNET_TRANSPORT_monitor_peers (const struct GNUNET_CONFIGURATION_Handle *cfg,
420 const struct GNUNET_PeerIdentity *peer, 394 const struct GNUNET_PeerIdentity *peer,
diff --git a/src/transport/transport_api_monitor_plugins.c b/src/transport/transport_api_monitor_plugins.c
index d8eddddaa..43a11442b 100644
--- a/src/transport/transport_api_monitor_plugins.c
+++ b/src/transport/transport_api_monitor_plugins.c
@@ -211,7 +211,7 @@ locate_by_id (void *cls,
211 * Function called with responses from the service. 211 * Function called with responses from the service.
212 * 212 *
213 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` 213 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *`
214 * @paramm tpmm message with event data 214 * @param tpmm message with event data
215 * @return #GNUNET_Ok if message is well-formed 215 * @return #GNUNET_Ok if message is well-formed
216 */ 216 */
217static int 217static int
@@ -243,7 +243,7 @@ check_event (void *cls,
243 * Function called with responses from the service. 243 * Function called with responses from the service.
244 * 244 *
245 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` 245 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *`
246 * @paramm tpmm message with event data 246 * @param tpmm message with event data
247 */ 247 */
248static void 248static void
249handle_event (void *cls, 249handle_event (void *cls,
diff --git a/src/transport/transport_api_offer_hello.c b/src/transport/transport_api_offer_hello.c
index eb342f57c..1b611aa6b 100644
--- a/src/transport/transport_api_offer_hello.c
+++ b/src/transport/transport_api_offer_hello.c
@@ -125,11 +125,6 @@ GNUNET_TRANSPORT_offer_hello (const struct GNUNET_CONFIGURATION_Handle *cfg,
125} 125}
126 126
127 127
128/**
129 * Cancel the request to transport to offer the HELLO message
130 *
131 * @param ohh the handle for the operation to cancel
132 */
133void 128void
134GNUNET_TRANSPORT_offer_hello_cancel (struct 129GNUNET_TRANSPORT_offer_hello_cancel (struct
135 GNUNET_TRANSPORT_OfferHelloHandle *ohh) 130 GNUNET_TRANSPORT_OfferHelloHandle *ohh)
diff --git a/src/util/child_management.c b/src/util/child_management.c
index 832e05ece..8c413a8b5 100644
--- a/src/util/child_management.c
+++ b/src/util/child_management.c
@@ -197,7 +197,7 @@ child_management_done (void)
197 * Adding a child process to be monitored by the child management. 197 * Adding a child process to be monitored by the child management.
198 * 198 *
199 * @param proc The child process to be monitored. 199 * @param proc The child process to be monitored.
200 * @param cp The callback to be called, when the child process completed. 200 * @param cb The callback to be called, when the child process completed.
201 * @param cb_cls The closure for the callback. 201 * @param cb_cls The closure for the callback.
202 * @return An handle for the the child being monitored. 202 * @return An handle for the the child being monitored.
203 */ 203 */
diff --git a/src/util/common_logging.c b/src/util/common_logging.c
index 27d9ca3ce..9fa848224 100644
--- a/src/util/common_logging.c
+++ b/src/util/common_logging.c
@@ -1154,15 +1154,6 @@ GNUNET_h2s2 (const struct GNUNET_HashCode *hc)
1154} 1154}
1155 1155
1156 1156
1157/**
1158 * @ingroup logging
1159 * Convert a public key value to a string (for printing debug messages).
1160 * This is one of the very few calls in the entire API that is
1161 * NOT reentrant!
1162 *
1163 * @param hc the hash code
1164 * @return string
1165 */
1166const char * 1157const char *
1167GNUNET_p2s (const struct GNUNET_CRYPTO_EddsaPublicKey *p) 1158GNUNET_p2s (const struct GNUNET_CRYPTO_EddsaPublicKey *p)
1168{ 1159{
@@ -1176,15 +1167,6 @@ GNUNET_p2s (const struct GNUNET_CRYPTO_EddsaPublicKey *p)
1176} 1167}
1177 1168
1178 1169
1179/**
1180 * @ingroup logging
1181 * Convert a public key value to a string (for printing debug messages).
1182 * This is one of the very few calls in the entire API that is
1183 * NOT reentrant!
1184 *
1185 * @param hc the hash code
1186 * @return string
1187 */
1188const char * 1170const char *
1189GNUNET_p2s2 (const struct GNUNET_CRYPTO_EddsaPublicKey *p) 1171GNUNET_p2s2 (const struct GNUNET_CRYPTO_EddsaPublicKey *p)
1190{ 1172{
@@ -1198,15 +1180,6 @@ GNUNET_p2s2 (const struct GNUNET_CRYPTO_EddsaPublicKey *p)
1198} 1180}
1199 1181
1200 1182
1201/**
1202 * @ingroup logging
1203 * Convert a public key value to a string (for printing debug messages).
1204 * This is one of the very few calls in the entire API that is
1205 * NOT reentrant!
1206 *
1207 * @param hc the hash code
1208 * @return string
1209 */
1210const char * 1183const char *
1211GNUNET_e2s (const struct GNUNET_CRYPTO_EcdhePublicKey *p) 1184GNUNET_e2s (const struct GNUNET_CRYPTO_EcdhePublicKey *p)
1212{ 1185{
@@ -1220,15 +1193,6 @@ GNUNET_e2s (const struct GNUNET_CRYPTO_EcdhePublicKey *p)
1220} 1193}
1221 1194
1222 1195
1223/**
1224 * @ingroup logging
1225 * Convert a public key value to a string (for printing debug messages).
1226 * This is one of the very few calls in the entire API that is
1227 * NOT reentrant!
1228 *
1229 * @param hc the hash code
1230 * @return string
1231 */
1232const char * 1196const char *
1233GNUNET_e2s2 (const struct GNUNET_CRYPTO_EcdhePublicKey *p) 1197GNUNET_e2s2 (const struct GNUNET_CRYPTO_EcdhePublicKey *p)
1234{ 1198{
@@ -1476,7 +1440,7 @@ GNUNET_log_config_invalid (enum GNUNET_ErrorType kind,
1476 * Set the async scope for the current thread. 1440 * Set the async scope for the current thread.
1477 * 1441 *
1478 * @param aid the async scope identifier 1442 * @param aid the async scope identifier
1479 * @param old_scope[out] location to save the old scope 1443 * @param[out] old_scope location to save the old scope
1480 */ 1444 */
1481void 1445void
1482GNUNET_async_scope_enter (const struct GNUNET_AsyncScopeId *aid, 1446GNUNET_async_scope_enter (const struct GNUNET_AsyncScopeId *aid,
diff --git a/src/util/configuration.c b/src/util/configuration.c
index 27e6cf612..5c415aff7 100644
--- a/src/util/configuration.c
+++ b/src/util/configuration.c
@@ -91,7 +91,7 @@ struct ConfigSection
91 /** 91 /**
92 * Is the configuration section marked as inaccessible? 92 * Is the configuration section marked as inaccessible?
93 * 93 *
94 * This can happen if the section name is used in an @inline-secret@ 94 * This can happen if the section name is used in an \@inline-secret\@
95 * directive, but the referenced file can't be found or accessed. 95 * directive, but the referenced file can't be found or accessed.
96 */ 96 */
97 bool inaccessible; 97 bool inaccessible;
@@ -135,7 +135,7 @@ struct ConfigFile
135 135
136 /** 136 /**
137 * Was this configuration file parsed via 137 * Was this configuration file parsed via
138 * @inline-secret@? 138 * \@inline-secret\@?
139 */ 139 */
140 char *hint_restrict_section; 140 char *hint_restrict_section;
141 141
diff --git a/src/util/container_multihashmap32.c b/src/util/container_multihashmap32.c
index ccedd1bbb..2416c40f2 100644
--- a/src/util/container_multihashmap32.c
+++ b/src/util/container_multihashmap32.c
@@ -259,11 +259,11 @@ GNUNET_CONTAINER_multihashmap32_iterate (
259 259
260 260
261/** 261/**
262 * We are about to free() the @a bme, make sure it is not in 262 * We are about to free() the @a me, make sure it is not in
263 * the list of next values for any iterator in the @a map's next_cache. 263 * the list of next values for any iterator in the @a map's next_cache.
264 * 264 *
265 * @param map the map to check 265 * @param map the map to check
266 * @param bme the entry that is about to be free'd 266 * @param me the entry that is about to be free'd
267 */ 267 */
268static void 268static void
269update_next_cache (struct GNUNET_CONTAINER_MultiHashMap32 *map, 269update_next_cache (struct GNUNET_CONTAINER_MultiHashMap32 *map,
diff --git a/src/util/crypto_rsa.c b/src/util/crypto_rsa.c
index 4b8e5a5ce..325a1fe86 100644
--- a/src/util/crypto_rsa.c
+++ b/src/util/crypto_rsa.c
@@ -709,7 +709,7 @@ rsa_blinding_key_free (struct RsaBlindingKey *bkey)
709 * Print an MPI to a newly created buffer 709 * Print an MPI to a newly created buffer
710 * 710 *
711 * @param v MPI to print. 711 * @param v MPI to print.
712 * @param[out] newly allocated buffer containing the result 712 * @param[out] buffer newly allocated buffer containing the result
713 * @return number of bytes stored in @a buffer 713 * @return number of bytes stored in @a buffer
714 */ 714 */
715static size_t 715static size_t
diff --git a/src/util/dnsstub.c b/src/util/dnsstub.c
index c2f2a441f..9763f6501 100644
--- a/src/util/dnsstub.c
+++ b/src/util/dnsstub.c
@@ -387,7 +387,7 @@ do_dns_read (struct GNUNET_DNSSTUB_RequestSocket *rs,
387/** 387/**
388 * Read a DNS response from the (unhindered) UDP-Socket 388 * Read a DNS response from the (unhindered) UDP-Socket
389 * 389 *
390 * @param cls socket to read from 390 * @param cls `struct GNUNET_DNSSTUB_RequestSocket` to read from
391 */ 391 */
392static void 392static void
393read_response (void *cls); 393read_response (void *cls);
@@ -421,11 +421,6 @@ schedule_read (struct GNUNET_DNSSTUB_RequestSocket *rs)
421} 421}
422 422
423 423
424/**
425 * Read a DNS response from the (unhindered) UDP-Socket
426 *
427 * @param cls `struct GNUNET_DNSSTUB_RequestSocket` to read from
428 */
429static void 424static void
430read_response (void *cls) 425read_response (void *cls)
431{ 426{
@@ -692,13 +687,6 @@ GNUNET_DNSSTUB_add_dns_sa (struct GNUNET_DNSSTUB_Context *ctx,
692} 687}
693 688
694 689
695/**
696 * How long should we try requests before timing out?
697 * Only effective for requests issued after this call.
698 *
699 * @param ctx resolver context to modify
700 * @param retry_freq how long to wait between retries
701 */
702void 690void
703GNUNET_DNSSTUB_set_retry (struct GNUNET_DNSSTUB_Context *ctx, 691GNUNET_DNSSTUB_set_retry (struct GNUNET_DNSSTUB_Context *ctx,
704 struct GNUNET_TIME_Relative retry_freq) 692 struct GNUNET_TIME_Relative retry_freq)
diff --git a/src/util/gnunet-scrypt.c b/src/util/gnunet-scrypt.c
index ad46e3f39..3c219ef4f 100644
--- a/src/util/gnunet-scrypt.c
+++ b/src/util/gnunet-scrypt.c
@@ -81,7 +81,6 @@ shutdown_task (void *cls)
81 * Find our proof of work. 81 * Find our proof of work.
82 * 82 *
83 * @param cls closure (unused) 83 * @param cls closure (unused)
84 * @param tc task context
85 */ 84 */
86static void 85static void
87find_proof (void *cls) 86find_proof (void *cls)
diff --git a/src/util/gnunet-service-resolver.c b/src/util/gnunet-service-resolver.c
index 9bde04117..bb70ac3bd 100644
--- a/src/util/gnunet-service-resolver.c
+++ b/src/util/gnunet-service-resolver.c
@@ -313,8 +313,8 @@ extract_search_domain (const char *line, size_t line_len)
313/** 313/**
314 * Reads the list of nameservers from /etc/resolve.conf 314 * Reads the list of nameservers from /etc/resolve.conf
315 * 315 *
316 * @param server_addrs[out] a list of null-terminated server address strings 316 * @param[out] server_addrs a list of null-terminated server address strings
317 * @return the number of server addresses in @server_addrs, -1 on error 317 * @return the number of server addresses in @a server_addrs, -1 on error
318 */ 318 */
319static int 319static int
320lookup_dns_servers (char ***server_addrs) 320lookup_dns_servers (char ***server_addrs)
@@ -670,8 +670,8 @@ try_cache (const char *hostname,
670 * @param hostname DNS name to query 670 * @param hostname DNS name to query
671 * @param type requested DNS record type 671 * @param type requested DNS record type
672 * @param dns_id what should be the DNS request ID 672 * @param dns_id what should be the DNS request ID
673 * @param packet_buf[out] where to write the request packet 673 * @param[out] packet_buf where to write the request packet
674 * @param packet_size[out] set to size of @a packet_buf on success 674 * @param[out] packet_size set to size of @a packet_buf on success
675 * @return #GNUNET_OK on success 675 * @return #GNUNET_OK on success
676 */ 676 */
677static int 677static int
diff --git a/src/util/helper.c b/src/util/helper.c
index 0809c1f17..09d3fffab 100644
--- a/src/util/helper.c
+++ b/src/util/helper.c
@@ -164,15 +164,6 @@ struct GNUNET_HELPER_Handle
164}; 164};
165 165
166 166
167/**
168 * Sends termination signal to the helper process. The helper process is not
169 * reaped; call GNUNET_HELPER_wait() for reaping the dead helper process.
170 *
171 * @param h the helper handle
172 * @param soft_kill if GNUNET_YES, signals termination by closing the helper's
173 * stdin; GNUNET_NO to signal termination by sending SIGTERM to helper
174 * @return #GNUNET_OK on success; #GNUNET_SYSERR on error
175 */
176int 167int
177GNUNET_HELPER_kill (struct GNUNET_HELPER_Handle *h, int soft_kill) 168GNUNET_HELPER_kill (struct GNUNET_HELPER_Handle *h, int soft_kill)
178{ 169{
@@ -213,14 +204,6 @@ GNUNET_HELPER_kill (struct GNUNET_HELPER_Handle *h, int soft_kill)
213} 204}
214 205
215 206
216/**
217 * Reap the helper process. This call is blocking(!). The helper process
218 * should either be sent a termination signal before or should be dead before
219 * calling this function
220 *
221 * @param h the helper handle
222 * @return #GNUNET_OK on success; #GNUNET_SYSERR on error
223 */
224int 207int
225GNUNET_HELPER_wait (struct GNUNET_HELPER_Handle *h) 208GNUNET_HELPER_wait (struct GNUNET_HELPER_Handle *h)
226{ 209{
@@ -475,22 +458,6 @@ restart_task (void *cls)
475} 458}
476 459
477 460
478/**
479 * Starts a helper and begins reading from it. The helper process is
480 * restarted when it dies except when it is stopped using GNUNET_HELPER_stop()
481 * or when the exp_cb callback is not NULL.
482 *
483 * @param with_control_pipe does the helper support the use of a control pipe for signalling?
484 * @param binary_name name of the binary to run
485 * @param binary_argv NULL-terminated list of arguments to give when starting the binary (this
486 * argument must not be modified by the client for
487 * the lifetime of the helper handle)
488 * @param cb function to call if we get messages from the helper
489 * @param exp_cb the exception callback to call. Set this to NULL if the helper
490 * process has to be restarted automatically when it dies/crashes
491 * @param cb_cls closure for the above callback
492 * @return the new Handle, NULL on error
493 */
494struct GNUNET_HELPER_Handle * 461struct GNUNET_HELPER_Handle *
495GNUNET_HELPER_start (int with_control_pipe, 462GNUNET_HELPER_start (int with_control_pipe,
496 const char *binary_name, 463 const char *binary_name,
@@ -644,19 +611,6 @@ helper_write (void *cls)
644} 611}
645 612
646 613
647/**
648 * Send an message to the helper.
649 *
650 * @param h helper to send message to
651 * @param msg message to send
652 * @param can_drop can the message be dropped if there is already one in the queue?
653 * @param cont continuation to run once the message is out (#GNUNET_OK on success, #GNUNET_NO
654 * if the helper process died, #GNUNET_SYSERR during #GNUNET_HELPER_destroy).
655 * @param cont_cls closure for @a cont
656 * @return NULL if the message was dropped,
657 * otherwise handle to cancel *cont* (actual transmission may
658 * not be abortable)
659 */
660struct GNUNET_HELPER_SendHandle * 614struct GNUNET_HELPER_SendHandle *
661GNUNET_HELPER_send (struct GNUNET_HELPER_Handle *h, 615GNUNET_HELPER_send (struct GNUNET_HELPER_Handle *h,
662 const struct GNUNET_MessageHeader *msg, 616 const struct GNUNET_MessageHeader *msg,
diff --git a/src/util/mst.c b/src/util/mst.c
index 2236f2883..264fdb979 100644
--- a/src/util/mst.c
+++ b/src/util/mst.c
@@ -96,20 +96,6 @@ GNUNET_MST_create (GNUNET_MessageTokenizerCallback cb,
96} 96}
97 97
98 98
99/**
100 * Add incoming data to the receive buffer and call the
101 * callback for all complete messages.
102 *
103 * @param mst tokenizer to use
104 * @param buf input data to add
105 * @param size number of bytes in @a buf
106 * @param purge should any excess bytes in the buffer be discarded
107 * (i.e. for packet-based services like UDP)
108 * @param one_shot only call callback once, keep rest of message in buffer
109 * @return #GNUNET_OK if we are done processing (need more data)
110 * #GNUNET_NO if @a one_shot was set and we have another message ready
111 * #GNUNET_SYSERR if the data stream is corrupt
112 */
113int 99int
114GNUNET_MST_from_buffer (struct GNUNET_MessageStreamTokenizer *mst, 100GNUNET_MST_from_buffer (struct GNUNET_MessageStreamTokenizer *mst,
115 const char *buf, 101 const char *buf,
diff --git a/src/util/network.c b/src/util/network.c
index 2f77bc54e..7588033c4 100644
--- a/src/util/network.c
+++ b/src/util/network.c
@@ -561,11 +561,6 @@ GNUNET_NETWORK_socket_close (struct GNUNET_NETWORK_Handle *desc)
561} 561}
562 562
563 563
564/**
565 * Only free memory of a socket, keep the file descriptor untouched.
566 *
567 * @param desc socket
568 */
569void 564void
570GNUNET_NETWORK_socket_free_memory_only_ (struct GNUNET_NETWORK_Handle *desc) 565GNUNET_NETWORK_socket_free_memory_only_ (struct GNUNET_NETWORK_Handle *desc)
571{ 566{
@@ -688,16 +683,6 @@ GNUNET_NETWORK_socket_recvfrom_amount (const struct GNUNET_NETWORK_Handle *desc)
688} 683}
689 684
690 685
691/**
692 * Read data from a socket (always non-blocking).
693 *
694 * @param desc socket
695 * @param buffer buffer
696 * @param length length of @a buffer
697 * @param src_addr either the source to recv from, or all zeroes
698 * to be filled in by recvfrom
699 * @param addrlen length of the @a src_addr
700 */
701ssize_t 686ssize_t
702GNUNET_NETWORK_socket_recvfrom (const struct GNUNET_NETWORK_Handle *desc, 687GNUNET_NETWORK_socket_recvfrom (const struct GNUNET_NETWORK_Handle *desc,
703 void *buffer, 688 void *buffer,
@@ -748,14 +733,6 @@ GNUNET_NETWORK_socket_recv (const struct GNUNET_NETWORK_Handle *desc,
748} 733}
749 734
750 735
751/**
752 * Send data (always non-blocking).
753 *
754 * @param desc socket
755 * @param buffer data to send
756 * @param length size of the @a buffer
757 * @return number of bytes sent, #GNUNET_SYSERR on error
758 */
759ssize_t 736ssize_t
760GNUNET_NETWORK_socket_send (const struct GNUNET_NETWORK_Handle *desc, 737GNUNET_NETWORK_socket_send (const struct GNUNET_NETWORK_Handle *desc,
761 const void *buffer, 738 const void *buffer,
diff --git a/src/util/os_installation.c b/src/util/os_installation.c
index 1835c6e84..7a348b42e 100644
--- a/src/util/os_installation.c
+++ b/src/util/os_installation.c
@@ -117,11 +117,6 @@ GNUNET_OS_project_data_get ()
117} 117}
118 118
119 119
120/**
121 * Setup OS subsystem with project data.
122 *
123 * @param pd project data used to determine paths
124 */
125void 120void
126GNUNET_OS_init (const struct GNUNET_OS_ProjectData *pd) 121GNUNET_OS_init (const struct GNUNET_OS_ProjectData *pd)
127{ 122{
diff --git a/src/util/os_priority.c b/src/util/os_priority.c
index 2ed49b5aa..e60273814 100644
--- a/src/util/os_priority.c
+++ b/src/util/os_priority.c
@@ -128,14 +128,6 @@ parent_control_handler (void *cls)
128} 128}
129 129
130 130
131/**
132 * Task that connects this process to its parent via pipe;
133 * essentially, the parent control handler will read signal numbers
134 * from the #GNUNET_OS_CONTROL_PIPE (as given in an environment
135 * variable) and raise those signals.
136 *
137 * @param cls closure (unused)
138 */
139void 131void
140GNUNET_OS_install_parent_control_handler (void *cls) 132GNUNET_OS_install_parent_control_handler (void *cls)
141{ 133{
@@ -583,17 +575,6 @@ start_process (enum GNUNET_OS_InheritStdioFlags std_inheritance,
583} 575}
584 576
585 577
586/**
587 * Start a process.
588 *
589 * @param std_inheritance a set of GNUNET_OS_INHERIT_STD_* flags
590 * @param pipe_stdin pipe to use to send input to child process (or NULL)
591 * @param pipe_stdout pipe to use to get output from child process (or NULL)
592 * @param pipe_stderr pipe to use to get output from child process (or NULL)
593 * @param filename name of the binary
594 * @param argv NULL-terminated array of arguments to the process
595 * @return pointer to process structure of the new process, NULL on error
596 */
597struct GNUNET_OS_Process * 578struct GNUNET_OS_Process *
598GNUNET_OS_start_process_vap (enum GNUNET_OS_InheritStdioFlags std_inheritance, 579GNUNET_OS_start_process_vap (enum GNUNET_OS_InheritStdioFlags std_inheritance,
599 struct GNUNET_DISK_PipeHandle *pipe_stdin, 580 struct GNUNET_DISK_PipeHandle *pipe_stdin,
@@ -612,17 +593,6 @@ GNUNET_OS_start_process_vap (enum GNUNET_OS_InheritStdioFlags std_inheritance,
612} 593}
613 594
614 595
615/**
616 * Start a process.
617 *
618 * @param std_inheritance a set of GNUNET_OS_INHERIT_STD_* flags
619 * @param pipe_stdin pipe to use to send input to child process (or NULL)
620 * @param pipe_stdout pipe to use to get output from child process (or NULL)
621 * @param pipe_stderr pipe to use to get output from child process (or NULL)
622 * @param filename name of the binary
623 * @param va NULL-terminated list of arguments to the process
624 * @return pointer to process structure of the new process, NULL on error
625 */
626struct GNUNET_OS_Process * 596struct GNUNET_OS_Process *
627GNUNET_OS_start_process_va (enum GNUNET_OS_InheritStdioFlags std_inheritance, 597GNUNET_OS_start_process_va (enum GNUNET_OS_InheritStdioFlags std_inheritance,
628 struct GNUNET_DISK_PipeHandle *pipe_stdin, 598 struct GNUNET_DISK_PipeHandle *pipe_stdin,
@@ -658,16 +628,6 @@ GNUNET_OS_start_process_va (enum GNUNET_OS_InheritStdioFlags std_inheritance,
658} 628}
659 629
660 630
661/**
662 * Start a process.
663 *
664 * @param std_inheritance a set of GNUNET_OS_INHERIT_STD_* flags
665 * @param pipe_stdin pipe to use to send input to child process (or NULL)
666 * @param pipe_stdout pipe to use to get output from child process (or NULL)
667 * @param filename name of the binary
668 * @param ... NULL-terminated list of arguments to the process
669 * @return pointer to process structure of the new process, NULL on error
670 */
671struct GNUNET_OS_Process * 631struct GNUNET_OS_Process *
672GNUNET_OS_start_process (enum GNUNET_OS_InheritStdioFlags std_inheritance, 632GNUNET_OS_start_process (enum GNUNET_OS_InheritStdioFlags std_inheritance,
673 struct GNUNET_DISK_PipeHandle *pipe_stdin, 633 struct GNUNET_DISK_PipeHandle *pipe_stdin,
@@ -1127,17 +1087,6 @@ cmd_read (void *cls)
1127} 1087}
1128 1088
1129 1089
1130/**
1131 * Run the given command line and call the given function
1132 * for each line of the output.
1133 *
1134 * @param proc function to call for each line of the output
1135 * @param proc_cls closure for @a proc
1136 * @param timeout when to time out
1137 * @param binary command to run
1138 * @param ... arguments to command
1139 * @return NULL on error
1140 */
1141struct GNUNET_OS_CommandHandle * 1090struct GNUNET_OS_CommandHandle *
1142GNUNET_OS_command_run (GNUNET_OS_LineProcessor proc, 1091GNUNET_OS_command_run (GNUNET_OS_LineProcessor proc,
1143 void *proc_cls, 1092 void *proc_cls,
diff --git a/src/util/peer.c b/src/util/peer.c
index 257922f36..809efdcd5 100644
--- a/src/util/peer.c
+++ b/src/util/peer.c
@@ -152,12 +152,6 @@ GNUNET_PEER_intern (const struct GNUNET_PeerIdentity *pid)
152} 152}
153 153
154 154
155/**
156 * Decrement multiple RCs of peer identities by one.
157 *
158 * @param ids array of PIDs to decrement the RCs of
159 * @param count size of the ids array
160 */
161void 155void
162GNUNET_PEER_decrement_rcs (const GNUNET_PEER_Id *ids, unsigned int count) 156GNUNET_PEER_decrement_rcs (const GNUNET_PEER_Id *ids, unsigned int count)
163{ 157{
@@ -235,12 +229,6 @@ GNUNET_PEER_resolve (GNUNET_PEER_Id id, struct GNUNET_PeerIdentity *pid)
235} 229}
236 230
237 231
238/**
239 * Convert an interned PID to a normal peer identity.
240 *
241 * @param id interned PID to convert
242 * @return pointer to peer identity, valid as long 'id' is valid
243 */
244const struct GNUNET_PeerIdentity * 232const struct GNUNET_PeerIdentity *
245GNUNET_PEER_resolve2 (GNUNET_PEER_Id id) 233GNUNET_PEER_resolve2 (GNUNET_PEER_Id id)
246{ 234{
diff --git a/src/util/regex.c b/src/util/regex.c
index fed325cd6..c2040a4b8 100644
--- a/src/util/regex.c
+++ b/src/util/regex.c
@@ -33,14 +33,6 @@
33#define DOT "(0|1|2|3|4|5|6|7|8|9|A|B|C|D|E|F)" 33#define DOT "(0|1|2|3|4|5|6|7|8|9|A|B|C|D|E|F)"
34 34
35 35
36/**
37 * Create a regex in @a rxstr from the given @a ip and @a netmask.
38 *
39 * @param ip IPv4 representation.
40 * @param port destination port
41 * @param rxstr generated regex, must be at least #GNUNET_TUN_IPV4_REGEXLEN
42 * bytes long.
43 */
44void 36void
45GNUNET_TUN_ipv4toregexsearch (const struct in_addr *ip, 37GNUNET_TUN_ipv4toregexsearch (const struct in_addr *ip,
46 uint16_t port, 38 uint16_t port,
@@ -54,14 +46,6 @@ GNUNET_TUN_ipv4toregexsearch (const struct in_addr *ip,
54} 46}
55 47
56 48
57/**
58 * Create a regex in @a rxstr from the given @a ipv6 and @a prefixlen.
59 *
60 * @param ipv6 IPv6 representation.
61 * @param port destination port
62 * @param rxstr generated regex, must be at least #GNUNET_TUN_IPV6_REGEXLEN
63 * bytes long.
64 */
65void 49void
66GNUNET_TUN_ipv6toregexsearch (const struct in6_addr *ipv6, 50GNUNET_TUN_ipv6toregexsearch (const struct in6_addr *ipv6,
67 uint16_t port, 51 uint16_t port,
@@ -694,15 +678,6 @@ ipv6_to_regex (const struct GNUNET_STRINGS_IPv6NetworkPolicy *v6)
694} 678}
695 679
696 680
697/**
698 * Convert an exit policy to a regular expression. The exit policy
699 * specifies a set of subnets this peer is willing to serve as an
700 * exit for; the resulting regular expression will match the
701 * IPv4 address strings as returned by #GNUNET_TUN_ipv4toregexsearch().
702 *
703 * @param policy exit policy specification
704 * @return regular expression, NULL on error
705 */
706char * 681char *
707GNUNET_TUN_ipv4policy2regex (const char *policy) 682GNUNET_TUN_ipv4policy2regex (const char *policy)
708{ 683{
@@ -746,15 +721,6 @@ GNUNET_TUN_ipv4policy2regex (const char *policy)
746} 721}
747 722
748 723
749/**
750 * Convert an exit policy to a regular expression. The exit policy
751 * specifies a set of subnets this peer is willing to serve as an
752 * exit for; the resulting regular expression will match the
753 * IPv6 address strings as returned by #GNUNET_TUN_ipv6toregexsearch().
754 *
755 * @param policy exit policy specification
756 * @return regular expression, NULL on error
757 */
758char * 724char *
759GNUNET_TUN_ipv6policy2regex (const char *policy) 725GNUNET_TUN_ipv6policy2regex (const char *policy)
760{ 726{
@@ -802,14 +768,6 @@ GNUNET_TUN_ipv6policy2regex (const char *policy)
802} 768}
803 769
804 770
805/**
806 * Hash the service name of a hosted service to the
807 * hash code that is used to identify the service on
808 * the network.
809 *
810 * @param service_name a string
811 * @param hc corresponding hash
812 */
813void 771void
814GNUNET_TUN_service_name_to_hash (const char *service_name, 772GNUNET_TUN_service_name_to_hash (const char *service_name,
815 struct GNUNET_HashCode *hc) 773 struct GNUNET_HashCode *hc)
diff --git a/src/util/scheduler.c b/src/util/scheduler.c
index 7e035ae3d..acae4d7e2 100644
--- a/src/util/scheduler.c
+++ b/src/util/scheduler.c
@@ -687,20 +687,6 @@ select_loop (struct GNUNET_SCHEDULER_Handle *sh,
687 struct DriverContext *context); 687 struct DriverContext *context);
688 688
689 689
690/**
691 * Initialize and run scheduler. This function will return when all
692 * tasks have completed. On systems with signals, receiving a SIGTERM
693 * (and other similar signals) will cause #GNUNET_SCHEDULER_shutdown()
694 * to be run after the active task is complete. As a result, SIGTERM
695 * causes all active tasks to be scheduled with reason
696 * #GNUNET_SCHEDULER_REASON_SHUTDOWN. (However, tasks added
697 * afterwards will execute normally!). Note that any particular signal
698 * will only shut down one scheduler; applications should always only
699 * create a single scheduler.
700 *
701 * @param task task to run immediately
702 * @param task_cls closure of @a task
703 */
704void 690void
705GNUNET_SCHEDULER_run (GNUNET_SCHEDULER_TaskCallback task, 691GNUNET_SCHEDULER_run (GNUNET_SCHEDULER_TaskCallback task,
706 void *task_cls) 692 void *task_cls)
@@ -1345,20 +1331,6 @@ GNUNET_SCHEDULER_add_shutdown (GNUNET_SCHEDULER_TaskCallback task,
1345} 1331}
1346 1332
1347 1333
1348/**
1349 * Schedule a new task to be run as soon as possible with the
1350 * (transitive) ignore-shutdown flag either explicitly set or
1351 * explicitly enabled. This task (and all tasks created from it,
1352 * other than by another call to this function) will either count or
1353 * not count for the "lifeness" of the process. This API is only
1354 * useful in a few special cases.
1355 *
1356 * @param lifeness #GNUNET_YES if the task counts for lifeness, #GNUNET_NO if not.
1357 * @param task main function of the task
1358 * @param task_cls closure of @a task
1359 * @return unique task identifier for the job
1360 * only valid until @a task is started!
1361 */
1362struct GNUNET_SCHEDULER_Task * 1334struct GNUNET_SCHEDULER_Task *
1363GNUNET_SCHEDULER_add_now_with_lifeness (int lifeness, 1335GNUNET_SCHEDULER_add_now_with_lifeness (int lifeness,
1364 GNUNET_SCHEDULER_TaskCallback task, 1336 GNUNET_SCHEDULER_TaskCallback task,
diff --git a/src/util/service.c b/src/util/service.c
index c48060437..27183981e 100644
--- a/src/util/service.c
+++ b/src/util/service.c
@@ -743,7 +743,7 @@ service_client_recv (void *cls)
743 * setup the client (with the scheduler) and tell the application. 743 * setup the client (with the scheduler) and tell the application.
744 * 744 *
745 * @param sh service that accepted the client 745 * @param sh service that accepted the client
746 * @param sock socket associated with the client 746 * @param csock socket associated with the client
747 */ 747 */
748static void 748static void
749start_client (struct GNUNET_SERVICE_Handle *sh, 749start_client (struct GNUNET_SERVICE_Handle *sh,
diff --git a/src/util/socks.c b/src/util/socks.c
index 5c9f8a5f8..a1990ec8b 100644
--- a/src/util/socks.c
+++ b/src/util/socks.c
@@ -516,7 +516,7 @@ GNUNET_SOCKS_init_handshake_noauth ()
516 * and port. 516 * and port.
517 * 517 *
518 * @param ih SOCKS5 handshake 518 * @param ih SOCKS5 handshake
519 * @param hostname 519 * @param host
520 * @param port 520 * @param port
521 */ 521 */
522void 522void
diff --git a/src/util/speedup.c b/src/util/speedup.c
index 3d9e82319..82a8746a9 100644
--- a/src/util/speedup.c
+++ b/src/util/speedup.c
@@ -55,12 +55,6 @@ do_speedup (void *cls)
55} 55}
56 56
57 57
58/**
59 * Start task that may speed up our system clock artificially
60 *
61 * @param cfg configuration to use
62 * @return #GNUNET_OK on success, #GNUNET_SYSERR if the speedup was not configured
63 */
64int 58int
65GNUNET_SPEEDUP_start_ (const struct GNUNET_CONFIGURATION_Handle *cfg) 59GNUNET_SPEEDUP_start_ (const struct GNUNET_CONFIGURATION_Handle *cfg)
66{ 60{
diff --git a/src/util/tun.c b/src/util/tun.c
index d2b675c71..e22cf0be8 100644
--- a/src/util/tun.c
+++ b/src/util/tun.c
@@ -97,14 +97,6 @@ GNUNET_TUN_initialize_ipv6_header (struct GNUNET_TUN_IPv6Header *ip,
97} 97}
98 98
99 99
100/**
101 * Calculate IPv4 TCP checksum.
102 *
103 * @param ip ipv4 header fully initialized
104 * @param tcp TCP header (initialized except for CRC)
105 * @param payload the TCP payload
106 * @param payload_length number of bytes of TCP payload
107 */
108void 100void
109GNUNET_TUN_calculate_tcp4_checksum (const struct GNUNET_TUN_IPv4Header *ip, 101GNUNET_TUN_calculate_tcp4_checksum (const struct GNUNET_TUN_IPv4Header *ip,
110 struct GNUNET_TUN_TcpHeader *tcp, 102 struct GNUNET_TUN_TcpHeader *tcp,
@@ -135,14 +127,6 @@ GNUNET_TUN_calculate_tcp4_checksum (const struct GNUNET_TUN_IPv4Header *ip,
135} 127}
136 128
137 129
138/**
139 * Calculate IPv6 TCP checksum.
140 *
141 * @param ip ipv6 header fully initialized
142 * @param tcp header (initialized except for CRC)
143 * @param payload the TCP payload
144 * @param payload_length number of bytes of TCP payload
145 */
146void 130void
147GNUNET_TUN_calculate_tcp6_checksum (const struct GNUNET_TUN_IPv6Header *ip, 131GNUNET_TUN_calculate_tcp6_checksum (const struct GNUNET_TUN_IPv6Header *ip,
148 struct GNUNET_TUN_TcpHeader *tcp, 132 struct GNUNET_TUN_TcpHeader *tcp,
@@ -171,14 +155,6 @@ GNUNET_TUN_calculate_tcp6_checksum (const struct GNUNET_TUN_IPv6Header *ip,
171} 155}
172 156
173 157
174/**
175 * Calculate IPv4 UDP checksum.
176 *
177 * @param ip ipv4 header fully initialized
178 * @param udp UDP header (initialized except for CRC)
179 * @param payload the UDP payload
180 * @param payload_length number of bytes of UDP payload
181 */
182void 158void
183GNUNET_TUN_calculate_udp4_checksum (const struct GNUNET_TUN_IPv4Header *ip, 159GNUNET_TUN_calculate_udp4_checksum (const struct GNUNET_TUN_IPv4Header *ip,
184 struct GNUNET_TUN_UdpHeader *udp, 160 struct GNUNET_TUN_UdpHeader *udp,
@@ -210,14 +186,6 @@ GNUNET_TUN_calculate_udp4_checksum (const struct GNUNET_TUN_IPv4Header *ip,
210} 186}
211 187
212 188
213/**
214 * Calculate IPv6 UDP checksum.
215 *
216 * @param ip ipv6 header fully initialized
217 * @param udp UDP header (initialized except for CRC)
218 * @param payload the UDP payload
219 * @param payload_length number of bytes of UDP payload
220 */
221void 189void
222GNUNET_TUN_calculate_udp6_checksum (const struct GNUNET_TUN_IPv6Header *ip, 190GNUNET_TUN_calculate_udp6_checksum (const struct GNUNET_TUN_IPv6Header *ip,
223 struct GNUNET_TUN_UdpHeader *udp, 191 struct GNUNET_TUN_UdpHeader *udp,
@@ -249,13 +217,6 @@ GNUNET_TUN_calculate_udp6_checksum (const struct GNUNET_TUN_IPv6Header *ip,
249} 217}
250 218
251 219
252/**
253 * Calculate ICMP checksum.
254 *
255 * @param icmp IMCP header (initialized except for CRC)
256 * @param payload the ICMP payload
257 * @param payload_length number of bytes of ICMP payload
258 */
259void 220void
260GNUNET_TUN_calculate_icmp_checksum (struct GNUNET_TUN_IcmpHeader *icmp, 221GNUNET_TUN_calculate_icmp_checksum (struct GNUNET_TUN_IcmpHeader *icmp,
261 const void *payload, 222 const void *payload,
diff --git a/src/vpn/gnunet-service-vpn.c b/src/vpn/gnunet-service-vpn.c
index b4233905f..a2a16e380 100644
--- a/src/vpn/gnunet-service-vpn.c
+++ b/src/vpn/gnunet-service-vpn.c
@@ -696,7 +696,7 @@ make_up_icmpv6_payload (struct ChannelState *ts,
696 * We got an ICMP packet back from the CADET channel. Check it is OK. 696 * We got an ICMP packet back from the CADET channel. Check it is OK.
697 * 697 *
698 * @param cls our `struct ChannelState *` 698 * @param cls our `struct ChannelState *`
699 * @param message the actual message 699 * @param i2v the actual message
700 * @return #GNUNET_OK to keep the connection open, 700 * @return #GNUNET_OK to keep the connection open,
701 * #GNUNET_SYSERR to close it (signal serious error) 701 * #GNUNET_SYSERR to close it (signal serious error)
702 */ 702 */
@@ -724,7 +724,7 @@ check_icmp_back (void *cls, const struct GNUNET_EXIT_IcmpToVPNMessage *i2v)
724 * local virtual interface via the helper. 724 * local virtual interface via the helper.
725 * 725 *
726 * @param cls our `struct ChannelState *` 726 * @param cls our `struct ChannelState *`
727 * @param message the actual message 727 * @param i2v the actual message
728 */ 728 */
729static void 729static void
730handle_icmp_back (void *cls, const struct GNUNET_EXIT_IcmpToVPNMessage *i2v) 730handle_icmp_back (void *cls, const struct GNUNET_EXIT_IcmpToVPNMessage *i2v)
diff --git a/src/vpn/vpn_api.c b/src/vpn/vpn_api.c
index 3f7d9d000..8a3464786 100644
--- a/src/vpn/vpn_api.c
+++ b/src/vpn/vpn_api.c
@@ -384,28 +384,6 @@ GNUNET_VPN_cancel_request (struct GNUNET_VPN_RedirectionRequest *rr)
384} 384}
385 385
386 386
387/**
388 * Tell the VPN that a forwarding to a particular peer offering a
389 * particular service is requested. The VPN is to reserve a
390 * particular IP for the redirection and return it. The VPN will
391 * begin the redirection as soon as possible and maintain it as long
392 * as it is actively used and keeping it is feasible. Given resource
393 * limitations, the longest inactive mappings will be destroyed.
394 *
395 * @param vh VPN handle
396 * @param result_af desired address family for the returned allocation
397 * can also be AF_UNSPEC
398 * @param protocol protocol, IPPROTO_UDP or IPPROTO_TCP
399 * @param peer target peer for the redirection
400 * @param serv service descriptor to give to the peer
401 * @param expiration_time at what time should the redirection expire?
402 * (this should not impact connections that are active at that time)
403 * @param cb function to call with the IP
404 * @param cb_cls closure for @a cb
405 * @return handle to cancel the request (means the callback won't be
406 * invoked anymore; the mapping may or may not be established
407 * anyway)
408 */
409struct GNUNET_VPN_RedirectionRequest * 387struct GNUNET_VPN_RedirectionRequest *
410GNUNET_VPN_redirect_to_peer (struct GNUNET_VPN_Handle *vh, 388GNUNET_VPN_redirect_to_peer (struct GNUNET_VPN_Handle *vh,
411 int result_af, 389 int result_af,