move

1 files changed, 95 insertions, 22 deletions

diff --git a/TODO b/TODO
index bde3d97b4..0d2725793 100644
--- a/TODO
+++ b/TODO
@@ -14,11 +14,61 @@ away), in order in which they will likely be done:
 * FS [Christian]
 
 0.9.0pre0:
-* HOSTLIST/PEERINFO/CORE/TRANSPORT/TOPOLOGY:
-  - hostlist server learns about 2nd peer, but soon forgets (not 
-    clear if this is still an issue, or if validation failed or
-    if this was an issue with the client's parsing of the reply, which
-    was broken...)
+* TRANSPORT:
+  - TCP not used bi-directionally (especially important also for PONG!)
+    Need a way for plugin to tell to service that it can *reliably* transmit
+    PONGs.  Need *good* way to ensure only one (plugin) session is active at 
+    any given point in time; need systematic way to periodically probe latency/
+    transport cost changes
+  - disconnect notifications from TCP not always as nice as we might want
+    them to be (but how can we do this cleanly given that UDP is connectionless?)
+  - hostlist testcase shows that (randomly) we jump to an address that
+    seems to be a plugin function *after* the plugin has been unloaded
+    (directly from scheduler); check that *all* plugin tasks are cancelled
+    after plugin is unloaded! (need better testcases for that...)
+  - implement transport API to pretty-print transport address 
+    + transport_api extension (API extension!)
+    + service-transport extension (protocol extension)
+  - implement gnunet-transport (transport configurator / tester)
+  - instantly filter addresses from *other* peers that 
+    are *equal* to our own address + port (i.e., localhost:2086).  We 
+    no longer filter those for outgoing (helps with loopback testing
+    and keeps the code clean), but we should filter strictly *impossible*
+    incoming addresses!  This is for efficiency, not correctness.
+  - UPnP-based IP detection
+    (Note: build library always, build service when libxml2/etc. are available)
+  - We currently are happy to take any address told to us in a WELCOME
+    to our set of addresses; we should have some minimal threshold-based
+    scheme, limiting both the total number of addresses that we accept 
+    this way as well as requiring multiple confirmations; also, we
+    should possibly try to confirm that the given address works for
+    us ourselves (loopback-style) before adding it to the list
+    [SECURITY issue]
+    + we may be able to simplify WELCOME messages (no need to add 
+      addresses there anymore, but may help to learn them there anyway...).
+    + we probably want some kind of voting/counting for learning IP addresses
+      (maybe including IP addresses in ads proportional to how often others
+       report them? we at least need some protection against >64k HELLOs!),
+    + provide a way to give the user a list of "learned" IP addresses and
+      a way to easily "veto" addresses off the list!
+      => If MiM attacker uses vetoed address, blacklist the specific IP for
+         the presumed neighbour!
+  - [./transport/gnunet-service-transport.c:173]: (style) struct or union member 'TransportPlugin::rebuild' is never used
+  - [./transport/plugin_transport_tcp.c:391]: (style) struct or union member 'Plugin::address_update_task' is never used
+* FS:
+  - [./fs/gnunet-service-fs.c:208]: (style) struct or union member 'LocalGetContext::results_bf_size' is never used
+  - [./fs/gnunet-service-fs.c:501]: (style) struct or union member 'PendingRequest::used_pids_size' is never used
+  - [./fs/gnunet-service-fs.c:654]: (style) struct or union member 'ConnectedPeer::last_client_replies' is never used
+  - [./fs/gnunet-service-fs.c:669]: (style) struct or union member 'ConnectedPeer::avg_delay' is never used
+  - [./fs/gnunet-service-fs.c:675]: (style) struct or union member 'ConnectedPeer::avg_priority' is never used
+  - [./fs/gnunet-service-fs.c:688]: (style) struct or union member 'ConnectedPeer::pending_requests' is never used
+  - [./fs/gnunet-service-fs.c:694]: (style) struct or union member 'ConnectedPeer::last_p2p_replies_woff' is never used
+  - [./fs/gnunet-service-fs.c:700]: (style) struct or union member 'ConnectedPeer::last_client_replies_woff' is never used
+* CORE:
+  - SET_KEY is triggered every 2.5 minutes (after session is up); should
+    just do PING (not SET_KEY + PING)
+  - "Forcing disconnect of XXX due to inactivity" -- can happen every few MS!?
+    (disconnect does not really succeed, or what?)
 * TOPOLOGY:
   - needs more testing (especially F2F topology)
   - needs to re-try connecting after disconnect (currently, it
@@ -27,28 +77,34 @@ away), in order in which they will likely be done:
     cause seems to be the 'blacklist_after_attempt' being set to 1h,
     which is rather long -- and should probably be adjusted based on
     the number of connections / known peers)
-* CORE:
-  - peers do not seem to connect (setkey, ping are there; PONG is sent,
-    not sure what else happens; eventually, the "neighbour" entry times
-    out and is removed)
+  - If the topology daemon crashes, peers that were put on the
+    blacklist with transport will never be removed from it (until
+    transport service dies); we should use the blacklist notification
+    API to learn about the exact set of blacklisted peers at all times
+    (FIXME: the transport_api implementation of blacklisting
+     also does not work nicely for this since it won't let us know about
+     disconnect-reconnect events and the implicit whitelisting
+     that might happen here; that's not so bad since we will
+     re-blacklist on pre-connect attempts anyway, so this is 
+     a minor issue).
+  - the code uses the term 'blacklist' for both peers that are forbidden
+    to connect (i.e. F2F mode) as well as peers that we currently
+    won't try to actively connect to ourselves (since we just tried);
+    This is confusing.  We need two distinct terms.
+  - move code to use hash table instead of linked list
+  - instead of periodically discarding blacklisted entries,
+    simply add task that is triggered at the right time (earlier free,
+    more balanced load)
+  - check if new HELLO learned is different from old HELLO
+    before resetting entire state!
 * UTIL:
-  - load: need way to determine network load (up/down) -- and quickly so!
   - trust: need *fast* way to check/update trust in peers
            (async peerinfo would not be right)
   - scheduler should change OS process priority based on task priority;   
     should make better use of task priorities in general
-* TRANSPORT:
-  - disconnect notifications from TCP not always as nice as we might want
-    them to be (but how can we do this cleanly given that UDP is connectionless?)
-  - TCP not used bi-directionally (especially important also for PONG!)
-    Need a way for plugin to tell to service that it can *reliably* transmit
-    PONGs.  Need *good* way to ensure only one (plugin) session is active at 
-    any given point in time; need systematic way to periodically probe latency/
-    transport cost changes
-  - hostlist testcase shows that (randomly) we jump to an address that
-    seems to be a plugin function *after* the plugin has been unloaded
-    (directly from scheduler); check that *all* plugin tasks are cancelled
-    after plugin is unloaded! (need better testcases for that...)
+  - only connect() sockets that are ready (select()) [Nils]
+    [On W32, we need to select after calling socket before
+     doing connect etc.]
 * STATISTICS:
   - synchronous/asynchronous API (& implementation) is not nice;
     => provide notification-based API
@@ -58,9 +114,18 @@ away), in order in which they will likely be done:
 * ARM:
   - need to get rid of synchronous API for service starts (cause all kinds of problems)
     [=> eliminate for need to tell ARM about service starts most of the time!] [Safey]
+  - better tracking of which config changes actually need to cause process restarts by ARM.
+  - listen for requests to discover dependencies between services (and avoid
+    having to explicitly program start requests)
+  - better crash management (attach debugging support, capture and analyze
+    debug output, detect random vs. deterministic crashes)
+  - shutdown sequence?
 * HELLO:
   - need function to test "equivalency" of HELLOs; use in topology!
 * FS:
+  - GAP improvements:
+    + active reply route caching design & implementation of service,
+      gap extension!
   - gnunet-publish cannot be aborted using CTRL-C
   - gnunet-publish segfaults if file does not exist
   - on some systems, keyword search does not find locally published content
@@ -112,6 +177,9 @@ away), in order in which they will likely be done:
     + test basic peer re-configure [Nate]
     + test topology creation [Nate]
     + test churn generation [Nate]
+* TESTING:
+  - consider changing API for peer-group termination to 
+    call continuation when done
 * WWW:
   - Get IPv6 hooked up
   - change DNS
@@ -127,9 +195,14 @@ away), in order in which they will likely be done:
     + implement DV transport plugin [Nate & CG]
     + implement testcases [Nate]
     + implement performance tests [Nate]
+* SETUP:
+  - design & implement new setup tool
 * GUIs to implement:
   - gtk (RC-pre1)
     + how to integrate scheduler with GTK event loop!
+* HOSTLIST:
+  - 'server' uses 'GNUNET_PEERINFO_iterate', should probably switch to notification API
+    (for more instant / up-to-date hostlists at lower cost) [OPTIMIZATION]
 
 0.9.0pre2:
 * Module features to implement: