diff options
author | Christian Grothoff <christian@grothoff.org> | 2014-12-07 00:17:25 +0000 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2014-12-07 00:17:25 +0000 |
commit | 2b306e4a9ac8b0f4968a9cc2336fbc346de845e4 (patch) | |
tree | 306b3f0b8b66820d867debf38f6e7db45fa0a8ec /src/ats | |
parent | fcea691a0f179abf8bde499ac9c68ce34f58422e (diff) | |
download | gnunet-2b306e4a9ac8b0f4968a9cc2336fbc346de845e4.tar.gz gnunet-2b306e4a9ac8b0f4968a9cc2336fbc346de845e4.zip |
-fixing misc minor ats test/driver bugs
Diffstat (limited to 'src/ats')
-rw-r--r-- | src/ats/gnunet-ats-solver-eval.c | 25 | ||||
-rw-r--r-- | src/ats/perf_ats_solver.c | 5 |
2 files changed, 21 insertions, 9 deletions
diff --git a/src/ats/gnunet-ats-solver-eval.c b/src/ats/gnunet-ats-solver-eval.c index 17bdf6b15..86930d392 100644 --- a/src/ats/gnunet-ats-solver-eval.c +++ b/src/ats/gnunet-ats-solver-eval.c | |||
@@ -381,6 +381,7 @@ GNUNET_ATS_solver_logging_write_to_disk (struct LoggingHandle *l, int add_time_s | |||
381 | { | 381 | { |
382 | fprintf (stderr, "Cannot open `%s' to write log data!\n", filename); | 382 | fprintf (stderr, "Cannot open `%s' to write log data!\n", filename); |
383 | GNUNET_free (filename); | 383 | GNUNET_free (filename); |
384 | GNUNET_free (cur); | ||
384 | goto cleanup; | 385 | goto cleanup; |
385 | } | 386 | } |
386 | GNUNET_free (filename); | 387 | GNUNET_free (filename); |
@@ -633,15 +634,19 @@ set_prop_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc) | |||
633 | } | 634 | } |
634 | if (NULL == (p = find_peer_by_id (pg->peer))) | 635 | if (NULL == (p = find_peer_by_id (pg->peer))) |
635 | { | 636 | { |
637 | GNUNET_break (0); | ||
636 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, | 638 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
637 | "Setting property generation for unknown peer %u\n", | 639 | "Setting property generation for unknown peer %u\n", |
638 | pg->peer); | 640 | pg->peer); |
641 | return; | ||
639 | } | 642 | } |
640 | if (NULL == (a = find_address_by_id (p, pg->address_id))) | 643 | if (NULL == (a = find_address_by_id (p, pg->address_id))) |
641 | { | 644 | { |
645 | GNUNET_break (0); | ||
642 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, | 646 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
643 | "Setting property generation for unknown peer %u\n", | 647 | "Setting property generation for unknown peer %u\n", |
644 | pg->peer); | 648 | pg->peer); |
649 | return; | ||
645 | } | 650 | } |
646 | 651 | ||
647 | prop_value = get_property (pg); | 652 | prop_value = get_property (pg); |
@@ -2268,10 +2273,14 @@ enforce_del_address (struct GNUNET_ATS_TEST_Operation *op) | |||
2268 | GNUNET_ATS_solver_generate_property_stop (pg); | 2273 | GNUNET_ATS_solver_generate_property_stop (pg); |
2269 | } | 2274 | } |
2270 | 2275 | ||
2271 | GNUNET_CONTAINER_multipeermap_remove (sh->addresses, &p->peer_id, a->ats_addr); | 2276 | GNUNET_assert (GNUNET_YES == |
2272 | 2277 | GNUNET_CONTAINER_multipeermap_remove (sh->addresses, | |
2273 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Removing address %u for peer %u\n", | 2278 | &p->peer_id, |
2274 | op->address_id, op->peer_id); | 2279 | a->ats_addr)); |
2280 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, | ||
2281 | "Removing address %u for peer %u\n", | ||
2282 | op->address_id, | ||
2283 | op->peer_id); | ||
2275 | 2284 | ||
2276 | sh->env.sf.s_del (sh->solver, a->ats_addr, GNUNET_NO); | 2285 | sh->env.sf.s_del (sh->solver, a->ats_addr, GNUNET_NO); |
2277 | 2286 | ||
@@ -2961,7 +2970,7 @@ solver_bandwidth_changed_cb (void *cls, struct ATS_Address *address) | |||
2961 | GNUNET_i2s (&address->peer)); | 2970 | GNUNET_i2s (&address->peer)); |
2962 | } | 2971 | } |
2963 | p = find_peer_by_pid(&address->peer); | 2972 | p = find_peer_by_pid(&address->peer); |
2964 | if(NULL == p) | 2973 | if (NULL == p) |
2965 | return; | 2974 | return; |
2966 | p->assigned_bw_out = address->assigned_bw_out; | 2975 | p->assigned_bw_out = address->assigned_bw_out; |
2967 | p->assigned_bw_in = address->assigned_bw_in; | 2976 | p->assigned_bw_in = address->assigned_bw_in; |
@@ -3020,13 +3029,15 @@ get_property_cb (void *cls, const struct ATS_Address *address) | |||
3020 | if (GNUNET_YES == opt_disable_normalization) | 3029 | if (GNUNET_YES == opt_disable_normalization) |
3021 | { | 3030 | { |
3022 | p = find_peer_by_pid (&address->peer); | 3031 | p = find_peer_by_pid (&address->peer); |
3032 | if (NULL == p) | ||
3033 | return NULL; | ||
3023 | a = find_address_by_ats_address (p, address); | 3034 | a = find_address_by_ats_address (p, address); |
3024 | return a->prop_abs; | 3035 | return a->prop_abs; |
3025 | } | 3036 | } |
3026 | else | 3037 | return GAS_normalization_get_properties ((struct ATS_Address *) address); |
3027 | return GAS_normalization_get_properties ((struct ATS_Address *) address); | ||
3028 | } | 3038 | } |
3029 | 3039 | ||
3040 | |||
3030 | static void | 3041 | static void |
3031 | set_updated_property ( struct ATS_Address *address, uint32_t type, double prop_rel) | 3042 | set_updated_property ( struct ATS_Address *address, uint32_t type, double prop_rel) |
3032 | { | 3043 | { |
diff --git a/src/ats/perf_ats_solver.c b/src/ats/perf_ats_solver.c index 6fbf547ac..d25d5da58 100644 --- a/src/ats/perf_ats_solver.c +++ b/src/ats/perf_ats_solver.c | |||
@@ -786,7 +786,7 @@ evaluate (int iteration) | |||
786 | 786 | ||
787 | for (cp = ph.N_peers_start; cp <= ph.N_peers_end; cp ++) | 787 | for (cp = ph.N_peers_start; cp <= ph.N_peers_end; cp ++) |
788 | { | 788 | { |
789 | cur = ph.iterations_results[ph.current_iteration-1].results_array[cp]; | 789 | cur = ph.iterations_results[ph.current_iteration-1].results_array[cp]; |
790 | if (0 == cp) | 790 | if (0 == cp) |
791 | continue; | 791 | continue; |
792 | if (NULL == cur) | 792 | if (NULL == cur) |
@@ -794,6 +794,7 @@ evaluate (int iteration) | |||
794 | GNUNET_break (0); | 794 | GNUNET_break (0); |
795 | fprintf (stderr, | 795 | fprintf (stderr, |
796 | "Missing result for %u peers\n", cp); | 796 | "Missing result for %u peers\n", cp); |
797 | continue; | ||
797 | } | 798 | } |
798 | 799 | ||
799 | 800 | ||
@@ -845,9 +846,9 @@ evaluate (int iteration) | |||
845 | (unsigned long long )cur->d_mlp_full.rel_value_us); | 846 | (unsigned long long )cur->d_mlp_full.rel_value_us); |
846 | } | 847 | } |
847 | } | 848 | } |
848 | |||
849 | } | 849 | } |
850 | 850 | ||
851 | |||
851 | /** | 852 | /** |
852 | * Evaluate average results for all iterations | 853 | * Evaluate average results for all iterations |
853 | */ | 854 | */ |