- better feedback to users about duplicated messages

1 files changed, 20 insertions, 4 deletions

diff --git a/src/cadet/gnunet-service-cadet_channel.c b/src/cadet/gnunet-service-cadet_channel.c
index 3dc7101d4..cc809e9d0 100644
--- a/src/cadet/gnunet-service-cadet_channel.c
+++ b/src/cadet/gnunet-service-cadet_channel.c
@@ -1972,10 +1972,26 @@ GCCH_handle_data (struct CadetChannel *ch,
   }
   else
   {
-    GNUNET_break_op (GC_is_pid_bigger (rel->mid_recv, mid));
-    LOG (GNUNET_ERROR_TYPE_WARNING,
-         "MID %u on channel %s not expected (window: %u - %u). Dropping!\n",
-         mid, GCCH_2s (ch), rel->mid_recv, rel->mid_recv + 63);
+    if (GC_is_pid_bigger (rel->mid_recv, mid))
+    {
+      GNUNET_break_op (0);
+      LOG (GNUNET_ERROR_TYPE_WARNING,
+          "MID %u on channel %s not expected (window: %u - %u). Dropping!\n",
+          mid, GCCH_2s (ch), rel->mid_recv, rel->mid_recv + 63);
+    }
+    else
+    {
+      LOG (GNUNET_ERROR_TYPE_WARNING,
+           "Duplicate MID %u, channel %s (expecting MID %u). Re-sending ACK!\n",
+           mid, GCCH_2s (ch), rel->mid_recv);
+      if (NULL != rel->uniq)
+      {
+        LOG (GNUNET_ERROR_TYPE_WARNING,
+            "We are trying to send an ACK, but don't seem have the "
+            "bandwidth. Try to increase your ats QUOTA in you config file\n");
+      }
+
+    }
   }
 
   GCCH_send_data_ack (ch, fwd);