Fix #3929: cancel poll towards disconnected neighbor

3 files changed, 11 insertions, 11 deletions

diff --git a/src/cadet/gnunet-service-cadet_connection.c b/src/cadet/gnunet-service-cadet_connection.c
index 04cb2294a..f27637c7d 100644
--- a/src/cadet/gnunet-service-cadet_connection.c
+++ b/src/cadet/gnunet-service-cadet_connection.c
@@ -3270,17 +3270,18 @@ GCC_allow (struct CadetConnection *c, unsigned int buffer, int fwd)
  * @param peer Peer that disconnected.
  */
 void
-GCC_notify_broken (struct CadetConnection *c,
-                   struct CadetPeer *peer)
+GCC_neighbor_disconnected (struct CadetConnection *c, struct CadetPeer *peer)
 {
   struct CadetPeer *hop;
+  char peer_name[16];
   int fwd;
 
   GCC_check_connections ();
+  strncpy (peer_name, GCP_2s (peer), 16);
+  peer_name[15] = '\0';
   LOG (GNUNET_ERROR_TYPE_DEBUG,
-       "Notify broken on %s due to %s disconnect\n",
-       GCC_2s (c),
-       GCP_2s (peer));
+       "shutting down %s, %s disconnected\n",
+       GCC_2s (c), peer_name);
   hop = get_prev_hop (c);
   if (NULL == hop)
   {
@@ -3290,7 +3291,7 @@ GCC_notify_broken (struct CadetConnection *c,
   }
   fwd = (peer == hop);
   if ( (GNUNET_YES == GCC_is_terminal (c, fwd)) ||
-       (GNUNET_YES == c->destroy) )
+       (GNUNET_NO != c->destroy) )
   {
     /* Local shutdown, or other peer already down (hence 'c->destroy');
        so there is no one to notify about this, just clean up. */
@@ -3312,6 +3313,7 @@ GCC_notify_broken (struct CadetConnection *c,
                                                       c));
   /* Cancel queue in the direction that just died. */
   connection_cancel_queues (c, ! fwd);
+  GCC_stop_poll (c, ! fwd);
   unregister_neighbors (c);
   GCC_check_connections ();
 }
diff --git a/src/cadet/gnunet-service-cadet_connection.h b/src/cadet/gnunet-service-cadet_connection.h
index 784d9cf59..645e277b1 100644
--- a/src/cadet/gnunet-service-cadet_connection.h
+++ b/src/cadet/gnunet-service-cadet_connection.h
@@ -460,8 +460,7 @@ GCC_bck_keepalive (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc);
  * @param peer Peer that disconnected.
  */
 void
-GCC_notify_broken (struct CadetConnection *c,
-                   struct CadetPeer *peer);
+GCC_neighbor_disconnected (struct CadetConnection *c, struct CadetPeer *peer);
 
 /**
  * Is this peer the first one on the connection?
diff --git a/src/cadet/gnunet-service-cadet_peer.c b/src/cadet/gnunet-service-cadet_peer.c
index 9b7c19e4a..64adb6268 100644
--- a/src/cadet/gnunet-service-cadet_peer.c
+++ b/src/cadet/gnunet-service-cadet_peer.c
@@ -343,7 +343,7 @@ GCP_debug (const struct CadetPeer *p, enum GNUNET_ErrorType level)
  * Iterator to notify all connections of a broken link. Mark connections
  * to destroy after all traffic has been sent.
  *
- * @param cls Closure (peer disconnected).
+ * @param cls Closure (disconnected peer).
  * @param key Current key code (peer id).
  * @param value Value in the hash map (connection).
  *
@@ -361,8 +361,7 @@ notify_broken (void *cls,
        "Notifying %s due to %s\n",
        GCC_2s (c),
        GCP_2s (peer));
-  GCC_notify_broken (c,
-                     peer);
+  GCC_neighbor_disconnected (c, peer);
   return GNUNET_YES;
 }