aboutsummaryrefslogtreecommitdiff
path: root/src/cadet
diff options
context:
space:
mode:
authorBart Polot <bart@net.in.tum.de>2015-01-09 18:04:25 +0000
committerBart Polot <bart@net.in.tum.de>2015-01-09 18:04:25 +0000
commita9a9d47e481109341d4f366a3e9a70de34799c84 (patch)
tree0a355553521c3a9e20081259c46032daf38b158b /src/cadet
parentca8615c316a44ad9d669c777bf2677e835bee373 (diff)
downloadgnunet-a9a9d47e481109341d4f366a3e9a70de34799c84.tar.gz
gnunet-a9a9d47e481109341d4f366a3e9a70de34799c84.zip
- check minimum size, param order
Diffstat (limited to 'src/cadet')
-rw-r--r--src/cadet/cadet_api.c1
-rw-r--r--src/cadet/gnunet-service-cadet_local.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/src/cadet/cadet_api.c b/src/cadet/cadet_api.c
index 43fe3535f..f0d01d8aa 100644
--- a/src/cadet/cadet_api.c
+++ b/src/cadet/cadet_api.c
@@ -1357,6 +1357,7 @@ send_callback (void *cls, size_t size, void *buf)
1357 { 1357 {
1358 psize += sizeof (struct GNUNET_CADET_LocalData); 1358 psize += sizeof (struct GNUNET_CADET_LocalData);
1359 GNUNET_assert (size >= psize); 1359 GNUNET_assert (size >= psize);
1360 GNUNET_assert (sizeof (struct GNUNET_MessageHeader) <= psize);
1360 dmsg->header.size = htons (psize); 1361 dmsg->header.size = htons (psize);
1361 dmsg->id = htonl (ch->chid); 1362 dmsg->id = htonl (ch->chid);
1362 dmsg->header.type = htons (GNUNET_MESSAGE_TYPE_CADET_LOCAL_DATA); 1363 dmsg->header.type = htons (GNUNET_MESSAGE_TYPE_CADET_LOCAL_DATA);
diff --git a/src/cadet/gnunet-service-cadet_local.c b/src/cadet/gnunet-service-cadet_local.c
index 5eb17a55f..5fe160bdc 100644
--- a/src/cadet/gnunet-service-cadet_local.c
+++ b/src/cadet/gnunet-service-cadet_local.c
@@ -493,7 +493,7 @@ handle_data (void *cls, struct GNUNET_SERVER_Client *client,
493 493
494 /* Sanity check for message size */ 494 /* Sanity check for message size */
495 size = ntohs (message->size) - sizeof (struct GNUNET_CADET_LocalData); 495 size = ntohs (message->size) - sizeof (struct GNUNET_CADET_LocalData);
496 if (size < sizeof (struct GNUNET_MessageHeader)) 496 if (sizeof (struct GNUNET_MessageHeader) > size)
497 { 497 {
498 GNUNET_break (0); 498 GNUNET_break (0);
499 GNUNET_SERVER_receive_done (client, GNUNET_SYSERR); 499 GNUNET_SERVER_receive_done (client, GNUNET_SYSERR);