diff options
author | Nathan S. Evans <evans@in.tum.de> | 2010-12-21 14:04:56 +0000 |
---|---|---|
committer | Nathan S. Evans <evans@in.tum.de> | 2010-12-21 14:04:56 +0000 |
commit | 219b776fcf4f033722cf806db9f018b292481293 (patch) | |
tree | d1ecf978fdc92b00aaefdab73f697b3e6ad9e068 /src/core/core_api_iterate_peers.c | |
parent | c2a57ff4d805bb504f8d7d4f31775c99d6523285 (diff) | |
download | gnunet-219b776fcf4f033722cf806db9f018b292481293.tar.gz gnunet-219b776fcf4f033722cf806db9f018b292481293.zip |
possible null dereference
Diffstat (limited to 'src/core/core_api_iterate_peers.c')
-rw-r--r-- | src/core/core_api_iterate_peers.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/core_api_iterate_peers.c b/src/core/core_api_iterate_peers.c index d1c3828bb..6a4e7858d 100644 --- a/src/core/core_api_iterate_peers.c +++ b/src/core/core_api_iterate_peers.c | |||
@@ -71,10 +71,9 @@ receive_info (void *cls, | |||
71 | uint16_t msize; | 71 | uint16_t msize; |
72 | 72 | ||
73 | /* Handle last message or error case, disconnect and clean up */ | 73 | /* Handle last message or error case, disconnect and clean up */ |
74 | msize = ntohs (msg->size); | ||
75 | if ( (msg == NULL) || | 74 | if ( (msg == NULL) || |
76 | ((ntohs (msg->type) == GNUNET_MESSAGE_TYPE_CORE_ITERATE_PEERS_END) && | 75 | ((ntohs (msg->type) == GNUNET_MESSAGE_TYPE_CORE_ITERATE_PEERS_END) && |
77 | (msize == sizeof (struct GNUNET_MessageHeader))) ) | 76 | (ntohs (msg->size) == sizeof (struct GNUNET_MessageHeader))) ) |
78 | { | 77 | { |
79 | if (request_context->peer_cb != NULL) | 78 | if (request_context->peer_cb != NULL) |
80 | request_context->peer_cb (request_context->cb_cls, | 79 | request_context->peer_cb (request_context->cb_cls, |
@@ -84,6 +83,7 @@ receive_info (void *cls, | |||
84 | return; | 83 | return; |
85 | } | 84 | } |
86 | 85 | ||
86 | msize = ntohs (msg->size); | ||
87 | /* Handle incorrect message type or size, disconnect and clean up */ | 87 | /* Handle incorrect message type or size, disconnect and clean up */ |
88 | if ( (ntohs (msg->type) != GNUNET_MESSAGE_TYPE_CORE_NOTIFY_CONNECT) || | 88 | if ( (ntohs (msg->type) != GNUNET_MESSAGE_TYPE_CORE_NOTIFY_CONNECT) || |
89 | (msize < sizeof (struct ConnectNotifyMessage)) ) | 89 | (msize < sizeof (struct ConnectNotifyMessage)) ) |