-fix check, do not drop our own messages, but count foreign drops in stats

2 files changed, 7 insertions, 3 deletions

diff --git a/src/dv/gnunet-service-dv.c b/src/dv/gnunet-service-dv.c
index 706291e2b..42ae9a4d6 100644
--- a/src/dv/gnunet-service-dv.c
+++ b/src/dv/gnunet-service-dv.c
@@ -634,9 +634,9 @@ core_transmit_notify (void *cls, size_t size, void *buf)
  * Forward the given payload to the given target.
  *
  * @param target where to send the message
+ * @param distance expected (remaining) distance to the target
  * @param uid unique ID for the message
  * @param ultimate_target ultimate recipient for the message
- * @param distance expected (remaining) distance to the target
  * @param sender original sender of the message
  * @param payload payload of the message
  */
@@ -653,11 +653,15 @@ forward_payload (struct DirectNeighbor *target,
   size_t msize;
 
   if ( (target->pm_queue_size >= MAX_QUEUE_SIZE) &&
+       (0 == uid) &&
        (0 != memcmp (sender,
                      &my_identity,
                      sizeof (struct GNUNET_PeerIdentity))) )
   {
-    GNUNET_break (0 == uid);
+    /* not _our_ client and queue is full, drop */
+    GNUNET_STATISTICS_update (stats,
+                              "# messages dropped",
+                              1, GNUNET_NO);
     return;
   }
   msize = sizeof (struct RouteMessage) + ntohs (payload->size);
diff --git a/src/dv/plugin_transport_dv.c b/src/dv/plugin_transport_dv.c
index b4de760d2..e90604086 100644
--- a/src/dv/plugin_transport_dv.c
+++ b/src/dv/plugin_transport_dv.c
@@ -301,7 +301,7 @@ handle_dv_connect (void *cls,
    * If you remove it, also remove libgnunetats linkage from Makefile.am
    */
   LOG (GNUNET_ERROR_TYPE_DEBUG,
-       "Received `%s' message for peer `%s' with next hop in network %s \n",
+       "Received `%s' message for peer `%s' with next hop in network %s\n",
        "DV_CONNECT",
        GNUNET_i2s (peer),
        GNUNET_ATS_print_network_type (network));