aboutsummaryrefslogtreecommitdiff
path: root/src/identity
diff options
context:
space:
mode:
authorMartin Schanzenbach <mschanzenbach@posteo.de>2020-08-06 23:06:16 +0200
committerMartin Schanzenbach <mschanzenbach@posteo.de>2020-08-06 23:06:16 +0200
commit7648cde6cfb181f03df9e145a576430220234f5f (patch)
tree987badd6024e09608b47e72f56052cf79f67b405 /src/identity
parent19fe8e8ff74a9639fc075f5d974a01a977e1196a (diff)
downloadgnunet-7648cde6cfb181f03df9e145a576430220234f5f.tar.gz
gnunet-7648cde6cfb181f03df9e145a576430220234f5f.zip
-improve request cleanup handling
Diffstat (limited to 'src/identity')
-rw-r--r--src/identity/plugin_rest_identity.c33
1 files changed, 30 insertions, 3 deletions
diff --git a/src/identity/plugin_rest_identity.c b/src/identity/plugin_rest_identity.c
index 5e7d719f0..4e32b73dd 100644
--- a/src/identity/plugin_rest_identity.c
+++ b/src/identity/plugin_rest_identity.c
@@ -191,6 +191,16 @@ struct EgoEntry
191struct RequestHandle 191struct RequestHandle
192{ 192{
193 /** 193 /**
194 * DLL
195 */
196 struct RequestHandle *next;
197
198 /**
199 * DLL
200 */
201 struct RequestHandle *prev;
202
203 /**
194 * The data from the REST request 204 * The data from the REST request
195 */ 205 */
196 const char *data; 206 const char *data;
@@ -252,6 +262,16 @@ struct RequestHandle
252}; 262};
253 263
254/** 264/**
265 * DLL
266 */
267static struct RequestHandle *requests_head;
268
269/**
270 * DLL
271 */
272static struct RequestHandle *requests_tail;
273
274/**
255 * Cleanup lookup handle 275 * Cleanup lookup handle
256 * @param handle Handle to clean up 276 * @param handle Handle to clean up
257 */ 277 */
@@ -273,7 +293,9 @@ cleanup_handle (void *cls)
273 GNUNET_free (handle->emsg); 293 GNUNET_free (handle->emsg);
274 if (NULL != handle->name) 294 if (NULL != handle->name)
275 GNUNET_free (handle->name); 295 GNUNET_free (handle->name);
276 296 GNUNET_CONTAINER_DLL_remove (requests_head,
297 requests_tail,
298 handle);
277 GNUNET_free (handle); 299 GNUNET_free (handle);
278} 300}
279 301
@@ -1310,6 +1332,11 @@ rest_process_request (struct GNUNET_REST_RequestHandle *rest_handle,
1310 handle->url = GNUNET_strdup (rest_handle->url); 1332 handle->url = GNUNET_strdup (rest_handle->url);
1311 if (handle->url[strlen (handle->url) - 1] == '/') 1333 if (handle->url[strlen (handle->url) - 1] == '/')
1312 handle->url[strlen (handle->url) - 1] = '\0'; 1334 handle->url[strlen (handle->url) - 1] = '\0';
1335 handle->timeout_task =
1336 GNUNET_SCHEDULER_add_delayed (handle->timeout, &do_error, handle);
1337 GNUNET_CONTAINER_DLL_insert (requests_head,
1338 requests_tail,
1339 handle);
1313 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting...\n"); 1340 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connecting...\n");
1314 if (GNUNET_NO == 1341 if (GNUNET_NO ==
1315 GNUNET_REST_handle_request (handle->rest_handle, handlers, &err, handle)) 1342 GNUNET_REST_handle_request (handle->rest_handle, handlers, &err, handle))
@@ -1318,8 +1345,6 @@ rest_process_request (struct GNUNET_REST_RequestHandle *rest_handle,
1318 return GNUNET_NO; 1345 return GNUNET_NO;
1319 } 1346 }
1320 1347
1321 handle->timeout_task =
1322 GNUNET_SCHEDULER_add_delayed (handle->timeout, &do_error, handle);
1323 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connected\n"); 1348 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Connected\n");
1324 return GNUNET_YES; 1349 return GNUNET_YES;
1325} 1350}
@@ -1376,6 +1401,8 @@ libgnunet_plugin_rest_identity_done (void *cls)
1376 struct EgoEntry *ego_tmp; 1401 struct EgoEntry *ego_tmp;
1377 1402
1378 plugin->cfg = NULL; 1403 plugin->cfg = NULL;
1404 while (NULL != requests_head)
1405 cleanup_handle (requests_head);
1379 if (NULL != identity_handle) 1406 if (NULL != identity_handle)
1380 GNUNET_IDENTITY_disconnect (identity_handle); 1407 GNUNET_IDENTITY_disconnect (identity_handle);
1381 1408