Fix #3918

2 files changed, 15 insertions, 6 deletions

diff --git a/src/nat/nat.c b/src/nat/nat.c
index 270365425..42fe843e3 100644
--- a/src/nat/nat.c
+++ b/src/nat/nat.c
@@ -1115,9 +1115,16 @@ static void stun_request_callback(void *cls,
 
   struct GNUNET_NAT_Handle *h = cls;
 
+  if(NULL == cls)
+    return;
+
   h->waiting_stun = GNUNET_NO;
-  LOG (GNUNET_ERROR_TYPE_WARNING,
+
+  if(result != GNUNET_OK)
+  {
+    LOG (GNUNET_ERROR_TYPE_WARNING,
        "Error processing a STUN request");
+  }
 
 };
 
@@ -1131,7 +1138,7 @@ static void stun_request_callback(void *cls,
  * @return GNUNET_NO if it can't decode, GNUNET_YES if is a packet
  */
 int
-GNUNET_NAT_try_decode_stun_packet(void *cls, const uint8_t *data, size_t len)
+GNUNET_NAT_try_decode_stun_packet(void *cls, const void *data, size_t len)
 {
   struct GNUNET_NAT_Handle *h = cls;
   struct sockaddr_in answer;
diff --git a/src/nat/nat_stun.c b/src/nat/nat_stun.c
index 5e502c29e..5fff40656 100644
--- a/src/nat/nat_stun.c
+++ b/src/nat/nat_stun.c
@@ -334,7 +334,7 @@ stun_get_mapped(struct StunState *st, struct stun_attr *attr,struct sockaddr_in
  * @return, GNUNET_OK on OK, GNUNET_NO if the packet is invalid ( not a stun packet)
  */
 int
-GNUNET_NAT_stun_handle_packet(const uint8_t *data, size_t len,struct sockaddr_in *arg)
+GNUNET_NAT_stun_handle_packet(const void *data, size_t len, struct sockaddr_in *arg)
 {
     struct stun_header *hdr = (struct stun_header *)data;
     struct stun_attr *attr;
@@ -463,8 +463,9 @@ stun_dns_callback (void *cls,
 
         if( GNUNET_NO == request->dns_success){
             LOG (GNUNET_ERROR_TYPE_INFO, "Empty request\n");
-            clean(request);
             request->cb(request->cb_cls, GNUNET_NAT_ERROR_INTERNAL_NETWORK_ERROR);
+            clean(request);
+
         }
         return;
     }
@@ -474,8 +475,9 @@ stun_dns_callback (void *cls,
 
         if( GNUNET_NO == request->dns_success){
             LOG (GNUNET_ERROR_TYPE_INFO, "Error resolving host %s\n", request->stun_server);
-            clean(request);
             request->cb(request->cb_cls, GNUNET_NAT_ERROR_INTERNAL_NETWORK_ERROR);
+            clean(request);
+
         }
 
         return;
@@ -503,8 +505,8 @@ stun_dns_callback (void *cls,
                                             (const struct sockaddr *) &server, sizeof (server)))
     {
         GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "Fail to sendto");
-        clean(request);
         request->cb(request->cb_cls, GNUNET_NAT_ERROR_INTERNAL_NETWORK_ERROR);
+        clean(request);
         return;
     }