diff options
author | Gabor X Toth <*@tg-x.net> | 2013-09-16 12:21:10 +0000 |
---|---|---|
committer | Gabor X Toth <*@tg-x.net> | 2013-09-16 12:21:10 +0000 |
commit | cf45705470db25831f48452380021d1429973139 (patch) | |
tree | b800a33392b3346c066b27b11dfdbcf0f2edd488 /src/psycstore | |
parent | 312be136b087ce987ffe31c7d3ec4ac8a9670ea1 (diff) | |
download | gnunet-cf45705470db25831f48452380021d1429973139.tar.gz gnunet-cf45705470db25831f48452380021d1429973139.zip |
psycstore: fixing issues reported by static code analysis
Diffstat (limited to 'src/psycstore')
-rw-r--r-- | src/psycstore/gnunet-service-psycstore.c | 4 | ||||
-rw-r--r-- | src/psycstore/test_psycstore.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/psycstore/gnunet-service-psycstore.c b/src/psycstore/gnunet-service-psycstore.c index 3d6cfdc40..8a21167e1 100644 --- a/src/psycstore/gnunet-service-psycstore.c +++ b/src/psycstore/gnunet-service-psycstore.c | |||
@@ -113,7 +113,8 @@ send_result_code (struct GNUNET_SERVER_Client *client, uint32_t result_code, | |||
113 | res->header.size = htons (sizeof (struct OperationResult) + err_len); | 113 | res->header.size = htons (sizeof (struct OperationResult) + err_len); |
114 | res->result_code = htonl (result_code); | 114 | res->result_code = htonl (result_code); |
115 | res->op_id = op_id; | 115 | res->op_id = op_id; |
116 | memcpy (&res[1], err_msg, err_len); | 116 | if (0 < err_len) |
117 | memcpy (&res[1], err_msg, err_len); | ||
117 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, | 118 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, |
118 | "Sending result %d (%s) to client\n", | 119 | "Sending result %d (%s) to client\n", |
119 | (int) result_code, | 120 | (int) result_code, |
@@ -607,6 +608,7 @@ handle_state_get (void *cls, | |||
607 | ret = db->state_get (db->cls, &req->channel_key, n, | 608 | ret = db->state_get (db->cls, &req->channel_key, n, |
608 | &send_state_var, &sc); | 609 | &send_state_var, &sc); |
609 | } | 610 | } |
611 | GNUNET_free (n); | ||
610 | } | 612 | } |
611 | } | 613 | } |
612 | switch (ret) | 614 | switch (ret) |
diff --git a/src/psycstore/test_psycstore.c b/src/psycstore/test_psycstore.c index 2daf8d101..5f927a6d5 100644 --- a/src/psycstore/test_psycstore.c +++ b/src/psycstore/test_psycstore.c | |||
@@ -454,7 +454,8 @@ membership_test_result (void *cls, int64_t result, const char *err_msg) | |||
454 | - sizeof (msg->hop_counter) | 454 | - sizeof (msg->hop_counter) |
455 | - sizeof (msg->signature)); | 455 | - sizeof (msg->signature)); |
456 | msg->purpose.purpose = htonl (234); | 456 | msg->purpose.purpose = htonl (234); |
457 | GNUNET_CRYPTO_ecc_sign (slave_key, &msg->purpose, &msg->signature); | 457 | ASSERT (GNUNET_OK == GNUNET_CRYPTO_ecc_sign (slave_key, &msg->purpose, |
458 | &msg->signature)); | ||
458 | 459 | ||
459 | op = GNUNET_PSYCSTORE_fragment_store (h, &channel_pub_key, msg, fcls.flags[0], | 460 | op = GNUNET_PSYCSTORE_fragment_store (h, &channel_pub_key, msg, fcls.flags[0], |
460 | &fragment_store_result, GNUNET_NO); | 461 | &fragment_store_result, GNUNET_NO); |