diff options
author | David Barksdale <amatus.amongus@gmail.com> | 2010-09-30 19:55:00 +0000 |
---|---|---|
committer | David Barksdale <amatus.amongus@gmail.com> | 2010-09-30 19:55:00 +0000 |
commit | 76dbaecf4fdf31c95df43690798dd6de782b19af (patch) | |
tree | 774a303d9b54411270fe7f66cd8aeac7e94e049b /src/transport/transport_api.c | |
parent | 8b0a87c734f9726a9f7dfe7d87f338a83ef905cc (diff) | |
download | gnunet-76dbaecf4fdf31c95df43690798dd6de782b19af.tar.gz gnunet-76dbaecf4fdf31c95df43690798dd6de782b19af.zip |
The NULL test clearly needs to be before any dereferences.
Diffstat (limited to 'src/transport/transport_api.c')
-rw-r--r-- | src/transport/transport_api.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/transport/transport_api.c b/src/transport/transport_api.c index 093c00bef..1eea40bb7 100644 --- a/src/transport/transport_api.c +++ b/src/transport/transport_api.c | |||
@@ -1810,6 +1810,13 @@ GNUNET_TRANSPORT_notify_transmit_ready (struct GNUNET_TRANSPORT_Handle | |||
1810 | n = neighbour_add (handle, target); | 1810 | n = neighbour_add (handle, target); |
1811 | 1811 | ||
1812 | } | 1812 | } |
1813 | if (n == NULL) | ||
1814 | { | ||
1815 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, | ||
1816 | "Could not create neighbour entry for peer `%s'\n", | ||
1817 | GNUNET_i2s (target)); | ||
1818 | return NULL; | ||
1819 | } | ||
1813 | 1820 | ||
1814 | /** | 1821 | /** |
1815 | * Send a request connect message if not connected, | 1822 | * Send a request connect message if not connected, |
@@ -1821,13 +1828,6 @@ GNUNET_TRANSPORT_notify_transmit_ready (struct GNUNET_TRANSPORT_Handle | |||
1821 | send_request_connect_message(handle, n); | 1828 | send_request_connect_message(handle, n); |
1822 | } | 1829 | } |
1823 | 1830 | ||
1824 | if (n == NULL) | ||
1825 | { | ||
1826 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, | ||
1827 | "Could not create neighbour entry for peer `%s'\n", | ||
1828 | GNUNET_i2s (target)); | ||
1829 | return NULL; | ||
1830 | } | ||
1831 | switch (n->transmit_stage) | 1831 | switch (n->transmit_stage) |
1832 | { | 1832 | { |
1833 | case TS_NEW: | 1833 | case TS_NEW: |