-revert 'optimization' that broke test_crypto_hkdf

1 files changed, 16 insertions, 26 deletions

diff --git a/src/util/crypto_hkdf.c b/src/util/crypto_hkdf.c
index 1fc13ceaa..fa2bd1a69 100644
--- a/src/util/crypto_hkdf.c
+++ b/src/util/crypto_hkdf.c
@@ -87,11 +87,11 @@ doHMAC (gcry_md_hd_t mac, const void *key, size_t key_len, const void *buf,
  * @brief Generate pseudo-random key
  * @param mac gcrypt HMAC handle
  * @param xts salt
- * @param xts_len length of the salt
+ * @param xts_len length of the @a xts salt
  * @param skm source key material
- * @param skm_len length of skm
+ * @param skm_len length of @a skm
  * @param prk result buffer (allocated by caller; at least gcry_md_dlen() bytes)
- * @return GNUNET_YES on success
+ * @return #GNUNET_YES on success
  */
 static int
 getPRK (gcry_md_hd_t mac, const void *xts, size_t xts_len, const void *skm,
@@ -131,9 +131,9 @@ dump (const char *src, const void *p, unsigned int l)
  * @param xtr_algo hash algorithm for the extraction phase, GCRY_MD_...
  * @param prf_algo hash algorithm for the expansion phase, GCRY_MD_...
  * @param xts salt
- * @param xts_len length of xts
+ * @param xts_len length of @a xts
  * @param skm source key material
- * @param skm_len length of skm
+ * @param skm_len length of @a skm
  * @param argp va_list of void * & size_t pairs for context chunks
  * @return #GNUNET_YES on success
  */
@@ -142,9 +142,8 @@ GNUNET_CRYPTO_hkdf_v (void *result, size_t out_len, int xtr_algo, int prf_algo,
                       const void *xts, size_t xts_len, const void *skm,
                       size_t skm_len, va_list argp)
 {
-  static int once;
-  static gcry_md_hd_t xtr;
-  static gcry_md_hd_t prf;
+  gcry_md_hd_t xtr;
+  gcry_md_hd_t prf;
   const void *hc;
   unsigned long i;
   unsigned long t;
@@ -158,26 +157,15 @@ GNUNET_CRYPTO_hkdf_v (void *result, size_t out_len, int xtr_algo, int prf_algo,
 
   if (0 == k)
     return GNUNET_SYSERR;
-  if (! once)
-  {
-    if (GPG_ERR_NO_ERROR !=
-        gcry_md_open (&xtr, xtr_algo, GCRY_MD_FLAG_HMAC))
-      return GNUNET_SYSERR;
-
-    if (GPG_ERR_NO_ERROR !=
-        gcry_md_open (&prf, prf_algo, GCRY_MD_FLAG_HMAC))
-    {
-      gcry_md_close (xtr);
-      return GNUNET_SYSERR;
-    }
-    once = 1;
-  }
-  else
+  if (GPG_ERR_NO_ERROR !=
+      gcry_md_open (&xtr, xtr_algo, GCRY_MD_FLAG_HMAC))
+    return GNUNET_SYSERR;
+  if (GPG_ERR_NO_ERROR !=
+      gcry_md_open (&prf, prf_algo, GCRY_MD_FLAG_HMAC))
   {
-    gcry_md_reset (xtr);
-    gcry_md_reset (prf);
+    gcry_md_close (xtr);
+    return GNUNET_SYSERR;
   }
-
   va_copy (args, argp);
 
   ctx_len = 0;
@@ -275,6 +263,8 @@ GNUNET_CRYPTO_hkdf_v (void *result, size_t out_len, int xtr_algo, int prf_algo,
 hkdf_error:
   ret = GNUNET_SYSERR;
 hkdf_ok:
+  gcry_md_close (xtr);
+  gcry_md_close (prf);
   return ret;
 }