- add jsonapi tests

5 files changed, 127 insertions, 18 deletions

diff --git a/src/identity/plugin_rest_identity.c b/src/identity/plugin_rest_identity.c
index b827bfb2b..10836f103 100644
--- a/src/identity/plugin_rest_identity.c
+++ b/src/identity/plugin_rest_identity.c
@@ -504,7 +504,8 @@ ego_create_cont (struct RestConnectionDataHandle *con,
   }
   term_data[handle->data_size] = '\0';
   memcpy (term_data, handle->data, handle->data_size);
-  json_obj = GNUNET_JSONAPI_object_parse (term_data);
+  GNUNET_assert (GNUNET_OK == GNUNET_JSONAPI_object_parse (term_data,
+                                                           &json_obj));
   if (NULL == json_obj)
   {
     GNUNET_SCHEDULER_add_now (&do_error, handle);
@@ -618,7 +619,8 @@ ego_edit_cont (struct RestConnectionDataHandle *con,
 
   term_data[handle->data_size] = '\0';
   memcpy (term_data, handle->data, handle->data_size);
-  json_obj = GNUNET_JSONAPI_object_parse (term_data);
+  GNUNET_assert (GNUNET_OK == GNUNET_JSONAPI_object_parse (term_data,
+                                                           &json_obj));
 
   if (NULL == json_obj)
   {
diff --git a/src/include/gnunet_jsonapi_lib.h b/src/include/gnunet_jsonapi_lib.h
index 18dfbdf95..1e540f6b6 100644
--- a/src/include/gnunet_jsonapi_lib.h
+++ b/src/include/gnunet_jsonapi_lib.h
@@ -36,8 +36,8 @@ struct GNUNET_JSONAPI_Object;
  *
  * @param jsonapi_obj where to store the jsonapi object
  */
-struct GNUNET_JSONAPI_Specification
-GNUNET_JSONAPI_spec_jsonapi (struct GNUNET_JSONAPI_Object **jsonapi_obj);
+struct GNUNET_JSON_Specification
+GNUNET_JSON_spec_jsonapi (struct GNUNET_JSONAPI_Object **jsonapi_obj);
 
 /**
  * Create a JSON API resource
@@ -122,10 +122,12 @@ GNUNET_JSONAPI_object_new ();
  * Create a JSON API primary data from a string
  *
  * @param data the string of the JSON API data
- * @return a new JSON API resource or NULL on error.
+ * @param Pointer where to store new jsonapi Object.
+ * @return GNUNET_OK on success
  */
-struct GNUNET_JSONAPI_Object*
-GNUNET_JSONAPI_object_parse (const char* data);
+int
+GNUNET_JSONAPI_object_parse (const char* data,
+                             struct GNUNET_JSONAPI_Object** obj);
 
 
 /**
diff --git a/src/jsonapi/Makefile.am b/src/jsonapi/Makefile.am
index 1d3fcc760..8a702440d 100644
--- a/src/jsonapi/Makefile.am
+++ b/src/jsonapi/Makefile.am
@@ -20,15 +20,15 @@ libgnunetjsonapi_la_LIBADD = \
   -ljansson \
   $(XLIB)
 
-#check_PROGRAMS = \
-#  test_json
+check_PROGRAMS = \
+  test_jsonapi
 
-#TESTS = \
-#  $(check_PROGRAMS)
+TESTS = \
+  $(check_PROGRAMS)
 
-#test_json_SOURCES = \
-#  test_json.c
-#test_json_LDADD = \
-#  libgnunetjson.la \
-#  $(top_builddir)/src/util/libgnunetutil.la \
-#  -ljansson
+test_jsonapi_SOURCES = \
+  test_jsonapi.c
+test_jsonapi_LDADD = \
+  libgnunetjsonapi.la \
+  $(top_builddir)/src/util/libgnunetutil.la \
+  -ljansson
diff --git a/src/jsonapi/test_jsonapi.c b/src/jsonapi/test_jsonapi.c
new file mode 100644
index 000000000..e9c85eaf6
--- /dev/null
+++ b/src/jsonapi/test_jsonapi.c
@@ -0,0 +1,104 @@
+/*
+  This file is part of GNUnet
+  (C) 2015, 2016 GNUnet e.V.
+
+  GNUnet is free software; you can redistribute it and/or modify it under the
+  terms of the GNU General Public License as published by the Free Software
+  Foundation; either version 3, or (at your option) any later version.
+
+  GNUnet is distributed in the hope that it will be useful, but WITHOUT ANY
+  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License along with
+  GNUnet; see the file COPYING.  If not, If not, see <http://www.gnu.org/licenses/>
+*/
+
+/**
+ * @file json/test_jsonapi.c
+ * @brief Tests for jsonapi conversion functions
+ * @author Martin Schanzenbach
+ */
+#include "platform.h"
+#include "gnunet_util_lib.h"
+#include "gnunet_jsonapi_lib.h"
+#include "gnunet_json_lib.h"
+
+static int
+test_serialize ()
+{
+  struct GNUNET_JSONAPI_Object *obj;
+  char* data = "{\"data\":[{\"id\":\"1\", \"type\":\"test\"}]}";
+  char* tmp_data;
+  json_t* data_js;
+  json_t* tmp_data_js;
+  json_error_t err;
+  struct GNUNET_JSON_Specification jsonapispec[] = {
+    GNUNET_JSON_spec_jsonapi (&obj),
+    GNUNET_JSON_spec_end()
+  };
+  data_js = json_loads (data, JSON_DECODE_ANY, &err);
+  GNUNET_assert (NULL != data_js);
+  GNUNET_assert (GNUNET_OK ==
+                 GNUNET_JSON_parse (data_js, jsonapispec,
+                                    NULL, NULL));
+  GNUNET_assert (GNUNET_OK == GNUNET_JSONAPI_data_serialize (obj,
+                                                             &tmp_data));
+  GNUNET_JSON_parse_free (jsonapispec);
+  tmp_data_js = json_loads (tmp_data, JSON_DECODE_ANY, &err);
+  GNUNET_assert (NULL != tmp_data_js);
+  GNUNET_assert (0 != json_equal (tmp_data_js, data_js));
+  json_decref (data_js);
+  json_decref (tmp_data_js);
+  GNUNET_free (tmp_data);
+  return 0;
+}
+
+/**
+ * Test rsa conversions from/to JSON.
+ *
+ * @return 0 on success
+ */
+static int
+test_spec_jsonapi ()
+{
+  struct GNUNET_JSONAPI_Object *obj;
+  struct GNUNET_JSONAPI_Resource *res;
+  const char* data = "{\"data\":{\"id\":\"1\", \"type\":\"test\"}}";
+  json_t* data_js;
+  json_error_t err;
+
+  struct GNUNET_JSON_Specification jsonapispec[] = {
+    GNUNET_JSON_spec_jsonapi (&obj),
+    GNUNET_JSON_spec_end()
+  };
+  data_js = json_loads (data, JSON_DECODE_ANY, &err);
+  GNUNET_assert (NULL != data_js);
+  GNUNET_assert (GNUNET_OK ==
+                 GNUNET_JSON_parse (data_js, jsonapispec,
+                                    NULL, NULL));
+  json_decref (data_js);
+  res = GNUNET_JSONAPI_object_get_resource (obj, 0);
+  GNUNET_assert (GNUNET_YES == GNUNET_JSONAPI_resource_check_id (res, "1"));
+  GNUNET_assert (GNUNET_YES == GNUNET_JSONAPI_resource_check_type (res, "test"));
+  GNUNET_assert (1 == GNUNET_JSONAPI_object_resource_count (obj));
+  GNUNET_JSON_parse_free (jsonapispec);
+  return 0;
+}
+
+
+int
+main(int argc,
+     const char *const argv[])
+{
+  GNUNET_log_setup ("test-jsonapi",
+                    "WARNING",
+                    NULL);
+  if (0 != test_spec_jsonapi ())
+    return 1;
+  if (0 != test_serialize ())
+    return 1;
+  return 0;
+}
+
+/* end of test_json.c */
diff --git a/src/namestore/plugin_rest_namestore.c b/src/namestore/plugin_rest_namestore.c
index d33bf483b..c47a6a3c8 100644
--- a/src/namestore/plugin_rest_namestore.c
+++ b/src/namestore/plugin_rest_namestore.c
@@ -744,7 +744,8 @@ namestore_create_cont (struct RestConnectionDataHandle *con,
   }
   term_data[handle->data_size] = '\0';
   memcpy (term_data, handle->data, handle->data_size);
-  json_obj = GNUNET_JSONAPI_object_parse (term_data);
+  GNUNET_assert (GNUNET_OK == GNUNET_JSONAPI_object_parse (term_data,
+                                                           &json_obj));
   if (NULL == json_obj)
   {
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,