diff options
author | Christian Grothoff <christian@grothoff.org> | 2014-03-07 10:54:40 +0000 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2014-03-07 10:54:40 +0000 |
commit | 2ba62f67da9b2ae94d3d33c56fa9664082c83d94 (patch) | |
tree | f8c19bd80a0d3749f50babc8155e9666ff5ae8ba /src | |
parent | 710e1bc2eaf88a624c09e53c9b3280b842ce0302 (diff) | |
download | gnunet-2ba62f67da9b2ae94d3d33c56fa9664082c83d94.tar.gz gnunet-2ba62f67da9b2ae94d3d33c56fa9664082c83d94.zip |
-fix linkage issue that could cause a transport service crash on exit for certain NAT configurations
Diffstat (limited to 'src')
-rw-r--r-- | src/nat/nat_mini.c | 2 | ||||
-rw-r--r-- | src/peerinfo-tool/Makefile.am | 7 | ||||
-rw-r--r-- | src/transport/Makefile.am | 9 |
3 files changed, 13 insertions, 5 deletions
diff --git a/src/nat/nat_mini.c b/src/nat/nat_mini.c index 7a2b08f46..877c385d5 100644 --- a/src/nat/nat_mini.c +++ b/src/nat/nat_mini.c | |||
@@ -625,7 +625,7 @@ GNUNET_NAT_mini_map_start (uint16_t port, | |||
625 | /** | 625 | /** |
626 | * Process output from our 'unmap' command. | 626 | * Process output from our 'unmap' command. |
627 | * | 627 | * |
628 | * @param cls the 'struct GNUNET_NAT_MiniHandle' | 628 | * @param cls the `struct GNUNET_NAT_MiniHandle` |
629 | * @param line line of output, NULL at the end | 629 | * @param line line of output, NULL at the end |
630 | */ | 630 | */ |
631 | static void | 631 | static void |
diff --git a/src/peerinfo-tool/Makefile.am b/src/peerinfo-tool/Makefile.am index 01c1f3473..74f1edbad 100644 --- a/src/peerinfo-tool/Makefile.am +++ b/src/peerinfo-tool/Makefile.am | |||
@@ -10,7 +10,7 @@ if USE_COVERAGE | |||
10 | endif | 10 | endif |
11 | 11 | ||
12 | bin_PROGRAMS = \ | 12 | bin_PROGRAMS = \ |
13 | gnunet-peerinfo | 13 | gnunet-peerinfo |
14 | 14 | ||
15 | gnunet_peerinfo_SOURCES = \ | 15 | gnunet_peerinfo_SOURCES = \ |
16 | gnunet-peerinfo.c \ | 16 | gnunet-peerinfo.c \ |
@@ -18,14 +18,15 @@ gnunet_peerinfo_SOURCES = \ | |||
18 | 18 | ||
19 | gnunet_peerinfo_LDADD = \ | 19 | gnunet_peerinfo_LDADD = \ |
20 | $(top_builddir)/src/peerinfo/libgnunetpeerinfo.la \ | 20 | $(top_builddir)/src/peerinfo/libgnunetpeerinfo.la \ |
21 | $(top_builddir)/src/nat/libgnunetnat.la \ | ||
21 | $(top_builddir)/src/transport/libgnunettransport.la \ | 22 | $(top_builddir)/src/transport/libgnunettransport.la \ |
22 | $(top_builddir)/src/hello/libgnunethello.la \ | 23 | $(top_builddir)/src/hello/libgnunethello.la \ |
23 | $(top_builddir)/src/statistics/libgnunetstatistics.la \ | 24 | $(top_builddir)/src/statistics/libgnunetstatistics.la \ |
24 | $(top_builddir)/src/util/libgnunetutil.la | 25 | $(top_builddir)/src/util/libgnunetutil.la |
25 | 26 | ||
26 | if HAVE_PYTHON | 27 | if HAVE_PYTHON |
27 | check_SCRIPTS = \ | 28 | check_SCRIPTS = \ |
28 | test_gnunet_peerinfo.py | 29 | test_gnunet_peerinfo.py |
29 | endif | 30 | endif |
30 | 31 | ||
31 | if ENABLE_TEST_RUN | 32 | if ENABLE_TEST_RUN |
diff --git a/src/transport/Makefile.am b/src/transport/Makefile.am index 3112f0f30..d95e7e31d 100644 --- a/src/transport/Makefile.am +++ b/src/transport/Makefile.am | |||
@@ -105,7 +105,7 @@ UNIX_QUOTA_TEST = test_quota_compliance_unix \ | |||
105 | test_quota_compliance_unix_asymmetric | 105 | test_quota_compliance_unix_asymmetric |
106 | if LINUX | 106 | if LINUX |
107 | UNIX_API_ABSTRACT_TEST = test_transport_api_unix_abstract | 107 | UNIX_API_ABSTRACT_TEST = test_transport_api_unix_abstract |
108 | endif | 108 | endif |
109 | endif | 109 | endif |
110 | 110 | ||
111 | noinst_PROGRAMS = \ | 111 | noinst_PROGRAMS = \ |
@@ -212,11 +212,17 @@ gnunet_service_transport_SOURCES = \ | |||
212 | gnunet-service-transport_plugins.h gnunet-service-transport_plugins.c \ | 212 | gnunet-service-transport_plugins.h gnunet-service-transport_plugins.c \ |
213 | gnunet-service-transport_validation.h gnunet-service-transport_validation.c \ | 213 | gnunet-service-transport_validation.h gnunet-service-transport_validation.c \ |
214 | gnunet-service-transport_manipulation.h gnunet-service-transport_manipulation.c | 214 | gnunet-service-transport_manipulation.h gnunet-service-transport_manipulation.c |
215 | # Note that while gnunet-service-transport does not use libgnunetnat | ||
216 | # directly, we must link against it as GNUNET_NAT_mini_map_stop will | ||
217 | # leave a 'dangling' task to process_unmap_output which will cause | ||
218 | # a crash on unloading of a plugin unless the service links against | ||
219 | # that library as well. | ||
215 | gnunet_service_transport_LDADD = \ | 220 | gnunet_service_transport_LDADD = \ |
216 | $(top_builddir)/src/transport/libgnunettransport.la \ | 221 | $(top_builddir)/src/transport/libgnunettransport.la \ |
217 | $(top_builddir)/src/ats/libgnunetats.la \ | 222 | $(top_builddir)/src/ats/libgnunetats.la \ |
218 | $(top_builddir)/src/hello/libgnunethello.la \ | 223 | $(top_builddir)/src/hello/libgnunethello.la \ |
219 | $(top_builddir)/src/peerinfo/libgnunetpeerinfo.la \ | 224 | $(top_builddir)/src/peerinfo/libgnunetpeerinfo.la \ |
225 | $(top_builddir)/src/nat/libgnunetnat.la \ | ||
220 | $(top_builddir)/src/statistics/libgnunetstatistics.la \ | 226 | $(top_builddir)/src/statistics/libgnunetstatistics.la \ |
221 | $(top_builddir)/src/util/libgnunetutil.la \ | 227 | $(top_builddir)/src/util/libgnunetutil.la \ |
222 | $(GN_GLPK) \ | 228 | $(GN_GLPK) \ |
@@ -1095,6 +1101,7 @@ test_quota_compliance_wlan_asymmetric_LDADD = \ | |||
1095 | test_quota_compliance_bluetooth_SOURCES = \ | 1101 | test_quota_compliance_bluetooth_SOURCES = \ |
1096 | test_quota_compliance.c | 1102 | test_quota_compliance.c |
1097 | test_quota_compliance_bluetooth_LDADD = \ | 1103 | test_quota_compliance_bluetooth_LDADD = \ |
1104 | $(top_builddir)/src/nat/libgnunetnat.la \ | ||
1098 | $(top_builddir)/src/transport/libgnunettransport.la \ | 1105 | $(top_builddir)/src/transport/libgnunettransport.la \ |
1099 | $(top_builddir)/src/hello/libgnunethello.la \ | 1106 | $(top_builddir)/src/hello/libgnunethello.la \ |
1100 | $(top_builddir)/src/util/libgnunetutil.la \ | 1107 | $(top_builddir)/src/util/libgnunetutil.la \ |