aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSree Harsha Totakura <totakura@in.tum.de>2012-11-05 19:05:49 +0000
committerSree Harsha Totakura <totakura@in.tum.de>2012-11-05 19:05:49 +0000
commit36407c989a9dd94a54a185ae67244bbdddc0b566 (patch)
tree56caf1dca91d28e206f33e4c85f01f366eeae149 /src
parent1c1f5bb6c85b1239b5e48efea09d5f5b1b3912d2 (diff)
downloadgnunet-36407c989a9dd94a54a185ae67244bbdddc0b566.tar.gz
gnunet-36407c989a9dd94a54a185ae67244bbdddc0b566.zip
coverity fixes
Diffstat (limited to 'src')
-rw-r--r--src/stream/stream_api.c18
1 files changed, 11 insertions, 7 deletions
diff --git a/src/stream/stream_api.c b/src/stream/stream_api.c
index 3abea2a49..1aec60285 100644
--- a/src/stream/stream_api.c
+++ b/src/stream/stream_api.c
@@ -877,10 +877,10 @@ write_data (struct GNUNET_STREAM_Socket *socket)
877 } 877 }
878 } 878 }
879 /* Now send new packets if there is enough buffer space */ 879 /* Now send new packets if there is enough buffer space */
880 while ( (NULL != io_handle->messages[packet]) && 880 while ((packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH) &&
881 (socket->receiver_window_available 881 (NULL != io_handle->messages[packet]) &&
882 >= ntohs (io_handle->messages[packet]->header.header.size)) && 882 (socket->receiver_window_available
883 (packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH)) 883 >= ntohs (io_handle->messages[packet]->header.header.size)))
884 { 884 {
885 socket->receiver_window_available -= 885 socket->receiver_window_available -=
886 ntohs (io_handle->messages[packet]->header.header.size); 886 ntohs (io_handle->messages[packet]->header.header.size);
@@ -968,7 +968,10 @@ call_read_processor (void *cls,
968 for (packet = 0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++) 968 for (packet = 0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++)
969 { 969 {
970 if (socket->copy_offset == socket->receive_buffer_boundaries[packet]) 970 if (socket->copy_offset == socket->receive_buffer_boundaries[packet])
971 { packet++; break; } 971 {
972 packet++;
973 break;
974 }
972 if (socket->copy_offset < socket->receive_buffer_boundaries[packet]) 975 if (socket->copy_offset < socket->receive_buffer_boundaries[packet])
973 break; 976 break;
974 } 977 }
@@ -999,7 +1002,7 @@ call_read_processor (void *cls,
999 /* Fix relative boundaries */ 1002 /* Fix relative boundaries */
1000 for (packet=0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++) 1003 for (packet=0; packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH; packet++)
1001 { 1004 {
1002 if (packet < GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH - sequence_increase) 1005 if (packet < (GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH - sequence_increase))
1003 { 1006 {
1004 uint32_t ahead_buffer_boundary; 1007 uint32_t ahead_buffer_boundary;
1005 1008
@@ -1108,7 +1111,7 @@ handle_data (struct GNUNET_STREAM_Socket *socket,
1108 expecting */ 1111 expecting */
1109 relative_sequence_number = 1112 relative_sequence_number =
1110 ntohl (msg->sequence_number) - socket->read_sequence_number; 1113 ntohl (msg->sequence_number) - socket->read_sequence_number;
1111 if ( relative_sequence_number > GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH) 1114 if ( relative_sequence_number >= GNUNET_STREAM_ACK_BITMAP_BIT_LENGTH)
1112 { 1115 {
1113 LOG (GNUNET_ERROR_TYPE_DEBUG, 1116 LOG (GNUNET_ERROR_TYPE_DEBUG,
1114 "%s: Ignoring received message with sequence number %u\n", 1117 "%s: Ignoring received message with sequence number %u\n",
@@ -1490,6 +1493,7 @@ control_retransmission_task (void *cls,
1490 GNUNET_NO); 1493 GNUNET_NO);
1491 else 1494 else
1492 GNUNET_break (0); 1495 GNUNET_break (0);
1496 break;
1493 default: 1497 default:
1494 GNUNET_break (0); 1498 GNUNET_break (0);
1495 } 1499 }