1 files changed, 121 insertions, 54 deletions

diff --git a/src/transport/test_transport_plugin_cmd_udp_backchannel.c b/src/transport/test_transport_plugin_cmd_udp_backchannel.c
index 6b0342e51..108e1ac09 100644
--- a/src/transport/test_transport_plugin_cmd_udp_backchannel.c
+++ b/src/transport/test_transport_plugin_cmd_udp_backchannel.c
@@ -39,28 +39,32 @@
 
 #define TOPOLOGY_CONFIG "test_transport_udp_backchannel_topo.conf"
 
-/**
- * The name for a specific test environment directory.
- *
- */
-char *testdir;
+struct TestState
+{
+  /**
+   * Callback to write messages to the master loop.
+   *
+   */
+  TESTING_CMD_HELPER_write_cb write_message;
 
-/**
- * The name for the configuration file of the specific node.
- *
- */
-char *cfgname;
+  /**
+   * The name for a specific test environment directory.
+   *
+   */
+  char *testdir;
 
-/**
- * Flag indicating if all peers have been started.
- *
- */
-unsigned int are_all_peers_started;
+  /**
+   * The name for the configuration file of the specific node.
+   *
+   */
+  char *cfgname;
+};
 
-/**
- * Flag indicating a received message.
- */
-unsigned int message_received;
+static struct GNUNET_TESTING_Command block_send;
+
+static struct GNUNET_TESTING_Command block_receive;
+
+static struct GNUNET_TESTING_Command connect_peers;
 
 
 /**
@@ -85,7 +89,14 @@ static void
 handle_test (void *cls,
              const struct GNUNET_TRANSPORT_TESTING_TestMessage *message)
 {
-  message_received = GNUNET_YES;
+  struct GNUNET_TESTING_AsyncContext *ac;
+
+  GNUNET_TESTING_get_trait_async_context (&block_receive,
+                                          &ac);
+  if ((NULL == ac) || (NULL == ac->cont))
+    GNUNET_TESTING_async_fail (ac);
+  else
+    GNUNET_TESTING_async_finish (ac);
 }
 
 
@@ -96,10 +107,62 @@ handle_test (void *cls,
 static void
 all_peers_started ()
 {
-  are_all_peers_started = GNUNET_YES;
-  LOG (GNUNET_ERROR_TYPE_ERROR,
-       "setting are_all_peers_started: %d\n",
-       are_all_peers_started);
+  struct GNUNET_TESTING_AsyncContext *ac;
+
+  GNUNET_TESTING_get_trait_async_context (&block_send,
+                                          &ac);
+  if ((NULL == ac) || (NULL == ac->cont))
+    GNUNET_TESTING_async_fail (ac);
+  else
+    GNUNET_TESTING_async_finish (ac);
+}
+
+
+/**
+* Function called with the final result of the test.
+*
+* @param cls the `struct MainParams`
+* @param rv #GNUNET_OK if the test passed
+*/
+static void
+handle_result (void *cls,
+               enum GNUNET_GenericReturnValue rv)
+{
+  struct TestState *ts = cls;
+  struct GNUNET_MessageHeader *reply;
+
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+              "Local test exits with status %d\n",
+              rv);
+  reply = GNUNET_TESTING_send_local_test_finished_msg (rv);
+
+  ts->write_message (reply,
+                     ntohs (reply->size));
+  GNUNET_free (ts->testdir);
+  GNUNET_free (ts->cfgname);
+  GNUNET_free (ts);
+}
+
+
+/**
+ * Callback from start peer cmd for signaling a peer got connected.
+ *
+ */
+static void *
+notify_connect (void *cls,
+                const struct GNUNET_PeerIdentity *peer,
+                struct GNUNET_MQ_Handle *mq)
+{
+  struct ConnectPeersState *cps;
+
+  GNUNET_TESTING_get_trait_connect_peer_state (&connect_peers,
+                                               &cps);
+  void *ret = NULL;
+
+  cps->notify_connect (cps,
+                       peer,
+                       mq);
+  return ret;
 }
 
 
@@ -121,7 +184,11 @@ start_testcase (TESTING_CMD_HELPER_write_cb write_message, char *router_ip,
                 char *local_m)
 {
 
-  unsigned int n_int, m_int, local_m_int, num;
+  unsigned int n_int;
+  unsigned int m_int;
+  unsigned int local_m_int;
+  unsigned int num;
+  struct TestState *ts = GNUNET_new (struct TestState);
 
   struct GNUNET_TESTING_NetjailTopology *topology =
     GNUNET_TESTING_get_topo_from_file (TOPOLOGY_CONFIG);
@@ -136,18 +203,27 @@ start_testcase (TESTING_CMD_HELPER_write_cb write_message, char *router_ip,
   else
     num = (n_int - 1) * local_m_int + m_int + topology->nodes_x;
 
-  GNUNET_asprintf (&cfgname,
+  block_send = GNUNET_TESTING_cmd_block_until_external_trigger ("block");
+  block_receive = GNUNET_TESTING_cmd_block_until_external_trigger (
+    "block-receive");
+  connect_peers = GNUNET_TRANSPORT_cmd_connect_peers ("connect-peers",
+                                                      "start-peer",
+                                                      "system-create",
+                                                      num,
+                                                      NULL);
+
+  GNUNET_asprintf (&ts->cfgname,
                    "test_transport_api2_tcp_node1.conf");
 
   LOG (GNUNET_ERROR_TYPE_ERROR,
        "plugin cfgname: %s\n",
-       cfgname);
+       ts->cfgname);
 
   LOG (GNUNET_ERROR_TYPE_ERROR,
        "node ip: %s\n",
        node_ip);
 
-  GNUNET_asprintf (&testdir,
+  GNUNET_asprintf (&ts->testdir,
                    "%s%s%s",
                    BASE_DIR,
                    m,
@@ -163,39 +239,32 @@ start_testcase (TESTING_CMD_HELPER_write_cb write_message, char *router_ip,
 
   struct GNUNET_TESTING_Command commands[] = {
     GNUNET_TESTING_cmd_system_create ("system-create",
-                                      testdir),
-    GNUNET_TRANSPORT_cmd_start_peer_v3 ("start-peer",
-                                        "system-create",
-                                        num,
-                                        node_ip,
-                                        handlers,
-                                        cfgname),
+                                      ts->testdir),
+    GNUNET_TRANSPORT_cmd_start_peer ("start-peer",
+                                     "system-create",
+                                     num,
+                                     node_ip,
+                                     handlers,
+                                     ts->cfgname,
+                                     notify_connect),
     GNUNET_TESTING_cmd_send_peer_ready ("send-peer-ready",
                                         write_message),
-    GNUNET_TESTING_cmd_block_until_all_peers_started ("block",
-                                                      &are_all_peers_started),
-    GNUNET_TRANSPORT_cmd_connect_peers_v3 ("connect-peers",
-                                           "start-peer",
-                                           "system-create",
-                                           num,
-                                           topology),
-    GNUNET_TRANSPORT_cmd_send_simple_v2 ("send-simple",
-                                         "start-peer",
-                                         num),
-    GNUNET_TESTING_cmd_block_until_external_trigger ("block-receive",
-                                                     &message_received),
+    block_send,
+    connect_peers,
+    GNUNET_TRANSPORT_cmd_send_simple ("send-simple",
+                                      "start-peer",
+                                      num),
+    block_receive,
     GNUNET_TRANSPORT_cmd_stop_peer ("stop-peer",
                                     "start-peer"),
     GNUNET_TESTING_cmd_system_destroy ("system-destroy",
-                                       "system-create"),
-    GNUNET_TESTING_cmd_local_test_finished ("local-test-finished",
-                                            write_message)
+                                       "system-create")
   };
 
   GNUNET_TESTING_run (commands,
                       GNUNET_TIME_UNIT_FOREVER_REL,
-                      NULL, /* FIMXE: will crash */
-                      NULL);
+                      &handle_result,
+                      ts);
 
 }
 
@@ -234,8 +303,6 @@ libgnunet_test_transport_plugin_cmd_udp_backchannel_done (void *cls)
   struct GNUNET_TESTING_PluginFunctions *api = cls;
 
   GNUNET_free (api);
-  GNUNET_free (testdir);
-  GNUNET_free (cfgname);
   return NULL;
 }