Matthew Mundell wrote:

Hi

We've been having some mysterious parameter loss of POST parameters in
OpenVAS's GSA.  This only happens with IE8 and Chrome.  We saw this with
libmicrohttpd 0.9.19 and 0.9.20.

The cause looks to be an error in libmicrohttpd.  Patch to 0.9.20 to
resolve below.

In post_process_multipart in postprocessor.c the PP_Init state calls
find_boundary to find the first boundary.  If there is junk before the
first boundary it just reads over the junk.  However, it is also reading
over the actual boundary when there was too little data to determine
whether the next character is the start of the boundary.

In the error case Chrome seems to sends the POST request in multiple
writes.  The first chunk includes a single "-" from the first boundary at
end of the headers.  Thus libmicrohttpd has a partial boundary to deal
with.

I guess Chrome intends to send just the headers but gets the count wrong
due to sending the initial P of the POST on its own (all the browsers do
that for some reason).  Firefox on the other hand sends the headers and the
body in a single write, so it always works.

Thanks, and thanks for libmicrohttpd!

Matt

1 files changed, 1 insertions, 0 deletions

diff --git a/AUTHORS b/AUTHORS
index 9c7fe895..2041e941 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -39,6 +39,7 @@ Sven Geggus <sts@fuchsschwanzdomain.de>
 Steve Wolf <stevewolf6@gmail.com>
 Brecht Sanders <brecht@sanders.org>
 Jan Janak <jan@janakj.org>
+Matthew Mundell <matthew.mundell@greenbone.net>
 
 Documentation contributions also came from:
 Marco Maggi <marco.maggi-ipsu@poste.it>