exchange

commit 1ebfcf6b79a1a719ba12ac1788e69e581364a9b7
parent 4739d5f7e91cb36b6d884bd942229a104c3a281c
Author: Florian Dold <dold@taler.net>
Date:   Tue, 28 Jul 2026 12:49:43 +0200

kyclogic: stop re-requesting an SMS/postal check that was rejected

Echoing the rules back unchanged left the rule that asked for the check in
place, so the exchange asked for the identical check again indefinitely;
hand the account to an AML officer instead.

Diffstat:
M
src/kyclogic/taler-exchange-helper-measure-tops-postal-check
 | 
9
++++++---
M
src/kyclogic/taler-exchange-helper-measure-tops-sms-check
 | 
9
++++++---

2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/kyclogic/taler-exchange-helper-measure-tops-postal-check b/src/kyclogic/taler-exchange-helper-measure-tops-postal-check
@@ -114,10 +114,13 @@ then
     NEW_RULES=$(echo "$CURRENT_RULES" | jq 'del(.rules[] | select ((.rule_name=="p2p-domestic-identification-requirement") or (.rule_name=="withdraw-limit-low") ))')
     TO_INVESTIGATE="false"
 else
-    # Invalid country
+    # Invalid country.  Repeating the check cannot change the outcome, so hand
+    # the account to an AML officer.  Echoing the rules back unchanged would
+    # leave the rule that asked for the address in place and the exchange would
+    # request the very same check again, forever.
     echo "Country ${COUNTRY} invalid." 1>&2
-    NEW_RULES="$CURRENT_RULES"
-    TO_INVESTIGATE="true"
+    echo "$INPUTS" | taler-exchange-helper-measure-inform-investigate
+    exit $?
 fi
 
 # Finally, output the new rules.
diff --git a/src/kyclogic/taler-exchange-helper-measure-tops-sms-check b/src/kyclogic/taler-exchange-helper-measure-tops-sms-check
@@ -116,10 +116,13 @@ NEW_RULES=$(echo "$NEW_RULES" | jq 'del(.rules[] | select (.rule_name=="balance-
 
     TO_INVESTIGATE="false"
 else
-    # Invalid phone number
+    # Invalid phone number.  Repeating the check cannot change the outcome, so
+    # hand the account to an AML officer.  Echoing the rules back unchanged
+    # would leave the rule that asked for the SMS in place and the exchange
+    # would request the very same check again, forever.
     echo "Phone number ${PHONE_NUMBER} invalid." 1>&2
-    NEW_RULES=$(echo "$CURRENT_RULES" | jq '.+{"to_investigate": true}')
-    TO_INVESTIGATE="true"
+    echo "$INPUTS" | taler-exchange-helper-measure-inform-investigate
+    exit $?
 fi