exchange

commit 277a535a0405c1c992badd4e75a0ddde07170871
parent a885a8da71d5b0131075adeafe43fd3151e8099d
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Mon, 17 Aug 2026 17:09:12 +0200

check return values

Diffstat:
M
src/bank-lib/bank_api_account_token.c
 | 
8
+++++++-
M
src/bank-lib/bank_api_admin_add_incoming.c
 | 
7
+++++++
M
src/bank-lib/bank_api_admin_add_kycauth.c
 | 
7
+++++++
M
src/bank-lib/bank_api_credit.c
 | 
7
+++++++
M
src/bank-lib/bank_api_debit.c
 | 
7
+++++++
M
src/bank-lib/bank_api_registration.c
 | 
7
+++++++
M
src/bank-lib/bank_api_transfer.c
 | 
7
+++++++

7 files changed, 49 insertions(+), 1 deletion(-)
diff --git a/src/bank-lib/bank_api_account_token.c b/src/bank-lib/bank_api_account_token.c
@@ -238,7 +238,13 @@ TALER_BANK_account_token (
                                    ath->post_ctx.headers,
                                    &handle_account_token_finished,
                                    ath);
-  GNUNET_assert (NULL != ath->job);
+  if (NULL == ath->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_account_token_cancel (ath);
+    return NULL;
+  }
   return ath;
 }
 
diff --git a/src/bank-lib/bank_api_admin_add_incoming.c b/src/bank-lib/bank_api_admin_add_incoming.c
@@ -232,6 +232,13 @@ TALER_BANK_admin_add_incoming (
                                    aai->post_ctx.headers,
                                    &handle_admin_add_incoming_finished,
                                    aai);
+  if (NULL == aai->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_admin_add_incoming_cancel (aai);
+    return NULL;
+  }
   return aai;
 }
 
diff --git a/src/bank-lib/bank_api_admin_add_kycauth.c b/src/bank-lib/bank_api_admin_add_kycauth.c
@@ -232,6 +232,13 @@ TALER_BANK_admin_add_kycauth (
                                    aai->post_ctx.headers,
                                    &handle_admin_add_kycauth_finished,
                                    aai);
+  if (NULL == aai->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_admin_add_kycauth_cancel (aai);
+    return NULL;
+  }
   return aai;
 }
 
diff --git a/src/bank-lib/bank_api_credit.c b/src/bank-lib/bank_api_credit.c
@@ -422,6 +422,13 @@ TALER_BANK_credit_history (struct GNUNET_CURL_Context *ctx,
                                   NULL,
                                   &handle_credit_history_finished,
                                   hh);
+  if (NULL == hh->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_credit_history_cancel (hh);
+    return NULL;
+  }
   return hh;
 }
 
diff --git a/src/bank-lib/bank_api_debit.c b/src/bank-lib/bank_api_debit.c
@@ -324,6 +324,13 @@ TALER_BANK_debit_history (struct GNUNET_CURL_Context *ctx,
                                   NULL,
                                   &handle_debit_history_finished,
                                   hh);
+  if (NULL == hh->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_debit_history_cancel (hh);
+    return NULL;
+  }
   return hh;
 }
 
diff --git a/src/bank-lib/bank_api_registration.c b/src/bank-lib/bank_api_registration.c
@@ -381,6 +381,13 @@ TALER_BANK_registration (
                                   rh->post_ctx.headers,
                                   &handle_registration_finished,
                                   rh);
+  if (NULL == rh->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_registration_cancel (rh);
+    return NULL;
+  }
   return rh;
 }
 
diff --git a/src/bank-lib/bank_api_transfer.c b/src/bank-lib/bank_api_transfer.c
@@ -362,6 +362,13 @@ TALER_BANK_transfer (
                                   th->post_ctx.headers,
                                   &handle_transfer_finished,
                                   th);
+  if (NULL == th->job)
+  {
+    GNUNET_break (0);
+    curl_easy_cleanup (eh);
+    TALER_BANK_transfer_cancel (th);
+    return NULL;
+  }
   return th;
 }