exchange

commit c93d9ab4deacb67523b9678cf3916f2ceeb7daec
parent 82c392f568be5d3713550d451191d1d8d1745164
Author: Christian Grothoff <christian@grothoff.org>
Date:   Mon, 29 Jun 2026 00:59:28 +0200

fixes

Diffstat:
M
src/json/conversion.c
 | 
1
+
M
src/json/i18n.c
 | 
22
+++++++++++-----------
M
src/util/age_restriction.c
 | 
2
+-
M
src/util/secmod_eddsa.c
 | 
2
+-
M
src/util/url.c
 | 
2
+-

5 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/json/conversion.c b/src/json/conversion.c
@@ -353,6 +353,7 @@ TALER_JSON_external_conversion_start (const json_t *input,
                 GNUNET_DISK_pipe_close (pipe_stdout));
   ec->write_buf = json_dumps (input,
                               JSON_COMPACT);
+  GNUNET_assert (NULL != ec->write_buf);
   ec->write_size = strlen (ec->write_buf);
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Passing %llu bytes to JSON conversion tool\n",
diff --git a/src/json/i18n.c b/src/json/i18n.c
@@ -89,38 +89,38 @@ TALER_JSON_check_i18n (const json_t *i18n)
     case 1:
       return false;
     case 2:
-      if (! isalpha (field[0]))
+      if (! isalpha ((unsigned char) field[0]))
         return false;
-      if (! isalpha (field[1]))
+      if (! isalpha ((unsigned char) field[1]))
         return false;
       break;
     case 3:
     case 4:
       return false;
     case 5:
-      if (! isalpha (field[0]))
+      if (! isalpha ((unsigned char) field[0]))
         return false;
-      if (! isalpha (field[1]))
+      if (! isalpha ((unsigned char) field[1]))
         return false;
       if ('_' != field[2])
         return false;
-      if (! isalpha (field[3]))
+      if (! isalpha ((unsigned char) field[3]))
         return false;
-      if (! isalpha (field[4]))
+      if (! isalpha ((unsigned char) field[4]))
         return false;
       break;
     case 6:
-      if (! isalpha (field[0]))
+      if (! isalpha ((unsigned char) field[0]))
         return false;
-      if (! isalpha (field[1]))
+      if (! isalpha ((unsigned char) field[1]))
         return false;
       if ('_' != field[2])
         return false;
-      if (! isalpha (field[3]))
+      if (! isalpha ((unsigned char) field[3]))
         return false;
-      if (! isalpha (field[4]))
+      if (! isalpha ((unsigned char) field[4]))
         return false;
-      if (! isalpha (field[5]))
+      if (! isalpha ((unsigned char) field[5]))
         return false;
       break;
     default:
diff --git a/src/util/age_restriction.c b/src/util/age_restriction.c
@@ -137,7 +137,7 @@ ecdsa_create_from_seed (
     GNUNET_OK ==
     GNUNET_CRYPTO_hkdf_gnunet (key,
                                sizeof (*key),
-                               &seed,
+                               seed,
                                seed_size,
                                "age commitment",
                                sizeof ("age commitment") - 1));
diff --git a/src/util/secmod_eddsa.c b/src/util/secmod_eddsa.c
@@ -246,7 +246,7 @@ handle_sign_request (struct TES_Client *client,
   if (purpose_size != htonl (purpose->size))
   {
     struct TALER_CRYPTO_EddsaSignFailure sf = {
-      .header.size = htons (sizeof (sr)),
+      .header.size = htons (sizeof (sf)),
       .header.type = htons (TALER_HELPER_EDDSA_MT_RES_SIGN_FAILURE),
       .ec = htonl (TALER_EC_GENERIC_PARAMETER_MALFORMED)
     };
diff --git a/src/util/url.c b/src/util/url.c
@@ -94,7 +94,7 @@ buffer_write_urlencode (struct GNUNET_Buffer *buf,
     if (GNUNET_YES == is_reserved (s[i]))
       GNUNET_buffer_write_fstr (buf,
                                 "%%%02X",
-                                s[i]);
+                                (unsigned char) s[i]);
     else
       buf->mem[buf->position++] = s[i];
   }