exchange

commit e17884bb462ea1159330281a8d671e0a92786a2a
parent 161b72e0e249f020935f8276cac2a04442ed010e
Author: Christian Grothoff <christian@grothoff.org>
Date:   Tue, 30 Jun 2026 23:12:27 +0200

GNUNET_JSON_PACK never returns NULL

Diffstat:
M
src/bank-lib/bank_api_account_token.c
 | 
5
-----
M
src/bank-lib/bank_api_admin_add_incoming.c
 | 
5
-----
M
src/bank-lib/bank_api_parse.c
 | 
4
+++-
M
src/bank-lib/bank_api_transfer.c
 | 
5
-----

4 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/src/bank-lib/bank_api_account_token.c b/src/bank-lib/bank_api_account_token.c
@@ -196,11 +196,6 @@ TALER_BANK_account_token (
     GNUNET_JSON_pack_allow_null (
       GNUNET_JSON_pack_bool ("refreshable",
                              refreshable)));
-  if (NULL == token_req)
-  {
-    GNUNET_break (0);
-    return NULL;
-  }
   ath = GNUNET_new (struct TALER_BANK_AccountTokenHandle);
   ath->cb = res_cb;
   ath->cb_cls = res_cb_cls;
diff --git a/src/bank-lib/bank_api_admin_add_incoming.c b/src/bank-lib/bank_api_admin_add_incoming.c
@@ -188,11 +188,6 @@ TALER_BANK_admin_add_incoming (
                             amount),
     TALER_JSON_pack_full_payto ("debit_account",
                                 debit_account));
-  if (NULL == admin_obj)
-  {
-    GNUNET_break (0);
-    return NULL;
-  }
   aai = GNUNET_new (struct TALER_BANK_AdminAddIncomingHandle);
   aai->cb = res_cb;
   aai->cb_cls = res_cb_cls;
diff --git a/src/bank-lib/bank_api_parse.c b/src/bank-lib/bank_api_parse.c
@@ -39,7 +39,9 @@ TALER_BANK_auth_parse_cfg (const struct GNUNET_CONFIGURATION_Handle *cfg,
   };
   char *method;
 
-  auth->core_bank_url = NULL;
+  memset (auth,
+          0,
+          sizeof (*auth));
   if (GNUNET_OK ==
       GNUNET_CONFIGURATION_get_value_string (cfg,
                                              section,
diff --git a/src/bank-lib/bank_api_transfer.c b/src/bank-lib/bank_api_transfer.c
@@ -333,11 +333,6 @@ TALER_BANK_transfer (
                                 &wp->wtid),
     GNUNET_JSON_pack_string ("credit_account",
                              destination_account_uri));
-  if (NULL == transfer_obj)
-  {
-    GNUNET_break (0);
-    return NULL;
-  }
   eh = curl_easy_init ();
   if ( (NULL == eh) ||
        (GNUNET_OK !=